All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Serge Hallyn (AMD)" <sergeh@kernel.org>
To: Peter Xu <peterx@redhat.com>
Cc: "Tony Lindgren" <tony.lindgren@linux.intel.com>,
	"Kishen Maloor" <kishen.maloor@intel.com>,
	"Serge E. Hallyn" <serge@hallyn.com>,
	"Artem Bityutskiy" <dedekind1@gmail.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Sean Christopherson" <seanjc@google.com>,
	"Fabiano Rosas" <farosas@suse.de>,
	"Jon Grimm" <Jon.Grimm@amd.com>,
	"Pankaj Gupta" <pankaj.gupta@amd.com>,
	"Tom Lendacky" <thomas.lendacky@amd.com>,
	"Marc Zyngier" <maz@kernel.org>,
	"Oliver Upton" <oliver.upton@linux.dev>,
	"Steven Price" <steven.price@arm.com>,
	"Anup Patel" <anup@brainfault.org>,
	"Samuel Ortiz" <sameo@rivosinc.com>,
	"Jakub Růžička" <jakub.ruzicka@matfyz.cz>,
	"Jörg Rödel" <joro@8bytes.org>,
	"Vishal Annapurve" <vannapurve@google.com>,
	"Elena Reshetova" <elena.reshetova@intel.com>,
	"Kai Huang" <kai.huang@intel.com>,
	"Mika Westerberg" <mika.westerberg@linux.intel.com>,
	"Peter Fang" <peter.fang@intel.com>,
	"Rick Edgecombe" <rick.p.edgecombe@intel.com>,
	"Xiaoyao Li" <xiaoyao.li@intel.com>,
	"Xu Yilun" <yilun.xu@linux.intel.com>,
	kvm@vger.kernel.org, David.Kaplan@amd.com,
	Mathias.Brossard@arm.com, tycho@kernel.org, "Adam,
	Mahmoud" <Mahmoud.Adam@amd.com>
Subject: Re: TDX migration model
Date: Thu, 19 Nov 2026 11:09:00 -0600	[thread overview]
Message-ID: <av8tLIFEpHgluthp@shallyn-amd> (raw)
In-Reply-To: <av8F-DwJnTkSeYsz@zhexu-thinkpadt14gen5.rmtcaon.csb>

On Thu, Nov 19, 2026 at 09:21:44AM -0500, Peter Xu wrote:
> On Tue, Nov 10, 2026 at 07:16:06AM +0200, Tony Lindgren wrote:
> > On Mon, Nov 09, 2026 at 04:15:45PM -0600, Serge Hallyn (AMD) wrote:
> > > (Adding Tycho and Mahmoud, who will be working with me on this)
> > > 
> > > On Mon, Nov 09, 2026 at 09:45:17AM +0200, Tony Lindgren wrote:
> > > > On Thu, Nov 05, 2026 at 06:00:41PM -0800, Kishen Maloor wrote:
> > > > > On 11/5/26 8:42 AM, Serge E. Hallyn wrote:
> > > > > > On Thu, Nov 05, 2026 at 05:59:01PM +0200, Artem Bityutskiy wrote:
> > > > > >> On Thu, 2026-11-05 at 08:58 -0600, Serge Hallyn (AMD) wrote:
> > > > > >>> ...
> > > > > >>> So, looking at the section '### How the Setup Session Works', is it safe
> > > > > >>> to assume that you are using the qemu migration fd for the message
> > > > > >>> transfers?  So basically qemu loops over KVM_MIGRATE_SETUP calls, which
> > > > > >>> ...
> > > > > >> Yes, that's the flow. I’m not sure about the migration fd part, I believe we
> > > > > >> pass the setup session data via ioctl buffers. I am sure Kishen will can
> > > > > >> clarify.
> > > > > > 
> > > > > > If you mean pass via ioctl buffers from tdx->kvm-> back to qemu, which passes
> > > > > > it over the migration fd to the other side, then that's what I expected.
> > > > > > Othewise I'll be interested to the details :)
> > > > > 
> > > > > Hi Serge,
> > > > > 
> > > > > Your understanding is right. Migration setup requires a handshake of some sort
> > > > > between the source and destination. So the messages KVM_MIGRATE_SETUP returns
> > > > > are transferred over QEMU's migration channel to the other side and processed
> > > > > by a matching call.
> > > > 
> > > > Serge, on the QEMU side, we have been enabling the return-path early for
> > > > the key exchange before migration is active. Not sure if the key exchange
> > > > can be done using a VMState, possibly could be if we can ensure it happens
> > > > before the migration is active.
> > > 
> > > Key exchange requires bidirectional communication, so I don't think a
> > > VMState would work, at least not on its own. If the destination's
> > > info got send to the source out of band and delivered through migrate
> > > command option, that could work, but it seems much nicer to me if it's
> > > all done more transparently.  OTOH if this simplifies the qemu code
> > > enough, maybe it's worth it.
> > 
> > Yeah agreed and can be revisited.
> 
> Just FYI: on QEMU side, we should be introducing handshake for migration
> soon, so that there'll be an early stage where the out+in messages will be
> all done in the entrance of migration_thread(), trying to have both src/dst
> QEMUs talk first before really starting the migration procedure.
> 
> Agreed that vmstate isn't designed for bi-directional conversations.
> 
> That was initially for other things, including channel mgmts, sync
> migration caps/params, but it sounds like it could be useful for CoCo too.
> 
> Thanks,
> 
> -- 
> Peter Xu

Is there a draft repo/branch where we could look at the current state of
the 'handshake' feature?

thanks,
-serge

  reply	other threads:[~2026-11-19 17:09 UTC|newest]

Thread overview: 103+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-31  7:13 [RFC PATCH v2 0/4] Add KVM API for confidential guest live migration Tony Lindgren
2026-08-31  7:13 ` [RFC PATCH v2 1/4] Documentation: KVM: Add live migration API for confidential guests Tony Lindgren
2026-08-31  7:20   ` sashiko-bot
2026-09-18 11:35   ` Peter Xu
2026-09-21  4:20     ` Tony Lindgren
2026-09-24  1:50     ` Wei Wang
2026-09-24  4:51       ` Tony Lindgren
2026-11-10 12:42   ` Artem Bityutskiy
2026-08-31  7:13 ` [RFC PATCH v2 2/4] KVM: x86: Add optional KVM_CAP_LIVE_MIGRATION and KVM_MIGRATE_CMD Tony Lindgren
2026-08-31  7:23   ` sashiko-bot
2026-09-01  6:03     ` Tony Lindgren
2026-09-07 11:53   ` Tony Lindgren
2026-09-07 13:15     ` Jörg Rödel
2026-09-07 13:32       ` Artem Bityutskiy
2026-09-08  4:15         ` Tony Lindgren
2026-09-08  4:43         ` Tony Lindgren
2026-09-09  0:22           ` Kishen Maloor
2026-09-09  6:57             ` Tony Lindgren
2026-09-10  1:11               ` Kishen Maloor
2026-09-10  6:33                 ` Tony Lindgren
2026-09-11  1:40                   ` Kishen Maloor
2026-09-11  4:23                     ` Tony Lindgren
2026-09-15  0:14                       ` Kishen Maloor
2026-09-15  4:44                         ` Tony Lindgren
2026-09-15 15:53                           ` Kishen Maloor
2026-09-16  5:09                             ` Tony Lindgren
2026-09-17  3:31                               ` Kishen Maloor
2026-09-17  6:42                                 ` Tony Lindgren
2026-09-18  4:32                                   ` Kishen Maloor
2026-09-18  5:58                                     ` Tony Lindgren
2026-09-21  0:13                                       ` Kishen Maloor
2026-09-21  6:52                                         ` Tony Lindgren
2026-09-21  9:24                                           ` Tony Lindgren
2026-09-21 10:58                                             ` Tony Lindgren
2026-09-22  3:57                                           ` Kishen Maloor
2026-09-22  5:25                                             ` Tony Lindgren
2026-09-23  0:38                                               ` Kishen Maloor
2026-09-23  6:04                                                 ` Tony Lindgren
2026-09-24  5:53                                                   ` Kishen Maloor
2026-09-24  6:59                                                     ` Tony Lindgren
2026-09-18  4:33   ` Kishen Maloor
2026-09-21  5:58     ` Tony Lindgren
2026-09-21  6:56       ` Tony Lindgren
2026-09-22  3:56         ` Kishen Maloor
2026-09-22  6:27           ` Tony Lindgren
2026-09-23  0:37             ` Kishen Maloor
2026-09-23  6:50               ` Tony Lindgren
2026-09-24  5:34                 ` Kishen Maloor
2026-09-24  7:15                   ` Tony Lindgren
2026-10-08  9:22                     ` Tony Lindgren
2026-10-16  4:00                       ` Kishen Maloor
2026-08-31  7:13 ` [RFC PATCH v2 3/4] KVM: x86: Add optional KVM_EXPORT_MEMORY and KVM_IMPORT_MEMORY Tony Lindgren
2026-08-31  7:23   ` sashiko-bot
2026-09-01  6:10     ` Tony Lindgren
2026-08-31  7:13 ` [RFC PATCH v2 4/4] KVM: x86: Add optional KVM_EXPORT_VCPU and KVM_IMPORT_VCPU Tony Lindgren
2026-08-31  7:23   ` sashiko-bot
2026-09-01  6:12     ` Tony Lindgren
2026-09-04 18:24 ` [RFC PATCH v2 0/4] Add KVM API for confidential guest live migration Artem Bityutskiy
2026-09-17 21:27   ` Peter Xu
2026-09-18 12:46     ` Artem Bityutskiy
2026-09-18 15:53       ` Peter Xu
2026-09-22  8:09         ` Artem Bityutskiy
2026-09-22  9:42           ` Tony Lindgren
2026-09-22 11:54             ` Artem Bityutskiy
2026-09-23  4:20               ` Tony Lindgren
2026-09-22 21:18           ` Peter Xu
2026-09-23 12:05             ` Artem Bityutskiy
2026-09-24 21:19               ` Peter Xu
2026-09-28 14:15                 ` Artem Bityutskiy
2026-09-29 21:05                   ` Peter Xu
2026-10-02 19:57                     ` Artem Bityutskiy
2026-10-07 20:00                       ` Peter Xu
2026-09-23 15:28           ` Serge Hallyn (AMD)
2026-11-04 13:51         ` TDX migration model Artem Bityutskiy
2026-11-05 14:58           ` Serge Hallyn (AMD)
2026-11-05 15:59             ` Artem Bityutskiy
2026-11-05 16:42               ` Serge E. Hallyn
2026-11-06  2:00                 ` Kishen Maloor
2026-11-09  7:45                   ` Tony Lindgren
2026-11-09 22:15                     ` Serge Hallyn (AMD)
2026-11-10  5:16                       ` Tony Lindgren
2026-11-19 14:21                         ` Peter Xu
2026-11-19 17:09                           ` Serge Hallyn (AMD) [this message]
2026-11-19 17:27                             ` Peter Xu
2026-10-09  6:11       ` [RFC PATCH v2 0/4] Add KVM API for confidential guest live migration Tony Lindgren
2026-10-16  3:56         ` Kishen Maloor
2026-10-19  7:34           ` Tony Lindgren
2026-09-20 23:56     ` Kishen Maloor
2026-09-23 21:36       ` Peter Xu
2026-09-24  4:27         ` Kishen Maloor
2026-09-25 14:18           ` Peter Xu
2026-09-29  1:28             ` Kishen Maloor
2026-09-30 20:42               ` Peter Xu
2026-10-07  4:27                 ` Kishen Maloor
2026-10-07 20:13                   ` Peter Xu
2026-10-08  6:23                     ` Tony Lindgren
2026-10-08 14:31                       ` Peter Xu
2026-10-09  4:29                         ` Tony Lindgren
2026-10-16  4:02                     ` Kishen Maloor
2026-09-18 18:36 ` Ionut Mihalcea
2026-09-21  4:35   ` Tony Lindgren
2026-09-25 16:03 ` Serge Hallyn (AMD)
2026-09-28  3:24   ` Kishen Maloor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=av8tLIFEpHgluthp@shallyn-amd \
    --to=sergeh@kernel.org \
    --cc=David.Kaplan@amd.com \
    --cc=Jon.Grimm@amd.com \
    --cc=Mahmoud.Adam@amd.com \
    --cc=Mathias.Brossard@arm.com \
    --cc=anup@brainfault.org \
    --cc=dedekind1@gmail.com \
    --cc=elena.reshetova@intel.com \
    --cc=farosas@suse.de \
    --cc=jakub.ruzicka@matfyz.cz \
    --cc=joro@8bytes.org \
    --cc=kai.huang@intel.com \
    --cc=kishen.maloor@intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=oliver.upton@linux.dev \
    --cc=pankaj.gupta@amd.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.fang@intel.com \
    --cc=peterx@redhat.com \
    --cc=rick.p.edgecombe@intel.com \
    --cc=sameo@rivosinc.com \
    --cc=seanjc@google.com \
    --cc=serge@hallyn.com \
    --cc=steven.price@arm.com \
    --cc=thomas.lendacky@amd.com \
    --cc=tony.lindgren@linux.intel.com \
    --cc=tycho@kernel.org \
    --cc=vannapurve@google.com \
    --cc=xiaoyao.li@intel.com \
    --cc=yilun.xu@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.