From: Benjamin Marzinski <bmarzins@redhat.com>
To: Brian Bunker <brian@purestorage.com>
Cc: Martin Wilck <mwilck@suse.com>,
Christophe Varoqui <christophe.varoqui@opensvc.com>,
dm-devel@lists.linux.dev
Subject: Re: [PATCH v4 1/1] multipathd: recheck WWIDs of re-added paths with the device
Date: Thu, 19 Nov 2026 12:30:56 -0500 [thread overview]
Message-ID: <av8yUJLcMz9_4ljM@redhat.com> (raw)
In-Reply-To: <20261118223449.85519-1-brian@purestorage.com>
On Wed, Nov 18, 2026 at 02:34:49PM -0800, Brian Bunker wrote:
> Martin, Ben,
>
> Thanks, both. Two points before I do a v5.
>
> On Mon, 2026-11-16, Benjamin Marzinski wrote:
> > If this code was only run when we got a wwid before and then it
> > changed, then requiring a matching WWID from the device seems much
> > more reasonable.
>
> Agreed, and that changes my earlier position. With PATH_ADD_REINIT
> passed only from the changed-WWID branch, the check only runs when the
> path already had a WWID and udev now reports a different one. In that
> case, if the device doesn't confirm the new WWID, including when SG_IO
> fails, I'd keep the path out and let the checker retrigger, as for a
> mismatch.
>
> check_path_wwid_change() returns false both for a match and for an SG_IO
> failure, so v5 would need to tell those apart.
>
> > we never reset pp->retriggers once we have a reasonable WWID
>
> On Mon, 2026-11-16, Martin Wilck wrote:
> > I don't see an issue with resetting retrigger_tries once the issues
> > with path's WWID are sorted out, in both cases.
>
> I'm fine with resetting pp->retriggers once a path has a confirmed WWID,
> so that "no WWID from udev" and "WWID didn't match" don't share one
> budget for the life of the path. Would you rather have that in this
> patch or as a separate one? I lean towards a separate patch, since it
> also changes the existing missing-udev handling.
Yes to a separate patch.
> If you're both fine with this, I'll send v5.
I'm fine with this.
-Ben
> Brian
prev parent reply other threads:[~2026-11-19 17:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 18:16 [PATCH v4 0/1] multipathd: recheck WWIDs of re-added paths with the device Brian Bunker
2026-11-11 18:16 ` [PATCH v4 1/1] " Brian Bunker
2026-11-12 22:24 ` Martin Wilck
2026-11-13 18:00 ` Benjamin Marzinski
2026-11-13 20:52 ` Martin Wilck
2026-11-16 18:43 ` Brian Bunker
2026-11-16 22:19 ` Martin Wilck
2026-11-16 19:46 ` Benjamin Marzinski
2026-11-16 22:27 ` Martin Wilck
2026-11-18 22:34 ` Brian Bunker
2026-11-19 17:30 ` Benjamin Marzinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=av8yUJLcMz9_4ljM@redhat.com \
--to=bmarzins@redhat.com \
--cc=brian@purestorage.com \
--cc=christophe.varoqui@opensvc.com \
--cc=dm-devel@lists.linux.dev \
--cc=mwilck@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.