From: Eric Blake <eblake@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org,
Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>
Subject: Re: [PATCH for-11.2 2/2] tests/qemu-iotest: Add test for qcow2 image with empty reftable
Date: Thu, 19 Nov 2026 13:41:58 -0600 [thread overview]
Message-ID: <av9Qg0zn9197-Kf0@redhat.com> (raw)
In-Reply-To: <20261119140338.2918386-3-peter.maydell@linaro.org>
On Thu, Nov 19, 2026 at 02:03:38PM +0000, Peter Maydell wrote:
> This test creates a qcow2 image, manually zeroes out its entire
> reftable, and then runs 'qemu-img amend -o refcount_bits=64" on it.
> This used to cause qemu-img to crash; now we will report that the
> image can't be opened because it's corrupted.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> tests/qemu-iotests/315 | 59 ++++++++++++++++++++++++++++++++++++++
> tests/qemu-iotests/315.out | 9 ++++++
These days, it seems better to create named tests under
qemu-iotests/tests, rather than as a new three-digit number. But a
file rename is trivial enough that I fine with giving my review,
whether or not we adjust the patch.
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
next prev parent reply other threads:[~2026-11-19 19:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 14:03 [PATCH for-11.2 0/2] block/qcow2: Avoid crash in qemu-img amend when reftable is empty Peter Maydell
2026-11-19 14:03 ` [PATCH for-11.2 1/2] block/qcow2: Detect corrupt images where first refcount block " Peter Maydell
2026-11-19 18:48 ` Peter Maydell
2026-11-19 19:42 ` Eric Blake
2026-11-19 14:03 ` [PATCH for-11.2 2/2] tests/qemu-iotest: Add test for qcow2 image with empty reftable Peter Maydell
2026-11-19 19:41 ` Eric Blake [this message]
2026-11-20 17:32 ` [PATCH for-11.2 0/2] block/qcow2: Avoid crash in qemu-img amend when reftable is empty Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=av9Qg0zn9197-Kf0@redhat.com \
--to=eblake@redhat.com \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.