All of lore.kernel.org
 help / color / mirror / Atom feed
From: Frank Li <Frank.li@oss.nxp.com>
To: Nas Chung <nas.chung@chipsnmedia.com>
Cc: mchehab@kernel.org, hverkuil@kernel.org, robh@kernel.org,
	krzk+dt@kernel.org, conor+dt@kernel.org, Frank.Li@nxp.com,
	s.hauer@pengutronix.de, linux-media@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
	festevam@gmail.com, kernel@pengutronix.de,
	nicolas.dufresne@collabora.com, ming.qian@oss.nxp.com,
	marek.vasut@mailbox.org, jackson.lee@chipsnmedia.com,
	lafley.kim@chipsnmedia.com
Subject: Re: [PATCH v8 03/11] media: chips-media: wave6: Add Wave6 core driver
Date: Thu, 19 Nov 2026 14:27:38 -0600	[thread overview]
Message-ID: <av9bugRyMCQRNEcQ@SMW015318> (raw)
In-Reply-To: <1030b93108a94a28b572a97695f3b5bfc75e0ac9.1795075580.git.nas.chung@chipsnmedia.com>

On Thu, Nov 19, 2026 at 05:59:57PM +0900, Nas Chung wrote:
> Add the core driver for the Chips&Media Wave6 video codec IP.
>
> The hardware contains one control register region and four interface
> register regions for a shared video processing engine. The core driver
> handles the interface register regions, each with its own MMIO range
> and interrupt, while relying on the control driver for firmware loading
> and shared resource management.
>
> It configures the V4L2 mem2mem devices and communicates with the Wave6
> hardware to perform video processing tasks.
>
> Tested-by: Ming Qian <ming.qian@oss.nxp.com>
> Tested-by: Marek Vasut <marek.vasut@mailbox.org>
> Signed-off-by: Nas Chung <nas.chung@chipsnmedia.com>
> ---
>  .../media/platform/chips-media/wave6/Kconfig  |   2 +
>  .../media/platform/chips-media/wave6/Makefile |   5 +-
>  .../platform/chips-media/wave6/wave6-hw.c     | 181 ++++++++
>  .../platform/chips-media/wave6/wave6-hw.h     |  22 +
>  .../chips-media/wave6/wave6-regdefine.h       |  65 +++
>  .../platform/chips-media/wave6/wave6-vdi.h    |  20 +
>  .../chips-media/wave6/wave6-vpu-core.c        | 392 ++++++++++++++++++
>  .../chips-media/wave6/wave6-vpu-core.h        | 106 +++++
>  .../chips-media/wave6/wave6-vpu-v4l2.c        | 384 +++++++++++++++++
>  .../platform/chips-media/wave6/wave6-vpu.c    |  24 +-
>  .../platform/chips-media/wave6/wave6-vpu.h    |   2 +
>  .../platform/chips-media/wave6/wave6-vpuapi.h | 381 +++++++++++++++++
>  .../chips-media/wave6/wave6-vpuconfig.h       |   6 +
>  13 files changed, 1588 insertions(+), 2 deletions(-)
>  create mode 100644 drivers/media/platform/chips-media/wave6/wave6-hw.c
>  create mode 100644 drivers/media/platform/chips-media/wave6/wave6-hw.h
>  create mode 100644 drivers/media/platform/chips-media/wave6/wave6-vpu-core.c
>  create mode 100644 drivers/media/platform/chips-media/wave6/wave6-vpu-core.h
>  create mode 100644 drivers/media/platform/chips-media/wave6/wave6-vpu-v4l2.c
>  create mode 100644 drivers/media/platform/chips-media/wave6/wave6-vpuapi.h
>
...
> +
> +u32 wave6_vpu_readl(struct vpu_core_device *core, u32 addr)
> +{
> +	u32 data;
> +
> +	data = wave6_vdi_readl(core->reg_base, addr);
> +
> +	return data;

return wave6_vdi_readl(core->reg_base, addr);

> +}
> +
> +void wave6_vpu_writel_relaxed(struct vpu_core_device *core, u32 addr, u32 data)
> +{
> +	wave6_vdi_writel_relaxed(core->reg_base, addr, data);
> +}
> +
> +u32 wave6_vpu_readl_relaxed(struct vpu_core_device *core, u32 addr)
> +{
> +	u32 data;
> +
> +	data = wave6_vdi_readl_relaxed(core->reg_base, addr);

return wave6_vdi_readl_relaxed(core->reg_base, addr);

> +
> +	return data;
> +}
> +
...
> +static u32 wave6_vpu_get_product_id(struct vpu_core_device *core)
> +{
> +	u32 val;
> +
> +	lockdep_assert_held(&core->hw_lock);
> +
> +	val = vpu_read_reg_relaxed(core, W6_VPU_RET_PRODUCT_CODE);
> +
> +	switch (val) {
> +	case WAVE617_CODE:
> +		return PRODUCT_ID_617;
> +	case WAVE627_CODE:
> +		return PRODUCT_ID_627;
> +	case WAVE633_CODE:
> +	case WAVE637_CODE:
> +	case WAVE663_CODE:
> +	case WAVE677_CODE:
> +		return PRODUCT_ID_637;

what is use for? why not direct use WAVE*_CODE?

> +	default:
> +		dev_err(core->dev, "Invalid product (%x)\n", val);
> +		break;
> +	}
> +
> +	return PRODUCT_ID_NONE;
> +}
> +
...
> +
> +#endif /* __WAVE6_HW_H__ */
> diff --git a/drivers/media/platform/chips-media/wave6/wave6-regdefine.h b/drivers/media/platform/chips-media/wave6/wave6-regdefine.h
> index e879a9743cb3..aa9b972c82d1 100644
> --- a/drivers/media/platform/chips-media/wave6/wave6-regdefine.h
> +++ b/drivers/media/platform/chips-media/wave6/wave6-regdefine.h
> @@ -14,14 +14,51 @@ enum wave6_command {
>  	W6_CMD_INIT_VPU		= 0x0001,
>  	W6_CMD_WAKEUP_VPU	= 0x0002,
>  	W6_CMD_SLEEP_VPU	= 0x0004,
> +	W6_CMD_CREATE_INSTANCE	= 0x0008,
> +	W6_CMD_FLUSH_INSTANCE	= 0x0010,
> +	W6_CMD_DESTROY_INSTANCE	= 0x0020,
> +	W6_CMD_INIT_SEQ		= 0x0040,
> +	W6_CMD_SET_FB		= 0x0080,
> +	W6_CMD_DEC_PIC		= 0x0100,
> +	W6_CMD_DEC_SET_DISP	= 0x0400,

BIT()?

>  	W6_CMD_INIT_WORK_BUF	= 0x1000,
> +	W6_CMD_QUERY		= 0x4000,
> +};
> +
...
>
>  #endif /* __WAVE6_REGDEFINE_H__ */
> diff --git a/drivers/media/platform/chips-media/wave6/wave6-vdi.h b/drivers/media/platform/chips-media/wave6/wave6-vdi.h
> index 69ebf0ebcb13..67704fdbe27d 100644
> --- a/drivers/media/platform/chips-media/wave6/wave6-vdi.h
> +++ b/drivers/media/platform/chips-media/wave6/wave6-vdi.h
> @@ -13,6 +13,26 @@
>  #include <linux/dma-mapping.h>
>  #include <linux/io.h>
>
> +enum endian_mode {

name is too general and easy happen name collision.

> +	VDI_128BIT_BIG_ENDIAN = 0,
> +	VDI_128BIT_BE_BYTE_SWAP,
> +	VDI_128BIT_BE_WORD_SWAP,
> +	VDI_128BIT_BE_WORD_BYTE_SWAP,
> +	VDI_128BIT_BE_DWORD_SWAP,
> +	VDI_128BIT_BE_DWORD_BYTE_SWAP,
> +	VDI_128BIT_BE_DWORD_WORD_SWAP,
> +	VDI_128BIT_BE_DWORD_WORD_BYTE_SWAP,
> +	VDI_128BIT_LE_DWORD_WORD_BYTE_SWAP,
> +	VDI_128BIT_LE_DWORD_WORD_SWAP,
> +	VDI_128BIT_LE_DWORD_BYTE_SWAP,
> +	VDI_128BIT_LE_DWORD_SWAP,
> +	VDI_128BIT_LE_WORD_BYTE_SWAP,
> +	VDI_128BIT_LE_WORD_SWAP,
> +	VDI_128BIT_LE_BYTE_SWAP,
> +	VDI_128BIT_LITTLE_ENDIAN = 15,
> +	VDI_ENDIAN_MAX
> +};
> +
>  /**
>   * struct vpu_buf - VPU buffer for a coherent DMA buffer
>   * @size:	Buffer size
> diff --git a/drivers/media/platform/chips-media/wave6/wave6-vpu-core.c b/drivers/media/platform/chips-media/wave6/wave6-vpu-core.c
> new file mode 100644
> index 000000000000..67c6666579d9
> --- /dev/null
> +++ b/drivers/media/platform/chips-media/wave6/wave6-vpu-core.c
> @@ -0,0 +1,392 @@
> +// SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause)
> +/*
> + * Wave6 series multi-standard codec IP - wave6 core driver
> + *
> + * Copyright (C) 2026 CHIPS&MEDIA INC
> + */
> +
> +#include <linux/kernel.h>
> +#include <linux/platform_device.h>
> +#include <linux/clk.h>
> +#include <linux/interrupt.h>
> +#include <linux/pm_runtime.h>
> +#include <linux/iopoll.h>

sort

> +
> +#include "wave6-vpu-core.h"
> +#include "wave6-regdefine.h"
> +#include "wave6-vpuconfig.h"
> +#include "wave6-hw.h"
> +
> +static irqreturn_t wave6_vpu_core_irq(int irq, void *dev_id)
> +{
> +	struct vpu_core_device *core = dev_id;
> +	struct vpu_irq irq_info;
> +
> +	if (!vpu_read_reg(core, W6_VPU_VPU_INT_STS))
> +		return IRQ_NONE;
> +
> +	irq_info.status = vpu_read_reg(core, W6_VPU_VINT_REASON);
> +	irq_info.inst_idc = vpu_read_reg(core, W6_RET_INT_INSTANCE_INFO);
> +
> +	vpu_write_reg(core, W6_RET_INT_INSTANCE_INFO, INT_INSTANCE_INFO_CLEAR);

suppose only already set irq, irq_info.inst_idc, like below code?

> +	vpu_write_reg(core, W6_VPU_VINT_REASON_CLEAR, irq_info.status);
> +	vpu_write_reg(core, W6_VPU_VINT_CLEAR, VINT_CLEAR);
> +
> +	if (irq_info.status & BIT(W6_INT_BIT_REQ_WORK_BUF)) {
> +		wave6_vpu_require_work_buffer(core->vpu, core->reg_base);
> +
> +		return IRQ_HANDLED;
> +	}
> +
> +	if (kfifo_in(&core->irq_fifo, &irq_info, sizeof(struct vpu_irq)) !=
> +	    sizeof(struct vpu_irq))
> +		dev_err(core->dev, "IRQ overflow status 0x%x idc 0x%x\n",
> +			irq_info.status, irq_info.inst_idc);
> +
> +	return IRQ_WAKE_THREAD;
> +}
> +
> +	core->irq = platform_get_irq(pdev, 0);

...

> +	if (core->irq < 0)
> +		return core->irq;
> +
> +	ret = devm_request_threaded_irq(&pdev->dev, core->irq,
> +					wave6_vpu_core_irq,
> +					wave6_vpu_core_irq_thread,
> +					0, "vpu_irq", core);
> +	if (ret) {
> +		dev_err(&pdev->dev, "failed to request IRQ: %d\n", ret);
> +		return ret;

return dev_err_probe();

> +	}
> +
> +	ret = v4l2_device_register(&pdev->dev, &core->v4l2_dev);
> +	if (ret) {
> +		dev_err(&pdev->dev, "failed to register v4l2_dev: %d\n", ret);
> +		return ret;
> +	}
> +
...
> +void wave6_vpu_writel(struct vpu_core_device *core, u32 addr, u32 data);
> +void wave6_vpu_writel_relaxed(struct vpu_core_device *core, u32 addr, u32 data);
> +u32 wave6_vpu_readl(struct vpu_core_device *core, u32 addr);
> +u32 wave6_vpu_readl_relaxed(struct vpu_core_device *core, u32 addr);
> +
> +#endif /* __WAVE6_VPUAPI_H__ */
> diff --git a/drivers/media/platform/chips-media/wave6/wave6-vpuconfig.h b/drivers/media/platform/chips-media/wave6/wave6-vpuconfig.h
> index 1d4e016c2a58..fccb854a8a8c 100644
> --- a/drivers/media/platform/chips-media/wave6/wave6-vpuconfig.h
> +++ b/drivers/media/platform/chips-media/wave6/wave6-vpuconfig.h
> @@ -18,13 +18,19 @@
>  #define W6_VPU_MAX_NUM_CORE		4
>  #define MAX_NUM_INSTANCE		32
>
> +#define W6_MAX_PIC_STRIDE		(4096 * 4)
> +#define W6_PIC_STRIDE_ALIGNMENT		32
> +
>  #define W6_VPU_POLL_DELAY_US		10
>  #define W6_VPU_POLL_TIMEOUT		300000
> +#define W6_BOOT_WAIT_TIMEOUT		10000
> +#define W6_VPU_TIMEOUT			6000

Need unit

Frank
>
>  #define W6_MAX_REMAP_PAGE_SIZE		(1024 * 1024)
>  #define W6_MAX_CODE_BUF_SIZE		(4 * 1024 * 1024)
>  #define W6_CODE_BUF_SIZE		(1 * 1024 * 1024)
>  #define W6_EXTRA_CODE_BUF_SIZE		(256 * 1024)
> +#define W6_TEMPBUF_SIZE			(3 * 1024 * 1024)
>  #define W637DEC_WORKBUF_SIZE_FOR_CQ	(3 * 512 * 1024)
>
>  static inline bool wave6_is_product_w_series(u32 code)
> --
> 2.41.0.windows.3
>
>

  parent reply	other threads:[~2026-11-19 20:27 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19  8:59 [PATCH v8 00/11] Add support for Wave6 video codec driver Nas Chung
2026-11-19  8:59 ` [PATCH v8 01/11] dt-bindings: media: nxp: Add Wave6 video codec device Nas Chung
2026-11-19  8:59 ` [PATCH v8 02/11] media: chips-media: wave6: Add Wave6 control driver Nas Chung
2026-11-19  9:26   ` sashiko-bot
2026-11-19 19:36     ` Frank Li
2026-11-19 20:07   ` Frank Li
2026-11-20  8:58     ` Nas Chung
2026-11-19  8:59 ` [PATCH v8 03/11] media: chips-media: wave6: Add Wave6 core driver Nas Chung
2026-11-19  9:32   ` sashiko-bot
2026-11-19 20:27   ` Frank Li [this message]
2026-11-20  8:49     ` Nas Chung
2026-11-19  8:59 ` [PATCH v8 04/11] media: chips-media: wave6: Add Wave6 decoder firmware interface Nas Chung
2026-11-19  9:22   ` sashiko-bot
2026-11-19 20:37   ` Frank Li
2026-11-20  8:35     ` Nas Chung
2026-11-19  8:59 ` [PATCH v8 05/11] media: chips-media: wave6: Add Wave6 m2m decoder Nas Chung
2026-11-19  9:31   ` sashiko-bot
2026-11-19  9:00 ` [PATCH v8 06/11] media: chips-media: wave6: Add Wave6 encoder firmware interface Nas Chung
2026-11-19  9:10   ` sashiko-bot
2026-11-19  9:00 ` [PATCH v8 07/11] media: chips-media: wave6: Add Wave6 m2m encoder Nas Chung
2026-11-19  9:35   ` sashiko-bot
2026-11-19  9:00 ` [PATCH v8 08/11] media: chips-media: wave6: Add trace and debugfs Nas Chung
2026-11-19  9:14   ` sashiko-bot
2026-11-19  9:00 ` [PATCH v8 09/11] media: chips-media: wave6: Add performance profiling Nas Chung
2026-11-19  9:20   ` sashiko-bot
2026-11-19 20:56   ` Frank Li
2026-11-19  9:00 ` [PATCH v8 10/11] media: chips-media: wave6: Add Wave6 thermal cooling device Nas Chung
2026-11-19  9:21   ` sashiko-bot
2026-11-19 21:03   ` Frank Li
2026-11-20  4:34     ` Nas Chung
2026-11-19  9:00 ` [PATCH v8 11/11] arm64: dts: freescale: imx95: Add video codec node Nas Chung
2026-11-19  9:37   ` sashiko-bot
2026-11-19 21:05   ` Frank Li
2026-11-20  4:32     ` Nas Chung

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=av9bugRyMCQRNEcQ@SMW015318 \
    --to=frank.li@oss.nxp.com \
    --cc=Frank.Li@nxp.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=hverkuil@kernel.org \
    --cc=imx@lists.linux.dev \
    --cc=jackson.lee@chipsnmedia.com \
    --cc=kernel@pengutronix.de \
    --cc=krzk+dt@kernel.org \
    --cc=lafley.kim@chipsnmedia.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=marek.vasut@mailbox.org \
    --cc=mchehab@kernel.org \
    --cc=ming.qian@oss.nxp.com \
    --cc=nas.chung@chipsnmedia.com \
    --cc=nicolas.dufresne@collabora.com \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.