From: Frank Li <Frank.li@oss.nxp.com>
To: Nas Chung <nas.chung@chipsnmedia.com>
Cc: mchehab@kernel.org, hverkuil@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, Frank.Li@nxp.com,
s.hauer@pengutronix.de, linux-media@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
festevam@gmail.com, kernel@pengutronix.de,
nicolas.dufresne@collabora.com, ming.qian@oss.nxp.com,
marek.vasut@mailbox.org, jackson.lee@chipsnmedia.com,
lafley.kim@chipsnmedia.com
Subject: Re: [PATCH v8 10/11] media: chips-media: wave6: Add Wave6 thermal cooling device
Date: Thu, 19 Nov 2026 15:03:30 -0600 [thread overview]
Message-ID: <av9kIkW6rYeUGFBE@SMW015318> (raw)
In-Reply-To: <d973e48036b43e9f1e5fc254153303a4c21deebb.1795075582.git.nas.chung@chipsnmedia.com>
On Thu, Nov 19, 2026 at 06:00:04PM +0900, Nas Chung wrote:
> Add a thermal cooling device for the Wave6 VPU, so the thermal
> framework can lower the VPU performance state when the SoC gets hot.
>
> The control driver registers the cooling device on its device tree
> node. The cooling states are built from the OPP table of the "perf"
> power domain.
>
> Tested-by: Ming Qian <ming.qian@oss.nxp.com>
> Tested-by: Marek Vasut <marek.vasut@mailbox.org>
> Signed-off-by: Nas Chung <nas.chung@chipsnmedia.com>
> ---
> .../media/platform/chips-media/wave6/Makefile | 1 +
> .../chips-media/wave6/wave6-vpu-thermal.c | 141 ++++++++++++++++++
> .../chips-media/wave6/wave6-vpu-thermal.h | 24 +++
> .../platform/chips-media/wave6/wave6-vpu.c | 22 +++
> .../platform/chips-media/wave6/wave6-vpu.h | 3 +
> 5 files changed, 191 insertions(+)
> create mode 100644 drivers/media/platform/chips-media/wave6/wave6-vpu-thermal.c
> create mode 100644 drivers/media/platform/chips-media/wave6/wave6-vpu-thermal.h
...
> +
> + if (!thermal->thermal_max)
> + goto error;
nothing clean up at error label, just return ret
> +
> + thermal->thermal_event = 0;
> + thermal->cooling = devm_thermal_of_child_cooling_device_register(dev,
> + dev->of_node,
> + dev_name(thermal->dev),
> + thermal,
> + &wave6_cooling_ops);
> + if (IS_ERR(thermal->cooling)) {
> + dev_err(thermal->dev, "register cooling device failed\n");
> + ret = PTR_ERR(thermal->cooling);
> + goto error;
return dev_err_probe()
Frank
next prev parent reply other threads:[~2026-11-19 21:03 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 8:59 [PATCH v8 00/11] Add support for Wave6 video codec driver Nas Chung
2026-11-19 8:59 ` [PATCH v8 01/11] dt-bindings: media: nxp: Add Wave6 video codec device Nas Chung
2026-11-19 8:59 ` [PATCH v8 02/11] media: chips-media: wave6: Add Wave6 control driver Nas Chung
2026-11-19 9:26 ` sashiko-bot
2026-11-19 19:36 ` Frank Li
2026-11-19 20:07 ` Frank Li
2026-11-20 8:58 ` Nas Chung
2026-11-19 8:59 ` [PATCH v8 03/11] media: chips-media: wave6: Add Wave6 core driver Nas Chung
2026-11-19 9:32 ` sashiko-bot
2026-11-19 20:27 ` Frank Li
2026-11-20 8:49 ` Nas Chung
2026-11-19 8:59 ` [PATCH v8 04/11] media: chips-media: wave6: Add Wave6 decoder firmware interface Nas Chung
2026-11-19 9:22 ` sashiko-bot
2026-11-19 20:37 ` Frank Li
2026-11-20 8:35 ` Nas Chung
2026-11-19 8:59 ` [PATCH v8 05/11] media: chips-media: wave6: Add Wave6 m2m decoder Nas Chung
2026-11-19 9:31 ` sashiko-bot
2026-11-19 9:00 ` [PATCH v8 06/11] media: chips-media: wave6: Add Wave6 encoder firmware interface Nas Chung
2026-11-19 9:10 ` sashiko-bot
2026-11-19 9:00 ` [PATCH v8 07/11] media: chips-media: wave6: Add Wave6 m2m encoder Nas Chung
2026-11-19 9:35 ` sashiko-bot
2026-11-19 9:00 ` [PATCH v8 08/11] media: chips-media: wave6: Add trace and debugfs Nas Chung
2026-11-19 9:14 ` sashiko-bot
2026-11-19 9:00 ` [PATCH v8 09/11] media: chips-media: wave6: Add performance profiling Nas Chung
2026-11-19 9:20 ` sashiko-bot
2026-11-19 20:56 ` Frank Li
2026-11-19 9:00 ` [PATCH v8 10/11] media: chips-media: wave6: Add Wave6 thermal cooling device Nas Chung
2026-11-19 9:21 ` sashiko-bot
2026-11-19 21:03 ` Frank Li [this message]
2026-11-20 4:34 ` Nas Chung
2026-11-19 9:00 ` [PATCH v8 11/11] arm64: dts: freescale: imx95: Add video codec node Nas Chung
2026-11-19 9:37 ` sashiko-bot
2026-11-19 21:05 ` Frank Li
2026-11-20 4:32 ` Nas Chung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=av9kIkW6rYeUGFBE@SMW015318 \
--to=frank.li@oss.nxp.com \
--cc=Frank.Li@nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=hverkuil@kernel.org \
--cc=imx@lists.linux.dev \
--cc=jackson.lee@chipsnmedia.com \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=lafley.kim@chipsnmedia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=marek.vasut@mailbox.org \
--cc=mchehab@kernel.org \
--cc=ming.qian@oss.nxp.com \
--cc=nas.chung@chipsnmedia.com \
--cc=nicolas.dufresne@collabora.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.