All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v19 00/19] Crescent Island PMT support
@ 2026-11-19 15:54 Michael J. Ruhl
  2026-11-19 15:54 ` [PATCH v19 01/19] platform/x86/intel/pmt: Introduce a callback for discovery data Michael J. Ruhl
                   ` (21 more replies)
  0 siblings, 22 replies; 30+ messages in thread
From: Michael J. Ruhl @ 2026-11-19 15:54 UTC (permalink / raw)
  To: platform-driver-x86, intel-xe, hansg, ilpo.jarvinen,
	matthew.brost, rodrigo.vivi, thomas.hellstrom, airlied, simona,
	david.e.box, anoop.c.vijay, badal.nilawar, matthew.d.roper,
	james.ausmus

The Crescent Island (CRI) GPU supports PMT via Xe driver
registration.

The CRI PMT MMIO mapping is shared for each PMT feature and it is
necessary to set an index register value to access the correct memory
space.

The PMT driver has a callback infrastructure to access data areas with
driver specific access. It is does not support the PMT control access.

CRI discovery/control spaces are part of the access window so a driver
callback is necessary to allow for the correct window to be exposed.

Add control path callback support to the PMT driver.

Add CRI PMT discovery information.

Update the Xe driver to support the CRI PMT access.

The crashlog access needs to be done with power enabled (telem is only
available when the device is powered).

Determine which access is requested, and do the appropriate power
request.

CRI FW is loaded at device power.  Support the late-binding API to
wait for FW readiness. (pending sysctl patch set implements the API).

v2:
  Address AI feedback:
  - add missing entry->cb check
  - address SRIOV VF concerns
  - use xe_pm_runtime_put instead of _get in error path

  Address review comments:
  - redo power/lock sequencing
  - support device hotplug events

v3:
  - cleanup power manangement flow
  - fixed an out of order power management locking issue
  - add a GUID caching mechanism, for GUID read
  - removed unused parameter (mmio)

v4:
 - address various review comments
 - refactor crashlog to allow for return values
 - for callback usage, decouple PMT remap of data areas
 - use IS_SRIOV_VF() rather than expose soc-remapper internals
 - separate locking fixes intos distinct steps
 - refactor define update patches to seperate BMG and CRI updates
 - separate internal GUID into separate steps

v5:
 - removed callback helpers
 - do not return error message with sysfs
 - fix missed return code check in trigger_store
 - return error value not false
 - use DEFINE_RES_MEM
 - document when base is unused
 - return error on invalid GUID request

v6:
 - fix enabled/disabled inversion
 - fix missing DOC reference
 - change memcpy_to/fromio to readl/writel for register read
 - guid cache comment and update on valid guid

v7:
 - reordered to have BMG updates followed by CRI support
 - separate base_offset usage for clarity
 - added EAGAIN usage to block uninitialized use of the API

v8:
 - fix punit crashlog offset (should be 0xE60 not 0xE78)
 - remove EAGAIN support and re-order probe steps to initialize
   VSEC before other features use it

v9:
 - added appropriate reviewed-bys
 - use dev_err instead of pr_err
 - enforce defined base usage when callbacks are in plcace
 - move SRIOV check to get_platform_info
 - assert SRIOV for API check
 - use scoped_guard() where possible
 - update to use correct sysctrl helper

v10:
 - fix incorrect return type (broken in refactor, int -> bool)
 - fix incorrectly documented error return values
 - doc text cleanup

v11:
 - add reviewed-by
 - fix minor checkpatch issue
 - use xe_assert() for a consistent API check

v12:
 - add survivability mode support
 - add reviewed-by

v13:
 - PMT patches (original commits 1 - 5) are merged upstream
 - resubmitting XeKMD patches

v14:
 - address AI review comments
 - init soc-remapper in survivability path
 - reset soc-remapper index to the discovery index after access
 - re-order read/write to eliminate need for goto
 - check for signals in wait_for_fw
 - add appropriate doc updates
 - use system_freezable_wq vs system_wq
 - cache survivability mode to avoid error path issues

v15:
 - add/correct fixes tags
 - replace devm_add with xe_vsec_remove() to avoid error path race

v16:
 - fix xe_vsec_remove path to verify CRI usage before cleanup

v17:
 - one last AI review fix
 - return error GUID == 0

v18:
 - use a callback to prefill discovery records
   this corrects a locking issue during probe
 - use the prefilled header for crashlog
 - setting the soc-remapper index now only occurs with the lock held

v19:
 - checkpatch issue
 - submit to the correct mailing lists


Michael J. Ruhl (19):
  platform/x86/intel/pmt: Introduce a callback for discovery data
  platform/x86/intel/pmt: Use the pre-populated header info for crashlog
  drm/xe/vsec: VSEC requires soc-remapper
  drm/xe/vsec: Do not register BMG PMT for VF
  drm/xe/vsec: Correct locking order
  drm/xe/vsec: Use correct pm state get
  drm/xe/vsec: Add DOC text for VSEC
  drm/xe/vsec: Support possible hotplug exit
  drm/xe/vsec: Refactor BattleMage PMT defines
  drm/xe/vsec: Update VSEC probe order
  drm/xe/vsec: Add base_offset to allow for more flexibilty
  drm/xe/vsec: Support Crescent Island PMT
  drm/xe/vsec: Crescent Island PMT decode
  drm/xe/vsec: Crescent Island PMT callbacks
  drm/xe/vsec: Support late bind fw information
  drm/xe/vsec: Add PMT GUID internal access
  drm/xe/vsec: Update PMT internal access
  drm/xe/vsec: Refactor platform check
  drm/xe/vsec: Support survivability mode for CRI

 Documentation/gpu/xe/index.rst             |   1 +
 Documentation/gpu/xe/xe_vsec.rst           |  14 +
 drivers/gpu/drm/xe/regs/xe_pmt.h           |  12 +-
 drivers/gpu/drm/xe/xe_debugfs.c            |  45 +-
 drivers/gpu/drm/xe/xe_device.c             |   7 +-
 drivers/gpu/drm/xe/xe_device_types.h       |  11 +
 drivers/gpu/drm/xe/xe_hwmon.c              |  10 +-
 drivers/gpu/drm/xe/xe_pcode.c              |  10 +-
 drivers/gpu/drm/xe/xe_survivability_mode.c |   2 +
 drivers/gpu/drm/xe/xe_vsec.c               | 654 +++++++++++++++++++--
 drivers/gpu/drm/xe/xe_vsec.h               |   2 +
 drivers/platform/x86/intel/pmt/class.c     |  18 +-
 drivers/platform/x86/intel/pmt/crashlog.c  |  24 +-
 include/linux/intel_vsec.h                 |   6 +
 14 files changed, 721 insertions(+), 95 deletions(-)
 create mode 100644 Documentation/gpu/xe/xe_vsec.rst

-- 
2.43.0


^ permalink raw reply	[flat|nested] 30+ messages in thread

* [PATCH v19 01/19] platform/x86/intel/pmt: Introduce a callback for discovery data
  2026-11-19 15:54 [PATCH v19 00/19] Crescent Island PMT support Michael J. Ruhl
@ 2026-11-19 15:54 ` Michael J. Ruhl
  2026-11-19 20:06   ` David E. Box
  2026-11-19 15:54 ` [PATCH v19 02/19] platform/x86/intel/pmt: Use the pre-populated header info for crashlog Michael J. Ruhl
                   ` (20 subsequent siblings)
  21 siblings, 1 reply; 30+ messages in thread
From: Michael J. Ruhl @ 2026-11-19 15:54 UTC (permalink / raw)
  To: platform-driver-x86, intel-xe, hansg, ilpo.jarvinen,
	matthew.brost, rodrigo.vivi, thomas.hellstrom, airlied, simona,
	david.e.box, anoop.c.vijay, badal.nilawar, matthew.d.roper,
	james.ausmus

Some devices require special handling to access discovery data.

Provide a callback to allow for the special handling.

Suggested-by: David E. Box <david.e.box@linux.intel.com>
Signed-off-by: Michael J. Ruhl <michael.j.ruhl@intel.com>
---
 drivers/platform/x86/intel/pmt/class.c | 18 ++++++++++++------
 include/linux/intel_vsec.h             |  6 ++++++
 2 files changed, 18 insertions(+), 6 deletions(-)

diff --git a/drivers/platform/x86/intel/pmt/class.c b/drivers/platform/x86/intel/pmt/class.c
index 2b11c4012f6a..601cdf68f0bc 100644
--- a/drivers/platform/x86/intel/pmt/class.c
+++ b/drivers/platform/x86/intel/pmt/class.c
@@ -466,12 +466,17 @@ static int pmt_get_headers(struct intel_vsec_device *ivdev, int idx,
 	switch (ivdev->src) {
 	case INTEL_VSEC_DISC_PCI: {
 		struct resource *disc_res = &ivdev->resource[idx];
+		struct pmt_callbacks *cb = ivdev->priv_data;
 		void __iomem *disc_table;
+		int ret = 0;
 
 		disc_table = devm_ioremap_resource(dev, disc_res);
 		if (IS_ERR(disc_table))
 			return PTR_ERR(disc_table);
 
+		/* Used by crashlog driver */
+		entry->disc_table = disc_table;
+
 		/*
 		 * The mapped resource is sized by the namespace's DVSEC
 		 * entry_size (in dwords), which can be less than the default
@@ -480,13 +485,14 @@ static int pmt_get_headers(struct intel_vsec_device *ivdev, int idx,
 		 * region.
 		 */
 		memset(entry->disc_header, 0, header_bytes);
-		memcpy_fromio(entry->disc_header, disc_table,
-			      min(header_bytes, resource_size(disc_res)));
-
-		/* Used by crashlog driver */
-		entry->disc_table = disc_table;
 
-		return 0;
+		if (cb && cb->read_discovery)
+			ret = cb->read_discovery(ivdev->dev, ivdev->cap_id, idx,
+						 entry->disc_header);
+		else
+			memcpy_fromio(entry->disc_header, disc_table,
+				      min(header_bytes, resource_size(disc_res)));
+		return ret;
 	}
 	case INTEL_VSEC_DISC_ACPI: {
 		memcpy(entry->disc_header, &ivdev->acpi_disc[idx][0], header_bytes);
diff --git a/include/linux/intel_vsec.h b/include/linux/intel_vsec.h
index 8686e79c4f75..400231989b49 100644
--- a/include/linux/intel_vsec.h
+++ b/include/linux/intel_vsec.h
@@ -94,6 +94,11 @@ enum intel_vsec_quirks {
  * * data:  buffer for the data to be copied
  * * off:   offset into the requested buffer
  * * count: size of buffer
+ * @read_discovery: when specified called by client driver to read PMT discovery structs
+ * * dev:     device reference for the callback's use
+ * * cap_id: telem, crashlog, etc, ilog2 of VSEC_CAP value
+ * * idx:     element to access
+ * * disc_data:  buffer for the discovery data to be copied
  * @read_reg: when specified called by client driver to read PMT state
  * * dev:      device reference for the callback's use
  * * guid:     ID of data to access
@@ -107,6 +112,7 @@ enum intel_vsec_quirks {
  */
 struct pmt_callbacks {
 	int (*read_telem)(struct device *dev, u32 guid, u64 *data, loff_t off, u32 count);
+	int (*read_discovery)(struct device *dev, unsigned long cap_id, u32 idx, u32 *disc_data);
 	int (*read_reg)(struct device *dev, u32 guid, u32 *reg_data, u32 offset);
 	int (*write_reg)(struct device *dev, u32 guid, u32 reg_data, u32 offset);
 };
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 30+ messages in thread

* [PATCH v19 02/19] platform/x86/intel/pmt: Use the pre-populated header info for crashlog
  2026-11-19 15:54 [PATCH v19 00/19] Crescent Island PMT support Michael J. Ruhl
  2026-11-19 15:54 ` [PATCH v19 01/19] platform/x86/intel/pmt: Introduce a callback for discovery data Michael J. Ruhl
@ 2026-11-19 15:54 ` Michael J. Ruhl
  2026-11-19 20:13   ` David E. Box
  2026-11-19 15:54 ` [PATCH v19 03/19] drm/xe/vsec: VSEC requires soc-remapper Michael J. Ruhl
                   ` (19 subsequent siblings)
  21 siblings, 1 reply; 30+ messages in thread
From: Michael J. Ruhl @ 2026-11-19 15:54 UTC (permalink / raw)
  To: platform-driver-x86, intel-xe, hansg, ilpo.jarvinen,
	matthew.brost, rodrigo.vivi, thomas.hellstrom, airlied, simona,
	david.e.box, anoop.c.vijay, badal.nilawar, matthew.d.roper,
	james.ausmus

Discovery data is pre-populated.

Use the data for crashlog probe.

Signed-off-by: Michael J. Ruhl <michael.j.ruhl@intel.com>
---
 drivers/platform/x86/intel/pmt/crashlog.c | 24 +++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/drivers/platform/x86/intel/pmt/crashlog.c b/drivers/platform/x86/intel/pmt/crashlog.c
index d7018b495217..f7c391d145ff 100644
--- a/drivers/platform/x86/intel/pmt/crashlog.c
+++ b/drivers/platform/x86/intel/pmt/crashlog.c
@@ -27,10 +27,10 @@
 #define CRASH_TYPE_OOBMSM	1
 
 /* Crashlog Discovery Header */
-#define CONTROL_OFFSET		0x0
-#define GUID_OFFSET		0x4
-#define BASE_OFFSET		0x8
-#define SIZE_OFFSET		0xC
+#define STATUS_IDX		0
+#define GUID_IDX		1
+#define BASE_IDX		2
+#define SIZE_IDX		3
 #define GET_ACCESS(v)		((v) & GENMASK(3, 0))
 #define GET_TYPE(v)		(((v) & GENMASK(7, 4)) >> 4)
 #define GET_VERSION(v)		(((v) & GENMASK(19, 16)) >> 16)
@@ -208,10 +208,10 @@ static int pmt_crashlog_disabled(struct crashlog_entry *crashlog, bool *state)
 
 static bool pmt_crashlog_supported(struct intel_pmt_entry *entry, u32 *crash_type, u32 *version)
 {
-	u32 discovery_header = readl(entry->disc_table + CONTROL_OFFSET);
+	u32 *disc_header = entry->disc_header;
 
-	*crash_type = GET_TYPE(discovery_header);
-	*version = GET_VERSION(discovery_header);
+	*crash_type = GET_TYPE(disc_header[STATUS_IDX]);
+	*version = GET_VERSION(disc_header[STATUS_IDX]);
 
 	/*
 	 * Currently we only recognize OOBMSM (type 1) and version 0 or 2
@@ -608,15 +608,15 @@ static int pmt_crashlog_pre_decode(struct intel_vsec_device *ivdev,
 static int pmt_crashlog_header_decode(struct intel_pmt_entry *entry,
 				      struct device *dev)
 {
-	void __iomem *disc_table = entry->disc_table;
 	struct intel_pmt_header *header = &entry->header;
+	u32 *disc_header = entry->disc_header;
 
-	header->access_type = GET_ACCESS(readl(disc_table));
-	header->guid = readl(disc_table + GUID_OFFSET);
-	header->base_offset = readl(disc_table + BASE_OFFSET);
+	header->access_type = GET_ACCESS(disc_header[STATUS_IDX]);
+	header->guid = disc_header[GUID_IDX];
+	header->base_offset = disc_header[BASE_IDX];
 
 	/* Size is measured in DWORDS, but accessor returns bytes */
-	header->size = GET_SIZE(readl(disc_table + SIZE_OFFSET));
+	header->size = GET_SIZE(disc_header[SIZE_IDX]);
 
 	return 0;
 }
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 30+ messages in thread

* [PATCH v19 03/19] drm/xe/vsec: VSEC requires soc-remapper
  2026-11-19 15:54 [PATCH v19 00/19] Crescent Island PMT support Michael J. Ruhl
  2026-11-19 15:54 ` [PATCH v19 01/19] platform/x86/intel/pmt: Introduce a callback for discovery data Michael J. Ruhl
  2026-11-19 15:54 ` [PATCH v19 02/19] platform/x86/intel/pmt: Use the pre-populated header info for crashlog Michael J. Ruhl
@ 2026-11-19 15:54 ` Michael J. Ruhl
  2026-11-19 15:54 ` [PATCH v19 04/19] drm/xe/vsec: Do not register BMG PMT for VF Michael J. Ruhl
                   ` (18 subsequent siblings)
  21 siblings, 0 replies; 30+ messages in thread
From: Michael J. Ruhl @ 2026-11-19 15:54 UTC (permalink / raw)
  To: platform-driver-x86, intel-xe, hansg, ilpo.jarvinen,
	matthew.brost, rodrigo.vivi, thomas.hellstrom, airlied, simona,
	david.e.box, anoop.c.vijay, badal.nilawar, matthew.d.roper,
	james.ausmus

Survivability mode includes xe_vsec_init().  VSEC requires
the soc remapper to be initialized.

Add the correct init to allow correct VSEC behavior.

Fixes: 32eab46a6160 ("drm/xe/soc_remapper: Use SoC remapper helper from VSEC code")
Signed-off-by: Michael J. Ruhl <michael.j.ruhl@intel.com>
---
 drivers/gpu/drm/xe/xe_survivability_mode.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/xe/xe_survivability_mode.c b/drivers/gpu/drm/xe/xe_survivability_mode.c
index 91a0680e449b..10f9de4eb03b 100644
--- a/drivers/gpu/drm/xe/xe_survivability_mode.c
+++ b/drivers/gpu/drm/xe/xe_survivability_mode.c
@@ -21,6 +21,7 @@
 #include "xe_nvm.h"
 #include "xe_pcode_api.h"
 #include "xe_printk.h"
+#include "xe_soc_remapper.h"
 #include "xe_vsec.h"
 #include "xe_wedge.h"
 
@@ -354,6 +355,7 @@ static int enable_boot_survivability_mode(struct pci_dev *pdev)
 
 	xe_heci_gsc_init(xe);
 
+	xe_soc_remapper_init(xe);
 	xe_vsec_init(xe);
 
 	if (survivability->fdo_mode) {
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 30+ messages in thread

* [PATCH v19 04/19] drm/xe/vsec: Do not register BMG PMT for VF
  2026-11-19 15:54 [PATCH v19 00/19] Crescent Island PMT support Michael J. Ruhl
                   ` (2 preceding siblings ...)
  2026-11-19 15:54 ` [PATCH v19 03/19] drm/xe/vsec: VSEC requires soc-remapper Michael J. Ruhl
@ 2026-11-19 15:54 ` Michael J. Ruhl
  2026-11-19 15:54 ` [PATCH v19 05/19] drm/xe/vsec: Correct locking order Michael J. Ruhl
                   ` (17 subsequent siblings)
  21 siblings, 0 replies; 30+ messages in thread
From: Michael J. Ruhl @ 2026-11-19 15:54 UTC (permalink / raw)
  To: platform-driver-x86, intel-xe, hansg, ilpo.jarvinen,
	matthew.brost, rodrigo.vivi, thomas.hellstrom, airlied, simona,
	david.e.box, anoop.c.vijay, badal.nilawar, matthew.d.roper,
	james.ausmus

BMG PMT is not supported for VF nodes.

If IS_SRIOV_VF() is true, do NOT register with PMT.

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Michael J. Ruhl <michael.j.ruhl@intel.com>
---
 drivers/gpu/drm/xe/xe_vsec.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_vsec.c b/drivers/gpu/drm/xe/xe_vsec.c
index a9baf0bfe572..178f22db4046 100644
--- a/drivers/gpu/drm/xe/xe_vsec.c
+++ b/drivers/gpu/drm/xe/xe_vsec.c
@@ -149,6 +149,8 @@ int xe_pmt_telem_read(struct device *dev, u32 guid, u64 *data, loff_t user_offse
 	u32 offset;
 	int ret;
 
+	xe_assert(xe, !IS_SRIOV_VF(xe));
+
 	ret = xe_guid_decode(guid, &mem_region, &offset);
 	if (ret)
 		return ret;
@@ -157,9 +159,6 @@ int xe_pmt_telem_read(struct device *dev, u32 guid, u64 *data, loff_t user_offse
 
 	guard(mutex)(&xe->pmt.lock);
 
-	if (!xe->soc_remapper.set_telem_region)
-		return -ENODEV;
-
 	/* indicate that we are not at an appropriate power level */
 	if (!xe_pm_runtime_get_if_active(xe))
 		return -ENODATA;
@@ -186,6 +185,9 @@ static enum xe_vsec get_platform_info(struct xe_device *xe)
 	if (xe->info.platform > XE_BATTLEMAGE)
 		return XE_VSEC_UNKNOWN;
 
+	if (IS_SRIOV_VF(xe) && xe->info.platform == XE_BATTLEMAGE)
+		return XE_VSEC_UNKNOWN;
+
 	return vsec_platforms[xe->info.platform];
 }
 
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 30+ messages in thread

* [PATCH v19 05/19] drm/xe/vsec: Correct locking order
  2026-11-19 15:54 [PATCH v19 00/19] Crescent Island PMT support Michael J. Ruhl
                   ` (3 preceding siblings ...)
  2026-11-19 15:54 ` [PATCH v19 04/19] drm/xe/vsec: Do not register BMG PMT for VF Michael J. Ruhl
@ 2026-11-19 15:54 ` Michael J. Ruhl
  2026-11-19 15:54 ` [PATCH v19 06/19] drm/xe/vsec: Use correct pm state get Michael J. Ruhl
                   ` (16 subsequent siblings)
  21 siblings, 0 replies; 30+ messages in thread
From: Michael J. Ruhl @ 2026-11-19 15:54 UTC (permalink / raw)
  To: platform-driver-x86, intel-xe, hansg, ilpo.jarvinen,
	matthew.brost, rodrigo.vivi, thomas.hellstrom, airlied, simona,
	david.e.box, anoop.c.vijay, badal.nilawar, matthew.d.roper,
	james.ausmus

Xe locking order is power state first, and then local locks.

Reorder locking for correct usage.

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Michael J. Ruhl <michael.j.ruhl@intel.com>
---
 drivers/gpu/drm/xe/xe_vsec.c | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_vsec.c b/drivers/gpu/drm/xe/xe_vsec.c
index 178f22db4046..d93c042cf25b 100644
--- a/drivers/gpu/drm/xe/xe_vsec.c
+++ b/drivers/gpu/drm/xe/xe_vsec.c
@@ -157,16 +157,17 @@ int xe_pmt_telem_read(struct device *dev, u32 guid, u64 *data, loff_t user_offse
 
 	telem_addr += offset + user_offset;
 
-	guard(mutex)(&xe->pmt.lock);
-
 	/* indicate that we are not at an appropriate power level */
 	if (!xe_pm_runtime_get_if_active(xe))
 		return -ENODATA;
 
-	/* set SoC re-mapper index register based on GUID memory region */
-	xe->soc_remapper.set_telem_region(xe, mem_region);
+	scoped_guard(mutex, &xe->pmt.lock) {
+		/* set SoC re-mapper index register based on GUID memory region */
+		xe->soc_remapper.set_telem_region(xe, mem_region);
+
+		memcpy_fromio(data, telem_addr, count);
+	}
 
-	memcpy_fromio(data, telem_addr, count);
 	xe_pm_runtime_put(xe);
 
 	return count;
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 30+ messages in thread

* [PATCH v19 06/19] drm/xe/vsec: Use correct pm state get
  2026-11-19 15:54 [PATCH v19 00/19] Crescent Island PMT support Michael J. Ruhl
                   ` (4 preceding siblings ...)
  2026-11-19 15:54 ` [PATCH v19 05/19] drm/xe/vsec: Correct locking order Michael J. Ruhl
@ 2026-11-19 15:54 ` Michael J. Ruhl
  2026-11-19 15:54 ` [PATCH v19 07/19] drm/xe/vsec: Add DOC text for VSEC Michael J. Ruhl
                   ` (15 subsequent siblings)
  21 siblings, 0 replies; 30+ messages in thread
From: Michael J. Ruhl @ 2026-11-19 15:54 UTC (permalink / raw)
  To: platform-driver-x86, intel-xe, hansg, ilpo.jarvinen,
	matthew.brost, rodrigo.vivi, thomas.hellstrom, airlied, simona,
	david.e.box, anoop.c.vijay, badal.nilawar, matthew.d.roper,
	james.ausmus

Crashlog needs to be collected at all times.  The current pm check
assumes telemetry only.

Update read path to enable device for crashlog instances.

Include check of the WATCHER CAP_TYPE for completeness.
WATCHER is a possible type and needs to be accounted for, but is not
supported.

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Fixes: 0c45e76fcc62 ("drm/xe/vsec: Support BMG devices")
Signed-off-by: Michael J. Ruhl <michael.j.ruhl@intel.com>
---
 drivers/gpu/drm/xe/xe_vsec.c | 16 +++++++++++++---
 1 file changed, 13 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_vsec.c b/drivers/gpu/drm/xe/xe_vsec.c
index d93c042cf25b..38081dacd307 100644
--- a/drivers/gpu/drm/xe/xe_vsec.c
+++ b/drivers/gpu/drm/xe/xe_vsec.c
@@ -145,6 +145,7 @@ int xe_pmt_telem_read(struct device *dev, u32 guid, u64 *data, loff_t user_offse
 {
 	struct xe_device *xe = kdev_to_xe_device(dev);
 	void __iomem *telem_addr = xe->mmio.regs + BMG_TELEMETRY_OFFSET;
+	u32 cap_type = FIELD_GET(GUID_CAP_TYPE, guid);
 	u32 mem_region;
 	u32 offset;
 	int ret;
@@ -157,9 +158,18 @@ int xe_pmt_telem_read(struct device *dev, u32 guid, u64 *data, loff_t user_offse
 
 	telem_addr += offset + user_offset;
 
-	/* indicate that we are not at an appropriate power level */
-	if (!xe_pm_runtime_get_if_active(xe))
-		return -ENODATA;
+	/* Always allow crashlog. Telemetry, only when powered */
+	switch (cap_type) {
+	case CRASHLOG:
+		xe_pm_runtime_get(xe);
+		break;
+	case TELEMETRY:
+		if (!xe_pm_runtime_get_if_active(xe))
+			return -ENODATA;
+		break;
+	case WATCHER:
+		return -EINVAL;
+	}
 
 	scoped_guard(mutex, &xe->pmt.lock) {
 		/* set SoC re-mapper index register based on GUID memory region */
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 30+ messages in thread

* [PATCH v19 07/19] drm/xe/vsec: Add DOC text for VSEC
  2026-11-19 15:54 [PATCH v19 00/19] Crescent Island PMT support Michael J. Ruhl
                   ` (5 preceding siblings ...)
  2026-11-19 15:54 ` [PATCH v19 06/19] drm/xe/vsec: Use correct pm state get Michael J. Ruhl
@ 2026-11-19 15:54 ` Michael J. Ruhl
  2026-11-19 15:54 ` [PATCH v19 08/19] drm/xe/vsec: Support possible hotplug exit Michael J. Ruhl
                   ` (14 subsequent siblings)
  21 siblings, 0 replies; 30+ messages in thread
From: Michael J. Ruhl @ 2026-11-19 15:54 UTC (permalink / raw)
  To: platform-driver-x86, intel-xe, hansg, ilpo.jarvinen,
	matthew.brost, rodrigo.vivi, thomas.hellstrom, airlied, simona,
	david.e.box, anoop.c.vijay, badal.nilawar, matthew.d.roper,
	james.ausmus

Add the necessary files and text to use the DOC system.

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Michael J. Ruhl <michael.j.ruhl@intel.com>
---
 Documentation/gpu/xe/index.rst   |  1 +
 Documentation/gpu/xe/xe_vsec.rst | 14 ++++++++++++++
 drivers/gpu/drm/xe/xe_vsec.c     | 24 ++++++++++++++++++++++++
 3 files changed, 39 insertions(+)
 create mode 100644 Documentation/gpu/xe/xe_vsec.rst

diff --git a/Documentation/gpu/xe/index.rst b/Documentation/gpu/xe/index.rst
index 497a0a4b12f6..de829aecf8f1 100644
--- a/Documentation/gpu/xe/index.rst
+++ b/Documentation/gpu/xe/index.rst
@@ -37,3 +37,4 @@ The display, or :ref:`drm-kms`, support for drm/xe is provided by
    xe_gt_stats
    xe_sigid
    xe_pci_error
+   xe_vsec
diff --git a/Documentation/gpu/xe/xe_vsec.rst b/Documentation/gpu/xe/xe_vsec.rst
new file mode 100644
index 000000000000..1a87548489ea
--- /dev/null
+++ b/Documentation/gpu/xe/xe_vsec.rst
@@ -0,0 +1,14 @@
+.. SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+
+=====
+VSEC
+=====
+
+.. kernel-doc:: drivers/gpu/drm/xe/xe_vsec.c
+   :doc: VSEC
+
+Internal API
+============
+
+.. kernel-doc:: drivers/gpu/drm/xe/xe_vsec.c
+   :internal:
diff --git a/drivers/gpu/drm/xe/xe_vsec.c b/drivers/gpu/drm/xe/xe_vsec.c
index 38081dacd307..082b25b017db 100644
--- a/drivers/gpu/drm/xe/xe_vsec.c
+++ b/drivers/gpu/drm/xe/xe_vsec.c
@@ -19,6 +19,17 @@
 
 #include "regs/xe_pmt.h"
 
+/**
+ * DOC: VSEC
+ *
+ * Some GPUs support the PMT feature.  For those that do, this API provides
+ * probe, discovery and usage (control and access) for GPUs that have PMT.
+ *
+ * PMT is usually accessed through a PCI function.  However, that is not always
+ * available, so the PMT intel_vsec_register() function can be used to set up
+ * PMT usage.
+ */
+
 /* PMT GUID value for BMG devices.  NOTE: this is NOT a PCI id */
 #define BMG_DEVICE_ID 0xE2F8
 
@@ -140,6 +151,19 @@ static int xe_guid_decode(u32 guid, int *index, u32 *offset)
 	return 0;
 }
 
+/**
+ * xe_pmt_telem_read - Given a device and a PMT GUID, read data into a buffer
+ * @dev: valid Xe device
+ * @guid: PMT GUID (from the PMT discovery struct)
+ * @data: buffer to place data in
+ * @user_offset: a user offset relative to the beginning of the data to read
+ * @count: bytes to read
+ *
+ * Return:
+ * * -ENODATA for incorrect power state
+ * * -EINVAL for unsupported PMT feature
+ * * count   number of bytes read on success
+ */
 int xe_pmt_telem_read(struct device *dev, u32 guid, u64 *data, loff_t user_offset,
 		      u32 count)
 {
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 30+ messages in thread

* [PATCH v19 08/19] drm/xe/vsec: Support possible hotplug exit
  2026-11-19 15:54 [PATCH v19 00/19] Crescent Island PMT support Michael J. Ruhl
                   ` (6 preceding siblings ...)
  2026-11-19 15:54 ` [PATCH v19 07/19] drm/xe/vsec: Add DOC text for VSEC Michael J. Ruhl
@ 2026-11-19 15:54 ` Michael J. Ruhl
  2026-11-19 15:54 ` [PATCH v19 09/19] drm/xe/vsec: Refactor BattleMage PMT defines Michael J. Ruhl
                   ` (13 subsequent siblings)
  21 siblings, 0 replies; 30+ messages in thread
From: Michael J. Ruhl @ 2026-11-19 15:54 UTC (permalink / raw)
  To: platform-driver-x86, intel-xe, hansg, ilpo.jarvinen,
	matthew.brost, rodrigo.vivi, thomas.hellstrom, airlied, simona,
	david.e.box, anoop.c.vijay, badal.nilawar, matthew.d.roper,
	james.ausmus

DRM has an API that will verify that a device is valid in the hotplug
context.

Verify device is valid before access in the VSEC callback API.

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Michael J. Ruhl <michael.j.ruhl@intel.com>
---
 drivers/gpu/drm/xe/xe_vsec.c | 29 +++++++++++++++++++++++------
 1 file changed, 23 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_vsec.c b/drivers/gpu/drm/xe/xe_vsec.c
index 082b25b017db..c0e06b2aeca6 100644
--- a/drivers/gpu/drm/xe/xe_vsec.c
+++ b/drivers/gpu/drm/xe/xe_vsec.c
@@ -10,6 +10,8 @@
 #include <linux/pci.h>
 #include <linux/types.h>
 
+#include <drm/drm_drv.h>
+
 #include "xe_device.h"
 #include "xe_device_types.h"
 #include "xe_mmio.h"
@@ -159,7 +161,12 @@ static int xe_guid_decode(u32 guid, int *index, u32 *offset)
  * @user_offset: a user offset relative to the beginning of the data to read
  * @count: bytes to read
  *
+ * This is a callback API.  I.e this can be accessed external to the XE driver
+ * (PMT driver scope).  Because of this, DRM hotplug needs to be verified
+ * (drm_dev_enter()).
+ *
  * Return:
+ * * -ENODEV device is not available (hotplug)
  * * -ENODATA for incorrect power state
  * * -EINVAL for unsupported PMT feature
  * * count   number of bytes read on success
@@ -172,13 +179,17 @@ int xe_pmt_telem_read(struct device *dev, u32 guid, u64 *data, loff_t user_offse
 	u32 cap_type = FIELD_GET(GUID_CAP_TYPE, guid);
 	u32 mem_region;
 	u32 offset;
-	int ret;
+	int ret = 0;
+	int idx;
 
 	xe_assert(xe, !IS_SRIOV_VF(xe));
 
+	if (!drm_dev_enter(&xe->drm, &idx))
+		return -ENODEV;
+
 	ret = xe_guid_decode(guid, &mem_region, &offset);
 	if (ret)
-		return ret;
+		goto dev_exit;
 
 	telem_addr += offset + user_offset;
 
@@ -188,11 +199,14 @@ int xe_pmt_telem_read(struct device *dev, u32 guid, u64 *data, loff_t user_offse
 		xe_pm_runtime_get(xe);
 		break;
 	case TELEMETRY:
-		if (!xe_pm_runtime_get_if_active(xe))
-			return -ENODATA;
+		if (!xe_pm_runtime_get_if_active(xe)) {
+			ret = -ENODATA;
+			goto dev_exit;
+		}
 		break;
 	case WATCHER:
-		return -EINVAL;
+		ret = -EINVAL;
+		goto dev_exit;
 	}
 
 	scoped_guard(mutex, &xe->pmt.lock) {
@@ -204,7 +218,10 @@ int xe_pmt_telem_read(struct device *dev, u32 guid, u64 *data, loff_t user_offse
 
 	xe_pm_runtime_put(xe);
 
-	return count;
+dev_exit:
+	drm_dev_exit(idx);
+
+	return ret == 0 ? count : ret;
 }
 
 static struct pmt_callbacks xe_pmt_cb = {
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 30+ messages in thread

* [PATCH v19 09/19] drm/xe/vsec: Refactor BattleMage PMT defines
  2026-11-19 15:54 [PATCH v19 00/19] Crescent Island PMT support Michael J. Ruhl
                   ` (7 preceding siblings ...)
  2026-11-19 15:54 ` [PATCH v19 08/19] drm/xe/vsec: Support possible hotplug exit Michael J. Ruhl
@ 2026-11-19 15:54 ` Michael J. Ruhl
  2026-11-19 15:54 ` [PATCH v19 10/19] drm/xe/vsec: Update VSEC probe order Michael J. Ruhl
                   ` (12 subsequent siblings)
  21 siblings, 0 replies; 30+ messages in thread
From: Michael J. Ruhl @ 2026-11-19 15:54 UTC (permalink / raw)
  To: platform-driver-x86, intel-xe, hansg, ilpo.jarvinen,
	matthew.brost, rodrigo.vivi, thomas.hellstrom, airlied, simona,
	david.e.box, anoop.c.vijay, badal.nilawar, matthew.d.roper,
	james.ausmus

Rename generic defines to be BMG specific.
Define several magic numbers.

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Michael J. Ruhl <michael.j.ruhl@intel.com>
---
 drivers/gpu/drm/xe/xe_vsec.c | 29 +++++++++++++++++------------
 1 file changed, 17 insertions(+), 12 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_vsec.c b/drivers/gpu/drm/xe/xe_vsec.c
index c0e06b2aeca6..ebe56c85bc05 100644
--- a/drivers/gpu/drm/xe/xe_vsec.c
+++ b/drivers/gpu/drm/xe/xe_vsec.c
@@ -90,10 +90,15 @@ static struct intel_vsec_platform_info xe_vsec_info[] = {
 #define GUID_CAP_TYPE		GENMASK(29, 28)
 #define GUID_RECORD_ID		GENMASK(31, 30)
 
-#define PUNIT_TELEMETRY_OFFSET		0x0200
-#define PUNIT_WATCHER_OFFSET		0x14A0
-#define OOBMSM_0_WATCHER_OFFSET		0x18D8
-#define OOBMSM_1_TELEMETRY_OFFSET	0x1000
+#define BMG_IDX_TELEM_PUNIT		0x00
+#define BMG_IDX_TELEM_OOBMSM		0x01
+#define BMG_IDX_CRASHLOG_PUNIT		0x02
+#define BMG_IDX_CRASHLOG_OOBMSM		0x04
+
+#define BMG_PUNIT_TELEMETRY_OFFSET	0x0200
+#define BMG_PUNIT_WATCHER_OFFSET	0x14A0
+#define BMG_OOBMSM_0_WATCHER_OFFSET	0x18D8
+#define BMG_OOBMSM_1_TELEMETRY_OFFSET	0x1000
 
 enum record_id {
 	PUNIT,
@@ -122,29 +127,29 @@ static int xe_guid_decode(u32 guid, int *index, u32 *offset)
 	*offset = 0;
 
 	if (cap_type == CRASHLOG) {
-		*index = record_id == PUNIT ? 2 : 4;
+		*index = record_id == PUNIT ? BMG_IDX_CRASHLOG_PUNIT : BMG_IDX_CRASHLOG_OOBMSM;
 		return 0;
 	}
 
 	switch (record_id) {
 	case PUNIT:
-		*index = 0;
+		*index = BMG_IDX_TELEM_PUNIT;
 		if (cap_type == TELEMETRY)
-			*offset = PUNIT_TELEMETRY_OFFSET;
+			*offset = BMG_PUNIT_TELEMETRY_OFFSET;
 		else
-			*offset = PUNIT_WATCHER_OFFSET;
+			*offset = BMG_PUNIT_WATCHER_OFFSET;
 		break;
 
 	case OOBMSM_0:
-		*index = 1;
+		*index = BMG_IDX_TELEM_OOBMSM;
 		if (cap_type == WATCHER)
-			*offset = OOBMSM_0_WATCHER_OFFSET;
+			*offset = BMG_OOBMSM_0_WATCHER_OFFSET;
 		break;
 
 	case OOBMSM_1:
-		*index = 1;
+		*index = BMG_IDX_TELEM_OOBMSM;
 		if (cap_type == TELEMETRY)
-			*offset = OOBMSM_1_TELEMETRY_OFFSET;
+			*offset = BMG_OOBMSM_1_TELEMETRY_OFFSET;
 		break;
 	default:
 		return -EINVAL;
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 30+ messages in thread

* [PATCH v19 10/19] drm/xe/vsec: Update VSEC probe order
  2026-11-19 15:54 [PATCH v19 00/19] Crescent Island PMT support Michael J. Ruhl
                   ` (8 preceding siblings ...)
  2026-11-19 15:54 ` [PATCH v19 09/19] drm/xe/vsec: Refactor BattleMage PMT defines Michael J. Ruhl
@ 2026-11-19 15:54 ` Michael J. Ruhl
  2026-11-19 15:54 ` [PATCH v19 11/19] drm/xe/vsec: Add base_offset to allow for more flexibilty Michael J. Ruhl
                   ` (11 subsequent siblings)
  21 siblings, 0 replies; 30+ messages in thread
From: Michael J. Ruhl @ 2026-11-19 15:54 UTC (permalink / raw)
  To: platform-driver-x86, intel-xe, hansg, ilpo.jarvinen,
	matthew.brost, rodrigo.vivi, thomas.hellstrom, airlied, simona,
	david.e.box, anoop.c.vijay, badal.nilawar, matthew.d.roper,
	james.ausmus

Both debugfs and hwmon access the PMT data area before PMT is
initialized.

Hardwired offset usage allows this to work by accident.
Upcoming changes will break this usage.

Re-order the probe steps to initialize VSEC before the other
features are initialized.

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Michael J. Ruhl <michael.j.ruhl@intel.com>
---
 drivers/gpu/drm/xe/xe_device.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c
index f5a581d39c96..ba1f49a56794 100644
--- a/drivers/gpu/drm/xe/xe_device.c
+++ b/drivers/gpu/drm/xe/xe_device.c
@@ -1088,6 +1088,8 @@ int xe_device_probe(struct xe_device *xe)
 	if (err)
 		goto err_unregister_display;
 
+	xe_vsec_init(xe);
+
 	xe_debugfs_register(xe);
 
 	err = xe_hwmon_register(xe);
@@ -1098,8 +1100,6 @@ int xe_device_probe(struct xe_device *xe)
 	if (err)
 		goto err_unregister_display;
 
-	xe_vsec_init(xe);
-
 	err = xe_sriov_init_late(xe);
 	if (err)
 		goto err_unregister_display;
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 30+ messages in thread

* [PATCH v19 11/19] drm/xe/vsec: Add base_offset to allow for more flexibilty
  2026-11-19 15:54 [PATCH v19 00/19] Crescent Island PMT support Michael J. Ruhl
                   ` (9 preceding siblings ...)
  2026-11-19 15:54 ` [PATCH v19 10/19] drm/xe/vsec: Update VSEC probe order Michael J. Ruhl
@ 2026-11-19 15:54 ` Michael J. Ruhl
  2026-11-19 15:54 ` [PATCH v19 12/19] drm/xe/vsec: Support Crescent Island PMT Michael J. Ruhl
                   ` (10 subsequent siblings)
  21 siblings, 0 replies; 30+ messages in thread
From: Michael J. Ruhl @ 2026-11-19 15:54 UTC (permalink / raw)
  To: platform-driver-x86, intel-xe, hansg, ilpo.jarvinen,
	matthew.brost, rodrigo.vivi, thomas.hellstrom, airlied, simona,
	david.e.box, anoop.c.vijay, badal.nilawar, matthew.d.roper,
	james.ausmus

Current pmt_telem_read() usage is a fixed (for BMG) offset.
In order to support other devices this must be settable.

Add a base offset for more flexibility.
Add a check to verify that it has been set before allowing
device access.

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Michael J. Ruhl <michael.j.ruhl@intel.com>
---
 drivers/gpu/drm/xe/xe_device_types.h | 2 ++
 drivers/gpu/drm/xe/xe_vsec.c         | 9 ++++++++-
 2 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_device_types.h b/drivers/gpu/drm/xe/xe_device_types.h
index 8f2a31949073..28b1669a14d8 100644
--- a/drivers/gpu/drm/xe/xe_device_types.h
+++ b/drivers/gpu/drm/xe/xe_device_types.h
@@ -485,6 +485,8 @@ struct xe_device {
 	struct {
 		/** @pmt.lock: protect access for telemetry data */
 		struct mutex lock;
+		/** @pmt.base_offset: device specific base offset */
+		u64 base_offset;
 	} pmt;
 
 	/** @soc_remapper: SoC remapper object */
diff --git a/drivers/gpu/drm/xe/xe_vsec.c b/drivers/gpu/drm/xe/xe_vsec.c
index ebe56c85bc05..04aec1e5c15c 100644
--- a/drivers/gpu/drm/xe/xe_vsec.c
+++ b/drivers/gpu/drm/xe/xe_vsec.c
@@ -172,6 +172,7 @@ static int xe_guid_decode(u32 guid, int *index, u32 *offset)
  *
  * Return:
  * * -ENODEV device is not available (hotplug)
+ * * -EAGAIN base_offset has not been set, so init path has not yet been done.
  * * -ENODATA for incorrect power state
  * * -EINVAL for unsupported PMT feature
  * * count   number of bytes read on success
@@ -180,8 +181,8 @@ int xe_pmt_telem_read(struct device *dev, u32 guid, u64 *data, loff_t user_offse
 		      u32 count)
 {
 	struct xe_device *xe = kdev_to_xe_device(dev);
-	void __iomem *telem_addr = xe->mmio.regs + BMG_TELEMETRY_OFFSET;
 	u32 cap_type = FIELD_GET(GUID_CAP_TYPE, guid);
+	void __iomem *telem_addr = xe->mmio.regs + xe->pmt.base_offset;
 	u32 mem_region;
 	u32 offset;
 	int ret = 0;
@@ -192,6 +193,11 @@ int xe_pmt_telem_read(struct device *dev, u32 guid, u64 *data, loff_t user_offse
 	if (!drm_dev_enter(&xe->drm, &idx))
 		return -ENODEV;
 
+	if (!xe->pmt.base_offset) {
+		ret = -EAGAIN;
+		goto dev_exit;
+	}
+
 	ret = xe_guid_decode(guid, &mem_region, &offset);
 	if (ret)
 		goto dev_exit;
@@ -269,6 +275,7 @@ void xe_vsec_init(struct xe_device *xe)
 
 	switch (platform) {
 	case XE_VSEC_BMG:
+		xe->pmt.base_offset = BMG_TELEMETRY_OFFSET;
 		info->priv_data = &xe_pmt_cb;
 		break;
 	default:
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 30+ messages in thread

* [PATCH v19 12/19] drm/xe/vsec: Support Crescent Island PMT
  2026-11-19 15:54 [PATCH v19 00/19] Crescent Island PMT support Michael J. Ruhl
                   ` (10 preceding siblings ...)
  2026-11-19 15:54 ` [PATCH v19 11/19] drm/xe/vsec: Add base_offset to allow for more flexibilty Michael J. Ruhl
@ 2026-11-19 15:54 ` Michael J. Ruhl
  2026-11-19 15:54 ` [PATCH v19 13/19] drm/xe/vsec: Crescent Island PMT decode Michael J. Ruhl
                   ` (9 subsequent siblings)
  21 siblings, 0 replies; 30+ messages in thread
From: Michael J. Ruhl @ 2026-11-19 15:54 UTC (permalink / raw)
  To: platform-driver-x86, intel-xe, hansg, ilpo.jarvinen,
	matthew.brost, rodrigo.vivi, thomas.hellstrom, airlied, simona,
	david.e.box, anoop.c.vijay, badal.nilawar, matthew.d.roper,
	james.ausmus

Crescent Island (CRI) supports PMT telemetry and crashlog.

Add Crescent Island (CRI) discovery structure (DVSEC) information to
allow for Xe registration.

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Michael J. Ruhl <michael.j.ruhl@intel.com>
---
 drivers/gpu/drm/xe/regs/xe_pmt.h |  8 +++--
 drivers/gpu/drm/xe/xe_vsec.c     | 51 +++++++++++++++++++++++++++++---
 2 files changed, 53 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/xe/regs/xe_pmt.h b/drivers/gpu/drm/xe/regs/xe_pmt.h
index a62ab05c6b4c..2f6658395587 100644
--- a/drivers/gpu/drm/xe/regs/xe_pmt.h
+++ b/drivers/gpu/drm/xe/regs/xe_pmt.h
@@ -17,8 +17,12 @@
 
 #define PUNIT_VERSION_OFFSET		0xA0
 
-#define BMG_TELEMETRY_BASE_OFFSET	0xE0000
-#define BMG_TELEMETRY_OFFSET		(SOC_BASE + BMG_TELEMETRY_BASE_OFFSET)
+#define XE_PMT_BASE_OFFSET		0xE0000
+
+#define BMG_TELEMETRY_OFFSET		(SOC_BASE + XE_PMT_BASE_OFFSET)
+
+/* for CRI discovery and telemetry are in an indexed window */
+#define CRI_PMT_OFFSET			(SOC_BASE + XE_PMT_BASE_OFFSET)
 
 #define BMG_MODS_RESIDENCY_OFFSET		(0x4D0)
 #define BMG_G2_RESIDENCY_OFFSET		(0x530)
diff --git a/drivers/gpu/drm/xe/xe_vsec.c b/drivers/gpu/drm/xe/xe_vsec.c
index 04aec1e5c15c..4ecc2d9f3f38 100644
--- a/drivers/gpu/drm/xe/xe_vsec.c
+++ b/drivers/gpu/drm/xe/xe_vsec.c
@@ -8,6 +8,7 @@
 #include <linux/module.h>
 #include <linux/mutex.h>
 #include <linux/pci.h>
+#include <linux/sizes.h>
 #include <linux/types.h>
 
 #include <drm/drm_drv.h>
@@ -32,12 +33,23 @@
  * PMT usage.
  */
 
-/* PMT GUID value for BMG devices.  NOTE: this is NOT a PCI id */
+/* PMT GUID value for BMG and CRI devices.  NOTE: this is NOT a PCI id */
 #define BMG_DEVICE_ID 0xE2F8
+#define CRI_DEVICE_ID 0xE2FA
+
+/*
+ * sizeof(Crashlog Type1 Version2) = 0x18 (24) bytes
+ * For BMG and CRI PUNIT and OOBMSMS crashlogs are consecutive.
+ */
+#define BMG_CRASHLOG_PUNIT_DISC_OFFSET (0x60)
+#define BMG_CRASHLOG_OOBMSM_DISC_OFFSET (BMG_CRASHLOG_PUNIT_DISC_OFFSET + 0x18)
+
+#define CRI_CRASHLOG_PUNIT_DISC_OFFSET (0x80)
+#define CRI_CRASHLOG_OOBMSM_DISC_OFFSET (CRI_CRASHLOG_PUNIT_DISC_OFFSET + 0x18)
 
 static struct intel_vsec_header bmg_telemetry = {
 	.rev = 1,
-	.length = 0x10,
+	.length = SZ_16,
 	.id = VSEC_ID_TELEMETRY,
 	.num_entries = 2,
 	.entry_size = 4,
@@ -47,12 +59,12 @@ static struct intel_vsec_header bmg_telemetry = {
 
 static struct intel_vsec_header bmg_crashlog = {
 	.rev = 1,
-	.length = 0x10,
+	.length = SZ_16,
 	.id = VSEC_ID_CRASHLOG,
 	.num_entries = 2,
 	.entry_size = 6,
 	.tbir = 0,
-	.offset = BMG_DISCOVERY_OFFSET + 0x60,
+	.offset = BMG_DISCOVERY_OFFSET + BMG_CRASHLOG_PUNIT_DISC_OFFSET,
 };
 
 static struct intel_vsec_header *bmg_capabilities[] = {
@@ -61,9 +73,36 @@ static struct intel_vsec_header *bmg_capabilities[] = {
 	NULL
 };
 
+static struct intel_vsec_header cri_telemetry = {
+	.rev = 1,
+	.length = SZ_16,
+	.id = VSEC_ID_TELEMETRY,
+	.num_entries = 3,
+	.entry_size = 4,
+	.tbir = 0,
+	.offset = CRI_PMT_OFFSET,
+};
+
+static struct intel_vsec_header cri_crashlog = {
+	.rev = 1,
+	.length = SZ_16,
+	.id = VSEC_ID_CRASHLOG,
+	.num_entries = 2,
+	.entry_size = 6,
+	.tbir = 0,
+	.offset = CRI_PMT_OFFSET + CRI_CRASHLOG_PUNIT_DISC_OFFSET,
+};
+
+static struct intel_vsec_header *cri_capabilities[] = {
+	&cri_telemetry,
+	&cri_crashlog,
+	NULL
+};
+
 enum xe_vsec {
 	XE_VSEC_UNKNOWN = 0,
 	XE_VSEC_BMG,
+	XE_VSEC_CRI,
 };
 
 static struct intel_vsec_platform_info xe_vsec_info[] = {
@@ -71,6 +110,10 @@ static struct intel_vsec_platform_info xe_vsec_info[] = {
 		.caps = VSEC_CAP_TELEMETRY | VSEC_CAP_CRASHLOG,
 		.headers = bmg_capabilities,
 	},
+	[XE_VSEC_CRI] = {
+		.caps = VSEC_CAP_TELEMETRY | VSEC_CAP_CRASHLOG,
+		.headers = cri_capabilities,
+	},
 	{ }
 };
 
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 30+ messages in thread

* [PATCH v19 13/19] drm/xe/vsec: Crescent Island PMT decode
  2026-11-19 15:54 [PATCH v19 00/19] Crescent Island PMT support Michael J. Ruhl
                   ` (11 preceding siblings ...)
  2026-11-19 15:54 ` [PATCH v19 12/19] drm/xe/vsec: Support Crescent Island PMT Michael J. Ruhl
@ 2026-11-19 15:54 ` Michael J. Ruhl
  2026-11-19 15:54 ` [PATCH v19 14/19] drm/xe/vsec: Crescent Island PMT callbacks Michael J. Ruhl
                   ` (8 subsequent siblings)
  21 siblings, 0 replies; 30+ messages in thread
From: Michael J. Ruhl @ 2026-11-19 15:54 UTC (permalink / raw)
  To: platform-driver-x86, intel-xe, hansg, ilpo.jarvinen,
	matthew.brost, rodrigo.vivi, thomas.hellstrom, airlied, simona,
	david.e.box, anoop.c.vijay, badal.nilawar, matthew.d.roper,
	james.ausmus

Crescent Island (CRI) has different index and offset values for
accessing the PMT data area.

Update the decode path to support the CRI device.

Update the data read callback so to support the CRI usage.

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Michael J. Ruhl <michael.j.ruhl@intel.com>
---
 drivers/gpu/drm/xe/xe_vsec.c | 100 +++++++++++++++++++++++++++++++----
 1 file changed, 90 insertions(+), 10 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_vsec.c b/drivers/gpu/drm/xe/xe_vsec.c
index 4ecc2d9f3f38..a814d7151eea 100644
--- a/drivers/gpu/drm/xe/xe_vsec.c
+++ b/drivers/gpu/drm/xe/xe_vsec.c
@@ -120,19 +120,25 @@ static struct intel_vsec_platform_info xe_vsec_info[] = {
 /*
  * The GUID will have the following bits to decode:
  *   [0:3]   - {Telemetry space iteration number (0,1,..)}
- *   [4:7]   - Segment (SEGMENT_INDEPENDENT-0, Client-1, Server-2)
+ *   [4:7]   - BMG Segment (SEGMENT_INDEPENDENT-0, Client-1, Server-2)
+ *   [4:5]   - CRI Segment (SEGMENT_INDEPENDENT-0, Client-1, Server-2)
+ *   [6:7]   - CRI Instance
  *   [8:11]  - SOC_SKU
  *   [12:27] – Device ID – changes for each down bin SKU’s
  *   [28:29] - Capability Type (Crashlog-0, Telemetry Aggregator-1, Watcher-2)
  *   [30:31] - Record-ID (0-PUNIT, 1-OOBMSM_0, 2-OOBMSM_1)
  */
 #define GUID_TELEM_ITERATION	GENMASK(3, 0)
-#define GUID_SEGMENT		GENMASK(7, 4)
 #define GUID_SOC_SKU		GENMASK(11, 8)
 #define GUID_DEVICE_ID		GENMASK(27, 12)
 #define GUID_CAP_TYPE		GENMASK(29, 28)
 #define GUID_RECORD_ID		GENMASK(31, 30)
 
+#define BMG_GUID_SEGMENT	GENMASK(7, 4)
+
+#define CRI_GUID_SEGMENT	GENMASK(5, 4)
+#define CRI_GUID_INSTANCE	GENMASK(7, 6)
+
 #define BMG_IDX_TELEM_PUNIT		0x00
 #define BMG_IDX_TELEM_OOBMSM		0x01
 #define BMG_IDX_CRASHLOG_PUNIT		0x02
@@ -143,6 +149,18 @@ static struct intel_vsec_platform_info xe_vsec_info[] = {
 #define BMG_OOBMSM_0_WATCHER_OFFSET	0x18D8
 #define BMG_OOBMSM_1_TELEMETRY_OFFSET	0x1000
 
+#define CRI_IDX_TELEM_DISCOVERY		0x00
+#define CRI_IDX_TELEM_PUNIT		0x01
+#define CRI_IDX_TELEM_OOBMSM		0x02
+#define CRI_IDX_CRASHLOG_PUNIT		0x03
+#define CRI_IDX_WATCHER_OOBMSM		0x03  /* PUNIT and OOBMSM share this index */
+#define CRI_IDX_CRASHLOG_OOBMSM		0x04
+
+#define CRI_PUNIT_WATCHER_OFFSET		0x08A0
+#define CRI_OOBMSM_WATCHER_OFFSET		0x0CF8
+#define CRI_OOBMSM_GFSP_TELEMETRY_OFFSET	0x1600
+#define CRI_PUNIT_CRASHLOG_OFFSET		0x0E60
+
 enum record_id {
 	PUNIT,
 	OOBMSM_0,
@@ -155,17 +173,10 @@ enum capability {
 	WATCHER,
 };
 
-static int xe_guid_decode(u32 guid, int *index, u32 *offset)
+static int bmg_guid_decode(u32 guid, int *index, u32 *offset)
 {
 	u32 record_id = FIELD_GET(GUID_RECORD_ID, guid);
 	u32 cap_type  = FIELD_GET(GUID_CAP_TYPE, guid);
-	u32 device_id = FIELD_GET(GUID_DEVICE_ID, guid);
-
-	if (device_id != BMG_DEVICE_ID)
-		return -ENODEV;
-
-	if (cap_type > WATCHER)
-		return -EINVAL;
 
 	*offset = 0;
 
@@ -201,6 +212,75 @@ static int xe_guid_decode(u32 guid, int *index, u32 *offset)
 	return 0;
 }
 
+static int cri_guid_decode(u32 guid, int *index, u32 *offset)
+{
+	u32 record_id = FIELD_GET(GUID_RECORD_ID, guid);
+	u32 cap_type  = FIELD_GET(GUID_CAP_TYPE, guid);
+	u32 instance  = FIELD_GET(CRI_GUID_INSTANCE, guid);
+
+	*offset = 0;
+
+	if (cap_type == CRASHLOG) {
+		if (record_id == PUNIT) {
+			*index = CRI_IDX_CRASHLOG_PUNIT;
+			*offset = CRI_PUNIT_CRASHLOG_OFFSET;
+		} else {
+			*index = CRI_IDX_CRASHLOG_OOBMSM;
+		}
+		return 0;
+	}
+
+	switch (record_id) {
+	case PUNIT:
+		*index = CRI_IDX_TELEM_PUNIT;
+		if (cap_type == WATCHER)
+			*offset = CRI_PUNIT_WATCHER_OFFSET;
+		break;
+
+	case OOBMSM_0:
+		*index = CRI_IDX_TELEM_OOBMSM;
+		switch (instance) {
+		case 0:
+			if (cap_type == WATCHER) {
+				*index = CRI_IDX_WATCHER_OOBMSM;
+				*offset = CRI_OOBMSM_WATCHER_OFFSET;
+			}
+			break;
+
+		case 1:
+			if (cap_type == TELEMETRY)
+				*offset = CRI_OOBMSM_GFSP_TELEMETRY_OFFSET;
+			break;
+
+		default:
+			return -EINVAL;
+		}
+		break;
+
+	default:
+		return -EINVAL;
+	}
+
+	return 0;
+}
+
+static int xe_guid_decode(u32 guid, int *index, u32 *offset)
+{
+	u32 cap_type  = FIELD_GET(GUID_CAP_TYPE, guid);
+	u32 device_id = FIELD_GET(GUID_DEVICE_ID, guid);
+
+	if (cap_type > WATCHER)
+		return -EINVAL;
+
+	if (device_id == BMG_DEVICE_ID)
+		return bmg_guid_decode(guid, index, offset);
+
+	if (device_id == CRI_DEVICE_ID)
+		return cri_guid_decode(guid, index, offset);
+
+	return -ENODEV;
+}
+
 /**
  * xe_pmt_telem_read - Given a device and a PMT GUID, read data into a buffer
  * @dev: valid Xe device
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 30+ messages in thread

* [PATCH v19 14/19] drm/xe/vsec: Crescent Island PMT callbacks
  2026-11-19 15:54 [PATCH v19 00/19] Crescent Island PMT support Michael J. Ruhl
                   ` (12 preceding siblings ...)
  2026-11-19 15:54 ` [PATCH v19 13/19] drm/xe/vsec: Crescent Island PMT decode Michael J. Ruhl
@ 2026-11-19 15:54 ` Michael J. Ruhl
  2026-11-19 21:05   ` Rodrigo Vivi
  2026-11-19 15:54 ` [PATCH v19 15/19] drm/xe/vsec: Support late bind fw information Michael J. Ruhl
                   ` (7 subsequent siblings)
  21 siblings, 1 reply; 30+ messages in thread
From: Michael J. Ruhl @ 2026-11-19 15:54 UTC (permalink / raw)
  To: platform-driver-x86, intel-xe, hansg, ilpo.jarvinen,
	matthew.brost, rodrigo.vivi, thomas.hellstrom, airlied, simona,
	david.e.box, anoop.c.vijay, badal.nilawar, matthew.d.roper,
	james.ausmus

CRI PMT support requires callbacks to access the discovery data and
control areas. Access is a common MMIO area that requires an index to
be set before access is allowed.

Introduce the necessary callbacks to get the discovery, status and
control information for CRI PMT usage.

Add the glue logic to register the CRI PMT functionality.

Signed-off-by: Michael J. Ruhl <michael.j.ruhl@intel.com>
---
 drivers/gpu/drm/xe/xe_vsec.c | 178 ++++++++++++++++++++++++++++++++++-
 1 file changed, 174 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_vsec.c b/drivers/gpu/drm/xe/xe_vsec.c
index a814d7151eea..58eb85fb6a9f 100644
--- a/drivers/gpu/drm/xe/xe_vsec.c
+++ b/drivers/gpu/drm/xe/xe_vsec.c
@@ -4,6 +4,7 @@
 #include <linux/bits.h>
 #include <linux/cleanup.h>
 #include <linux/errno.h>
+#include <linux/log2.h>
 #include <linux/intel_vsec.h>
 #include <linux/module.h>
 #include <linux/mutex.h>
@@ -344,10 +345,15 @@ int xe_pmt_telem_read(struct device *dev, u32 guid, u64 *data, loff_t user_offse
 	}
 
 	scoped_guard(mutex, &xe->pmt.lock) {
+		u32 device_id = FIELD_GET(GUID_DEVICE_ID, guid);
+
 		/* set SoC re-mapper index register based on GUID memory region */
 		xe->soc_remapper.set_telem_region(xe, mem_region);
 
 		memcpy_fromio(data, telem_addr, count);
+
+		if (device_id == CRI_DEVICE_ID)
+			xe->soc_remapper.set_telem_region(xe, CRI_IDX_TELEM_DISCOVERY);
 	}
 
 	xe_pm_runtime_put(xe);
@@ -358,20 +364,178 @@ int xe_pmt_telem_read(struct device *dev, u32 guid, u64 *data, loff_t user_offse
 	return ret == 0 ? count : ret;
 }
 
-static struct pmt_callbacks xe_pmt_cb = {
+/**
+ * xe_pmt_discovery_read - Given a device and an index, read discovery data into a buffer
+ * @dev: valid Xe device
+ * @cap_id: PMT type
+ * @element: element to access
+ * @disc_data: buffer for discovery data
+ * @count: bytes to read
+ *
+ * This is a callback API.  I.e this can be accessed external to the XE driver
+ * (PMT driver scope).  Because of this, DRM hotplug needs to be verified
+ * (drm_dev_enter()).
+ *
+ * Return:
+ * * -ENODEV device is not available (hotplug)
+ * * -EINVAL for unsupported device or PMT feature
+ * * 0 on success
+ */
+static int xe_pmt_discovery_read(struct device *dev, unsigned long cap_id, u32 element,
+				 u32 *disc_data)
+{
+	struct xe_device *xe = kdev_to_xe_device(dev);
+	void __iomem *disc_addr = xe->mmio.regs;
+	struct intel_vsec_header *headers;
+	int ret = 0;
+	u32 offset;
+	int idx;
+
+	if (!drm_dev_enter(&xe->drm, &idx))
+		return -ENODEV;
+
+	if (xe->info.platform != XE_CRESCENTISLAND) {
+		ret = -EINVAL;
+		goto dev_exit;
+	}
+
+	switch (cap_id) {
+	case ilog2(VSEC_CAP_TELEMETRY):
+		headers = &cri_telemetry;
+		break;
+
+	case ilog2(VSEC_CAP_CRASHLOG):
+		headers = &cri_crashlog;
+		break;
+
+	default:
+		ret = -EINVAL;
+		goto dev_exit;
+	}
+
+	offset = element * (headers->entry_size * sizeof(u32));
+	disc_addr += headers->offset + offset;
+
+	scoped_guard(mutex, &xe->pmt.lock) {
+		xe->soc_remapper.set_telem_region(xe, CRI_IDX_TELEM_DISCOVERY);
+		memcpy_fromio(disc_data, disc_addr, PMT_DISC_DWORDS * sizeof(u32));
+	}
+
+dev_exit:
+	drm_dev_exit(idx);
+
+	return ret;
+}
+
+/**
+ * xe_pmt_read_reg() - read a crashlog register
+ * @dev: the xe device that registered the callback
+ * @guid: PMT guid of the crashlog instance
+ * @reg: data read from the PMT data structure
+ * @offset: which data to read from the PMT data structure
+ *
+ * Read the requested PMT register based on the pcie device and guid.  The
+ * supported struct is the Crashlog Type1 Version2.
+ *
+ * Currently this is for CRI only.
+ *
+ * Return:
+ * * -ENODEV device is not available (hotplug)
+ * * -EINVAL invalid guid
+ * * 0       success
+ */
+static int xe_pmt_read_reg(struct device *dev, u32 guid, u32 *reg, u32 offset)
+{
+	struct xe_device *xe = kdev_to_xe_device(dev);
+	void __iomem *disc_addr = xe->mmio.regs + xe->pmt.base_offset;
+	int ret = 0;
+	u32 inst;
+	int idx;
+
+	if (FIELD_GET(GUID_DEVICE_ID, guid) != CRI_DEVICE_ID ||
+	    FIELD_GET(GUID_CAP_TYPE, guid) != CRASHLOG)
+		return -EINVAL;
+
+	if (!drm_dev_enter(&xe->drm, &idx))
+		return -ENODEV;
+
+	inst = FIELD_GET(GUID_RECORD_ID, guid) == PUNIT ?
+		CRI_CRASHLOG_PUNIT_DISC_OFFSET : CRI_CRASHLOG_OOBMSM_DISC_OFFSET;
+	disc_addr += inst + offset;
+
+	xe_pm_runtime_get(xe);
+
+	scoped_guard(mutex, &xe->pmt.lock) {
+		xe->soc_remapper.set_telem_region(xe, CRI_IDX_TELEM_DISCOVERY);
+
+		*reg = readl(disc_addr);
+	}
+
+	xe_pm_runtime_put(xe);
+
+	drm_dev_exit(idx);
+
+	return ret;
+}
+
+static int xe_pmt_write_reg(struct device *dev, u32 guid, u32 reg, u32 offset)
+{
+	struct xe_device *xe = kdev_to_xe_device(dev);
+	void __iomem *disc_addr = xe->mmio.regs + xe->pmt.base_offset;
+	int ret = 0;
+	u32 inst;
+	int idx;
+
+	if (FIELD_GET(GUID_DEVICE_ID, guid) != CRI_DEVICE_ID ||
+	    FIELD_GET(GUID_CAP_TYPE, guid) != CRASHLOG)
+		return -EINVAL;
+
+	if (!drm_dev_enter(&xe->drm, &idx))
+		return -ENODEV;
+
+	inst = FIELD_GET(GUID_RECORD_ID, guid) == PUNIT ?
+		CRI_CRASHLOG_PUNIT_DISC_OFFSET : CRI_CRASHLOG_OOBMSM_DISC_OFFSET;
+	disc_addr += inst + offset;
+
+	xe_pm_runtime_get(xe);
+
+	scoped_guard(mutex, &xe->pmt.lock) {
+		xe->soc_remapper.set_telem_region(xe, CRI_IDX_TELEM_DISCOVERY);
+
+		writel(reg, disc_addr);
+	}
+
+	xe_pm_runtime_put(xe);
+
+	drm_dev_exit(idx);
+
+	return ret;
+}
+
+static struct pmt_callbacks xe_bmg_pmt_cb = {
 	.read_telem = xe_pmt_telem_read,
 };
 
+static struct pmt_callbacks xe_cri_pmt_cb = {
+	.read_telem = xe_pmt_telem_read,
+	.read_discovery = xe_pmt_discovery_read,
+	.read_reg = xe_pmt_read_reg,
+	.write_reg = xe_pmt_write_reg,
+};
+
 static const int vsec_platforms[] = {
 	[XE_BATTLEMAGE] = XE_VSEC_BMG,
+	[XE_CRESCENTISLAND] = XE_VSEC_CRI,
 };
 
 static enum xe_vsec get_platform_info(struct xe_device *xe)
 {
-	if (xe->info.platform > XE_BATTLEMAGE)
+	if (xe->info.platform > XE_CRESCENTISLAND)
 		return XE_VSEC_UNKNOWN;
 
-	if (IS_SRIOV_VF(xe) && xe->info.platform == XE_BATTLEMAGE)
+	if (IS_SRIOV_VF(xe) &&
+	    (xe->info.platform == XE_BATTLEMAGE ||
+	     xe->info.platform == XE_CRESCENTISLAND))
 		return XE_VSEC_UNKNOWN;
 
 	return vsec_platforms[xe->info.platform];
@@ -399,8 +563,14 @@ void xe_vsec_init(struct xe_device *xe)
 	switch (platform) {
 	case XE_VSEC_BMG:
 		xe->pmt.base_offset = BMG_TELEMETRY_OFFSET;
-		info->priv_data = &xe_pmt_cb;
+		info->priv_data = &xe_bmg_pmt_cb;
 		break;
+
+	case XE_VSEC_CRI:
+		xe->pmt.base_offset = CRI_PMT_OFFSET;
+		info->priv_data = &xe_cri_pmt_cb;
+		break;
+
 	default:
 		break;
 	}
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 30+ messages in thread

* [PATCH v19 15/19] drm/xe/vsec: Support late bind fw information
  2026-11-19 15:54 [PATCH v19 00/19] Crescent Island PMT support Michael J. Ruhl
                   ` (13 preceding siblings ...)
  2026-11-19 15:54 ` [PATCH v19 14/19] drm/xe/vsec: Crescent Island PMT callbacks Michael J. Ruhl
@ 2026-11-19 15:54 ` Michael J. Ruhl
  2026-11-19 15:54 ` [PATCH v19 16/19] drm/xe/vsec: Add PMT GUID internal access Michael J. Ruhl
                   ` (6 subsequent siblings)
  21 siblings, 0 replies; 30+ messages in thread
From: Michael J. Ruhl @ 2026-11-19 15:54 UTC (permalink / raw)
  To: platform-driver-x86, intel-xe, hansg, ilpo.jarvinen,
	matthew.brost, rodrigo.vivi, thomas.hellstrom, airlied, simona,
	david.e.box, anoop.c.vijay, badal.nilawar, matthew.d.roper,
	james.ausmus

CRI FW is loaded on power on.  Because of this, access to the FW cannot
be done until it is running.

Update the XE PMT probe and access to check for late bind devices,
verify, and wait for the appropriate FW state before probe or access.

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Michael J. Ruhl <michael.j.ruhl@intel.com>
---
 drivers/gpu/drm/xe/xe_device.c       |   3 +
 drivers/gpu/drm/xe/xe_device_types.h |   5 ++
 drivers/gpu/drm/xe/xe_vsec.c         | 122 +++++++++++++++++++++++++--
 drivers/gpu/drm/xe/xe_vsec.h         |   1 +
 4 files changed, 126 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c
index ba1f49a56794..90e96a602091 100644
--- a/drivers/gpu/drm/xe/xe_device.c
+++ b/drivers/gpu/drm/xe/xe_device.c
@@ -1113,6 +1113,7 @@ int xe_device_probe(struct xe_device *xe)
 	return 0;
 
 err_unregister_display:
+	xe_vsec_remove(xe);
 	xe_display_unregister(xe);
 	drm_dev_unregister(&xe->drm);
 
@@ -1121,6 +1122,8 @@ int xe_device_probe(struct xe_device *xe)
 
 void xe_device_remove(struct xe_device *xe)
 {
+	xe_vsec_remove(xe);
+
 	xe_display_unregister(xe);
 
 	drm_dev_unplug(&xe->drm);
diff --git a/drivers/gpu/drm/xe/xe_device_types.h b/drivers/gpu/drm/xe/xe_device_types.h
index 28b1669a14d8..d1bdd3a872a8 100644
--- a/drivers/gpu/drm/xe/xe_device_types.h
+++ b/drivers/gpu/drm/xe/xe_device_types.h
@@ -7,6 +7,7 @@
 #define _XE_DEVICE_TYPES_H_
 
 #include <linux/pci.h>
+#include <linux/workqueue.h>
 
 #include <drm/drm_device.h>
 #include <drm/drm_file.h>
@@ -487,6 +488,10 @@ struct xe_device {
 		struct mutex lock;
 		/** @pmt.base_offset: device specific base offset */
 		u64 base_offset;
+		/** @pmt.work: support late-bind probe */
+		struct delayed_work work;
+		/** @pmt.retry_count: late-bind probe retry */
+		u32 retry_count;
 	} pmt;
 
 	/** @soc_remapper: SoC remapper object */
diff --git a/drivers/gpu/drm/xe/xe_vsec.c b/drivers/gpu/drm/xe/xe_vsec.c
index 58eb85fb6a9f..6a92abd83930 100644
--- a/drivers/gpu/drm/xe/xe_vsec.c
+++ b/drivers/gpu/drm/xe/xe_vsec.c
@@ -3,6 +3,7 @@
 #include <linux/bitfield.h>
 #include <linux/bits.h>
 #include <linux/cleanup.h>
+#include <linux/delay.h>
 #include <linux/errno.h>
 #include <linux/log2.h>
 #include <linux/intel_vsec.h>
@@ -19,6 +20,7 @@
 #include "xe_mmio.h"
 #include "xe_platform_types.h"
 #include "xe_pm.h"
+#include "xe_sysctrl.h"
 #include "xe_vsec.h"
 
 #include "regs/xe_pmt.h"
@@ -174,6 +176,14 @@ enum capability {
 	WATCHER,
 };
 
+/*
+ * Late bind will delay 100msec for up to 20 seconds
+ */
+#define VSEC_LATE_BIND_DELAY_MSEC	100
+#define VSEC_LATE_BIND_RETRY		200
+
+static void cri_late_bind_probe(struct xe_device *xe);
+
 static int bmg_guid_decode(u32 guid, int *index, u32 *offset)
 {
 	u32 record_id = FIELD_GET(GUID_RECORD_ID, guid);
@@ -282,6 +292,53 @@ static int xe_guid_decode(u32 guid, int *index, u32 *offset)
 	return -ENODEV;
 }
 
+static void cri_late_bind_probe_work(struct work_struct *work)
+{
+	struct xe_device *xe = container_of(work, struct xe_device, pmt.work.work);
+
+	if (xe_sysctrl_is_oobmsm_fw_ready(xe)) {
+		cri_late_bind_probe(xe);
+		xe_pm_runtime_put(xe);
+		return;
+	}
+
+	xe->pmt.retry_count++;
+
+	/* wait up to 20 seconds */
+	if (xe->pmt.retry_count == VSEC_LATE_BIND_RETRY) {
+		drm_warn(&xe->drm, "PMT probe: Late Binding failed to complete\n");
+		xe_pm_runtime_put(xe);
+		return;
+	}
+
+	if (!queue_delayed_work(system_freezable_wq, &xe->pmt.work,
+				msecs_to_jiffies(VSEC_LATE_BIND_DELAY_MSEC)))
+		xe_pm_runtime_put(xe);
+}
+
+static bool wait_for_fw(struct xe_device *xe)
+{
+	int retries = VSEC_LATE_BIND_RETRY;  /* wait up to 20 secs */
+
+	if (xe->info.platform != XE_CRESCENTISLAND)
+		return true;
+
+	while (retries--) {
+		if (xe_sysctrl_is_oobmsm_fw_ready(xe))
+			return true;
+
+		msleep(VSEC_LATE_BIND_DELAY_MSEC);
+		if (signal_pending(current)) {
+			drm_warn(&xe->drm, "Late Binding interrupted\n");
+			return false;
+		}
+	}
+
+	drm_warn(&xe->drm, "Late Binding failed to complete\n");
+
+	return false;
+}
+
 /**
  * xe_pmt_telem_read - Given a device and a PMT GUID, read data into a buffer
  * @dev: valid Xe device
@@ -344,6 +401,11 @@ int xe_pmt_telem_read(struct device *dev, u32 guid, u64 *data, loff_t user_offse
 		goto dev_exit;
 	}
 
+	if (!wait_for_fw(xe)) {
+		ret = -ENODATA;
+		goto runtime_exit;
+	}
+
 	scoped_guard(mutex, &xe->pmt.lock) {
 		u32 device_id = FIELD_GET(GUID_DEVICE_ID, guid);
 
@@ -356,6 +418,7 @@ int xe_pmt_telem_read(struct device *dev, u32 guid, u64 *data, loff_t user_offse
 			xe->soc_remapper.set_telem_region(xe, CRI_IDX_TELEM_DISCOVERY);
 	}
 
+runtime_exit:
 	xe_pm_runtime_put(xe);
 
 dev_exit:
@@ -464,6 +527,10 @@ static int xe_pmt_read_reg(struct device *dev, u32 guid, u32 *reg, u32 offset)
 	disc_addr += inst + offset;
 
 	xe_pm_runtime_get(xe);
+	if (!wait_for_fw(xe)) {
+		ret = -ENODATA;
+		goto runtime_exit;
+	}
 
 	scoped_guard(mutex, &xe->pmt.lock) {
 		xe->soc_remapper.set_telem_region(xe, CRI_IDX_TELEM_DISCOVERY);
@@ -471,6 +538,7 @@ static int xe_pmt_read_reg(struct device *dev, u32 guid, u32 *reg, u32 offset)
 		*reg = readl(disc_addr);
 	}
 
+runtime_exit:
 	xe_pm_runtime_put(xe);
 
 	drm_dev_exit(idx);
@@ -498,6 +566,10 @@ static int xe_pmt_write_reg(struct device *dev, u32 guid, u32 reg, u32 offset)
 	disc_addr += inst + offset;
 
 	xe_pm_runtime_get(xe);
+	if (!wait_for_fw(xe)) {
+		ret = -ENODATA;
+		goto runtime_exit;
+	}
 
 	scoped_guard(mutex, &xe->pmt.lock) {
 		xe->soc_remapper.set_telem_region(xe, CRI_IDX_TELEM_DISCOVERY);
@@ -505,6 +577,7 @@ static int xe_pmt_write_reg(struct device *dev, u32 guid, u32 reg, u32 offset)
 		writel(reg, disc_addr);
 	}
 
+runtime_exit:
 	xe_pm_runtime_put(xe);
 
 	drm_dev_exit(idx);
@@ -541,6 +614,25 @@ static enum xe_vsec get_platform_info(struct xe_device *xe)
 	return vsec_platforms[xe->info.platform];
 }
 
+static void cri_late_bind_probe(struct xe_device *xe)
+{
+	struct intel_vsec_platform_info *info;
+	struct device *dev = xe->drm.dev;
+	enum xe_vsec platform;
+
+	platform = get_platform_info(xe);
+	if (platform != XE_VSEC_CRI)
+		return;
+
+	info = &xe_vsec_info[platform];
+	if (!info->headers)
+		return;
+
+	info->priv_data = &xe_cri_pmt_cb;
+
+	intel_vsec_register(dev, info);
+}
+
 /**
  * xe_vsec_init - Initialize resources and add intel_vsec auxiliary
  * interface
@@ -569,16 +661,36 @@ void xe_vsec_init(struct xe_device *xe)
 	case XE_VSEC_CRI:
 		xe->pmt.base_offset = CRI_PMT_OFFSET;
 		info->priv_data = &xe_cri_pmt_cb;
+
+		xe->pmt.retry_count = 0;
+		INIT_DELAYED_WORK(&xe->pmt.work, cri_late_bind_probe_work);
+
+		if (!xe_sysctrl_is_oobmsm_fw_ready(xe)) {
+			xe_pm_runtime_get_noresume(xe);
+			queue_delayed_work(system_freezable_wq, &xe->pmt.work,
+					   msecs_to_jiffies(VSEC_LATE_BIND_DELAY_MSEC));
+			return;
+		}
 		break;
 
 	default:
-		break;
+		drm_err(&xe->drm, "Unsupported platform: %u\n", platform);
+		return;
 	}
 
-	/*
-	 * Register a VSEC. Cleanup is handled using device managed
-	 * resources.
-	 */
 	intel_vsec_register(dev, info);
 }
+
+/**
+ * xe_vsec_remove - cleanup any outstanding resources
+ * @xe: valid xe instance
+ */
+void xe_vsec_remove(struct xe_device *xe)
+{
+	/* Cleanup on Crescent Isle */
+	if (xe->info.platform == XE_CRESCENTISLAND &&
+	    xe->pmt.base_offset == CRI_PMT_OFFSET &&
+	    disable_delayed_work_sync(&xe->pmt.work))
+		xe_pm_runtime_put(xe);
+}
 MODULE_IMPORT_NS("INTEL_VSEC");
diff --git a/drivers/gpu/drm/xe/xe_vsec.h b/drivers/gpu/drm/xe/xe_vsec.h
index a25b4e6e681b..e925dba4158b 100644
--- a/drivers/gpu/drm/xe/xe_vsec.h
+++ b/drivers/gpu/drm/xe/xe_vsec.h
@@ -10,6 +10,7 @@ struct device;
 struct xe_device;
 
 void xe_vsec_init(struct xe_device *xe);
+void xe_vsec_remove(struct xe_device *xe);
 int xe_pmt_telem_read(struct device *dev, u32 guid, u64 *data, loff_t user_offset, u32 count);
 
 #endif
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 30+ messages in thread

* [PATCH v19 16/19] drm/xe/vsec: Add PMT GUID internal access
  2026-11-19 15:54 [PATCH v19 00/19] Crescent Island PMT support Michael J. Ruhl
                   ` (14 preceding siblings ...)
  2026-11-19 15:54 ` [PATCH v19 15/19] drm/xe/vsec: Support late bind fw information Michael J. Ruhl
@ 2026-11-19 15:54 ` Michael J. Ruhl
  2026-11-19 15:54 ` [PATCH v19 17/19] drm/xe/vsec: Update PMT " Michael J. Ruhl
                   ` (5 subsequent siblings)
  21 siblings, 0 replies; 30+ messages in thread
From: Michael J. Ruhl @ 2026-11-19 15:54 UTC (permalink / raw)
  To: platform-driver-x86, intel-xe, hansg, ilpo.jarvinen,
	matthew.brost, rodrigo.vivi, thomas.hellstrom, airlied, simona,
	david.e.box, anoop.c.vijay, badal.nilawar, matthew.d.roper,
	james.ausmus

Xe accesses the PMT infrastructure directly. The current usage is
supported ONLY by BMG devices.

CRI has further requirements for access.

Add the platform id to the GUID register define and use that for the
register access.

Add an API to allow access the GUID based on the platform.

Reviewed-by: Karthik Poosa <karthik.poosa@intel.com>
Signed-off-by: Michael J. Ruhl <michael.j.ruhl@intel.com>
---
 drivers/gpu/drm/xe/regs/xe_pmt.h     |  4 +-
 drivers/gpu/drm/xe/xe_debugfs.c      |  2 +-
 drivers/gpu/drm/xe/xe_device_types.h |  2 +
 drivers/gpu/drm/xe/xe_hwmon.c        |  2 +-
 drivers/gpu/drm/xe/xe_pcode.c        |  2 +-
 drivers/gpu/drm/xe/xe_vsec.c         | 59 ++++++++++++++++++++++++++++
 drivers/gpu/drm/xe/xe_vsec.h         |  1 +
 7 files changed, 68 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/xe/regs/xe_pmt.h b/drivers/gpu/drm/xe/regs/xe_pmt.h
index 2f6658395587..fb5b5a8648ba 100644
--- a/drivers/gpu/drm/xe/regs/xe_pmt.h
+++ b/drivers/gpu/drm/xe/regs/xe_pmt.h
@@ -10,7 +10,7 @@
 #define BMG_PMT_BASE_OFFSET		0xDB000
 #define BMG_DISCOVERY_OFFSET		(SOC_BASE + BMG_PMT_BASE_OFFSET)
 
-#define PUNIT_TELEMETRY_GUID		XE_REG(BMG_DISCOVERY_OFFSET + 0x4)
+#define BMG_PUNIT_TELEMETRY_GUID	XE_REG(BMG_DISCOVERY_OFFSET + 0x4)
 #define BMG_ENERGY_STATUS_PMT_OFFSET	(0x30)
 #define	ENERGY_PKG			REG_GENMASK64(31, 0)
 #define	ENERGY_CARD			REG_GENMASK64(63, 32)
@@ -24,6 +24,8 @@
 /* for CRI discovery and telemetry are in an indexed window */
 #define CRI_PMT_OFFSET			(SOC_BASE + XE_PMT_BASE_OFFSET)
 
+#define CRI_PUNIT_TELEMETRY_GUID	XE_REG(CRI_PMT_OFFSET + 0x4)
+
 #define BMG_MODS_RESIDENCY_OFFSET		(0x4D0)
 #define BMG_G2_RESIDENCY_OFFSET		(0x530)
 #define BMG_G6_RESIDENCY_OFFSET		(0x538)
diff --git a/drivers/gpu/drm/xe/xe_debugfs.c b/drivers/gpu/drm/xe/xe_debugfs.c
index 1a74a7106462..342182d5ecda 100644
--- a/drivers/gpu/drm/xe/xe_debugfs.c
+++ b/drivers/gpu/drm/xe/xe_debugfs.c
@@ -156,7 +156,7 @@ static void read_residency_counter(struct xe_device *xe, struct xe_mmio *mmio,
 	int ret;
 
 	ret = xe_pmt_telem_read(xe->drm.dev,
-				xe_mmio_read32(mmio, PUNIT_TELEMETRY_GUID),
+				xe_mmio_read32(mmio, BMG_PUNIT_TELEMETRY_GUID),
 				&residency, offset, sizeof(residency));
 	if (ret != sizeof(residency)) {
 		drm_warn(&xe->drm, "%s counter failed to read, ret %d\n", name, ret);
diff --git a/drivers/gpu/drm/xe/xe_device_types.h b/drivers/gpu/drm/xe/xe_device_types.h
index d1bdd3a872a8..be6feaff4baa 100644
--- a/drivers/gpu/drm/xe/xe_device_types.h
+++ b/drivers/gpu/drm/xe/xe_device_types.h
@@ -492,6 +492,8 @@ struct xe_device {
 		struct delayed_work work;
 		/** @pmt.retry_count: late-bind probe retry */
 		u32 retry_count;
+		/** @pmt.punit_guid_cache: cache of the PUNIT GUID */
+		u32 punit_guid_cache;
 	} pmt;
 
 	/** @soc_remapper: SoC remapper object */
diff --git a/drivers/gpu/drm/xe/xe_hwmon.c b/drivers/gpu/drm/xe/xe_hwmon.c
index defe8aaca7c1..d9636eca0133 100644
--- a/drivers/gpu/drm/xe/xe_hwmon.c
+++ b/drivers/gpu/drm/xe/xe_hwmon.c
@@ -605,7 +605,7 @@ xe_hwmon_energy_get(struct xe_hwmon *hwmon, int channel, long *energy)
 		u64 pmt_val;
 
 		ret = xe_pmt_telem_read(hwmon->xe->drm.dev,
-					xe_mmio_read32(mmio, PUNIT_TELEMETRY_GUID),
+					xe_mmio_read32(mmio, BMG_PUNIT_TELEMETRY_GUID),
 					&pmt_val, BMG_ENERGY_STATUS_PMT_OFFSET,	sizeof(pmt_val));
 		if (ret != sizeof(pmt_val)) {
 			drm_warn(&hwmon->xe->drm, "energy read from pmt failed, ret %d\n", ret);
diff --git a/drivers/gpu/drm/xe/xe_pcode.c b/drivers/gpu/drm/xe/xe_pcode.c
index 266deecbb100..8c901e54f384 100644
--- a/drivers/gpu/drm/xe/xe_pcode.c
+++ b/drivers/gpu/drm/xe/xe_pcode.c
@@ -369,7 +369,7 @@ int xe_get_pcode_version(struct xe_device *xe, struct xe_pcode_version *version)
 	guard(xe_pm_runtime)(xe);
 
 	ret = xe_pmt_telem_read(xe->drm.dev,
-				xe_mmio_read32(xe_root_tile_mmio(xe), PUNIT_TELEMETRY_GUID),
+				xe_mmio_read32(xe_root_tile_mmio(xe), BMG_PUNIT_TELEMETRY_GUID),
 				(u64 *)version, PUNIT_VERSION_OFFSET, sizeof(*version));
 	if (ret != sizeof(*version)) {
 		xe_warn(xe, "pcode version read from PMT failed, ret %pe\n", ERR_PTR(ret));
diff --git a/drivers/gpu/drm/xe/xe_vsec.c b/drivers/gpu/drm/xe/xe_vsec.c
index 6a92abd83930..8d3f46531295 100644
--- a/drivers/gpu/drm/xe/xe_vsec.c
+++ b/drivers/gpu/drm/xe/xe_vsec.c
@@ -633,6 +633,65 @@ static void cri_late_bind_probe(struct xe_device *xe)
 	intel_vsec_register(dev, info);
 }
 
+/**
+ * xe_vsec_get_guid - Get and cache the PUNIT guid value
+ * @xe: valid xe device
+ * @guid: returned guid
+ *
+ * Return:
+ * * -ENODATA device is not active
+ * * -EINVAL unsupported platform
+ * * 0 success
+ */
+int xe_vsec_get_guid(struct xe_device *xe, u32 *guid)
+{
+	struct xe_mmio *mmio = xe_root_tile_mmio(xe);
+	int ret = 0;
+
+	xe_assert(xe, !IS_SRIOV_VF(xe));
+
+	if (!xe_pm_runtime_get_if_active(xe))
+		return -ENODATA;
+
+	mutex_lock(&xe->pmt.lock);
+
+	if (xe->pmt.punit_guid_cache) {
+		*guid = xe->pmt.punit_guid_cache;
+		goto unlock;
+	}
+
+	switch (xe->info.platform) {
+	case XE_BATTLEMAGE:
+		*guid = xe_mmio_read32(mmio, BMG_PUNIT_TELEMETRY_GUID);
+		break;
+
+	case XE_CRESCENTISLAND:
+		xe->soc_remapper.set_telem_region(xe, CRI_IDX_TELEM_DISCOVERY);
+		*guid = xe_mmio_read32(mmio, CRI_PUNIT_TELEMETRY_GUID);
+		break;
+
+	default:
+		*guid = 0;
+		drm_err(&xe->drm, "Unsupported platform: %u\n", xe->info.platform);
+		ret = -EINVAL;
+		break;
+	}
+
+	/* the GUID is static, read once and cache for all requests */
+	if (*guid) {
+		xe->pmt.punit_guid_cache = *guid;
+	} else {
+		drm_err(&xe->drm, "Invalid GUID: 0x%x\n", *guid);
+		ret = -EINVAL;
+	}
+
+unlock:
+	mutex_unlock(&xe->pmt.lock);
+	xe_pm_runtime_put(xe);
+
+	return ret;
+}
+
 /**
  * xe_vsec_init - Initialize resources and add intel_vsec auxiliary
  * interface
diff --git a/drivers/gpu/drm/xe/xe_vsec.h b/drivers/gpu/drm/xe/xe_vsec.h
index e925dba4158b..88e6f6a9e4dd 100644
--- a/drivers/gpu/drm/xe/xe_vsec.h
+++ b/drivers/gpu/drm/xe/xe_vsec.h
@@ -11,6 +11,7 @@ struct xe_device;
 
 void xe_vsec_init(struct xe_device *xe);
 void xe_vsec_remove(struct xe_device *xe);
+int xe_vsec_get_guid(struct xe_device *xe, u32 *guid);
 int xe_pmt_telem_read(struct device *dev, u32 guid, u64 *data, loff_t user_offset, u32 count);
 
 #endif
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 30+ messages in thread

* [PATCH v19 17/19] drm/xe/vsec: Update PMT internal access
  2026-11-19 15:54 [PATCH v19 00/19] Crescent Island PMT support Michael J. Ruhl
                   ` (15 preceding siblings ...)
  2026-11-19 15:54 ` [PATCH v19 16/19] drm/xe/vsec: Add PMT GUID internal access Michael J. Ruhl
@ 2026-11-19 15:54 ` Michael J. Ruhl
  2026-11-19 15:54 ` [PATCH v19 18/19] drm/xe/vsec: Refactor platform check Michael J. Ruhl
                   ` (4 subsequent siblings)
  21 siblings, 0 replies; 30+ messages in thread
From: Michael J. Ruhl @ 2026-11-19 15:54 UTC (permalink / raw)
  To: platform-driver-x86, intel-xe, hansg, ilpo.jarvinen,
	matthew.brost, rodrigo.vivi, thomas.hellstrom, airlied, simona,
	david.e.box, anoop.c.vijay, badal.nilawar, matthew.d.roper,
	james.ausmus

Current PMT internal access assumes BMG devices.

Use the new PMT GUID API to read the device specific guid.

Minor cleanup for a newly unused parameter (mmio).

Reviewed-by: Karthik Poosa <karthik.poosa@intel.com>
Signed-off-by: Michael J. Ruhl <michael.j.ruhl@intel.com>
---
 drivers/gpu/drm/xe/xe_debugfs.c | 26 ++++++++++++++------------
 drivers/gpu/drm/xe/xe_hwmon.c   | 10 ++++++++--
 drivers/gpu/drm/xe/xe_pcode.c   | 10 ++++++++--
 3 files changed, 30 insertions(+), 16 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_debugfs.c b/drivers/gpu/drm/xe/xe_debugfs.c
index 342182d5ecda..578ee973d159 100644
--- a/drivers/gpu/drm/xe/xe_debugfs.c
+++ b/drivers/gpu/drm/xe/xe_debugfs.c
@@ -5,6 +5,7 @@
 
 #include "xe_debugfs.h"
 
+#include <linux/array_size.h>
 #include <linux/bits.h>
 #include <linux/debugfs.h>
 #include <linux/fault-inject.h>
@@ -21,7 +22,6 @@
 #include "xe_gt.h"
 #include "xe_gt_debugfs.h"
 #include "xe_hw_engine.h"
-#include "xe_mmio.h"
 #include "xe_pagefault.h"
 #include "xe_pcode.h"
 #include "xe_pm.h"
@@ -149,15 +149,20 @@ static void xe_fault_inject_debugfs_register(struct xe_device *xe,
 	}
 }
 
-static void read_residency_counter(struct xe_device *xe, struct xe_mmio *mmio,
-				   u32 offset, const char *name, struct drm_printer *p)
+static void read_residency_counter(struct xe_device *xe, u32 offset, const char *name,
+				   struct drm_printer *p)
 {
 	u64 residency = 0;
+	u32 guid;
 	int ret;
 
-	ret = xe_pmt_telem_read(xe->drm.dev,
-				xe_mmio_read32(mmio, BMG_PUNIT_TELEMETRY_GUID),
-				&residency, offset, sizeof(residency));
+	ret = xe_vsec_get_guid(xe, &guid);
+	if (ret) {
+		drm_warn(&xe->drm, "PMT device is not available: %d\n", ret);
+		return;
+	}
+
+	ret = xe_pmt_telem_read(xe->drm.dev, guid, &residency, offset, sizeof(residency));
 	if (ret != sizeof(residency)) {
 		drm_warn(&xe->drm, "%s counter failed to read, ret %d\n", name, ret);
 		return;
@@ -296,13 +301,12 @@ static int pcode_info(struct seq_file *m, void *data)
 static int dgfx_pkg_residencies_show(struct seq_file *m, void *data)
 {
 	struct xe_device *xe;
-	struct xe_mmio *mmio;
 	struct drm_printer p;
 
 	xe = node_to_xe(m->private);
 	p = drm_seq_file_printer(m);
 	guard(xe_pm_runtime)(xe);
-	mmio = xe_root_tile_mmio(xe);
+
 	static const struct {
 		u32 offset;
 		const char *name;
@@ -316,7 +320,7 @@ static int dgfx_pkg_residencies_show(struct seq_file *m, void *data)
 	};
 
 	for (int i = 0; i < ARRAY_SIZE(residencies); i++)
-		read_residency_counter(xe, mmio, residencies[i].offset, residencies[i].name, &p);
+		read_residency_counter(xe, residencies[i].offset, residencies[i].name, &p);
 
 	return 0;
 }
@@ -324,13 +328,11 @@ static int dgfx_pkg_residencies_show(struct seq_file *m, void *data)
 static int dgfx_pcie_link_residencies_show(struct seq_file *m, void *data)
 {
 	struct xe_device *xe;
-	struct xe_mmio *mmio;
 	struct drm_printer p;
 
 	xe = node_to_xe(m->private);
 	p = drm_seq_file_printer(m);
 	guard(xe_pm_runtime)(xe);
-	mmio = xe_root_tile_mmio(xe);
 
 	static const struct {
 		u32 offset;
@@ -342,7 +344,7 @@ static int dgfx_pcie_link_residencies_show(struct seq_file *m, void *data)
 	};
 
 	for (int i = 0; i < ARRAY_SIZE(residencies); i++)
-		read_residency_counter(xe, mmio, residencies[i].offset, residencies[i].name, &p);
+		read_residency_counter(xe, residencies[i].offset, residencies[i].name, &p);
 
 	return 0;
 }
diff --git a/drivers/gpu/drm/xe/xe_hwmon.c b/drivers/gpu/drm/xe/xe_hwmon.c
index d9636eca0133..55e0f961df4c 100644
--- a/drivers/gpu/drm/xe/xe_hwmon.c
+++ b/drivers/gpu/drm/xe/xe_hwmon.c
@@ -603,9 +603,15 @@ xe_hwmon_energy_get(struct xe_hwmon *hwmon, int channel, long *energy)
 
 	if (hwmon->xe->info.platform == XE_BATTLEMAGE) {
 		u64 pmt_val;
+		u32 guid;
 
-		ret = xe_pmt_telem_read(hwmon->xe->drm.dev,
-					xe_mmio_read32(mmio, BMG_PUNIT_TELEMETRY_GUID),
+		ret = xe_vsec_get_guid(hwmon->xe, &guid);
+		if (ret) {
+			drm_warn(&hwmon->xe->drm, "PMT device is not available: %d\n", ret);
+			*energy = 0;
+			return ret;
+		}
+		ret = xe_pmt_telem_read(hwmon->xe->drm.dev, guid,
 					&pmt_val, BMG_ENERGY_STATUS_PMT_OFFSET,	sizeof(pmt_val));
 		if (ret != sizeof(pmt_val)) {
 			drm_warn(&hwmon->xe->drm, "energy read from pmt failed, ret %d\n", ret);
diff --git a/drivers/gpu/drm/xe/xe_pcode.c b/drivers/gpu/drm/xe/xe_pcode.c
index 8c901e54f384..fa9f45d565cb 100644
--- a/drivers/gpu/drm/xe/xe_pcode.c
+++ b/drivers/gpu/drm/xe/xe_pcode.c
@@ -365,11 +365,17 @@ ALLOW_ERROR_INJECTION(xe_pcode_probe_early, ERRNO); /* See xe_pci_probe */
 int xe_get_pcode_version(struct xe_device *xe, struct xe_pcode_version *version)
 {
 	int ret = 0;
+	u32 guid;
 
 	guard(xe_pm_runtime)(xe);
 
-	ret = xe_pmt_telem_read(xe->drm.dev,
-				xe_mmio_read32(xe_root_tile_mmio(xe), BMG_PUNIT_TELEMETRY_GUID),
+	ret = xe_vsec_get_guid(xe, &guid);
+	if (ret) {
+		xe_warn(xe, "PMT device is not available: %d\n", ret);
+		return ret;
+	}
+
+	ret = xe_pmt_telem_read(xe->drm.dev, guid,
 				(u64 *)version, PUNIT_VERSION_OFFSET, sizeof(*version));
 	if (ret != sizeof(*version)) {
 		xe_warn(xe, "pcode version read from PMT failed, ret %pe\n", ERR_PTR(ret));
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 30+ messages in thread

* [PATCH v19 18/19] drm/xe/vsec: Refactor platform check
  2026-11-19 15:54 [PATCH v19 00/19] Crescent Island PMT support Michael J. Ruhl
                   ` (16 preceding siblings ...)
  2026-11-19 15:54 ` [PATCH v19 17/19] drm/xe/vsec: Update PMT " Michael J. Ruhl
@ 2026-11-19 15:54 ` Michael J. Ruhl
  2026-11-19 15:54 ` [PATCH v19 19/19] drm/xe/vsec: Support survivability mode for CRI Michael J. Ruhl
                   ` (3 subsequent siblings)
  21 siblings, 0 replies; 30+ messages in thread
From: Michael J. Ruhl @ 2026-11-19 15:54 UTC (permalink / raw)
  To: platform-driver-x86, intel-xe, hansg, ilpo.jarvinen,
	matthew.brost, rodrigo.vivi, thomas.hellstrom, airlied, simona,
	david.e.box, anoop.c.vijay, badal.nilawar, matthew.d.roper,
	james.ausmus

For debugfs, residencies and pcode_info are available on the BMG and
CRI (!SRIOV_VF) platforms.

Refactor to have one code path for adding the debugfs entries.

Reviewed-by: Karthik Poosa <karthik.poosa@intel.com>
Signed-off-by: Michael J. Ruhl <michael.j.ruhl@intel.com>
---
 drivers/gpu/drm/xe/xe_debugfs.c | 19 +++++++++----------
 1 file changed, 9 insertions(+), 10 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_debugfs.c b/drivers/gpu/drm/xe/xe_debugfs.c
index 578ee973d159..bc62d1054d29 100644
--- a/drivers/gpu/drm/xe/xe_debugfs.c
+++ b/drivers/gpu/drm/xe/xe_debugfs.c
@@ -704,23 +704,22 @@ void xe_debugfs_register(struct xe_device *xe)
 				 ARRAY_SIZE(debugfs_list),
 				 root, minor);
 
-	if (xe->info.platform == XE_BATTLEMAGE && !IS_SRIOV_VF(xe)) {
-		drm_debugfs_create_files(debugfs_residencies,
-					 ARRAY_SIZE(debugfs_residencies),
-					 root, minor);
-	}
-
 	/*
-	 * Pcode version read from PMT is currently only supported on CRI and BMG platforms in PF
-	 * mode, as both platforms support the necessary telemetry read mechanism and have a fixed
-	 * PUNIT_VERSION_OFFSET.
+	 * Residencies and Pcode version read from PMT is currently only supported on CRI and BMG
+	 * platforms in PF mode.  Both platforms support the necessary telemetry read mechanism
+	 * and have a fixed offsets for the required data.
 	 * Attempting this access on other platforms must be verified before enabling support.
 	 */
 	if (!IS_SRIOV_VF(xe) &&
-	    (xe->info.platform == XE_CRESCENTISLAND || xe->info.platform == XE_BATTLEMAGE))
+	    (xe->info.platform == XE_CRESCENTISLAND || xe->info.platform == XE_BATTLEMAGE)) {
+		drm_debugfs_create_files(debugfs_residencies,
+					 ARRAY_SIZE(debugfs_residencies),
+					 root, minor);
+
 		drm_debugfs_create_files(pcode_info_debugfs,
 					 ARRAY_SIZE(pcode_info_debugfs),
 					 root, minor);
+	}
 
 	debugfs_create_file("forcewake_all", 0400, root, xe,
 			    &forcewake_all_fops);
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 30+ messages in thread

* [PATCH v19 19/19] drm/xe/vsec: Support survivability mode for CRI
  2026-11-19 15:54 [PATCH v19 00/19] Crescent Island PMT support Michael J. Ruhl
                   ` (17 preceding siblings ...)
  2026-11-19 15:54 ` [PATCH v19 18/19] drm/xe/vsec: Refactor platform check Michael J. Ruhl
@ 2026-11-19 15:54 ` Michael J. Ruhl
  2026-11-19 20:11 ` ✗ CI.checkpatch: warning for Crescent Island PMT support (rev20) Patchwork
                   ` (2 subsequent siblings)
  21 siblings, 0 replies; 30+ messages in thread
From: Michael J. Ruhl @ 2026-11-19 15:54 UTC (permalink / raw)
  To: platform-driver-x86, intel-xe, hansg, ilpo.jarvinen,
	matthew.brost, rodrigo.vivi, thomas.hellstrom, airlied, simona,
	david.e.box, anoop.c.vijay, badal.nilawar, matthew.d.roper,
	james.ausmus

For survivability mode, CRI can only support access to the
PUNIT CRASHLOG PMT function.

Create a special config to support survivability mode.

Signed-off-by: Michael J. Ruhl <michael.j.ruhl@intel.com>
---
 drivers/gpu/drm/xe/xe_device_types.h |  2 ++
 drivers/gpu/drm/xe/xe_vsec.c         | 34 +++++++++++++++++++++++++++-
 2 files changed, 35 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_device_types.h b/drivers/gpu/drm/xe/xe_device_types.h
index be6feaff4baa..ae5426717eb4 100644
--- a/drivers/gpu/drm/xe/xe_device_types.h
+++ b/drivers/gpu/drm/xe/xe_device_types.h
@@ -494,6 +494,8 @@ struct xe_device {
 		u32 retry_count;
 		/** @pmt.punit_guid_cache: cache of the PUNIT GUID */
 		u32 punit_guid_cache;
+		/** @pmt.survivability_mode: cache of survivability mode state */
+		bool survivability_mode;
 	} pmt;
 
 	/** @soc_remapper: SoC remapper object */
diff --git a/drivers/gpu/drm/xe/xe_vsec.c b/drivers/gpu/drm/xe/xe_vsec.c
index 8d3f46531295..fed57deb2801 100644
--- a/drivers/gpu/drm/xe/xe_vsec.c
+++ b/drivers/gpu/drm/xe/xe_vsec.c
@@ -20,6 +20,7 @@
 #include "xe_mmio.h"
 #include "xe_platform_types.h"
 #include "xe_pm.h"
+#include "xe_survivability_mode.h"
 #include "xe_sysctrl.h"
 #include "xe_vsec.h"
 
@@ -102,10 +103,26 @@ static struct intel_vsec_header *cri_capabilities[] = {
 	NULL
 };
 
+static struct intel_vsec_header cri_survivability_crashlog = {
+	.rev = 1,
+	.length = SZ_16,
+	.id = VSEC_ID_CRASHLOG,
+	.num_entries = 1,
+	.entry_size = 6,
+	.tbir = 0,
+	.offset = CRI_PMT_OFFSET + CRI_CRASHLOG_PUNIT_DISC_OFFSET,
+};
+
+static struct intel_vsec_header *cri_survivability_capabilities[] = {
+	&cri_survivability_crashlog,
+	NULL
+};
+
 enum xe_vsec {
 	XE_VSEC_UNKNOWN = 0,
 	XE_VSEC_BMG,
 	XE_VSEC_CRI,
+	XE_VSEC_CRI_SURVIVABILITY,
 };
 
 static struct intel_vsec_platform_info xe_vsec_info[] = {
@@ -117,6 +134,10 @@ static struct intel_vsec_platform_info xe_vsec_info[] = {
 		.caps = VSEC_CAP_TELEMETRY | VSEC_CAP_CRASHLOG,
 		.headers = cri_capabilities,
 	},
+	[XE_VSEC_CRI_SURVIVABILITY] = {
+		.caps = VSEC_CAP_CRASHLOG,
+		.headers = cri_survivability_capabilities,
+	},
 	{ }
 };
 
@@ -320,7 +341,7 @@ static bool wait_for_fw(struct xe_device *xe)
 {
 	int retries = VSEC_LATE_BIND_RETRY;  /* wait up to 20 secs */
 
-	if (xe->info.platform != XE_CRESCENTISLAND)
+	if (xe->info.platform != XE_CRESCENTISLAND || xe->pmt.survivability_mode)
 		return true;
 
 	while (retries--) {
@@ -611,6 +632,10 @@ static enum xe_vsec get_platform_info(struct xe_device *xe)
 	     xe->info.platform == XE_CRESCENTISLAND))
 		return XE_VSEC_UNKNOWN;
 
+	if (xe_survivability_mode_is_boot_enabled(xe) &&
+	    xe->info.platform == XE_CRESCENTISLAND)
+		return XE_VSEC_CRI_SURVIVABILITY;
+
 	return vsec_platforms[xe->info.platform];
 }
 
@@ -732,6 +757,13 @@ void xe_vsec_init(struct xe_device *xe)
 		}
 		break;
 
+	case XE_VSEC_CRI_SURVIVABILITY:
+		xe->pmt.base_offset = CRI_PMT_OFFSET;
+		xe->pmt.survivability_mode = true;
+		info->priv_data = &xe_cri_pmt_cb;
+		xe->soc_remapper.set_telem_region(xe, CRI_IDX_TELEM_DISCOVERY);
+		break;
+
 	default:
 		drm_err(&xe->drm, "Unsupported platform: %u\n", platform);
 		return;
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 30+ messages in thread

* Re: [PATCH v19 01/19] platform/x86/intel/pmt: Introduce a callback for discovery data
  2026-11-19 15:54 ` [PATCH v19 01/19] platform/x86/intel/pmt: Introduce a callback for discovery data Michael J. Ruhl
@ 2026-11-19 20:06   ` David E. Box
  0 siblings, 0 replies; 30+ messages in thread
From: David E. Box @ 2026-11-19 20:06 UTC (permalink / raw)
  To: Michael J. Ruhl
  Cc: platform-driver-x86, intel-xe, hansg, ilpo.jarvinen,
	matthew.brost, rodrigo.vivi, thomas.hellstrom, airlied, simona,
	anoop.c.vijay, badal.nilawar, matthew.d.roper, james.ausmus

Hi Mike,


On Thu, Nov 19, 2026 at 07:54:39AM -0800, Michael J. Ruhl wrote:
> Some devices require special handling to access discovery data.
>
> Provide a callback to allow for the special handling.

The commit message could say why the handling is needed: On CRI the
discovery entries sit behind the shared PMT window, so a direct read
from the PMT drivers isn't safe, and the entry is identified by
capability and index because its GUID isn't known until it has been
read.

>
> Suggested-by: David E. Box <david.e.box@linux.intel.com>
> Signed-off-by: Michael J. Ruhl <michael.j.ruhl@intel.com>
> ---
>  drivers/platform/x86/intel/pmt/class.c | 18 ++++++++++++------
>  include/linux/intel_vsec.h             |  6 ++++++
>  2 files changed, 18 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/platform/x86/intel/pmt/class.c b/drivers/platform/x86/intel/pmt/class.c
> index 2b11c4012f6a..601cdf68f0bc 100644
> --- a/drivers/platform/x86/intel/pmt/class.c
> +++ b/drivers/platform/x86/intel/pmt/class.c
> @@ -466,12 +466,17 @@ static int pmt_get_headers(struct intel_vsec_device *ivdev, int idx,
>  	switch (ivdev->src) {
>  	case INTEL_VSEC_DISC_PCI: {
>  		struct resource *disc_res = &ivdev->resource[idx];
> +		struct pmt_callbacks *cb = ivdev->priv_data;
>  		void __iomem *disc_table;
> +		int ret = 0;
>  
>  		disc_table = devm_ioremap_resource(dev, disc_res);
>  		if (IS_ERR(disc_table))
>  			return PTR_ERR(disc_table);
>  
> +		/* Used by crashlog driver */
> +		entry->disc_table = disc_table;
> +
>  		/*
>  		 * The mapped resource is sized by the namespace's DVSEC
>  		 * entry_size (in dwords), which can be less than the default
> @@ -480,13 +485,14 @@ static int pmt_get_headers(struct intel_vsec_device *ivdev, int idx,
>  		 * region.
>  		 */
>  		memset(entry->disc_header, 0, header_bytes);
> -		memcpy_fromio(entry->disc_header, disc_table,
> -			      min(header_bytes, resource_size(disc_res)));
> -
> -		/* Used by crashlog driver */
> -		entry->disc_table = disc_table;
>  
> -		return 0;
> +		if (cb && cb->read_discovery)
> +			ret = cb->read_discovery(ivdev->dev, ivdev->cap_id, idx,
> +						 entry->disc_header);
> +		else
> +			memcpy_fromio(entry->disc_header, disc_table,
> +				      min(header_bytes, resource_size(disc_res)));
> +		return ret;

The resource_size() cap only applies to the MMIO path, so the callback
is expected to fill exactly PMT_DISC_DWORDS dwords. Fine for CRI, but
please document that (see below), since there's no length argument.

>  	}
>  	case INTEL_VSEC_DISC_ACPI: {
>  		memcpy(entry->disc_header, &ivdev->acpi_disc[idx][0], header_bytes);
> diff --git a/include/linux/intel_vsec.h b/include/linux/intel_vsec.h
> index 8686e79c4f75..400231989b49 100644
> --- a/include/linux/intel_vsec.h
> +++ b/include/linux/intel_vsec.h
> @@ -94,6 +94,11 @@ enum intel_vsec_quirks {
>   * * data:  buffer for the data to be copied
>   * * off:   offset into the requested buffer
>   * * count: size of buffer
> + * @read_discovery: when specified called by client driver to read PMT discovery structs
> + * * dev:     device reference for the callback's use
> + * * cap_id: telem, crashlog, etc, ilog2 of VSEC_CAP value
> + * * idx:     element to access
> + * * disc_data:  buffer for the discovery data to be copied

A few things for the kernel-doc:

- disc_data: say it holds PMT_DISC_DWORDS dwords.

- idx: say it is the index of the entry within its capability header,
  as enumerated by intel_vsec_register().

- The sub-items are not aligned

>   * @read_reg: when specified called by client driver to read PMT state
>   * * dev:      device reference for the callback's use
>   * * guid:     ID of data to access
> @@ -107,6 +112,7 @@ enum intel_vsec_quirks {
>   */
>  struct pmt_callbacks {
>  	int (*read_telem)(struct device *dev, u32 guid, u64 *data, loff_t off, u32 count);
> +	int (*read_discovery)(struct device *dev, unsigned long cap_id, u32 idx, u32 *disc_data);
>  	int (*read_reg)(struct device *dev, u32 guid, u32 *reg_data, u32 offset);
>  	int (*write_reg)(struct device *dev, u32 guid, u32 reg_data, u32 offset);
>  };

Most important, please document the calling context. With this change
the callbacks can be called from the client driver's probe, which is
what the crashlog notification relies on. Something like this after
the member list:

 * The callbacks may be called from the client driver's probe and remove
 * paths. A parent must not hold a lock taken by its callbacks across
 * the registration path or while its devices are being removed.

David

^ permalink raw reply	[flat|nested] 30+ messages in thread

* ✗ CI.checkpatch: warning for Crescent Island PMT support (rev20)
  2026-11-19 15:54 [PATCH v19 00/19] Crescent Island PMT support Michael J. Ruhl
                   ` (18 preceding siblings ...)
  2026-11-19 15:54 ` [PATCH v19 19/19] drm/xe/vsec: Support survivability mode for CRI Michael J. Ruhl
@ 2026-11-19 20:11 ` Patchwork
  2026-11-19 20:13 ` ✓ CI.KUnit: success " Patchwork
  2026-11-19 20:55 ` ✓ Xe.CI.BAT: " Patchwork
  21 siblings, 0 replies; 30+ messages in thread
From: Patchwork @ 2026-11-19 20:11 UTC (permalink / raw)
  To: Michael J. Ruhl; +Cc: intel-xe

== Series Details ==

Series: Crescent Island PMT support (rev20)
URL   : https://patchwork.freedesktop.org/series/160717/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
3009867cd31863246e4afc138520a7a8bd37bb11
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 6f10fca7526c173c56e99dbfb6c683959ace3967
Author: Michael J. Ruhl <michael.j.ruhl@intel.com>
Date:   Thu Nov 19 07:54:57 2026 -0800

    drm/xe/vsec: Support survivability mode for CRI
    
    For survivability mode, CRI can only support access to the
    PUNIT CRASHLOG PMT function.
    
    Create a special config to support survivability mode.
    
    Signed-off-by: Michael J. Ruhl <michael.j.ruhl@intel.com>
+ /mt/dim checkpatch 859a3f2c44944276c49ab8d35f0ffd31b02b19c5 drm-intel
b266346ed64e platform/x86/intel/pmt: Introduce a callback for discovery data
38f3f9953099 platform/x86/intel/pmt: Use the pre-populated header info for crashlog
6c052382b859 drm/xe/vsec: VSEC requires soc-remapper
8618f558cf00 drm/xe/vsec: Do not register BMG PMT for VF
7015bcdfc2be drm/xe/vsec: Correct locking order
73f756e825b3 drm/xe/vsec: Use correct pm state get
df11c2fb7277 drm/xe/vsec: Add DOC text for VSEC
-:21: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#21: 
new file mode 100644

total: 0 errors, 1 warnings, 0 checks, 54 lines checked
5a2ecaaf58eb drm/xe/vsec: Support possible hotplug exit
0a86c366a623 drm/xe/vsec: Refactor BattleMage PMT defines
831e2615816e drm/xe/vsec: Update VSEC probe order
a28d729cb407 drm/xe/vsec: Add base_offset to allow for more flexibilty
c426f80de81b drm/xe/vsec: Support Crescent Island PMT
d0de1183e4c6 drm/xe/vsec: Crescent Island PMT decode
85364f3ae82b drm/xe/vsec: Crescent Island PMT callbacks
a1ea785791c4 drm/xe/vsec: Support late bind fw information
941e25ce3c0d drm/xe/vsec: Add PMT GUID internal access
8d0cbb664242 drm/xe/vsec: Update PMT internal access
900ba243bed3 drm/xe/vsec: Refactor platform check
6f10fca7526c drm/xe/vsec: Support survivability mode for CRI



^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: [PATCH v19 02/19] platform/x86/intel/pmt: Use the pre-populated header info for crashlog
  2026-11-19 15:54 ` [PATCH v19 02/19] platform/x86/intel/pmt: Use the pre-populated header info for crashlog Michael J. Ruhl
@ 2026-11-19 20:13   ` David E. Box
  0 siblings, 0 replies; 30+ messages in thread
From: David E. Box @ 2026-11-19 20:13 UTC (permalink / raw)
  To: Michael J. Ruhl
  Cc: platform-driver-x86, intel-xe, hansg, ilpo.jarvinen,
	matthew.brost, rodrigo.vivi, thomas.hellstrom, airlied, simona,
	anoop.c.vijay, badal.nilawar, matthew.d.roper, james.ausmus

On Thu, Nov 19, 2026 at 07:54:40AM -0800, Michael J. Ruhl wrote:
> Discovery data is pre-populated.
>
> Use the data for crashlog probe.

Please say why: Crashlog read its discovery fields directly from
disc_table, which isn't valid on a parent that provides read_discovery().
Decoding from the disc_header copy that pmt_get_headers() already filled
works for both cases and it's what telemetry already does.

>
> Signed-off-by: Michael J. Ruhl <michael.j.ruhl@intel.com>
> ---
>  drivers/platform/x86/intel/pmt/crashlog.c | 24 +++++++++++------------
>  1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/platform/x86/intel/pmt/crashlog.c b/drivers/platform/x86/intel/pmt/crashlog.c
> index d7018b495217..f7c391d145ff 100644
> --- a/drivers/platform/x86/intel/pmt/crashlog.c
> +++ b/drivers/platform/x86/intel/pmt/crashlog.c
> @@ -27,10 +27,10 @@
>  #define CRASH_TYPE_OOBMSM	1
>  
>  /* Crashlog Discovery Header */
> -#define CONTROL_OFFSET		0x0
> -#define GUID_OFFSET		0x4
> -#define BASE_OFFSET		0x8
> -#define SIZE_OFFSET		0xC
> +#define STATUS_IDX		0
> +#define GUID_IDX		1
> +#define BASE_IDX		2
> +#define SIZE_IDX		3

For STATUS_IDX I'd call it ACCESS_IDX instead. Dword 0 holds the access
type, crashlog type and version, which is what this file reads it for. It
is only the status register on type 1 v2, and on v0 it is also the control
register, so STATUS is confusing here. It also matches GET_ACCESS().

>  #define GET_ACCESS(v)		((v) & GENMASK(3, 0))
>  #define GET_TYPE(v)		(((v) & GENMASK(7, 4)) >> 4)
>  #define GET_VERSION(v)		(((v) & GENMASK(19, 16)) >> 16)
> @@ -208,10 +208,10 @@ static int pmt_crashlog_disabled(struct crashlog_entry *crashlog, bool *state)
>  
>  static bool pmt_crashlog_supported(struct intel_pmt_entry *entry, u32 *crash_type, u32 *version)
>  {
> -	u32 discovery_header = readl(entry->disc_table + CONTROL_OFFSET);
> +	u32 *disc_header = entry->disc_header;
>  
> -	*crash_type = GET_TYPE(discovery_header);
> -	*version = GET_VERSION(discovery_header);
> +	*crash_type = GET_TYPE(disc_header[STATUS_IDX]);
> +	*version = GET_VERSION(disc_header[STATUS_IDX]);
>  
>  	/*
>  	 * Currently we only recognize OOBMSM (type 1) and version 0 or 2
> @@ -608,15 +608,15 @@ static int pmt_crashlog_pre_decode(struct intel_vsec_device *ivdev,
>  static int pmt_crashlog_header_decode(struct intel_pmt_entry *entry,
>  				      struct device *dev)
>  {
> -	void __iomem *disc_table = entry->disc_table;
>  	struct intel_pmt_header *header = &entry->header;
> +	u32 *disc_header = entry->disc_header;
>  
> -	header->access_type = GET_ACCESS(readl(disc_table));
> -	header->guid = readl(disc_table + GUID_OFFSET);
> -	header->base_offset = readl(disc_table + BASE_OFFSET);
> +	header->access_type = GET_ACCESS(disc_header[STATUS_IDX]);
> +	header->guid = disc_header[GUID_IDX];
> +	header->base_offset = disc_header[BASE_IDX];
>  
>  	/* Size is measured in DWORDS, but accessor returns bytes */
> -	header->size = GET_SIZE(readl(disc_table + SIZE_OFFSET));
> +	header->size = GET_SIZE(disc_header[SIZE_IDX]);
>  
>  	return 0;
>  }

With STATUS_IDX renamed and the commit message expanded, this looks good to
me.

David

^ permalink raw reply	[flat|nested] 30+ messages in thread

* ✓ CI.KUnit: success for Crescent Island PMT support (rev20)
  2026-11-19 15:54 [PATCH v19 00/19] Crescent Island PMT support Michael J. Ruhl
                   ` (19 preceding siblings ...)
  2026-11-19 20:11 ` ✗ CI.checkpatch: warning for Crescent Island PMT support (rev20) Patchwork
@ 2026-11-19 20:13 ` Patchwork
  2026-11-19 20:55 ` ✓ Xe.CI.BAT: " Patchwork
  21 siblings, 0 replies; 30+ messages in thread
From: Patchwork @ 2026-11-19 20:13 UTC (permalink / raw)
  To: Michael J. Ruhl; +Cc: intel-xe

== Series Details ==

Series: Crescent Island PMT support (rev20)
URL   : https://patchwork.freedesktop.org/series/160717/
State : success

== Summary ==

+ trap cleanup EXIT
+ kunitconfigs=('/kernel/drivers/gpu/tests/.kunitconfig' '/kernel/drivers/gpu/drm/xe/.kunitconfig' '/kernel/drivers/gpu/drm/tests/.kunitconfig' '/kernel/drivers/gpu/drm/ttm/tests/.kunitconfig' '/kernel/drivers/dma-buf/.kunitconfig')
+ for kcfg in "${kunitconfigs[@]}"
+ [[ ! -f /kernel/drivers/gpu/tests/.kunitconfig ]]
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/tests/.kunitconfig
[20:11:43] Configuring KUnit Kernel ...
Generating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
[20:11:48] Building KUnit Kernel ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
Building with:
$ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48
[20:12:09] Starting KUnit Kernel (1/1)...
[20:12:09] ============================================================
Running tests with:
$ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt
[20:12:09] ================= gpu_buddy (15 subtests) ==================
[20:12:09] [PASSED] gpu_test_buddy_alloc_limit
[20:12:09] [PASSED] gpu_test_buddy_alloc_optimistic
[20:12:09] [PASSED] gpu_test_buddy_alloc_pessimistic
[20:12:09] [PASSED] gpu_test_buddy_alloc_pathological
[20:12:09] [PASSED] gpu_test_buddy_alloc_contiguous
[20:12:09] [PASSED] gpu_test_buddy_alloc_clear
[20:12:09] [PASSED] gpu_test_buddy_alloc_range
[20:12:09] [PASSED] gpu_test_buddy_alloc_range_bias
[20:12:09] [PASSED] gpu_test_buddy_alloc_range_clear_guard
[20:12:10] [PASSED] gpu_test_buddy_fragmentation_performance
[20:12:11] [PASSED] gpu_test_buddy_dirty_tracker_performance
[20:12:11] [PASSED] gpu_test_buddy_alloc_exceeds_max_order
[20:12:11] [PASSED] gpu_test_buddy_offset_aligned_allocation
[20:12:11] [PASSED] gpu_test_buddy_subtree_offset_alignment_stress
[20:12:11] [PASSED] gpu_test_buddy_addr_to_block
[20:12:11] ==================== [PASSED] gpu_buddy ====================
[20:12:11] ============================================================
[20:12:11] Testing complete. Ran 15 tests: passed: 15
[20:12:11] Elapsed time: 27.919s total, 5.012s configuring, 20.840s building, 2.029s running

+ for kcfg in "${kunitconfigs[@]}"
+ [[ ! -f /kernel/drivers/gpu/drm/xe/.kunitconfig ]]
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/xe/.kunitconfig
[20:12:11] Configuring KUnit Kernel ...
Regenerating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
[20:12:14] Building KUnit Kernel ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
Building with:
$ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48
[20:12:52] Starting KUnit Kernel (1/1)...
[20:12:52] ============================================================
Running tests with:
$ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt
[20:12:53] ================= xe_ggtt_iov (9 subtests) =================
[20:12:53] [PASSED] init_shared_pf
[20:12:53] [PASSED] init_partial_overlap
[20:12:53] [PASSED] alloc_usable_pool_low
[20:12:53] [PASSED] alloc_shareable_pool_high
[20:12:53] [PASSED] alloc_partial_overlap
[20:12:53] [PASSED] alloc_partial_overlap_usable_full
[20:12:53] [PASSED] alloc_partial_overlap_shareable_full
[20:12:53] [PASSED] alloc_shareable_pool_unavailable
[20:12:53] [PASSED] alloc_shareable_pool_oversized
[20:12:53] =================== [PASSED] xe_ggtt_iov ===================
[20:12:53] =================== xe_ggtt (3 subtests) ===================
[20:12:53] [PASSED] init_native
[20:12:53] [PASSED] alloc_usable_pool_native
[20:12:53] [PASSED] alloc_usable_pool_oversized
[20:12:53] ===================== [PASSED] xe_ggtt =====================
[20:12:53] ================== guc_buf (11 subtests) ===================
[20:12:53] [PASSED] test_smallest
[20:12:53] [PASSED] test_largest
[20:12:53] [PASSED] test_granular
[20:12:53] [PASSED] test_unique
[20:12:53] [PASSED] test_overlap
[20:12:53] [PASSED] test_reusable
[20:12:53] [PASSED] test_too_big
[20:12:53] [PASSED] test_flush
[20:12:53] [PASSED] test_lookup
[20:12:53] [PASSED] test_data
[20:12:53] [PASSED] test_class
[20:12:53] ===================== [PASSED] guc_buf =====================
[20:12:53] =================== guc_dbm (7 subtests) ===================
[20:12:53] [PASSED] test_empty
[20:12:53] [PASSED] test_default
[20:12:53] ======================== test_size  ========================
[20:12:53] [PASSED] 4
[20:12:53] [PASSED] 8
[20:12:53] [PASSED] 32
[20:12:53] [PASSED] 256
[20:12:53] ==================== [PASSED] test_size ====================
[20:12:53] ======================= test_reuse  ========================
[20:12:53] [PASSED] 4
[20:12:53] [PASSED] 8
[20:12:53] [PASSED] 32
[20:12:53] [PASSED] 256
[20:12:53] =================== [PASSED] test_reuse ====================
[20:12:53] =================== test_range_overlap  ====================
[20:12:53] [PASSED] 4
[20:12:53] [PASSED] 8
[20:12:53] [PASSED] 32
[20:12:53] [PASSED] 256
[20:12:53] =============== [PASSED] test_range_overlap ================
[20:12:53] =================== test_range_compact  ====================
[20:12:53] [PASSED] 4
[20:12:53] [PASSED] 8
[20:12:53] [PASSED] 32
[20:12:53] [PASSED] 256
[20:12:53] =============== [PASSED] test_range_compact ================
[20:12:53] ==================== test_range_spare  =====================
[20:12:53] [PASSED] 4
[20:12:53] [PASSED] 8
[20:12:53] [PASSED] 32
[20:12:53] [PASSED] 256
[20:12:53] ================ [PASSED] test_range_spare =================
[20:12:53] ===================== [PASSED] guc_dbm =====================
[20:12:53] ================== guc_idm (22 subtests) ===================
[20:12:53] [PASSED] bad_init
[20:12:53] [PASSED] no_init
[20:12:53] [PASSED] init_fini
[20:12:53] [PASSED] check_init_small
[20:12:53] [PASSED] check_init_shared
[20:12:53] [PASSED] check_used
[20:12:53] [PASSED] check_quota
[20:12:53] [PASSED] check_all
[20:12:53] [PASSED] check_limits
[20:12:53] [PASSED] check_overlap
[20:12:53] [PASSED] check_overlap_alloc
[20:12:53] [PASSED] check_overlap_release
[20:12:53] [PASSED] check_overlap_partial_init
[20:12:53] [PASSED] check_overlap_partial_shared_range_blocking
[20:12:53] [PASSED] check_used_usable
[20:12:53] [PASSED] check_used_shareable
[20:12:53] [PASSED] check_used_mixed
[20:12:53] [PASSED] check_release_usable_range
[20:12:53] [PASSED] check_release_shareable_range
[20:12:53] [PASSED] check_split_boundaries
[20:12:53] [PASSED] check_shareable_spare
[20:12:53] [PASSED] check_shareable_spare_fragmented_tail
[20:12:53] ===================== [PASSED] guc_idm =====================
[20:12:53] ============== guc_klv_helpers (13 subtests) ===============
[20:12:53] [PASSED] test_count
[20:12:53] [PASSED] test_encode_u32
[20:12:53] [PASSED] test_encode_u64
[20:12:53] [PASSED] test_encode_string
[20:12:53] [PASSED] test_encode_object_raw
[20:12:53] [PASSED] test_encode_object_klv
[20:12:53] [PASSED] test_encode_object_nested
[20:12:53] [PASSED] test_encode_object_basic
[20:12:53] ===================== test_decode_u16  =====================
[20:12:53] [PASSED] empty
[20:12:53] [PASSED] valid
[20:12:53] [PASSED] max
[20:12:53] [PASSED] big
[20:12:53] [PASSED] long
[20:12:53] ================= [PASSED] test_decode_u16 =================
[20:12:53] ===================== test_decode_u32  =====================
[20:12:53] [PASSED] empty
[20:12:53] [PASSED] valid
[20:12:53] [PASSED] max
[20:12:53] [PASSED] long
[20:12:53] ================= [PASSED] test_decode_u32 =================
[20:12:53] ===================== test_decode_u64  =====================
[20:12:53] [PASSED] empty
[20:12:53] [PASSED] short
[20:12:53] [PASSED] valid
[20:12:53] [PASSED] max
[20:12:53] [PASSED] long
[20:12:53] ================= [PASSED] test_decode_u64 =================
[20:12:53] ===================== test_decode_str  =====================
[20:12:53] [PASSED] empty
[20:12:53] [PASSED] one
[20:12:53] [PASSED] one_trash
[20:12:53] [PASSED] two
[20:12:53] [PASSED] two_trash
[20:12:53] [PASSED] three
[20:12:53] [PASSED] dword
[20:12:53] [PASSED] four
[20:12:53] [PASSED] five
[20:12:53] [PASSED] six
[20:12:53] [PASSED] seven
[20:12:53] [PASSED] qword
[20:12:53] ================= [PASSED] test_decode_str =================
[20:12:53] [PASSED] test_print
[20:12:53] ================= [PASSED] guc_klv_helpers =================
[20:12:53] =================== xe_log (4 subtests) ====================
[20:12:53] [PASSED] demo_cper
[20:12:53] [PASSED] demo_dmesg
[20:12:53] ======================= test_dmesg  ========================
[20:12:53] [PASSED] test_fatal
[20:12:53] [PASSED] test_fatal_tile
[20:12:53] [PASSED] test_fatal_gt
[20:12:53] [PASSED] test_fatal_comp
[20:12:53] [PASSED] test_fatal_comp_tile
[20:12:53] [PASSED] test_fatal_comp_gt
[20:12:53] [PASSED] test_fatal_all
[20:12:53] [PASSED] test_recoverable
[20:12:53] [PASSED] test_recoverable_tile
[20:12:53] [PASSED] test_recoverable_gt
[20:12:53] [PASSED] test_recoverable_comp
[20:12:53] [PASSED] test_recoverable_comp_tile
[20:12:53] [PASSED] test_recoverable_comp_gt
[20:12:53] [PASSED] test_recoverable_all
[20:12:53] [PASSED] test_info
[20:12:53] [PASSED] test_info_tile
[20:12:53] [PASSED] test_info_gt
[20:12:53] [PASSED] test_info_err
[20:12:53] [PASSED] test_info_comp
[20:12:53] [PASSED] test_info_comp_tile
[20:12:53] [PASSED] test_info_comp_gt
[20:12:53] [PASSED] test_info_all
[20:12:53] [PASSED] test_hw_fatal
[20:12:53] [PASSED] test_hw_recoverable
[20:12:53] [PASSED] test_hw_corrected
[20:12:53] [PASSED] test_hw_informational
[20:12:53] =================== [PASSED] test_dmesg ====================
[20:12:53] ====================== test_invalid  =======================
[20:12:53] [SKIPPED] no-component no-location no-warn (requires CONFIG_DRM_XE_DEBUG)
[20:12:53] [SKIPPED] reserved location (requires CONFIG_DRM_XE_DEBUG)
[20:12:53] [SKIPPED] unknown location (requires CONFIG_DRM_XE_DEBUG)
[20:12:53] [SKIPPED] nonzero-device-id location (requires CONFIG_DRM_XE_DEBUG)
[20:12:53] [SKIPPED] invalid-tile-id location (requires CONFIG_DRM_XE_DEBUG)
[20:12:53] [SKIPPED] invalid-gt-id location (requires CONFIG_DRM_XE_DEBUG)
[20:12:53] [SKIPPED] unknown component class (requires CONFIG_DRM_XE_DEBUG)
[20:12:53] [SKIPPED] unknown system component (requires CONFIG_DRM_XE_DEBUG)
[20:12:53] [SKIPPED] unknown hardware component (requires CONFIG_DRM_XE_DEBUG)
[20:12:53] [SKIPPED] unknown component and location (requires CONFIG_DRM_XE_DEBUG)
[20:12:53] ================== [SKIPPED] test_invalid ==================
[20:12:53] ===================== [PASSED] xe_log ======================
[20:12:53] ================== no_relay (3 subtests) ===================
[20:12:53] [PASSED] xe_drops_guc2pf_if_not_ready
[20:12:53] [PASSED] xe_drops_guc2vf_if_not_ready
[20:12:53] [PASSED] xe_rejects_send_if_not_ready
[20:12:53] ==================== [PASSED] no_relay =====================
[20:12:53] ================== pf_relay (14 subtests) ==================
[20:12:53] [PASSED] pf_rejects_guc2pf_too_short
[20:12:53] [PASSED] pf_rejects_guc2pf_too_long
[20:12:53] [PASSED] pf_rejects_guc2pf_no_payload
[20:12:53] [PASSED] pf_fails_no_payload
[20:12:53] [PASSED] pf_fails_bad_origin
[20:12:53] [PASSED] pf_fails_bad_type
[20:12:53] [PASSED] pf_txn_reports_error
[20:12:53] [PASSED] pf_txn_sends_pf2guc
[20:12:53] [PASSED] pf_sends_pf2guc
[20:12:53] [SKIPPED] pf_loopback_nop (requires CONFIG_DRM_XE_DEBUG_SRIOV)
[20:12:53] [SKIPPED] pf_loopback_echo (requires CONFIG_DRM_XE_DEBUG_SRIOV)
[20:12:53] [SKIPPED] pf_loopback_fail (requires CONFIG_DRM_XE_DEBUG_SRIOV)
[20:12:53] [SKIPPED] pf_loopback_busy (requires CONFIG_DRM_XE_DEBUG_SRIOV)
[20:12:53] [SKIPPED] pf_loopback_retry (requires CONFIG_DRM_XE_DEBUG_SRIOV)
[20:12:53] ==================== [PASSED] pf_relay =====================
[20:12:53] ================== vf_relay (3 subtests) ===================
[20:12:53] [PASSED] vf_rejects_guc2vf_too_short
[20:12:53] [PASSED] vf_rejects_guc2vf_too_long
[20:12:53] [PASSED] vf_rejects_guc2vf_no_payload
[20:12:53] ==================== [PASSED] vf_relay =====================
[20:12:53] ================ pf_gt_config (9 subtests) =================
[20:12:53] [PASSED] fair_contexts_1vf
[20:12:53] [PASSED] fair_doorbells_1vf
[20:12:53] [PASSED] fair_ggtt_1vf
[20:12:53] ====================== fair_vram_1vf  ======================
[20:12:53] [PASSED] 3.50 GiB
[20:12:53] [PASSED] 11.5 GiB
[20:12:53] [PASSED] 15.5 GiB
[20:12:53] [PASSED] 31.5 GiB
[20:12:53] [PASSED] 63.5 GiB
[20:12:53] [PASSED] 1.91 GiB
[20:12:53] ================== [PASSED] fair_vram_1vf ==================
[20:12:53] ================ fair_vram_1vf_admin_only  =================
[20:12:53] [PASSED] 3.50 GiB
[20:12:53] [PASSED] 11.5 GiB
[20:12:53] [PASSED] 15.5 GiB
[20:12:53] [PASSED] 31.5 GiB
[20:12:53] [PASSED] 63.5 GiB
[20:12:53] [PASSED] 1.91 GiB
[20:12:53] ============ [PASSED] fair_vram_1vf_admin_only =============
[20:12:53] ====================== fair_contexts  ======================
[20:12:53] [PASSED] 1 VF
[20:12:53] [PASSED] 2 VFs
[20:12:53] [PASSED] 3 VFs
[20:12:53] [PASSED] 4 VFs
[20:12:53] [PASSED] 5 VFs
[20:12:53] [PASSED] 6 VFs
[20:12:53] [PASSED] 7 VFs
[20:12:53] [PASSED] 8 VFs
[20:12:53] [PASSED] 9 VFs
[20:12:53] [PASSED] 10 VFs
[20:12:53] [PASSED] 11 VFs
[20:12:53] [PASSED] 12 VFs
[20:12:53] [PASSED] 13 VFs
[20:12:53] [PASSED] 14 VFs
[20:12:53] [PASSED] 15 VFs
[20:12:53] [PASSED] 16 VFs
[20:12:53] [PASSED] 17 VFs
[20:12:53] [PASSED] 18 VFs
[20:12:53] [PASSED] 19 VFs
[20:12:53] [PASSED] 20 VFs
[20:12:53] [PASSED] 21 VFs
[20:12:53] [PASSED] 22 VFs
[20:12:53] [PASSED] 23 VFs
[20:12:53] [PASSED] 24 VFs
[20:12:53] [PASSED] 25 VFs
[20:12:53] [PASSED] 26 VFs
[20:12:53] [PASSED] 27 VFs
[20:12:53] [PASSED] 28 VFs
[20:12:53] [PASSED] 29 VFs
[20:12:53] [PASSED] 30 VFs
[20:12:53] [PASSED] 31 VFs
[20:12:53] [PASSED] 32 VFs
[20:12:53] [PASSED] 33 VFs
[20:12:53] [PASSED] 34 VFs
[20:12:53] [PASSED] 35 VFs
[20:12:53] [PASSED] 36 VFs
[20:12:53] [PASSED] 37 VFs
[20:12:53] [PASSED] 38 VFs
[20:12:53] [PASSED] 39 VFs
[20:12:53] [PASSED] 40 VFs
[20:12:53] [PASSED] 41 VFs
[20:12:53] [PASSED] 42 VFs
[20:12:53] [PASSED] 43 VFs
[20:12:53] [PASSED] 44 VFs
[20:12:53] [PASSED] 45 VFs
[20:12:53] [PASSED] 46 VFs
[20:12:53] [PASSED] 47 VFs
[20:12:53] [PASSED] 48 VFs
[20:12:53] [PASSED] 49 VFs
[20:12:53] [PASSED] 50 VFs
[20:12:53] [PASSED] 51 VFs
[20:12:53] [PASSED] 52 VFs
[20:12:53] [PASSED] 53 VFs
[20:12:53] [PASSED] 54 VFs
[20:12:53] [PASSED] 55 VFs
[20:12:53] [PASSED] 56 VFs
[20:12:53] [PASSED] 57 VFs
[20:12:53] [PASSED] 58 VFs
[20:12:53] [PASSED] 59 VFs
[20:12:53] [PASSED] 60 VFs
[20:12:53] [PASSED] 61 VFs
[20:12:53] [PASSED] 62 VFs
[20:12:53] [PASSED] 63 VFs
[20:12:53] ================== [PASSED] fair_contexts ==================
[20:12:53] ===================== fair_doorbells  ======================
[20:12:53] [PASSED] 1 VF
[20:12:53] [PASSED] 2 VFs
[20:12:53] [PASSED] 3 VFs
[20:12:53] [PASSED] 4 VFs
[20:12:53] [PASSED] 5 VFs
[20:12:53] [PASSED] 6 VFs
[20:12:53] [PASSED] 7 VFs
[20:12:53] [PASSED] 8 VFs
[20:12:53] [PASSED] 9 VFs
[20:12:53] [PASSED] 10 VFs
[20:12:53] [PASSED] 11 VFs
[20:12:53] [PASSED] 12 VFs
[20:12:53] [PASSED] 13 VFs
[20:12:53] [PASSED] 14 VFs
[20:12:53] [PASSED] 15 VFs
[20:12:53] [PASSED] 16 VFs
[20:12:53] [PASSED] 17 VFs
[20:12:53] [PASSED] 18 VFs
[20:12:53] [PASSED] 19 VFs
[20:12:53] [PASSED] 20 VFs
[20:12:53] [PASSED] 21 VFs
[20:12:53] [PASSED] 22 VFs
[20:12:53] [PASSED] 23 VFs
[20:12:53] [PASSED] 24 VFs
[20:12:53] [PASSED] 25 VFs
[20:12:53] [PASSED] 26 VFs
[20:12:53] [PASSED] 27 VFs
[20:12:53] [PASSED] 28 VFs
[20:12:53] [PASSED] 29 VFs
[20:12:53] [PASSED] 30 VFs
[20:12:53] [PASSED] 31 VFs
[20:12:53] [PASSED] 32 VFs
[20:12:53] [PASSED] 33 VFs
[20:12:53] [PASSED] 34 VFs
[20:12:53] [PASSED] 35 VFs
[20:12:53] [PASSED] 36 VFs
[20:12:53] [PASSED] 37 VFs
[20:12:53] [PASSED] 38 VFs
[20:12:53] [PASSED] 39 VFs
[20:12:53] [PASSED] 40 VFs
[20:12:53] [PASSED] 41 VFs
[20:12:53] [PASSED] 42 VFs
[20:12:53] [PASSED] 43 VFs
[20:12:53] [PASSED] 44 VFs
[20:12:53] [PASSED] 45 VFs
[20:12:53] [PASSED] 46 VFs
[20:12:53] [PASSED] 47 VFs
[20:12:53] [PASSED] 48 VFs
[20:12:53] [PASSED] 49 VFs
[20:12:53] [PASSED] 50 VFs
[20:12:53] [PASSED] 51 VFs
[20:12:53] [PASSED] 52 VFs
[20:12:53] [PASSED] 53 VFs
[20:12:53] [PASSED] 54 VFs
[20:12:53] [PASSED] 55 VFs
[20:12:53] [PASSED] 56 VFs
[20:12:53] [PASSED] 57 VFs
[20:12:53] [PASSED] 58 VFs
[20:12:53] [PASSED] 59 VFs
[20:12:53] [PASSED] 60 VFs
[20:12:53] [PASSED] 61 VFs
[20:12:53] [PASSED] 62 VFs
[20:12:53] [PASSED] 63 VFs
[20:12:53] ================= [PASSED] fair_doorbells ==================
[20:12:53] ======================== fair_ggtt  ========================
[20:12:53] [PASSED] 1 VF
[20:12:53] [PASSED] 2 VFs
[20:12:53] [PASSED] 3 VFs
[20:12:53] [PASSED] 4 VFs
[20:12:53] [PASSED] 5 VFs
[20:12:53] [PASSED] 6 VFs
[20:12:53] [PASSED] 7 VFs
[20:12:53] [PASSED] 8 VFs
[20:12:53] [PASSED] 9 VFs
[20:12:53] [PASSED] 10 VFs
[20:12:53] [PASSED] 11 VFs
[20:12:53] [PASSED] 12 VFs
[20:12:53] [PASSED] 13 VFs
[20:12:53] [PASSED] 14 VFs
[20:12:53] [PASSED] 15 VFs
[20:12:53] [PASSED] 16 VFs
[20:12:53] [PASSED] 17 VFs
[20:12:53] [PASSED] 18 VFs
[20:12:53] [PASSED] 19 VFs
[20:12:53] [PASSED] 20 VFs
[20:12:53] [PASSED] 21 VFs
[20:12:53] [PASSED] 22 VFs
[20:12:53] [PASSED] 23 VFs
[20:12:53] [PASSED] 24 VFs
[20:12:53] [PASSED] 25 VFs
[20:12:53] [PASSED] 26 VFs
[20:12:53] [PASSED] 27 VFs
[20:12:53] [PASSED] 28 VFs
[20:12:53] [PASSED] 29 VFs
[20:12:53] [PASSED] 30 VFs
[20:12:53] [PASSED] 31 VFs
[20:12:53] [PASSED] 32 VFs
[20:12:53] [PASSED] 33 VFs
[20:12:53] [PASSED] 34 VFs
[20:12:53] [PASSED] 35 VFs
[20:12:53] [PASSED] 36 VFs
[20:12:53] [PASSED] 37 VFs
[20:12:53] [PASSED] 38 VFs
[20:12:53] [PASSED] 39 VFs
[20:12:53] [PASSED] 40 VFs
[20:12:53] [PASSED] 41 VFs
[20:12:53] [PASSED] 42 VFs
[20:12:53] [PASSED] 43 VFs
[20:12:53] [PASSED] 44 VFs
[20:12:53] [PASSED] 45 VFs
[20:12:53] [PASSED] 46 VFs
[20:12:53] [PASSED] 47 VFs
[20:12:53] [PASSED] 48 VFs
[20:12:53] [PASSED] 49 VFs
[20:12:53] [PASSED] 50 VFs
[20:12:53] [PASSED] 51 VFs
[20:12:53] [PASSED] 52 VFs
[20:12:53] [PASSED] 53 VFs
[20:12:53] [PASSED] 54 VFs
[20:12:53] [PASSED] 55 VFs
[20:12:53] [PASSED] 56 VFs
[20:12:53] [PASSED] 57 VFs
[20:12:53] [PASSED] 58 VFs
[20:12:53] [PASSED] 59 VFs
[20:12:53] [PASSED] 60 VFs
[20:12:53] [PASSED] 61 VFs
[20:12:53] [PASSED] 62 VFs
[20:12:53] [PASSED] 63 VFs
[20:12:53] ==================== [PASSED] fair_ggtt ====================
[20:12:53] ======================== fair_vram  ========================
[20:12:53] [PASSED] 1 VF
[20:12:53] [PASSED] 2 VFs
[20:12:53] [PASSED] 3 VFs
[20:12:53] [PASSED] 4 VFs
[20:12:53] [PASSED] 5 VFs
[20:12:53] [PASSED] 6 VFs
[20:12:53] [PASSED] 7 VFs
[20:12:53] [PASSED] 8 VFs
[20:12:53] [PASSED] 9 VFs
[20:12:53] [PASSED] 10 VFs
[20:12:53] [PASSED] 11 VFs
[20:12:53] [PASSED] 12 VFs
[20:12:53] [PASSED] 13 VFs
[20:12:53] [PASSED] 14 VFs
[20:12:53] [PASSED] 15 VFs
[20:12:53] [PASSED] 16 VFs
[20:12:53] [PASSED] 17 VFs
[20:12:53] [PASSED] 18 VFs
[20:12:53] [PASSED] 19 VFs
[20:12:53] [PASSED] 20 VFs
[20:12:53] [PASSED] 21 VFs
[20:12:53] [PASSED] 22 VFs
[20:12:53] [PASSED] 23 VFs
[20:12:53] [PASSED] 24 VFs
[20:12:53] [PASSED] 25 VFs
[20:12:53] [PASSED] 26 VFs
[20:12:53] [PASSED] 27 VFs
[20:12:53] [PASSED] 28 VFs
[20:12:53] [PASSED] 29 VFs
[20:12:53] [PASSED] 30 VFs
[20:12:53] [PASSED] 31 VFs
[20:12:53] [PASSED] 32 VFs
[20:12:53] [PASSED] 33 VFs
[20:12:53] [PASSED] 34 VFs
[20:12:53] [PASSED] 35 VFs
[20:12:53] [PASSED] 36 VFs
[20:12:53] [PASSED] 37 VFs
[20:12:53] [PASSED] 38 VFs
[20:12:53] [PASSED] 39 VFs
[20:12:53] [PASSED] 40 VFs
[20:12:53] [PASSED] 41 VFs
[20:12:53] [PASSED] 42 VFs
[20:12:53] [PASSED] 43 VFs
[20:12:53] [PASSED] 44 VFs
[20:12:53] [PASSED] 45 VFs
[20:12:53] [PASSED] 46 VFs
[20:12:53] [PASSED] 47 VFs
[20:12:53] [PASSED] 48 VFs
[20:12:53] [PASSED] 49 VFs
[20:12:53] [PASSED] 50 VFs
[20:12:53] [PASSED] 51 VFs
[20:12:53] [PASSED] 52 VFs
[20:12:53] [PASSED] 53 VFs
[20:12:53] [PASSED] 54 VFs
[20:12:53] [PASSED] 55 VFs
[20:12:53] [PASSED] 56 VFs
[20:12:53] [PASSED] 57 VFs
[20:12:53] [PASSED] 58 VFs
[20:12:53] [PASSED] 59 VFs
[20:12:53] [PASSED] 60 VFs
[20:12:53] [PASSED] 61 VFs
[20:12:53] [PASSED] 62 VFs
[20:12:53] [PASSED] 63 VFs
[20:12:53] ==================== [PASSED] fair_vram ====================
[20:12:53] ================== [PASSED] pf_gt_config ===================
[20:12:53] ===================== lmtt (1 subtest) =====================
[20:12:53] ======================== test_ops  =========================
[20:12:53] [PASSED] 2-level
[20:12:53] [PASSED] multi-level
[20:12:53] ==================== [PASSED] test_ops =====================
[20:12:53] ====================== [PASSED] lmtt =======================
[20:12:53] ================= sriov_packet (1 subtest) =================
[20:12:53] [PASSED] test_descriptor_init
[20:12:53] ================== [PASSED] sriov_packet ===================
[20:12:53] ================= pf_service (11 subtests) =================
[20:12:53] [PASSED] pf_negotiate_any
[20:12:53] [PASSED] pf_negotiate_base_match
[20:12:53] [PASSED] pf_negotiate_base_newer
[20:12:53] [PASSED] pf_negotiate_base_next
[20:12:53] [SKIPPED] pf_negotiate_base_older (no older minor)
[20:12:53] [PASSED] pf_negotiate_base_prev
[20:12:53] [PASSED] pf_negotiate_latest_match
[20:12:53] [PASSED] pf_negotiate_latest_newer
[20:12:53] [PASSED] pf_negotiate_latest_next
[20:12:53] [SKIPPED] pf_negotiate_latest_older (no older minor)
[20:12:53] [SKIPPED] pf_negotiate_latest_prev (no prev major)
[20:12:53] =================== [PASSED] pf_service ====================
[20:12:53] ================= xe_guc_g2g (2 subtests) ==================
[20:12:53] ============== xe_live_guc_g2g_kunit_default  ==============
[20:12:53] ========= [SKIPPED] xe_live_guc_g2g_kunit_default ==========
[20:12:53] ============== xe_live_guc_g2g_kunit_allmem  ===============
[20:12:53] ========== [SKIPPED] xe_live_guc_g2g_kunit_allmem ==========
[20:12:53] =================== [SKIPPED] xe_guc_g2g ===================
[20:12:53] =================== xe_mocs (2 subtests) ===================
[20:12:53] ================ xe_live_mocs_kernel_kunit  ================
[20:12:53] =========== [SKIPPED] xe_live_mocs_kernel_kunit ============
[20:12:53] ================ xe_live_mocs_reset_kunit  =================
[20:12:53] ============ [SKIPPED] xe_live_mocs_reset_kunit ============
[20:12:53] ==================== [SKIPPED] xe_mocs =====================
[20:12:53] ================= xe_migrate (3 subtests) ==================
[20:12:53] ================= xe_migrate_sanity_kunit  =================
[20:12:53] ============ [SKIPPED] xe_migrate_sanity_kunit =============
[20:12:53] ================== xe_validate_ccs_kunit  ==================
[20:12:53] ============= [SKIPPED] xe_validate_ccs_kunit ==============
[20:12:53] ============= xe_migrate_access_memory_kunit  ==============
[20:12:53] ========= [SKIPPED] xe_migrate_access_memory_kunit =========
[20:12:53] =================== [SKIPPED] xe_migrate ===================
[20:12:53] ================== xe_dma_buf (1 subtest) ==================
[20:12:53] ==================== xe_dma_buf_kunit  =====================
[20:12:53] ================ [SKIPPED] xe_dma_buf_kunit ================
[20:12:53] =================== [SKIPPED] xe_dma_buf ===================
[20:12:53] ================= xe_bo_shrink (1 subtest) =================
[20:12:53] =================== xe_bo_shrink_kunit  ====================
[20:12:53] =============== [SKIPPED] xe_bo_shrink_kunit ===============
[20:12:53] ================== [SKIPPED] xe_bo_shrink ==================
[20:12:53] ==================== xe_bo (2 subtests) ====================
[20:12:53] ================== xe_ccs_migrate_kunit  ===================
[20:12:53] ============== [SKIPPED] xe_ccs_migrate_kunit ==============
[20:12:53] ==================== xe_bo_evict_kunit  ====================
[20:12:53] =============== [SKIPPED] xe_bo_evict_kunit ================
[20:12:53] ===================== [SKIPPED] xe_bo ======================
[20:12:53] =================== xe_any (9 subtests) ====================
[20:12:53] [PASSED] test_to_xe
[20:12:53] [PASSED] test_to_dev
[20:12:53] [PASSED] test_to_pdev
[20:12:53] [PASSED] test_to_drm
[20:12:53] [PASSED] test_if_pdev
[20:12:53] [PASSED] test_if_xe
[20:12:53] [PASSED] test_if_tile
[20:12:53] [PASSED] test_if_gt
[20:12:53] [PASSED] test_to_id
[20:12:53] ===================== [PASSED] xe_any ======================
[20:12:53] ==================== args (13 subtests) ====================
[20:12:53] [PASSED] count_args_test
[20:12:53] [PASSED] call_args_example
[20:12:53] [PASSED] call_args_test
[20:12:53] [PASSED] drop_first_arg_example
[20:12:53] [PASSED] drop_first_arg_test
[20:12:53] [PASSED] first_arg_example
[20:12:53] [PASSED] first_arg_test
[20:12:53] [PASSED] last_arg_example
[20:12:53] [PASSED] last_arg_test
[20:12:53] [PASSED] pick_arg_example
[20:12:53] [PASSED] if_args_example
[20:12:53] [PASSED] if_args_test
[20:12:53] [PASSED] sep_comma_example
[20:12:53] ====================== [PASSED] args =======================
[20:12:53] =================== xe_pci (3 subtests) ====================
[20:12:53] ==================== check_graphics_ip  ====================
[20:12:53] [PASSED] 12.00 Xe_LP
[20:12:53] [PASSED] 12.10 Xe_LP+
[20:12:53] [PASSED] 12.55 Xe_HPG
[20:12:53] [PASSED] 12.60 Xe_HPC
[20:12:53] [PASSED] 12.70 Xe_LPG
[20:12:53] [PASSED] 12.71 Xe_LPG
[20:12:53] [PASSED] 12.74 Xe_LPG+
[20:12:53] [PASSED] 20.01 Xe2_HPG
[20:12:53] [PASSED] 20.02 Xe2_HPG
[20:12:53] [PASSED] 20.04 Xe2_LPG
[20:12:53] [PASSED] 30.00 Xe3_LPG
[20:12:53] [PASSED] 30.01 Xe3_LPG
[20:12:53] [PASSED] 30.03 Xe3_LPG
[20:12:53] [PASSED] 30.04 Xe3_LPG
[20:12:53] [PASSED] 30.05 Xe3_LPG
[20:12:53] [PASSED] 35.10 Xe3p_LPG
[20:12:53] [PASSED] 35.11 Xe3p_XPC
[20:12:53] ================ [PASSED] check_graphics_ip ================
[20:12:53] ===================== check_media_ip  ======================
[20:12:53] [PASSED] 12.00 Xe_M
[20:12:53] [PASSED] 12.55 Xe_HPM
[20:12:53] [PASSED] 13.00 Xe_LPM+
[20:12:53] [PASSED] 13.01 Xe2_HPM
[20:12:53] [PASSED] 20.00 Xe2_LPM
[20:12:53] [PASSED] 30.00 Xe3_LPM
[20:12:53] [PASSED] 30.02 Xe3_LPM
[20:12:53] [PASSED] 35.00 Xe3p_LPM
[20:12:53] [PASSED] 35.03 Xe3p_HPM
[20:12:53] ================= [PASSED] check_media_ip ==================
[20:12:53] =================== check_platform_desc  ===================
[20:12:53] [PASSED] 0x9A60 (TIGERLAKE)
[20:12:53] [PASSED] 0x9A68 (TIGERLAKE)
[20:12:53] [PASSED] 0x9A70 (TIGERLAKE)
[20:12:53] [PASSED] 0x9A40 (TIGERLAKE)
[20:12:53] [PASSED] 0x9A49 (TIGERLAKE)
[20:12:53] [PASSED] 0x9A59 (TIGERLAKE)
[20:12:53] [PASSED] 0x9A78 (TIGERLAKE)
[20:12:53] [PASSED] 0x9AC0 (TIGERLAKE)
[20:12:53] [PASSED] 0x9AC9 (TIGERLAKE)
[20:12:53] [PASSED] 0x9AD9 (TIGERLAKE)
[20:12:53] [PASSED] 0x9AF8 (TIGERLAKE)
[20:12:53] [PASSED] 0x4C80 (ROCKETLAKE)
[20:12:53] [PASSED] 0x4C8A (ROCKETLAKE)
[20:12:53] [PASSED] 0x4C8B (ROCKETLAKE)
[20:12:53] [PASSED] 0x4C8C (ROCKETLAKE)
[20:12:53] [PASSED] 0x4C90 (ROCKETLAKE)
[20:12:53] [PASSED] 0x4C9A (ROCKETLAKE)
[20:12:53] [PASSED] 0x4680 (ALDERLAKE_S)
[20:12:53] [PASSED] 0x4682 (ALDERLAKE_S)
[20:12:53] [PASSED] 0x4688 (ALDERLAKE_S)
[20:12:53] [PASSED] 0x468A (ALDERLAKE_S)
[20:12:53] [PASSED] 0x468B (ALDERLAKE_S)
[20:12:53] [PASSED] 0x4690 (ALDERLAKE_S)
[20:12:53] [PASSED] 0x4692 (ALDERLAKE_S)
[20:12:53] [PASSED] 0x4693 (ALDERLAKE_S)
[20:12:53] [PASSED] 0x46A0 (ALDERLAKE_P)
[20:12:53] [PASSED] 0x46A1 (ALDERLAKE_P)
[20:12:53] [PASSED] 0x46A2 (ALDERLAKE_P)
[20:12:53] [PASSED] 0x46A3 (ALDERLAKE_P)
[20:12:53] [PASSED] 0x46A6 (ALDERLAKE_P)
[20:12:53] [PASSED] 0x46A8 (ALDERLAKE_P)
[20:12:53] [PASSED] 0x46AA (ALDERLAKE_P)
[20:12:53] [PASSED] 0x462A (ALDERLAKE_P)
[20:12:53] [PASSED] 0x4626 (ALDERLAKE_P)
[20:12:53] [PASSED] 0x4628 (ALDERLAKE_P)
[20:12:53] [PASSED] 0x46B0 (ALDERLAKE_P)
[20:12:53] [PASSED] 0x46B1 (ALDERLAKE_P)
[20:12:53] [PASSED] 0x46B2 (ALDERLAKE_P)
[20:12:53] [PASSED] 0x46B3 (ALDERLAKE_P)
[20:12:53] [PASSED] 0x46C0 (ALDERLAKE_P)
[20:12:53] [PASSED] 0x46C1 (ALDERLAKE_P)
[20:12:53] [PASSED] 0x46C2 (ALDERLAKE_P)
[20:12:53] [PASSED] 0x46C3 (ALDERLAKE_P)
[20:12:53] [PASSED] 0x46D0 (ALDERLAKE_N)
[20:12:53] [PASSED] 0x46D1 (ALDERLAKE_N)
[20:12:53] [PASSED] 0x46D2 (ALDERLAKE_N)
[20:12:53] [PASSED] 0x46D3 (ALDERLAKE_N)
[20:12:53] [PASSED] 0x46D4 (ALDERLAKE_N)
[20:12:53] [PASSED] 0xA721 (ALDERLAKE_P)
[20:12:53] [PASSED] 0xA7A1 (ALDERLAKE_P)
[20:12:53] [PASSED] 0xA7A9 (ALDERLAKE_P)
[20:12:53] [PASSED] 0xA7AC (ALDERLAKE_P)
[20:12:53] [PASSED] 0xA7AD (ALDERLAKE_P)
[20:12:53] [PASSED] 0xA720 (ALDERLAKE_P)
[20:12:53] [PASSED] 0xA7A0 (ALDERLAKE_P)
[20:12:53] [PASSED] 0xA7A8 (ALDERLAKE_P)
[20:12:53] [PASSED] 0xA7AA (ALDERLAKE_P)
[20:12:53] [PASSED] 0xA7AB (ALDERLAKE_P)
[20:12:53] [PASSED] 0xA780 (ALDERLAKE_S)
[20:12:53] [PASSED] 0xA781 (ALDERLAKE_S)
[20:12:53] [PASSED] 0xA782 (ALDERLAKE_S)
[20:12:53] [PASSED] 0xA783 (ALDERLAKE_S)
[20:12:53] [PASSED] 0xA788 (ALDERLAKE_S)
[20:12:53] [PASSED] 0xA789 (ALDERLAKE_S)
[20:12:53] [PASSED] 0xA78A (ALDERLAKE_S)
[20:12:53] [PASSED] 0xA78B (ALDERLAKE_S)
[20:12:53] [PASSED] 0x4905 (DG1)
[20:12:53] [PASSED] 0x4906 (DG1)
[20:12:53] [PASSED] 0x4907 (DG1)
[20:12:53] [PASSED] 0x4908 (DG1)
[20:12:53] [PASSED] 0x4909 (DG1)
[20:12:53] [PASSED] 0x56C0 (DG2)
[20:12:53] [PASSED] 0x56C2 (DG2)
[20:12:53] [PASSED] 0x56C1 (DG2)
[20:12:53] [PASSED] 0x7D51 (METEORLAKE)
[20:12:53] [PASSED] 0x7DD1 (METEORLAKE)
[20:12:53] [PASSED] 0x7D41 (METEORLAKE)
[20:12:53] [PASSED] 0x7D67 (METEORLAKE)
[20:12:53] [PASSED] 0xB640 (METEORLAKE)
[20:12:53] [PASSED] 0x56A0 (DG2)
[20:12:53] [PASSED] 0x56A1 (DG2)
[20:12:53] [PASSED] 0x56A2 (DG2)
[20:12:53] [PASSED] 0x56BE (DG2)
[20:12:53] [PASSED] 0x56BF (DG2)
[20:12:53] [PASSED] 0x5690 (DG2)
[20:12:53] [PASSED] 0x5691 (DG2)
[20:12:53] [PASSED] 0x5692 (DG2)
[20:12:53] [PASSED] 0x56A5 (DG2)
[20:12:53] [PASSED] 0x56A6 (DG2)
[20:12:53] [PASSED] 0x56B0 (DG2)
[20:12:53] [PASSED] 0x56B1 (DG2)
[20:12:53] [PASSED] 0x56BA (DG2)
[20:12:53] [PASSED] 0x56BB (DG2)
[20:12:53] [PASSED] 0x56BC (DG2)
[20:12:53] [PASSED] 0x56BD (DG2)
[20:12:53] [PASSED] 0x5693 (DG2)
[20:12:53] [PASSED] 0x5694 (DG2)
[20:12:53] [PASSED] 0x5695 (DG2)
[20:12:53] [PASSED] 0x56A3 (DG2)
[20:12:53] [PASSED] 0x56A4 (DG2)
[20:12:53] [PASSED] 0x56B2 (DG2)
[20:12:53] [PASSED] 0x56B3 (DG2)
[20:12:53] [PASSED] 0x5696 (DG2)
[20:12:53] [PASSED] 0x5697 (DG2)
[20:12:53] [PASSED] 0xB69 (PVC)
[20:12:53] [PASSED] 0xB6E (PVC)
[20:12:53] [PASSED] 0xBD4 (PVC)
[20:12:53] [PASSED] 0xBD5 (PVC)
[20:12:53] [PASSED] 0xBD6 (PVC)
[20:12:53] [PASSED] 0xBD7 (PVC)
[20:12:53] [PASSED] 0xBD8 (PVC)
[20:12:53] [PASSED] 0xBD9 (PVC)
[20:12:53] [PASSED] 0xBDA (PVC)
[20:12:53] [PASSED] 0xBDB (PVC)
[20:12:53] [PASSED] 0xBE0 (PVC)
[20:12:53] [PASSED] 0xBE1 (PVC)
[20:12:53] [PASSED] 0xBE5 (PVC)
[20:12:53] [PASSED] 0x7D40 (METEORLAKE)
[20:12:53] [PASSED] 0x7D45 (METEORLAKE)
[20:12:53] [PASSED] 0x7D55 (METEORLAKE)
[20:12:53] [PASSED] 0x7D60 (METEORLAKE)
[20:12:53] [PASSED] 0x7DD5 (METEORLAKE)
[20:12:53] [PASSED] 0x6420 (LUNARLAKE)
[20:12:53] [PASSED] 0x64A0 (LUNARLAKE)
[20:12:53] [PASSED] 0x64B0 (LUNARLAKE)
[20:12:53] [PASSED] 0xE202 (BATTLEMAGE)
[20:12:53] [PASSED] 0xE209 (BATTLEMAGE)
[20:12:53] [PASSED] 0xE20B (BATTLEMAGE)
[20:12:53] [PASSED] 0xE20C (BATTLEMAGE)
[20:12:53] [PASSED] 0xE20D (BATTLEMAGE)
[20:12:53] [PASSED] 0xE210 (BATTLEMAGE)
[20:12:53] [PASSED] 0xE211 (BATTLEMAGE)
[20:12:53] [PASSED] 0xE212 (BATTLEMAGE)
[20:12:53] [PASSED] 0xE216 (BATTLEMAGE)
[20:12:53] [PASSED] 0xE220 (BATTLEMAGE)
[20:12:53] [PASSED] 0xE221 (BATTLEMAGE)
[20:12:53] [PASSED] 0xE222 (BATTLEMAGE)
[20:12:53] [PASSED] 0xE223 (BATTLEMAGE)
[20:12:53] [PASSED] 0xB080 (PANTHERLAKE)
[20:12:53] [PASSED] 0xB081 (PANTHERLAKE)
[20:12:53] [PASSED] 0xB082 (PANTHERLAKE)
[20:12:53] [PASSED] 0xB083 (PANTHERLAKE)
[20:12:53] [PASSED] 0xB084 (PANTHERLAKE)
[20:12:53] [PASSED] 0xB085 (PANTHERLAKE)
[20:12:53] [PASSED] 0xB086 (PANTHERLAKE)
[20:12:53] [PASSED] 0xB087 (PANTHERLAKE)
[20:12:53] [PASSED] 0xB08F (PANTHERLAKE)
[20:12:53] [PASSED] 0xB090 (PANTHERLAKE)
[20:12:53] [PASSED] 0xB0A0 (PANTHERLAKE)
[20:12:53] [PASSED] 0xB0A1 (PANTHERLAKE)
[20:12:53] [PASSED] 0xB0B0 (PANTHERLAKE)
[20:12:53] [PASSED] 0xFD80 (PANTHERLAKE)
[20:12:53] [PASSED] 0xFD81 (PANTHERLAKE)
[20:12:53] [PASSED] 0xD740 (NOVALAKE_S)
[20:12:53] [PASSED] 0xD741 (NOVALAKE_S)
[20:12:53] [PASSED] 0xD742 (NOVALAKE_S)
[20:12:53] [PASSED] 0xD743 (NOVALAKE_S)
[20:12:53] [PASSED] 0xD745 (NOVALAKE_S)
[20:12:53] [PASSED] 0xD74A (NOVALAKE_S)
[20:12:53] [PASSED] 0xD74B (NOVALAKE_S)
[20:12:53] [PASSED] 0x674C (CRESCENTISLAND)
[20:12:53] [PASSED] 0x674D (CRESCENTISLAND)
[20:12:53] [PASSED] 0x674E (CRESCENTISLAND)
[20:12:53] [PASSED] 0x674F (CRESCENTISLAND)
[20:12:53] [PASSED] 0x6750 (CRESCENTISLAND)
[20:12:53] [PASSED] 0x6751 (CRESCENTISLAND)
[20:12:53] [PASSED] 0x6752 (CRESCENTISLAND)
[20:12:53] [PASSED] 0x6753 (CRESCENTISLAND)
[20:12:53] [PASSED] 0x6754 (CRESCENTISLAND)
[20:12:53] [PASSED] 0x6755 (CRESCENTISLAND)
[20:12:53] [PASSED] 0x6756 (CRESCENTISLAND)
[20:12:53] [PASSED] 0xD750 (NOVALAKE_P)
[20:12:53] [PASSED] 0xD751 (NOVALAKE_P)
[20:12:53] [PASSED] 0xD752 (NOVALAKE_P)
[20:12:53] [PASSED] 0xD753 (NOVALAKE_P)
[20:12:53] [PASSED] 0xD754 (NOVALAKE_P)
[20:12:53] [PASSED] 0xD755 (NOVALAKE_P)
[20:12:53] [PASSED] 0xD756 (NOVALAKE_P)
[20:12:53] [PASSED] 0xD757 (NOVALAKE_P)
[20:12:53] [PASSED] 0xD75F (NOVALAKE_P)
[20:12:53] =============== [PASSED] check_platform_desc ===============
[20:12:53] ===================== [PASSED] xe_pci ======================
[20:12:53] ============= xe_rtp_tables_test (5 subtests) ==============
[20:12:53] ================== xe_rtp_table_gt_test  ===================
[20:12:53] [PASSED] gt_was/14011060649
[20:12:53] [PASSED] gt_was/14011059788
[20:12:53] [PASSED] gt_was/14015795083
[20:12:53] [PASSED] gt_was/16021867713
[20:12:53] [PASSED] gt_was/14019449301
[20:12:53] [PASSED] gt_was/16028005424
[20:12:53] [PASSED] gt_was/14026578760
[20:12:53] [PASSED] gt_was/1409420604
[20:12:53] [PASSED] gt_was/1408615072
[20:12:53] [PASSED] gt_was/22010523718
[20:12:53] [PASSED] gt_was/14011006942
[20:12:53] [PASSED] gt_was/14014830051
[20:12:53] [PASSED] gt_was/18018781329
[20:12:53] [PASSED] gt_was/1509235366
[20:12:53] [PASSED] gt_was/18018781329
[20:12:53] [PASSED] gt_was/16016694945
[20:12:53] [PASSED] gt_was/14018575942
[20:12:53] [PASSED] gt_was/22016670082
[20:12:53] [PASSED] gt_was/22016670082
[20:12:53] [PASSED] gt_was/14017421178
[20:12:53] [PASSED] gt_was/16025250150
[20:12:53] [PASSED] gt_was/14021871409
[20:12:53] [PASSED] gt_was/16021865536
[20:12:53] [PASSED] gt_was/14021486841
[20:12:53] [PASSED] gt_was/14025160223
[20:12:53] [PASSED] gt_was/14026144927, 16029437861, 14026127056
[20:12:53] [PASSED] gt_was/14025635424
[20:12:53] [PASSED] gt_was/16028005424
[20:12:53] ============== [PASSED] xe_rtp_table_gt_test ===============
[20:12:53] ================== xe_rtp_table_gt_test  ===================
[20:12:53] [PASSED] gt_tunings/Tuning: Blend Fill Caching Optimization Disable
[20:12:53] [PASSED] gt_tunings/Tuning: 32B Access Enable
[20:12:53] [PASSED] gt_tunings/Tuning: L3 cache
[20:12:53] [PASSED] gt_tunings/Tuning: L3 cache - media
[20:12:53] [PASSED] gt_tunings/Tuning: Compression Overfetch
[20:12:53] [PASSED] gt_tunings/Tuning: Compression Overfetch - media
[20:12:53] [PASSED] gt_tunings/Tuning: Enable compressible partial write overfetch in L3
[20:12:53] [PASSED] gt_tunings/Tuning: Enable compressible partial write overfetch in L3 - media
[20:12:53] [PASSED] gt_tunings/Tuning: L2 Overfetch Compressible Only
[20:12:53] [PASSED] gt_tunings/Tuning: L2 Overfetch Compressible Only - media
[20:12:53] [PASSED] gt_tunings/Tuning: Stateless compression control
[20:12:53] [PASSED] gt_tunings/Tuning: Stateless compression control - media
[20:12:53] [PASSED] gt_tunings/Tuning: L3 RW flush all Cache
[20:12:53] [PASSED] gt_tunings/Tuning: L3 RW flush all cache - media
[20:12:53] [PASSED] gt_tunings/Tuning: Set STLB Bank Hash Mode to 4KB
[20:12:53] [PASSED] gt_tunings/Tuning: Force All Non-Compressible Memory Reads to be 256B Overfetches
[20:12:53] ============== [PASSED] xe_rtp_table_gt_test ===============
[20:12:53] ================== xe_rtp_table_oob_test  ==================
[20:12:53] [PASSED] oob_was/1607983814
[20:12:53] [PASSED] oob_was/16010904313
[20:12:53] [PASSED] oob_was/18022495364
[20:12:53] [PASSED] oob_was/22012773006
[20:12:53] [PASSED] oob_was/14014475959
[20:12:53] [PASSED] oob_was/22011391025
[20:12:53] [PASSED] oob_was/22012727170
[20:12:53] [PASSED] oob_was/22012727685
[20:12:53] [PASSED] oob_was/22016596838
[20:12:53] [PASSED] oob_was/18020744125
[20:12:53] [PASSED] oob_was/1409600907
[20:12:53] [PASSED] oob_was/22014953428
[20:12:53] [PASSED] oob_was/16017236439
[20:12:53] [PASSED] oob_was/14019821291
[20:12:53] [PASSED] oob_was/14015076503
[20:12:53] [PASSED] oob_was/22016122933
[20:12:53] [PASSED] oob_was/14018913170
[20:12:53] [PASSED] oob_was/14018094691
[20:12:53] [PASSED] oob_was/18024947630
[20:12:53] [PASSED] oob_was/16022287689
[20:12:53] [PASSED] oob_was/13011645652
[20:12:53] [PASSED] oob_was/14022293748
[20:12:53] [PASSED] oob_was/22019794406
[20:12:53] [PASSED] oob_was/22019338487
[20:12:53] [PASSED] oob_was/16023588340
[20:12:53] [PASSED] oob_was/14019789679
[20:12:53] [PASSED] oob_was/14022866841
[20:12:53] [PASSED] oob_was/16021333562
[20:12:53] [PASSED] oob_was/14016712196
[20:12:53] [PASSED] oob_was/14015568240
[20:12:53] [PASSED] oob_was/18013179988
[20:12:53] [PASSED] oob_was/1508761755
[20:12:53] [PASSED] oob_was/16023105232
[20:12:53] [PASSED] oob_was/16026508708
[20:12:53] [PASSED] oob_was/14020001231
[20:12:53] [PASSED] oob_was/16023683509
[20:12:53] [PASSED] oob_was/14025515070
[20:12:53] [PASSED] oob_was/15015404425_disable
[20:12:53] [PASSED] oob_was/16026007364
[20:12:53] [PASSED] oob_was/14020316580
[20:12:53] [PASSED] oob_was/14025883347
[20:12:53] [PASSED] oob_was/16029380221
[20:12:53] [PASSED] oob_was/22022079272
[20:12:53] [PASSED] oob_was/16029897822
[20:12:53] [PASSED] oob_was/14026539277
[20:12:53] [PASSED] oob_was/14027054324
[20:12:53] [PASSED] oob_was/14025941587
[20:12:53] [PASSED] oob_was/16030224309
[20:12:53] [PASSED] oob_was/14028709524
[20:12:53] [PASSED] oob_was/14028250015
[20:12:53] [PASSED] oob_was/16031259911
[20:12:53] ============== [PASSED] xe_rtp_table_oob_test ==============
[20:12:53] ================ xe_rtp_table_dev_oob_test  ================
[20:12:53] [PASSED] device_oob_was/22010954014
[20:12:53] [PASSED] device_oob_was/15015404425
[20:12:53] [PASSED] device_oob_was/22019338487_display
[20:12:53] [PASSED] device_oob_was/14022085890
[20:12:53] [PASSED] device_oob_was/14026633728
[20:12:53] [PASSED] device_oob_was/14026746987
[20:12:53] [PASSED] device_oob_was/14026779378
[20:12:53] [PASSED] device_oob_was/14028586678
[20:12:53] [PASSED] device_oob_was/14028434957
[20:12:53] ============ [PASSED] xe_rtp_table_dev_oob_test ============
[20:12:53] ========== xe_rtp_table_missing_upper_bound_test  ==========
[20:12:53] [PASSED] register_whitelist/WaAllowPMDepthAndInvocationCountAccessFromUMD, 1408556865
[20:12:53] [PASSED] register_whitelist/1508744258, 14012131227, 1808121037
[20:12:53] [PASSED] register_whitelist/1806527549
[20:12:53] [PASSED] register_whitelist/allow_read_ctx_timestamp
[20:12:53] [PASSED] register_whitelist/allow_read_queue_timestamp
[20:12:53] [PASSED] register_whitelist/16014440446
[20:12:53] [PASSED] register_whitelist/16017236439
[20:12:53] [PASSED] register_whitelist/16020183090
[20:12:53] [PASSED] register_whitelist/14024997852
[20:12:53] [PASSED] register_whitelist/14024997852
[20:12:53] ====== [PASSED] xe_rtp_table_missing_upper_bound_test ======
[20:12:53] =============== [PASSED] xe_rtp_tables_test ================
[20:12:53] =================== xe_rtp (3 subtests) ====================
[20:12:53] =================== xe_rtp_rules_tests  ====================
[20:12:53] [PASSED] no
[20:12:53] [PASSED] yes
[20:12:53] [PASSED] no-and-no
[20:12:53] [PASSED] no-and-yes
[20:12:53] [PASSED] yes-and-no
[20:12:53] [PASSED] yes-and-yes
[20:12:53] [PASSED] no-or-no
[20:12:53] [PASSED] no-or-yes
[20:12:53] [PASSED] yes-or-no
[20:12:53] [PASSED] yes-or-yes
[20:12:53] [PASSED] no-yes-or-yes-no
[20:12:53] [PASSED] no-yes-or-yes-yes
[20:12:53] [PASSED] yes-yes-or-no-yes
[20:12:53] [PASSED] yes-yes-or-yes-yes
[20:12:53] [PASSED] no-no-or-yes-or-no
[20:12:53] [PASSED] or
[20:12:53] [PASSED] or-yes
[20:12:53] [PASSED] or-no
[20:12:53] [PASSED] yes-or
[20:12:53] [PASSED] no-or
[20:12:53] [PASSED] no-or-or-yes
[20:12:53] [PASSED] yes-or-or-no
[20:12:53] [PASSED] no-or-or-no
[20:12:53] [PASSED] missing-context-engine-class
[20:12:53] [PASSED] missing-context-engine-class-or-yes
[20:12:53] [PASSED] missing-context-engine-class-or-or-yes
[20:12:53] =============== [PASSED] xe_rtp_rules_tests ================
[20:12:53] =============== xe_rtp_process_to_sr_tests  ================
[20:12:53] [PASSED] coalesce-same-reg
[20:12:53] [PASSED] coalesce-same-reg-literal-and-func
[20:12:53] [PASSED] no-match-no-add
[20:12:53] [PASSED] two-regs-two-entries
[20:12:53] [PASSED] clr-one-set-other
[20:12:53] [PASSED] set-field
[20:12:53] [PASSED] conflict-duplicate
[20:12:53] [PASSED] conflict-not-disjoint
[20:12:53] [PASSED] conflict-not-disjoint-literal-and-func
[20:12:53] [PASSED] conflict-reg-type
[20:12:53] [PASSED] bad-mcr-reg-forced-to-regular
[20:12:53] [PASSED] bad-regular-reg-forced-to-mcr
[20:12:53] =========== [PASSED] xe_rtp_process_to_sr_tests ============
[20:12:53] ================== xe_rtp_process_tests  ===================
[20:12:53] [PASSED] active1
[20:12:53] [PASSED] active2
[20:12:53] [PASSED] active-inactive
[20:12:53] [PASSED] inactive-active
[20:12:53] [PASSED] inactive-active-inactive
[20:12:53] [PASSED] inactive-inactive-inactive
[20:12:53] ============== [PASSED] xe_rtp_process_tests ===============
[20:12:53] ===================== [PASSED] xe_rtp ======================
[20:12:53] ==================== xe_wa (1 subtest) =====================
[20:12:53] ======================== xe_wa_gt  =========================
[20:12:53] [PASSED] TIGERLAKE B0
[20:12:53] [PASSED] DG1 A0
[20:12:53] [PASSED] DG1 B0
[20:12:53] [PASSED] ALDERLAKE_S A0
[20:12:53] [PASSED] ALDERLAKE_S B0
[20:12:53] [PASSED] ALDERLAKE_S C0
[20:12:53] [PASSED] ALDERLAKE_S D0
[20:12:53] [PASSED] ALDERLAKE_P A0
[20:12:53] [PASSED] ALDERLAKE_P B0
[20:12:53] [PASSED] ALDERLAKE_P C0
[20:12:53] [PASSED] ALDERLAKE_S RPLS D0
[20:12:53] [PASSED] ALDERLAKE_P RPLU E0
[20:12:53] [PASSED] DG2 G10 C0
[20:12:53] [PASSED] DG2 G11 B1
[20:12:53] [PASSED] DG2 G12 A1
[20:12:53] [PASSED] METEORLAKE 12.70(Xe_LPG) A0 13.00(Xe_LPM+) A0
[20:12:53] [PASSED] METEORLAKE 12.71(Xe_LPG) A0 13.00(Xe_LPM+) A0
[20:12:53] [PASSED] METEORLAKE 12.74(Xe_LPG+) A0 13.00(Xe_LPM+) A0
[20:12:53] [PASSED] LUNARLAKE 20.04(Xe2_LPG) A0 20.00(Xe2_LPM) A0
[20:12:53] [PASSED] LUNARLAKE 20.04(Xe2_LPG) B0 20.00(Xe2_LPM) A0
[20:12:53] [PASSED] BATTLEMAGE 20.01(Xe2_HPG) A0 13.01(Xe2_HPM) A1
[20:12:53] [PASSED] PANTHERLAKE 30.00(Xe3_LPG) A0 30.00(Xe3_LPM) A0
[20:12:53] ==================== [PASSED] xe_wa_gt =====================
[20:12:53] ====================== [PASSED] xe_wa ======================
[20:12:53] ============================================================
[20:12:53] Testing complete. Ran 860 tests: passed: 831, skipped: 29
[20:12:53] Elapsed time: 41.924s total, 2.533s configuring, 38.624s building, 0.735s running

+ for kcfg in "${kunitconfigs[@]}"
+ [[ ! -f /kernel/drivers/gpu/drm/tests/.kunitconfig ]]
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/tests/.kunitconfig
[20:12:53] Configuring KUnit Kernel ...
Regenerating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
[20:12:56] Building KUnit Kernel ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
Building with:
$ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48
[20:13:22] Starting KUnit Kernel (1/1)...
[20:13:22] ============================================================
Running tests with:
$ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt
[20:13:22] ============ drm_test_pick_cmdline (2 subtests) ============
[20:13:22] [PASSED] drm_test_pick_cmdline_res_1920_1080_60
[20:13:22] =============== drm_test_pick_cmdline_named  ===============
[20:13:22] [PASSED] NTSC
[20:13:22] [PASSED] NTSC-J
[20:13:22] [PASSED] PAL
[20:13:22] [PASSED] PAL-M
[20:13:22] =========== [PASSED] drm_test_pick_cmdline_named ===========
[20:13:22] ============== [PASSED] drm_test_pick_cmdline ==============
[20:13:22] == drm_test_atomic_get_connector_for_encoder (1 subtest) ===
[20:13:22] [PASSED] drm_test_drm_atomic_get_connector_for_encoder
[20:13:22] ==== [PASSED] drm_test_atomic_get_connector_for_encoder ====
[20:13:22] =========== drm_validate_clone_mode (2 subtests) ===========
[20:13:22] ============== drm_test_check_in_clone_mode  ===============
[20:13:22] [PASSED] in_clone_mode
[20:13:22] [PASSED] not_in_clone_mode
[20:13:22] ========== [PASSED] drm_test_check_in_clone_mode ===========
[20:13:22] =============== drm_test_check_valid_clones  ===============
[20:13:22] [PASSED] not_in_clone_mode
[20:13:22] [PASSED] valid_clone
[20:13:22] [PASSED] invalid_clone
[20:13:22] =========== [PASSED] drm_test_check_valid_clones ===========
[20:13:22] ============= [PASSED] drm_validate_clone_mode =============
[20:13:22] ============= drm_validate_modeset (1 subtest) =============
[20:13:22] [PASSED] drm_test_check_connector_changed_modeset
[20:13:22] ============== [PASSED] drm_validate_modeset ===============
[20:13:22] ====== drm_test_bridge_get_current_state (1 subtest) =======
[20:13:22] [PASSED] drm_test_drm_bridge_get_current_state_atomic
[20:13:22] ======== [PASSED] drm_test_bridge_get_current_state ========
[20:13:22] ====== drm_test_bridge_helper_reset_crtc (3 subtests) ======
[20:13:22] [PASSED] drm_test_drm_bridge_helper_reset_crtc_atomic
[20:13:22] [PASSED] drm_test_drm_bridge_helper_reset_crtc_atomic_disabled
[20:13:22] [PASSED] drm_test_drm_bridge_helper_hdmi_output_bus_fmts
[20:13:22] ======== [PASSED] drm_test_bridge_helper_reset_crtc ========
[20:13:22] ============== drm_bridge_alloc (2 subtests) ===============
[20:13:22] [PASSED] drm_test_drm_bridge_alloc_basic
[20:13:22] [PASSED] drm_test_drm_bridge_alloc_get_put
[20:13:22] ================ [PASSED] drm_bridge_alloc =================
[20:13:22] ============= drm_bridge_bus_fmt (5 subtests) ==============
[20:13:22] [PASSED] drm_test_bridge_rgb_yuv_rgb
[20:13:22] [PASSED] drm_test_bridge_must_convert_to_yuv444
[20:13:22] [PASSED] drm_test_bridge_hdmi_auto_rgb
[20:13:22] [PASSED] drm_test_bridge_auto_first
[20:13:22] [PASSED] drm_test_bridge_rgb_yuv_no_path
[20:13:22] =============== [PASSED] drm_bridge_bus_fmt ================
[20:13:22] ============= drm_cmdline_parser (40 subtests) =============
[20:13:22] [PASSED] drm_test_cmdline_force_d_only
[20:13:22] [PASSED] drm_test_cmdline_force_D_only_dvi
[20:13:22] [PASSED] drm_test_cmdline_force_D_only_hdmi
[20:13:22] [PASSED] drm_test_cmdline_force_D_only_not_digital
[20:13:22] [PASSED] drm_test_cmdline_force_e_only
[20:13:22] [PASSED] drm_test_cmdline_res
[20:13:22] [PASSED] drm_test_cmdline_res_vesa
[20:13:22] [PASSED] drm_test_cmdline_res_vesa_rblank
[20:13:22] [PASSED] drm_test_cmdline_res_rblank
[20:13:22] [PASSED] drm_test_cmdline_res_bpp
[20:13:22] [PASSED] drm_test_cmdline_res_refresh
[20:13:22] [PASSED] drm_test_cmdline_res_bpp_refresh
[20:13:22] [PASSED] drm_test_cmdline_res_bpp_refresh_interlaced
[20:13:22] [PASSED] drm_test_cmdline_res_bpp_refresh_margins
[20:13:22] [PASSED] drm_test_cmdline_res_bpp_refresh_force_off
[20:13:22] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on
[20:13:22] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on_analog
[20:13:22] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on_digital
[20:13:22] [PASSED] drm_test_cmdline_res_bpp_refresh_interlaced_margins_force_on
[20:13:22] [PASSED] drm_test_cmdline_res_margins_force_on
[20:13:22] [PASSED] drm_test_cmdline_res_vesa_margins
[20:13:22] [PASSED] drm_test_cmdline_name
[20:13:22] [PASSED] drm_test_cmdline_name_bpp
[20:13:22] [PASSED] drm_test_cmdline_name_option
[20:13:22] [PASSED] drm_test_cmdline_name_bpp_option
[20:13:22] [PASSED] drm_test_cmdline_rotate_0
[20:13:22] [PASSED] drm_test_cmdline_rotate_90
[20:13:22] [PASSED] drm_test_cmdline_rotate_180
[20:13:22] [PASSED] drm_test_cmdline_rotate_270
[20:13:22] [PASSED] drm_test_cmdline_hmirror
[20:13:22] [PASSED] drm_test_cmdline_vmirror
[20:13:22] [PASSED] drm_test_cmdline_margin_options
[20:13:22] [PASSED] drm_test_cmdline_multiple_options
[20:13:22] [PASSED] drm_test_cmdline_bpp_extra_and_option
[20:13:22] [PASSED] drm_test_cmdline_extra_and_option
[20:13:22] [PASSED] drm_test_cmdline_freestanding_options
[20:13:22] [PASSED] drm_test_cmdline_freestanding_force_e_and_options
[20:13:22] [PASSED] drm_test_cmdline_panel_orientation
[20:13:22] ================ drm_test_cmdline_invalid  =================
[20:13:22] [PASSED] margin_only
[20:13:22] [PASSED] interlace_only
[20:13:22] [PASSED] res_missing_x
[20:13:22] [PASSED] res_missing_y
[20:13:22] [PASSED] res_bad_y
[20:13:22] [PASSED] res_missing_y_bpp
[20:13:22] [PASSED] res_bad_bpp
[20:13:22] [PASSED] res_bad_refresh
[20:13:22] [PASSED] res_bpp_refresh_force_on_off
[20:13:22] [PASSED] res_invalid_mode
[20:13:22] [PASSED] res_bpp_wrong_place_mode
[20:13:22] [PASSED] name_bpp_refresh
[20:13:22] [PASSED] name_refresh
[20:13:22] [PASSED] name_refresh_wrong_mode
[20:13:22] [PASSED] name_refresh_invalid_mode
[20:13:22] [PASSED] rotate_multiple
[20:13:22] [PASSED] rotate_invalid_val
[20:13:22] [PASSED] rotate_truncated
[20:13:22] [PASSED] invalid_option
[20:13:22] [PASSED] invalid_tv_option
[20:13:22] [PASSED] truncated_tv_option
[20:13:22] ============ [PASSED] drm_test_cmdline_invalid =============
[20:13:22] =============== drm_test_cmdline_tv_options  ===============
[20:13:22] [PASSED] NTSC
[20:13:22] [PASSED] NTSC_443
[20:13:22] [PASSED] NTSC_J
[20:13:22] [PASSED] PAL
[20:13:22] [PASSED] PAL_M
[20:13:22] [PASSED] PAL_N
[20:13:22] [PASSED] SECAM
[20:13:22] [PASSED] MONO_525
[20:13:22] [PASSED] MONO_625
[20:13:22] =========== [PASSED] drm_test_cmdline_tv_options ===========
[20:13:22] =============== [PASSED] drm_cmdline_parser ================
[20:13:22] ========== drmm_connector_hdmi_init (20 subtests) ==========
[20:13:22] [PASSED] drm_test_connector_hdmi_init_valid
[20:13:22] [PASSED] drm_test_connector_hdmi_init_bpc_8
[20:13:22] [PASSED] drm_test_connector_hdmi_init_bpc_10
[20:13:22] [PASSED] drm_test_connector_hdmi_init_bpc_12
[20:13:22] [PASSED] drm_test_connector_hdmi_init_bpc_invalid
[20:13:22] [PASSED] drm_test_connector_hdmi_init_bpc_null
[20:13:22] [PASSED] drm_test_connector_hdmi_init_formats_empty
[20:13:22] [PASSED] drm_test_connector_hdmi_init_formats_no_rgb
[20:13:22] === drm_test_connector_hdmi_init_formats_yuv420_allowed  ===
[20:13:22] [PASSED] supported_formats=0x9 yuv420_allowed=1
[20:13:22] [PASSED] supported_formats=0x9 yuv420_allowed=0
[20:13:22] [PASSED] supported_formats=0x5 yuv420_allowed=1
[20:13:22] [PASSED] supported_formats=0x5 yuv420_allowed=0
[20:13:22] === [PASSED] drm_test_connector_hdmi_init_formats_yuv420_allowed ===
[20:13:22] [PASSED] drm_test_connector_hdmi_init_null_ddc
[20:13:22] [PASSED] drm_test_connector_hdmi_init_null_product
[20:13:22] [PASSED] drm_test_connector_hdmi_init_null_vendor
[20:13:22] [PASSED] drm_test_connector_hdmi_init_product_length_exact
[20:13:22] [PASSED] drm_test_connector_hdmi_init_product_length_too_long
[20:13:22] [PASSED] drm_test_connector_hdmi_init_product_valid
[20:13:22] [PASSED] drm_test_connector_hdmi_init_vendor_length_exact
[20:13:22] [PASSED] drm_test_connector_hdmi_init_vendor_length_too_long
[20:13:22] [PASSED] drm_test_connector_hdmi_init_vendor_valid
[20:13:22] ========= drm_test_connector_hdmi_init_type_valid  =========
[20:13:22] [PASSED] HDMI-A
[20:13:22] [PASSED] HDMI-B
[20:13:22] ===== [PASSED] drm_test_connector_hdmi_init_type_valid =====
[20:13:22] ======== drm_test_connector_hdmi_init_type_invalid  ========
[20:13:22] [PASSED] Unknown
[20:13:22] [PASSED] VGA
[20:13:22] [PASSED] DVI-I
[20:13:22] [PASSED] DVI-D
[20:13:22] [PASSED] DVI-A
[20:13:22] [PASSED] Composite
[20:13:22] [PASSED] SVIDEO
[20:13:22] [PASSED] LVDS
[20:13:22] [PASSED] Component
[20:13:22] [PASSED] DIN
[20:13:22] [PASSED] DP
[20:13:22] [PASSED] TV
[20:13:22] [PASSED] eDP
[20:13:22] [PASSED] Virtual
[20:13:22] [PASSED] DSI
[20:13:22] [PASSED] DPI
[20:13:22] [PASSED] Writeback
[20:13:22] [PASSED] SPI
[20:13:22] [PASSED] USB
[20:13:22] ==== [PASSED] drm_test_connector_hdmi_init_type_invalid ====
[20:13:22] ============ [PASSED] drmm_connector_hdmi_init =============
[20:13:22] ============= drmm_connector_init (3 subtests) =============
[20:13:22] [PASSED] drm_test_drmm_connector_init
[20:13:22] [PASSED] drm_test_drmm_connector_init_null_ddc
[20:13:22] ========= drm_test_drmm_connector_init_type_valid  =========
[20:13:22] [PASSED] Unknown
[20:13:22] [PASSED] VGA
[20:13:22] [PASSED] DVI-I
[20:13:22] [PASSED] DVI-D
[20:13:22] [PASSED] DVI-A
[20:13:22] [PASSED] Composite
[20:13:22] [PASSED] SVIDEO
[20:13:22] [PASSED] LVDS
[20:13:22] [PASSED] Component
[20:13:22] [PASSED] DIN
[20:13:22] [PASSED] DP
[20:13:22] [PASSED] HDMI-A
[20:13:22] [PASSED] HDMI-B
[20:13:22] [PASSED] TV
[20:13:22] [PASSED] eDP
[20:13:22] [PASSED] Virtual
[20:13:22] [PASSED] DSI
[20:13:22] [PASSED] DPI
[20:13:22] [PASSED] Writeback
[20:13:22] [PASSED] SPI
[20:13:22] [PASSED] USB
[20:13:22] ===== [PASSED] drm_test_drmm_connector_init_type_valid =====
[20:13:22] =============== [PASSED] drmm_connector_init ===============
[20:13:22] ========= drm_connector_dynamic_init (6 subtests) ==========
[20:13:22] [PASSED] drm_test_drm_connector_dynamic_init
[20:13:22] [PASSED] drm_test_drm_connector_dynamic_init_null_ddc
[20:13:22] [PASSED] drm_test_drm_connector_dynamic_init_not_added
[20:13:22] [PASSED] drm_test_drm_connector_dynamic_init_properties
[20:13:22] ===== drm_test_drm_connector_dynamic_init_type_valid  ======
[20:13:22] [PASSED] Unknown
[20:13:22] [PASSED] VGA
[20:13:22] [PASSED] DVI-I
[20:13:22] [PASSED] DVI-D
[20:13:22] [PASSED] DVI-A
[20:13:22] [PASSED] Composite
[20:13:22] [PASSED] SVIDEO
[20:13:22] [PASSED] LVDS
[20:13:22] [PASSED] Component
[20:13:22] [PASSED] DIN
[20:13:22] [PASSED] DP
[20:13:22] [PASSED] HDMI-A
[20:13:22] [PASSED] HDMI-B
[20:13:22] [PASSED] TV
[20:13:22] [PASSED] eDP
[20:13:22] [PASSED] Virtual
[20:13:22] [PASSED] DSI
[20:13:22] [PASSED] DPI
[20:13:22] [PASSED] Writeback
[20:13:22] [PASSED] SPI
[20:13:22] [PASSED] USB
[20:13:22] = [PASSED] drm_test_drm_connector_dynamic_init_type_valid ==
[20:13:22] ======== drm_test_drm_connector_dynamic_init_name  =========
[20:13:22] [PASSED] Unknown
[20:13:22] [PASSED] VGA
[20:13:22] [PASSED] DVI-I
[20:13:22] [PASSED] DVI-D
[20:13:22] [PASSED] DVI-A
[20:13:22] [PASSED] Composite
[20:13:22] [PASSED] SVIDEO
[20:13:22] [PASSED] LVDS
[20:13:22] [PASSED] Component
[20:13:22] [PASSED] DIN
[20:13:22] [PASSED] DP
[20:13:22] [PASSED] HDMI-A
[20:13:22] [PASSED] HDMI-B
[20:13:22] [PASSED] TV
[20:13:22] [PASSED] eDP
[20:13:22] [PASSED] Virtual
[20:13:22] [PASSED] DSI
[20:13:22] [PASSED] DPI
[20:13:22] [PASSED] Writeback
[20:13:22] [PASSED] SPI
[20:13:22] [PASSED] USB
[20:13:22] ==== [PASSED] drm_test_drm_connector_dynamic_init_name =====
[20:13:22] =========== [PASSED] drm_connector_dynamic_init ============
[20:13:22] ==== drm_connector_dynamic_register_early (4 subtests) =====
[20:13:22] [PASSED] drm_test_drm_connector_dynamic_register_early_on_list
[20:13:22] [PASSED] drm_test_drm_connector_dynamic_register_early_defer
[20:13:22] [PASSED] drm_test_drm_connector_dynamic_register_early_no_init
[20:13:22] [PASSED] drm_test_drm_connector_dynamic_register_early_no_mode_object
[20:13:22] ====== [PASSED] drm_connector_dynamic_register_early =======
[20:13:22] ======= drm_connector_dynamic_register (7 subtests) ========
[20:13:22] [PASSED] drm_test_drm_connector_dynamic_register_on_list
[20:13:22] [PASSED] drm_test_drm_connector_dynamic_register_no_defer
[20:13:22] [PASSED] drm_test_drm_connector_dynamic_register_no_init
[20:13:22] [PASSED] drm_test_drm_connector_dynamic_register_mode_object
[20:13:22] [PASSED] drm_test_drm_connector_dynamic_register_sysfs
[20:13:22] [PASSED] drm_test_drm_connector_dynamic_register_sysfs_name
[20:13:22] [PASSED] drm_test_drm_connector_dynamic_register_debugfs
[20:13:22] ========= [PASSED] drm_connector_dynamic_register ==========
[20:13:22] = drm_connector_attach_broadcast_rgb_property (2 subtests) =
[20:13:22] [PASSED] drm_test_drm_connector_attach_broadcast_rgb_property
[20:13:22] [PASSED] drm_test_drm_connector_attach_broadcast_rgb_property_hdmi_connector
[20:13:22] === [PASSED] drm_connector_attach_broadcast_rgb_property ===
[20:13:22] ========== drm_get_tv_mode_from_name (2 subtests) ==========
[20:13:22] ========== drm_test_get_tv_mode_from_name_valid  ===========
[20:13:22] [PASSED] NTSC
[20:13:22] [PASSED] NTSC-443
[20:13:22] [PASSED] NTSC-J
[20:13:22] [PASSED] PAL
[20:13:22] [PASSED] PAL-M
[20:13:22] [PASSED] PAL-N
[20:13:22] [PASSED] SECAM
[20:13:22] [PASSED] Mono
[20:13:22] ====== [PASSED] drm_test_get_tv_mode_from_name_valid =======
[20:13:22] [PASSED] drm_test_get_tv_mode_from_name_truncated
[20:13:22] ============ [PASSED] drm_get_tv_mode_from_name ============
[20:13:22] = drm_test_connector_hdmi_compute_mode_clock (12 subtests) =
[20:13:22] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb
[20:13:22] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_10bpc
[20:13:22] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_10bpc_vic_1
[20:13:22] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_12bpc
[20:13:22] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_12bpc_vic_1
[20:13:22] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_double
[20:13:22] = drm_test_connector_hdmi_compute_mode_clock_yuv420_valid  =
[20:13:22] [PASSED] VIC 96
[20:13:22] [PASSED] VIC 97
[20:13:22] [PASSED] VIC 101
[20:13:22] [PASSED] VIC 102
[20:13:22] [PASSED] VIC 106
[20:13:22] [PASSED] VIC 107
[20:13:22] === [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_valid ===
[20:13:22] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_10_bpc
[20:13:22] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_12_bpc
[20:13:22] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_8_bpc
[20:13:22] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_10_bpc
[20:13:22] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_12_bpc
[20:13:22] === [PASSED] drm_test_connector_hdmi_compute_mode_clock ====
[20:13:22] == drm_hdmi_connector_get_broadcast_rgb_name (2 subtests) ==
[20:13:22] === drm_test_drm_hdmi_connector_get_broadcast_rgb_name  ====
[20:13:22] [PASSED] Automatic
[20:13:22] [PASSED] Full
[20:13:22] [PASSED] Limited 16:235
[20:13:22] === [PASSED] drm_test_drm_hdmi_connector_get_broadcast_rgb_name ===
[20:13:22] [PASSED] drm_test_drm_hdmi_connector_get_broadcast_rgb_name_invalid
[20:13:22] ==== [PASSED] drm_hdmi_connector_get_broadcast_rgb_name ====
[20:13:22] == drm_hdmi_connector_get_output_format_name (2 subtests) ==
[20:13:22] === drm_test_drm_hdmi_connector_get_output_format_name  ====
[20:13:22] [PASSED] RGB
[20:13:22] [PASSED] YUV 4:2:0
[20:13:22] [PASSED] YUV 4:2:2
[20:13:22] [PASSED] YUV 4:4:4
[20:13:22] === [PASSED] drm_test_drm_hdmi_connector_get_output_format_name ===
[20:13:22] [PASSED] drm_test_drm_hdmi_connector_get_output_format_name_invalid
[20:13:22] ==== [PASSED] drm_hdmi_connector_get_output_format_name ====
[20:13:22] ============= drm_damage_helper (21 subtests) ==============
[20:13:22] [PASSED] drm_test_damage_iter_no_damage
[20:13:22] [PASSED] drm_test_damage_iter_no_damage_fractional_src
[20:13:22] [PASSED] drm_test_damage_iter_no_damage_src_moved
[20:13:22] [PASSED] drm_test_damage_iter_no_damage_fractional_src_moved
[20:13:22] [PASSED] drm_test_damage_iter_no_damage_not_visible
[20:13:22] [PASSED] drm_test_damage_iter_no_damage_no_crtc
[20:13:22] [PASSED] drm_test_damage_iter_no_damage_no_fb
[20:13:22] [PASSED] drm_test_damage_iter_simple_damage
[20:13:22] [PASSED] drm_test_damage_iter_single_damage
[20:13:22] [PASSED] drm_test_damage_iter_single_damage_intersect_src
[20:13:22] [PASSED] drm_test_damage_iter_single_damage_outside_src
[20:13:22] [PASSED] drm_test_damage_iter_single_damage_fractional_src
[20:13:22] [PASSED] drm_test_damage_iter_single_damage_intersect_fractional_src
[20:13:22] [PASSED] drm_test_damage_iter_single_damage_outside_fractional_src
[20:13:22] [PASSED] drm_test_damage_iter_single_damage_src_moved
[20:13:22] [PASSED] drm_test_damage_iter_single_damage_fractional_src_moved
[20:13:22] [PASSED] drm_test_damage_iter_damage
[20:13:22] [PASSED] drm_test_damage_iter_damage_one_intersect
[20:13:22] [PASSED] drm_test_damage_iter_damage_one_outside
[20:13:22] [PASSED] drm_test_damage_iter_damage_src_moved
[20:13:22] [PASSED] drm_test_damage_iter_damage_not_visible
[20:13:22] ================ [PASSED] drm_damage_helper ================
[20:13:22] ============== drm_dp_mst_helper (3 subtests) ==============
[20:13:22] ============== drm_test_dp_mst_calc_pbn_mode  ==============
[20:13:22] [PASSED] Clock 154000 BPP 30 DSC disabled
[20:13:22] [PASSED] Clock 234000 BPP 30 DSC disabled
[20:13:22] [PASSED] Clock 297000 BPP 24 DSC disabled
[20:13:22] [PASSED] Clock 332880 BPP 24 DSC enabled
[20:13:22] [PASSED] Clock 324540 BPP 24 DSC enabled
[20:13:22] ========== [PASSED] drm_test_dp_mst_calc_pbn_mode ==========
[20:13:22] ============== drm_test_dp_mst_calc_pbn_div  ===============
[20:13:22] [PASSED] Link rate 2000000 lane count 4
[20:13:22] [PASSED] Link rate 2000000 lane count 2
[20:13:22] [PASSED] Link rate 2000000 lane count 1
[20:13:22] [PASSED] Link rate 1350000 lane count 4
[20:13:22] [PASSED] Link rate 1350000 lane count 2
[20:13:22] [PASSED] Link rate 1350000 lane count 1
[20:13:22] [PASSED] Link rate 1000000 lane count 4
[20:13:22] [PASSED] Link rate 1000000 lane count 2
[20:13:22] [PASSED] Link rate 1000000 lane count 1
[20:13:22] [PASSED] Link rate 810000 lane count 4
[20:13:22] [PASSED] Link rate 810000 lane count 2
[20:13:22] [PASSED] Link rate 810000 lane count 1
[20:13:22] [PASSED] Link rate 540000 lane count 4
[20:13:22] [PASSED] Link rate 540000 lane count 2
[20:13:22] [PASSED] Link rate 540000 lane count 1
[20:13:22] [PASSED] Link rate 270000 lane count 4
[20:13:22] [PASSED] Link rate 270000 lane count 2
[20:13:22] [PASSED] Link rate 270000 lane count 1
[20:13:22] [PASSED] Link rate 162000 lane count 4
[20:13:22] [PASSED] Link rate 162000 lane count 2
[20:13:22] [PASSED] Link rate 162000 lane count 1
[20:13:22] ========== [PASSED] drm_test_dp_mst_calc_pbn_div ===========
[20:13:22] ========= drm_test_dp_mst_sideband_msg_req_decode  =========
[20:13:22] [PASSED] DP_ENUM_PATH_RESOURCES with port number
[20:13:22] [PASSED] DP_POWER_UP_PHY with port number
[20:13:22] [PASSED] DP_POWER_DOWN_PHY with port number
[20:13:22] [PASSED] DP_ALLOCATE_PAYLOAD with SDP stream sinks
[20:13:22] [PASSED] DP_ALLOCATE_PAYLOAD with port number
[20:13:22] [PASSED] DP_ALLOCATE_PAYLOAD with VCPI
[20:13:22] [PASSED] DP_ALLOCATE_PAYLOAD with PBN
[20:13:22] [PASSED] DP_QUERY_PAYLOAD with port number
[20:13:22] [PASSED] DP_QUERY_PAYLOAD with VCPI
[20:13:22] [PASSED] DP_REMOTE_DPCD_READ with port number
[20:13:22] [PASSED] DP_REMOTE_DPCD_READ with DPCD address
[20:13:22] [PASSED] DP_REMOTE_DPCD_READ with max number of bytes
[20:13:22] [PASSED] DP_REMOTE_DPCD_WRITE with port number
[20:13:22] [PASSED] DP_REMOTE_DPCD_WRITE with DPCD address
[20:13:22] [PASSED] DP_REMOTE_DPCD_WRITE with data array
[20:13:22] [PASSED] DP_REMOTE_I2C_READ with port number
[20:13:22] [PASSED] DP_REMOTE_I2C_READ with I2C device ID
[20:13:22] [PASSED] DP_REMOTE_I2C_READ with transactions array
[20:13:22] [PASSED] DP_REMOTE_I2C_WRITE with port number
[20:13:22] [PASSED] DP_REMOTE_I2C_WRITE with I2C device ID
[20:13:22] [PASSED] DP_REMOTE_I2C_WRITE with data array
[20:13:22] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream ID
[20:13:22] [PASSED] DP_QUERY_STREAM_ENC_STATUS with client ID
[20:13:22] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream event
[20:13:22] [PASSED] DP_QUERY_STREAM_ENC_STATUS with valid stream event
[20:13:22] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream behavior
[20:13:22] [PASSED] DP_QUERY_STREAM_ENC_STATUS with a valid stream behavior
[20:13:22] ===== [PASSED] drm_test_dp_mst_sideband_msg_req_decode =====
[20:13:22] ================ [PASSED] drm_dp_mst_helper ================
[20:13:22] ================== drm_exec (7 subtests) ===================
[20:13:22] [PASSED] sanitycheck
[20:13:22] [PASSED] test_lock
[20:13:22] [PASSED] test_lock_unlock
[20:13:22] [PASSED] test_duplicates
[20:13:22] [PASSED] test_prepare
[20:13:22] [PASSED] test_prepare_array
[20:13:22] [PASSED] test_multiple_loops
[20:13:22] ==================== [PASSED] drm_exec =====================
[20:13:22] =========== drm_format_helper_test (17 subtests) ===========
[20:13:22] ============== drm_test_fb_xrgb8888_to_gray8  ==============
[20:13:22] [PASSED] single_pixel_source_buffer
[20:13:22] [PASSED] single_pixel_clip_rectangle
[20:13:22] [PASSED] well_known_colors
[20:13:22] [PASSED] destination_pitch
[20:13:22] ========== [PASSED] drm_test_fb_xrgb8888_to_gray8 ==========
[20:13:22] ============= drm_test_fb_xrgb8888_to_rgb332  ==============
[20:13:22] [PASSED] single_pixel_source_buffer
[20:13:22] [PASSED] single_pixel_clip_rectangle
[20:13:22] [PASSED] well_known_colors
[20:13:22] [PASSED] destination_pitch
[20:13:22] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb332 ==========
[20:13:22] ============= drm_test_fb_xrgb8888_to_rgb565  ==============
[20:13:22] [PASSED] single_pixel_source_buffer
[20:13:22] [PASSED] single_pixel_clip_rectangle
[20:13:22] [PASSED] well_known_colors
[20:13:22] [PASSED] destination_pitch
[20:13:22] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb565 ==========
[20:13:22] ============ drm_test_fb_xrgb8888_to_xrgb1555  =============
[20:13:22] [PASSED] single_pixel_source_buffer
[20:13:22] [PASSED] single_pixel_clip_rectangle
[20:13:22] [PASSED] well_known_colors
[20:13:22] [PASSED] destination_pitch
[20:13:22] ======== [PASSED] drm_test_fb_xrgb8888_to_xrgb1555 =========
[20:13:22] ============ drm_test_fb_xrgb8888_to_argb1555  =============
[20:13:22] [PASSED] single_pixel_source_buffer
[20:13:22] [PASSED] single_pixel_clip_rectangle
[20:13:22] [PASSED] well_known_colors
[20:13:22] [PASSED] destination_pitch
[20:13:22] ======== [PASSED] drm_test_fb_xrgb8888_to_argb1555 =========
[20:13:22] ============ drm_test_fb_xrgb8888_to_rgba5551  =============
[20:13:22] [PASSED] single_pixel_source_buffer
[20:13:22] [PASSED] single_pixel_clip_rectangle
[20:13:22] [PASSED] well_known_colors
[20:13:22] [PASSED] destination_pitch
[20:13:22] ======== [PASSED] drm_test_fb_xrgb8888_to_rgba5551 =========
[20:13:22] ============= drm_test_fb_xrgb8888_to_rgb888  ==============
[20:13:22] [PASSED] single_pixel_source_buffer
[20:13:22] [PASSED] single_pixel_clip_rectangle
[20:13:22] [PASSED] well_known_colors
[20:13:22] [PASSED] destination_pitch
[20:13:22] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb888 ==========
[20:13:22] ============= drm_test_fb_xrgb8888_to_bgr888  ==============
[20:13:22] [PASSED] single_pixel_source_buffer
[20:13:22] [PASSED] single_pixel_clip_rectangle
[20:13:22] [PASSED] well_known_colors
[20:13:22] [PASSED] destination_pitch
[20:13:22] ========= [PASSED] drm_test_fb_xrgb8888_to_bgr888 ==========
[20:13:22] ============ drm_test_fb_xrgb8888_to_argb8888  =============
[20:13:22] [PASSED] single_pixel_source_buffer
[20:13:22] [PASSED] single_pixel_clip_rectangle
[20:13:22] [PASSED] well_known_colors
[20:13:22] [PASSED] destination_pitch
[20:13:22] ======== [PASSED] drm_test_fb_xrgb8888_to_argb8888 =========
[20:13:22] =========== drm_test_fb_xrgb8888_to_xrgb2101010  ===========
[20:13:22] [PASSED] single_pixel_source_buffer
[20:13:22] [PASSED] single_pixel_clip_rectangle
[20:13:22] [PASSED] well_known_colors
[20:13:22] [PASSED] destination_pitch
[20:13:22] ======= [PASSED] drm_test_fb_xrgb8888_to_xrgb2101010 =======
[20:13:22] =========== drm_test_fb_xrgb8888_to_argb2101010  ===========
[20:13:22] [PASSED] single_pixel_source_buffer
[20:13:22] [PASSED] single_pixel_clip_rectangle
[20:13:22] [PASSED] well_known_colors
[20:13:22] [PASSED] destination_pitch
[20:13:22] ======= [PASSED] drm_test_fb_xrgb8888_to_argb2101010 =======
[20:13:22] ============== drm_test_fb_xrgb8888_to_mono  ===============
[20:13:22] [PASSED] single_pixel_source_buffer
[20:13:22] [PASSED] single_pixel_clip_rectangle
[20:13:22] [PASSED] well_known_colors
[20:13:22] [PASSED] destination_pitch
[20:13:22] ========== [PASSED] drm_test_fb_xrgb8888_to_mono ===========
[20:13:22] ==================== drm_test_fb_swab  =====================
[20:13:22] [PASSED] single_pixel_source_buffer
[20:13:22] [PASSED] single_pixel_clip_rectangle
[20:13:22] [PASSED] well_known_colors
[20:13:22] [PASSED] destination_pitch
[20:13:22] ================ [PASSED] drm_test_fb_swab =================
[20:13:22] ============ drm_test_fb_xrgb8888_to_xbgr8888  =============
[20:13:22] [PASSED] single_pixel_source_buffer
[20:13:22] [PASSED] single_pixel_clip_rectangle
[20:13:22] [PASSED] well_known_colors
[20:13:22] [PASSED] destination_pitch
[20:13:22] ======== [PASSED] drm_test_fb_xrgb8888_to_xbgr8888 =========
[20:13:22] ============ drm_test_fb_xrgb8888_to_abgr8888  =============
[20:13:22] [PASSED] single_pixel_source_buffer
[20:13:22] [PASSED] single_pixel_clip_rectangle
[20:13:22] [PASSED] well_known_colors
[20:13:22] [PASSED] destination_pitch
[20:13:22] ======== [PASSED] drm_test_fb_xrgb8888_to_abgr8888 =========
[20:13:22] ================= drm_test_fb_clip_offset  =================
[20:13:22] [PASSED] pass through
[20:13:22] [PASSED] horizontal offset
[20:13:22] [PASSED] vertical offset
[20:13:22] [PASSED] horizontal and vertical offset
[20:13:22] [PASSED] horizontal offset (custom pitch)
[20:13:22] [PASSED] vertical offset (custom pitch)
[20:13:22] [PASSED] horizontal and vertical offset (custom pitch)
[20:13:22] ============= [PASSED] drm_test_fb_clip_offset =============
[20:13:22] =================== drm_test_fb_memcpy  ====================
[20:13:22] [PASSED] single_pixel_source_buffer: XR24 little-endian (0x34325258)
[20:13:22] [PASSED] single_pixel_source_buffer: XRA8 little-endian (0x38415258)
[20:13:22] [PASSED] single_pixel_source_buffer: YU24 little-endian (0x34325559)
[20:13:22] [PASSED] single_pixel_clip_rectangle: XB24 little-endian (0x34324258)
[20:13:22] [PASSED] single_pixel_clip_rectangle: XRA8 little-endian (0x38415258)
[20:13:22] [PASSED] single_pixel_clip_rectangle: YU24 little-endian (0x34325559)
[20:13:22] [PASSED] well_known_colors: XB24 little-endian (0x34324258)
[20:13:22] [PASSED] well_known_colors: XRA8 little-endian (0x38415258)
[20:13:22] [PASSED] well_known_colors: YU24 little-endian (0x34325559)
[20:13:22] [PASSED] destination_pitch: XB24 little-endian (0x34324258)
[20:13:22] [PASSED] destination_pitch: XRA8 little-endian (0x38415258)
[20:13:22] [PASSED] destination_pitch: YU24 little-endian (0x34325559)
[20:13:22] =============== [PASSED] drm_test_fb_memcpy ================
[20:13:22] ============= [PASSED] drm_format_helper_test ==============
[20:13:22] ================= drm_format (18 subtests) =================
[20:13:22] [PASSED] drm_test_format_block_width_invalid
[20:13:22] [PASSED] drm_test_format_block_width_one_plane
[20:13:22] [PASSED] drm_test_format_block_width_two_plane
[20:13:22] [PASSED] drm_test_format_block_width_three_plane
[20:13:22] [PASSED] drm_test_format_block_width_tiled
[20:13:22] [PASSED] drm_test_format_block_height_invalid
[20:13:22] [PASSED] drm_test_format_block_height_one_plane
[20:13:22] [PASSED] drm_test_format_block_height_two_plane
[20:13:22] [PASSED] drm_test_format_block_height_three_plane
[20:13:22] [PASSED] drm_test_format_block_height_tiled
[20:13:22] [PASSED] drm_test_format_min_pitch_invalid
[20:13:22] [PASSED] drm_test_format_min_pitch_one_plane_8bpp
[20:13:22] [PASSED] drm_test_format_min_pitch_one_plane_16bpp
[20:13:22] [PASSED] drm_test_format_min_pitch_one_plane_24bpp
[20:13:22] [PASSED] drm_test_format_min_pitch_one_plane_32bpp
[20:13:22] [PASSED] drm_test_format_min_pitch_two_plane
[20:13:22] [PASSED] drm_test_format_min_pitch_three_plane_8bpp
[20:13:22] [PASSED] drm_test_format_min_pitch_tiled
[20:13:22] =================== [PASSED] drm_format ====================
[20:13:22] ============== drm_framebuffer (10 subtests) ===============
[20:13:22] ========== drm_test_framebuffer_check_src_coords  ==========
[20:13:22] [PASSED] Success: source fits into fb
[20:13:22] [PASSED] Fail: overflowing fb with x-axis coordinate
[20:13:22] [PASSED] Fail: overflowing fb with y-axis coordinate
[20:13:22] [PASSED] Fail: overflowing fb with source width
[20:13:22] [PASSED] Fail: overflowing fb with source height
[20:13:22] ====== [PASSED] drm_test_framebuffer_check_src_coords ======
[20:13:22] [PASSED] drm_test_framebuffer_cleanup
[20:13:22] =============== drm_test_framebuffer_create  ===============
[20:13:22] [PASSED] ABGR8888 normal sizes
[20:13:22] [PASSED] ABGR8888 max sizes
[20:13:22] [PASSED] ABGR8888 pitch greater than min required
[20:13:22] [PASSED] ABGR8888 pitch less than min required
[20:13:22] [PASSED] ABGR8888 Invalid width
[20:13:22] [PASSED] ABGR8888 Invalid buffer handle
[20:13:22] [PASSED] No pixel format
[20:13:22] [PASSED] ABGR8888 Width 0
[20:13:22] [PASSED] ABGR8888 Height 0
[20:13:22] [PASSED] ABGR8888 Out of bound height * pitch combination
[20:13:22] [PASSED] ABGR8888 Large buffer offset
[20:13:22] [PASSED] ABGR8888 Buffer offset for inexistent plane
[20:13:22] [PASSED] ABGR8888 Invalid flag
[20:13:22] [PASSED] ABGR8888 Set DRM_MODE_FB_MODIFIERS without modifiers
[20:13:22] [PASSED] ABGR8888 Valid buffer modifier
[20:13:22] [PASSED] ABGR8888 Invalid buffer modifier(DRM_FORMAT_MOD_SAMSUNG_64_32_TILE)
[20:13:22] [PASSED] ABGR8888 Extra pitches without DRM_MODE_FB_MODIFIERS
[20:13:22] [PASSED] ABGR8888 Extra pitches with DRM_MODE_FB_MODIFIERS
[20:13:22] [PASSED] NV12 Normal sizes
[20:13:22] [PASSED] NV12 Max sizes
[20:13:22] [PASSED] NV12 Invalid pitch
[20:13:22] [PASSED] NV12 Invalid modifier/missing DRM_MODE_FB_MODIFIERS flag
[20:13:22] [PASSED] NV12 different  modifier per-plane
[20:13:22] [PASSED] NV12 with DRM_FORMAT_MOD_SAMSUNG_64_32_TILE
[20:13:22] [PASSED] NV12 Valid modifiers without DRM_MODE_FB_MODIFIERS
[20:13:22] [PASSED] NV12 Modifier for inexistent plane
[20:13:22] [PASSED] NV12 Handle for inexistent plane
[20:13:22] [PASSED] NV12 Handle for inexistent plane without DRM_MODE_FB_MODIFIERS
[20:13:22] [PASSED] YVU420 DRM_MODE_FB_MODIFIERS set without modifier
[20:13:22] [PASSED] YVU420 Normal sizes
[20:13:22] [PASSED] YVU420 Max sizes
[20:13:22] [PASSED] YVU420 Invalid pitch
[20:13:22] [PASSED] YVU420 Different pitches
[20:13:22] [PASSED] YVU420 Different buffer offsets/pitches
[20:13:22] [PASSED] YVU420 Modifier set just for plane 0, without DRM_MODE_FB_MODIFIERS
[20:13:22] [PASSED] YVU420 Modifier set just for planes 0, 1, without DRM_MODE_FB_MODIFIERS
[20:13:22] [PASSED] YVU420 Modifier set just for plane 0, 1, with DRM_MODE_FB_MODIFIERS
[20:13:22] [PASSED] YVU420 Valid modifier
[20:13:22] [PASSED] YVU420 Different modifiers per plane
[20:13:22] [PASSED] YVU420 Modifier for inexistent plane
[20:13:22] [PASSED] YUV420_10BIT Invalid modifier(DRM_FORMAT_MOD_LINEAR)
[20:13:22] [PASSED] X0L2 Normal sizes
[20:13:22] [PASSED] X0L2 Max sizes
[20:13:22] [PASSED] X0L2 Invalid pitch
[20:13:22] [PASSED] X0L2 Pitch greater than minimum required
[20:13:22] [PASSED] X0L2 Handle for inexistent plane
[20:13:22] [PASSED] X0L2 Offset for inexistent plane, without DRM_MODE_FB_MODIFIERS set
[20:13:22] [PASSED] X0L2 Modifier without DRM_MODE_FB_MODIFIERS set
[20:13:22] [PASSED] X0L2 Valid modifier
[20:13:22] [PASSED] X0L2 Modifier for inexistent plane
[20:13:22] =========== [PASSED] drm_test_framebuffer_create ===========
[20:13:22] [PASSED] drm_test_framebuffer_free
[20:13:22] [PASSED] drm_test_framebuffer_init
[20:13:22] [PASSED] drm_test_framebuffer_init_bad_format
[20:13:22] [PASSED] drm_test_framebuffer_init_dev_mismatch
[20:13:22] [PASSED] drm_test_framebuffer_lookup
[20:13:22] [PASSED] drm_test_framebuffer_lookup_inexistent
[20:13:22] [PASSED] drm_test_framebuffer_modifiers_not_supported
[20:13:22] ================= [PASSED] drm_framebuffer =================
[20:13:22] ================ drm_gem_shmem (8 subtests) ================
[20:13:22] [PASSED] drm_gem_shmem_test_obj_create
[20:13:22] [PASSED] drm_gem_shmem_test_obj_create_private
[20:13:22] [PASSED] drm_gem_shmem_test_pin_pages
[20:13:22] [PASSED] drm_gem_shmem_test_vmap
[20:13:22] [PASSED] drm_gem_shmem_test_get_sg_table
[20:13:22] [PASSED] drm_gem_shmem_test_get_pages_sgt
[20:13:22] [PASSED] drm_gem_shmem_test_madvise
[20:13:22] [PASSED] drm_gem_shmem_test_purge
[20:13:22] ================== [PASSED] drm_gem_shmem ==================
[20:13:22] === drm_atomic_helper_connector_hdmi_check (29 subtests) ===
[20:13:22] [PASSED] drm_test_check_broadcast_rgb_auto_cea_mode
[20:13:22] [PASSED] drm_test_check_broadcast_rgb_auto_cea_mode_vic_1
[20:13:22] [PASSED] drm_test_check_broadcast_rgb_full_cea_mode
[20:13:22] [PASSED] drm_test_check_broadcast_rgb_full_cea_mode_vic_1
[20:13:22] [PASSED] drm_test_check_broadcast_rgb_limited_cea_mode
[20:13:22] [PASSED] drm_test_check_broadcast_rgb_limited_cea_mode_vic_1
[20:13:22] ====== drm_test_check_broadcast_rgb_cea_mode_yuv420  =======
[20:13:22] [PASSED] Automatic
[20:13:22] [PASSED] Full
[20:13:22] [PASSED] Limited 16:235
[20:13:22] == [PASSED] drm_test_check_broadcast_rgb_cea_mode_yuv420 ===
[20:13:22] [PASSED] drm_test_check_broadcast_rgb_crtc_mode_changed
[20:13:22] [PASSED] drm_test_check_broadcast_rgb_crtc_mode_not_changed
[20:13:22] [PASSED] drm_test_check_disable_connector
[20:13:22] [PASSED] drm_test_check_hdmi_funcs_reject_rate
[20:13:22] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_rgb
[20:13:22] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_yuv420
[20:13:22] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_ignore_yuv422
[20:13:22] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_ignore_yuv420
[20:13:22] [PASSED] drm_test_check_driver_unsupported_fallback_yuv420
[20:13:22] [PASSED] drm_test_check_output_bpc_crtc_mode_changed
[20:13:22] [PASSED] drm_test_check_output_bpc_crtc_mode_not_changed
[20:13:22] [PASSED] drm_test_check_output_bpc_dvi
[20:13:22] [PASSED] drm_test_check_output_bpc_format_vic_1
[20:13:22] [PASSED] drm_test_check_output_bpc_format_display_8bpc_only
[20:13:22] [PASSED] drm_test_check_output_bpc_format_display_rgb_only
[20:13:22] [PASSED] drm_test_check_output_bpc_format_driver_8bpc_only
[20:13:22] [PASSED] drm_test_check_output_bpc_format_driver_rgb_only
[20:13:22] [PASSED] drm_test_check_tmds_char_rate_rgb_8bpc
[20:13:22] [PASSED] drm_test_check_tmds_char_rate_rgb_10bpc
[20:13:22] [PASSED] drm_test_check_tmds_char_rate_rgb_12bpc
[20:13:22] ============ drm_test_check_hdmi_color_format  =============
[20:13:22] [PASSED] AUTO -> RGB
[20:13:22] [PASSED] YCBCR422 -> YUV422
[20:13:22] [PASSED] YCBCR420 -> YUV420
[20:13:22] [PASSED] YCBCR444 -> YUV444
[20:13:22] [PASSED] RGB -> RGB
[20:13:22] ======== [PASSED] drm_test_check_hdmi_color_format =========
[20:13:22] ======== drm_test_check_hdmi_color_format_420_only  ========
[20:13:22] [PASSED] RGB should fail
[20:13:22] [PASSED] YUV444 should fail
[20:13:22] [PASSED] YUV422 should fail
[20:13:22] [PASSED] YUV420 should work
[20:13:22] ==== [PASSED] drm_test_check_hdmi_color_format_420_only ====
[20:13:22] ===== [PASSED] drm_atomic_helper_connector_hdmi_check ======
[20:13:22] === drm_atomic_helper_connector_hdmi_reset (6 subtests) ====
[20:13:22] [PASSED] drm_test_check_broadcast_rgb_value
[20:13:22] [PASSED] drm_test_check_bpc_8_value
[20:13:22] [PASSED] drm_test_check_bpc_10_value
[20:13:22] [PASSED] drm_test_check_bpc_12_value
[20:13:22] [PASSED] drm_test_check_format_value
[20:13:22] [PASSED] drm_test_check_tmds_char_value
[20:13:22] ===== [PASSED] drm_atomic_helper_connector_hdmi_reset ======
[20:13:22] = drm_atomic_helper_connector_hdmi_mode_valid (7 subtests) =
[20:13:22] [PASSED] drm_test_check_mode_valid
[20:13:22] [PASSED] drm_test_check_mode_valid_reject
[20:13:22] [PASSED] drm_test_check_mode_valid_reject_rate
[20:13:22] [PASSED] drm_test_check_mode_valid_reject_max_clock
[20:13:22] [PASSED] drm_test_check_mode_valid_yuv420_only_max_clock
[20:13:22] [PASSED] drm_test_check_mode_valid_reject_yuv420_only_connector
[20:13:22] [PASSED] drm_test_check_mode_valid_accept_yuv420_also_connector_rgb
[20:13:22] === [PASSED] drm_atomic_helper_connector_hdmi_mode_valid ===
[20:13:22] = drm_atomic_helper_connector_hdmi_infoframes (5 subtests) =
[20:13:22] [PASSED] drm_test_check_infoframes
[20:13:22] [PASSED] drm_test_check_reject_avi_infoframe
[20:13:22] [PASSED] drm_test_check_reject_hdr_infoframe_bpc_8
[20:13:22] [PASSED] drm_test_check_reject_hdr_infoframe_bpc_10
[20:13:22] [PASSED] drm_test_check_reject_audio_infoframe
[20:13:22] === [PASSED] drm_atomic_helper_connector_hdmi_infoframes ===
[20:13:22] ================= drm_managed (2 subtests) =================
[20:13:22] [PASSED] drm_test_managed_release_action
[20:13:22] [PASSED] drm_test_managed_run_action
[20:13:22] =================== [PASSED] drm_managed ===================
[20:13:22] =================== drm_mm (6 subtests) ====================
[20:13:22] [PASSED] drm_test_mm_init
[20:13:22] [PASSED] drm_test_mm_debug
[20:13:22] [PASSED] drm_test_mm_align32
[20:13:22] [PASSED] drm_test_mm_align64
[20:13:22] [PASSED] drm_test_mm_lowest
[20:13:22] [PASSED] drm_test_mm_highest
[20:13:22] ===================== [PASSED] drm_mm ======================
[20:13:22] ============= drm_modes_analog_tv (5 subtests) =============
[20:13:22] [PASSED] drm_test_modes_analog_tv_mono_576i
[20:13:22] [PASSED] drm_test_modes_analog_tv_ntsc_480i
[20:13:22] [PASSED] drm_test_modes_analog_tv_ntsc_480i_inlined
[20:13:22] [PASSED] drm_test_modes_analog_tv_pal_576i
[20:13:22] [PASSED] drm_test_modes_analog_tv_pal_576i_inlined
[20:13:22] =============== [PASSED] drm_modes_analog_tv ===============
[20:13:22] ============== drm_panic_helper (3 subtests) ===============
[20:13:22] ============= drm_test_panic_screen_user_map  ==============
[20:13:22] [PASSED] Panic screen user, mode: 1024 x 768 	XR24 little-endian (0x34325258)
[20:13:22] [PASSED] Panic screen user, mode: 494 x 494 	XR24 little-endian (0x34325258)
[20:13:22] [PASSED] Panic screen user, mode: 1920 x 1080 	XR24 little-endian (0x34325258)
[20:13:22] [PASSED] Panic screen user, mode: 1024 x 768 	RG16 little-endian (0x36314752)
[20:13:22] [PASSED] Panic screen user, mode: 1024 x 768 	RG24 little-endian (0x34324752)
[20:13:22] [PASSED] Panic screen kmsg, mode: 1024 x 768 	XR24 little-endian (0x34325258)
[20:13:22] [PASSED] Panic screen kmsg, mode: 494 x 494 	XR24 little-endian (0x34325258)
[20:13:22] [PASSED] Panic screen kmsg, mode: 1920 x 1080 	XR24 little-endian (0x34325258)
[20:13:22] [PASSED] Panic screen kmsg, mode: 1024 x 768 	RG16 little-endian (0x36314752)
[20:13:22] [PASSED] Panic screen kmsg, mode: 1024 x 768 	RG24 little-endian (0x34324752)
[20:13:22] ========= [PASSED] drm_test_panic_screen_user_map ==========
[20:13:22] ============= drm_test_panic_screen_user_page  =============
[20:13:22] [PASSED] Panic screen user, mode: 1024 x 768 	XR24 little-endian (0x34325258)
[20:13:22] [PASSED] Panic screen user, mode: 494 x 494 	XR24 little-endian (0x34325258)
[20:13:22] [PASSED] Panic screen user, mode: 1920 x 1080 	XR24 little-endian (0x34325258)
[20:13:22] [PASSED] Panic screen user, mode: 1024 x 768 	RG16 little-endian (0x36314752)
[20:13:22] [PASSED] Panic screen user, mode: 1024 x 768 	RG24 little-endian (0x34324752)
[20:13:22] [PASSED] Panic screen kmsg, mode: 1024 x 768 	XR24 little-endian (0x34325258)
[20:13:22] [PASSED] Panic screen kmsg, mode: 494 x 494 	XR24 little-endian (0x34325258)
[20:13:22] [PASSED] Panic screen kmsg, mode: 1920 x 1080 	XR24 little-endian (0x34325258)
[20:13:22] [PASSED] Panic screen kmsg, mode: 1024 x 768 	RG16 little-endian (0x36314752)
[20:13:22] [PASSED] Panic screen kmsg, mode: 1024 x 768 	RG24 little-endian (0x34324752)
[20:13:22] ========= [PASSED] drm_test_panic_screen_user_page =========
[20:13:22] ========== drm_test_panic_screen_user_set_pixel  ===========
[20:13:22] [PASSED] Panic screen user, mode: 1024 x 768 	XR24 little-endian (0x34325258)
[20:13:22] [PASSED] Panic screen user, mode: 494 x 494 	XR24 little-endian (0x34325258)
[20:13:22] [PASSED] Panic screen user, mode: 1920 x 1080 	XR24 little-endian (0x34325258)
[20:13:22] [PASSED] Panic screen user, mode: 1024 x 768 	RG16 little-endian (0x36314752)
[20:13:22] [PASSED] Panic screen user, mode: 1024 x 768 	RG24 little-endian (0x34324752)
[20:13:22] [PASSED] Panic screen kmsg, mode: 1024 x 768 	XR24 little-endian (0x34325258)
[20:13:22] [PASSED] Panic screen kmsg, mode: 494 x 494 	XR24 little-endian (0x34325258)
[20:13:22] [PASSED] Panic screen kmsg, mode: 1920 x 1080 	XR24 little-endian (0x34325258)
[20:13:22] [PASSED] Panic screen kmsg, mode: 1024 x 768 	RG16 little-endian (0x36314752)
[20:13:22] [PASSED] Panic screen kmsg, mode: 1024 x 768 	RG24 little-endian (0x34324752)
[20:13:22] ====== [PASSED] drm_test_panic_screen_user_set_pixel =======
[20:13:22] ================ [PASSED] drm_panic_helper =================
[20:13:22] ============== drm_plane_helper (2 subtests) ===============
[20:13:22] =============== drm_test_check_plane_state  ================
[20:13:22] [PASSED] clipping_simple
[20:13:22] [PASSED] clipping_rotate_reflect
[20:13:22] [PASSED] positioning_simple
[20:13:22] [PASSED] upscaling
[20:13:22] [PASSED] downscaling
[20:13:22] [PASSED] rounding1
[20:13:22] [PASSED] rounding2
[20:13:22] [PASSED] rounding3
[20:13:22] [PASSED] rounding4
[20:13:22] =========== [PASSED] drm_test_check_plane_state ============
[20:13:22] =========== drm_test_check_invalid_plane_state  ============
[20:13:22] [PASSED] positioning_invalid
[20:13:22] [PASSED] upscaling_invalid
[20:13:22] [PASSED] downscaling_invalid
[20:13:22] ======= [PASSED] drm_test_check_invalid_plane_state ========
[20:13:22] ================ [PASSED] drm_plane_helper =================
[20:13:22] ====== drm_connector_helper_tv_get_modes (1 subtest) =======
[20:13:22] ====== drm_test_connector_helper_tv_get_modes_check  =======
[20:13:22] [PASSED] None
[20:13:22] [PASSED] PAL
[20:13:22] [PASSED] NTSC
[20:13:22] [PASSED] Both, NTSC Default
[20:13:22] [PASSED] Both, PAL Default
[20:13:22] [PASSED] Both, NTSC Default, with PAL on command-line
[20:13:22] [PASSED] Both, PAL Default, with NTSC on command-line
[20:13:22] == [PASSED] drm_test_connector_helper_tv_get_modes_check ===
[20:13:22] ======== [PASSED] drm_connector_helper_tv_get_modes ========
[20:13:22] ================== drm_rect (9 subtests) ===================
[20:13:22] [PASSED] drm_test_rect_clip_scaled_div_by_zero
[20:13:22] [PASSED] drm_test_rect_clip_scaled_not_clipped
[20:13:22] [PASSED] drm_test_rect_clip_scaled_clipped
[20:13:22] [PASSED] drm_test_rect_clip_scaled_signed_vs_unsigned
[20:13:22] ================= drm_test_rect_intersect  =================
[20:13:22] [PASSED] top-left x bottom-right: 2x2+1+1 x 2x2+0+0
[20:13:22] [PASSED] top-right x bottom-left: 2x2+0+0 x 2x2+1-1
[20:13:22] [PASSED] bottom-left x top-right: 2x2+1-1 x 2x2+0+0
[20:13:22] [PASSED] bottom-right x top-left: 2x2+0+0 x 2x2+1+1
[20:13:22] [PASSED] right x left: 2x1+0+0 x 3x1+1+0
[20:13:22] [PASSED] left x right: 3x1+1+0 x 2x1+0+0
[20:13:22] [PASSED] up x bottom: 1x2+0+0 x 1x3+0-1
[20:13:22] [PASSED] bottom x up: 1x3+0-1 x 1x2+0+0
[20:13:22] [PASSED] touching corner: 1x1+0+0 x 2x2+1+1
[20:13:22] [PASSED] touching side: 1x1+0+0 x 1x1+1+0
[20:13:22] [PASSED] equal rects: 2x2+0+0 x 2x2+0+0
[20:13:22] [PASSED] inside another: 2x2+0+0 x 1x1+1+1
[20:13:22] [PASSED] far away: 1x1+0+0 x 1x1+3+6
[20:13:22] [PASSED] points intersecting: 0x0+5+10 x 0x0+5+10
[20:13:22] [PASSED] points not intersecting: 0x0+0+0 x 0x0+5+10
[20:13:22] ============= [PASSED] drm_test_rect_intersect =============
[20:13:22] ================ drm_test_rect_calc_hscale  ================
[20:13:22] [PASSED] normal use
[20:13:22] [PASSED] out of max range
[20:13:22] [PASSED] out of min range
[20:13:22] [PASSED] zero dst
[20:13:22] [PASSED] negative src
[20:13:22] [PASSED] negative dst
[20:13:22] ============ [PASSED] drm_test_rect_calc_hscale ============
[20:13:22] ================ drm_test_rect_calc_vscale  ================
[20:13:22] [PASSED] normal use
[20:13:22] [PASSED] out of max range
[20:13:22] [PASSED] out of min range
[20:13:22] [PASSED] zero dst
[20:13:22] [PASSED] negative src
[20:13:22] [PASSED] negative dst
[20:13:22] ============ [PASSED] drm_test_rect_calc_vscale ============
[20:13:22] ================== drm_test_rect_rotate  ===================
[20:13:22] [PASSED] reflect-x
[20:13:22] [PASSED] reflect-y
[20:13:22] [PASSED] rotate-0
[20:13:22] [PASSED] rotate-90
[20:13:22] [PASSED] rotate-180
[20:13:22] [PASSED] rotate-270
[20:13:22] ============== [PASSED] drm_test_rect_rotate ===============
[20:13:22] ================ drm_test_rect_rotate_inv  =================
[20:13:22] [PASSED] reflect-x
[20:13:22] [PASSED] reflect-y
[20:13:22] [PASSED] rotate-0
[20:13:22] [PASSED] rotate-90
[20:13:22] [PASSED] rotate-180
[20:13:22] [PASSED] rotate-270
[20:13:22] ============ [PASSED] drm_test_rect_rotate_inv =============
[20:13:22] ==================== [PASSED] drm_rect =====================
[20:13:22] ============ drm_sysfb_modeset_test (1 subtest) ============
[20:13:22] ============ drm_test_sysfb_build_fourcc_list  =============
[20:13:22] [PASSED] no native formats
[20:13:22] [PASSED] XRGB8888 as native format
[20:13:22] [PASSED] remove duplicates
[20:13:22] [PASSED] convert alpha formats
[20:13:22] [PASSED] random formats
[20:13:22] ======== [PASSED] drm_test_sysfb_build_fourcc_list =========
[20:13:22] ============= [PASSED] drm_sysfb_modeset_test ==============
[20:13:22] ================== drm_fixp (2 subtests) ===================
[20:13:22] [PASSED] drm_test_int2fixp
[20:13:22] [PASSED] drm_test_sm2fixp
[20:13:22] ==================== [PASSED] drm_fixp =====================
[20:13:22] ============================================================
[20:13:22] Testing complete. Ran 667 tests: passed: 667
[20:13:22] Elapsed time: 28.849s total, 2.522s configuring, 25.908s building, 0.407s running

+ for kcfg in "${kunitconfigs[@]}"
+ [[ ! -f /kernel/drivers/gpu/drm/ttm/tests/.kunitconfig ]]
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/ttm/tests/.kunitconfig
[20:13:22] Configuring KUnit Kernel ...
Regenerating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
[20:13:25] Building KUnit Kernel ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
Building with:
$ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48
[20:13:35] Starting KUnit Kernel (1/1)...
[20:13:35] ============================================================
Running tests with:
$ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt
[20:13:36] ================= ttm_device (5 subtests) ==================
[20:13:36] [PASSED] ttm_device_init_basic
[20:13:36] [PASSED] ttm_device_init_multiple
[20:13:36] [PASSED] ttm_device_fini_basic
[20:13:36] [PASSED] ttm_device_init_no_vma_man
[20:13:36] ================== ttm_device_init_pools  ==================
[20:13:36] [PASSED] No DMA allocations, no DMA32 required
[20:13:36] [PASSED] DMA allocations, DMA32 required
[20:13:36] [PASSED] No DMA allocations, DMA32 required
[20:13:36] [PASSED] DMA allocations, no DMA32 required
[20:13:36] ============== [PASSED] ttm_device_init_pools ==============
[20:13:36] =================== [PASSED] ttm_device ====================
[20:13:36] ================== ttm_pool (8 subtests) ===================
[20:13:36] ================== ttm_pool_alloc_basic  ===================
[20:13:36] [PASSED] One page
[20:13:36] [PASSED] More than one page
[20:13:36] [PASSED] Above the allocation limit
[20:13:36] [PASSED] One page, with coherent DMA mappings enabled
[20:13:36] [PASSED] Above the allocation limit, with coherent DMA mappings enabled
[20:13:36] ============== [PASSED] ttm_pool_alloc_basic ===============
[20:13:36] ============== ttm_pool_alloc_basic_dma_addr  ==============
[20:13:36] [PASSED] One page
[20:13:36] [PASSED] More than one page
[20:13:36] [PASSED] Above the allocation limit
[20:13:36] [PASSED] One page, with coherent DMA mappings enabled
[20:13:36] [PASSED] Above the allocation limit, with coherent DMA mappings enabled
[20:13:36] ========== [PASSED] ttm_pool_alloc_basic_dma_addr ==========
[20:13:36] [PASSED] ttm_pool_alloc_order_caching_match
[20:13:36] [PASSED] ttm_pool_alloc_caching_mismatch
[20:13:36] [PASSED] ttm_pool_alloc_order_mismatch
[20:13:36] [PASSED] ttm_pool_free_dma_alloc
[20:13:36] [PASSED] ttm_pool_free_no_dma_alloc
[20:13:36] [PASSED] ttm_pool_fini_basic
[20:13:36] ==================== [PASSED] ttm_pool =====================
[20:13:36] ================ ttm_resource (8 subtests) =================
[20:13:36] ================= ttm_resource_init_basic  =================
[20:13:36] [PASSED] Init resource in TTM_PL_SYSTEM
[20:13:36] [PASSED] Init resource in TTM_PL_VRAM
[20:13:36] [PASSED] Init resource in a private placement
[20:13:36] [PASSED] Init resource in TTM_PL_SYSTEM, set placement flags
[20:13:36] ============= [PASSED] ttm_resource_init_basic =============
[20:13:36] [PASSED] ttm_resource_init_pinned
[20:13:36] [PASSED] ttm_resource_fini_basic
[20:13:36] [PASSED] ttm_resource_manager_init_basic
[20:13:36] [PASSED] ttm_resource_manager_usage_basic
[20:13:36] [PASSED] ttm_resource_manager_set_used_basic
[20:13:36] [PASSED] ttm_sys_man_alloc_basic
[20:13:36] [PASSED] ttm_sys_man_free_basic
[20:13:36] ================== [PASSED] ttm_resource ===================
[20:13:36] =================== ttm_tt (15 subtests) ===================
[20:13:36] ==================== ttm_tt_init_basic  ====================
[20:13:36] [PASSED] Page-aligned size
[20:13:36] [PASSED] Extra pages requested
[20:13:36] ================ [PASSED] ttm_tt_init_basic ================
[20:13:36] [PASSED] ttm_tt_init_misaligned
[20:13:36] [PASSED] ttm_tt_fini_basic
[20:13:36] [PASSED] ttm_tt_fini_sg
[20:13:36] [PASSED] ttm_tt_fini_shmem
[20:13:36] [PASSED] ttm_tt_create_basic
[20:13:36] [PASSED] ttm_tt_create_invalid_bo_type
[20:13:36] [PASSED] ttm_tt_create_ttm_exists
[20:13:36] [PASSED] ttm_tt_create_failed
[20:13:36] [PASSED] ttm_tt_destroy_basic
[20:13:36] [PASSED] ttm_tt_populate_null_ttm
[20:13:36] [PASSED] ttm_tt_populate_populated_ttm
[20:13:36] [PASSED] ttm_tt_unpopulate_basic
[20:13:36] [PASSED] ttm_tt_unpopulate_empty_ttm
[20:13:36] [PASSED] ttm_tt_swapin_basic
[20:13:36] ===================== [PASSED] ttm_tt ======================
[20:13:36] =================== ttm_bo (14 subtests) ===================
[20:13:36] =========== ttm_bo_reserve_optimistic_no_ticket  ===========
[20:13:36] [PASSED] Cannot be interrupted and sleeps
[20:13:36] [PASSED] Cannot be interrupted, locks straight away
[20:13:36] [PASSED] Can be interrupted, sleeps
[20:13:36] ======= [PASSED] ttm_bo_reserve_optimistic_no_ticket =======
[20:13:36] [PASSED] ttm_bo_reserve_locked_no_sleep
[20:13:36] [PASSED] ttm_bo_reserve_no_wait_ticket
[20:13:36] [PASSED] ttm_bo_reserve_double_resv
[20:13:36] [PASSED] ttm_bo_reserve_interrupted
[20:13:36] [PASSED] ttm_bo_reserve_deadlock
[20:13:36] [PASSED] ttm_bo_unreserve_basic
[20:13:36] [PASSED] ttm_bo_unreserve_pinned
[20:13:36] [PASSED] ttm_bo_unreserve_bulk
[20:13:36] [PASSED] ttm_bo_fini_basic
[20:13:36] [PASSED] ttm_bo_fini_shared_resv
[20:13:36] [PASSED] ttm_bo_pin_basic
[20:13:36] [PASSED] ttm_bo_pin_unpin_resource
[20:13:36] [PASSED] ttm_bo_multiple_pin_one_unpin
[20:13:36] ===================== [PASSED] ttm_bo ======================
[20:13:36] ============== ttm_bo_validate (22 subtests) ===============
[20:13:36] ============== ttm_bo_init_reserved_sys_man  ===============
[20:13:36] [PASSED] Buffer object for userspace
[20:13:36] [PASSED] Kernel buffer object
[20:13:36] [PASSED] Shared buffer object
[20:13:36] ========== [PASSED] ttm_bo_init_reserved_sys_man ===========
[20:13:36] ============== ttm_bo_init_reserved_mock_man  ==============
[20:13:36] [PASSED] Buffer object for userspace
[20:13:36] [PASSED] Kernel buffer object
[20:13:36] [PASSED] Shared buffer object
[20:13:36] ========== [PASSED] ttm_bo_init_reserved_mock_man ==========
[20:13:36] [PASSED] ttm_bo_init_reserved_resv
[20:13:36] ================== ttm_bo_validate_basic  ==================
[20:13:36] [PASSED] Buffer object for userspace
[20:13:36] [PASSED] Kernel buffer object
[20:13:36] [PASSED] Shared buffer object
[20:13:36] ============== [PASSED] ttm_bo_validate_basic ==============
[20:13:36] [PASSED] ttm_bo_validate_invalid_placement
[20:13:36] ============= ttm_bo_validate_same_placement  ==============
[20:13:36] [PASSED] System manager
[20:13:36] [PASSED] VRAM manager
[20:13:36] ========= [PASSED] ttm_bo_validate_same_placement ==========
[20:13:36] [PASSED] ttm_bo_validate_failed_alloc
[20:13:36] [PASSED] ttm_bo_validate_pinned
[20:13:36] [PASSED] ttm_bo_validate_busy_placement
[20:13:36] ================ ttm_bo_validate_multihop  =================
[20:13:36] [PASSED] Buffer object for userspace
[20:13:36] [PASSED] Kernel buffer object
[20:13:36] [PASSED] Shared buffer object
[20:13:36] ============ [PASSED] ttm_bo_validate_multihop =============
[20:13:36] ========== ttm_bo_validate_no_placement_signaled  ==========
[20:13:36] [PASSED] Buffer object in system domain, no page vector
[20:13:36] [PASSED] Buffer object in system domain with an existing page vector
[20:13:36] ====== [PASSED] ttm_bo_validate_no_placement_signaled ======
[20:13:36] ======== ttm_bo_validate_no_placement_not_signaled  ========
[20:13:36] [PASSED] Buffer object for userspace
[20:13:36] [PASSED] Kernel buffer object
[20:13:36] [PASSED] Shared buffer object
[20:13:36] ==== [PASSED] ttm_bo_validate_no_placement_not_signaled ====
[20:13:36] [PASSED] ttm_bo_validate_move_fence_signaled
[20:13:36] ========= ttm_bo_validate_move_fence_not_signaled  =========
[20:13:36] [PASSED] Waits for GPU
[20:13:36] [PASSED] Tries to lock straight away
[20:13:36] ===== [PASSED] ttm_bo_validate_move_fence_not_signaled =====
[20:13:36] [PASSED] ttm_bo_validate_swapout
[20:13:36] [PASSED] ttm_bo_validate_happy_evict
[20:13:36] [PASSED] ttm_bo_validate_all_pinned_evict
[20:13:36] [PASSED] ttm_bo_validate_allowed_only_evict
[20:13:36] [PASSED] ttm_bo_validate_deleted_evict
[20:13:36] [PASSED] ttm_bo_validate_busy_domain_evict
[20:13:36] [PASSED] ttm_bo_validate_evict_gutting
[20:13:36] [PASSED] ttm_bo_validate_recrusive_evict
[20:13:36] ================= [PASSED] ttm_bo_validate =================
[20:13:36] ============================================================
[20:13:36] Testing complete. Ran 102 tests: passed: 102
[20:13:36] Elapsed time: 13.435s total, 2.531s configuring, 10.638s building, 0.228s running

+ for kcfg in "${kunitconfigs[@]}"
+ [[ ! -f /kernel/drivers/dma-buf/.kunitconfig ]]
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/dma-buf/.kunitconfig
[20:13:36] Configuring KUnit Kernel ...
Regenerating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
[20:13:38] Building KUnit Kernel ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
Building with:
$ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48
[20:13:48] Starting KUnit Kernel (1/1)...
[20:13:48] ============================================================
Running tests with:
$ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt
[20:13:48] =============== dma-buf-fence (12 subtests) ================
[20:13:48] [PASSED] test_sanitycheck
[20:13:48] [PASSED] test_signaling
[20:13:48] [PASSED] test_add_callback
[20:13:48] [PASSED] test_late_add_callback
[20:13:48] [PASSED] test_rm_callback
[20:13:48] [PASSED] test_late_rm_callback
[20:13:48] [PASSED] test_status
[20:13:48] [PASSED] test_error
[20:13:48] [PASSED] test_wait
[20:13:48] [PASSED] test_wait_timeout
[20:13:48] [PASSED] test_stub
[20:13:48] [SKIPPED] test_race_signal_callback (requires at least 2 CPUs)
[20:13:48] ================== [PASSED] dma-buf-fence ==================
[20:13:48] ============ dma-buf-fence-chain (11 subtests) =============
[20:13:48] [PASSED] test_sanitycheck
[20:13:48] [PASSED] test_find_seqno
[20:13:48] [PASSED] test_find_signaled
[20:13:48] [PASSED] test_find_out_of_order
[20:13:53] [PASSED] test_find_gap
[20:13:53] [PASSED] test_find_race
[20:13:53] [PASSED] test_signal_forward
[20:13:53] [PASSED] test_signal_backward
[20:13:53] [PASSED] test_wait_forward
[20:13:53] [PASSED] test_wait_backward
[20:13:53] [PASSED] test_wait_random
[20:13:53] =============== [PASSED] dma-buf-fence-chain ===============
[20:13:53] ============ dma-buf-fence-unwrap (11 subtests) ============
[20:13:53] [PASSED] test_sanitycheck
[20:13:53] [PASSED] test_unwrap_array
[20:13:53] [PASSED] test_unwrap_chain
[20:13:53] [PASSED] test_unwrap_chain_array
[20:13:53] [PASSED] test_unwrap_merge
[20:13:53] [PASSED] test_unwrap_merge_duplicate
[20:13:53] [PASSED] test_unwrap_merge_seqno
[20:13:53] [PASSED] test_unwrap_merge_order
[20:13:53] [PASSED] test_unwrap_merge_complex
[20:13:53] [PASSED] test_unwrap_merge_complex_seqno
[20:13:53] [PASSED] test_dedup_empty
[20:13:53] ============== [PASSED] dma-buf-fence-unwrap ===============
[20:13:53] ================ dma-buf-resv (5 subtests) =================
[20:13:53] [PASSED] test_sanitycheck
[20:13:53] ===================== test_signaling  ======================
[20:13:53] [PASSED] kernel
[20:13:53] [PASSED] write
[20:13:53] [PASSED] read
[20:13:53] [PASSED] bookkeep
[20:13:53] ================= [PASSED] test_signaling ==================
[20:13:53] ====================== test_for_each  ======================
[20:13:53] [PASSED] kernel
[20:13:53] [PASSED] write
[20:13:53] [PASSED] read
[20:13:53] [PASSED] bookkeep
[20:13:53] ================== [PASSED] test_for_each ==================
[20:13:53] ================= test_for_each_unlocked  ==================
[20:13:53] [PASSED] kernel
[20:13:53] [PASSED] write
[20:13:53] [PASSED] read
[20:13:53] [PASSED] bookkeep
[20:13:53] ============= [PASSED] test_for_each_unlocked ==============
[20:13:53] ===================== test_get_fences  =====================
[20:13:53] [PASSED] kernel
[20:13:53] [PASSED] write
[20:13:53] [PASSED] read
[20:13:53] [PASSED] bookkeep
[20:13:53] ================= [PASSED] test_get_fences =================
[20:13:53] ================== [PASSED] dma-buf-resv ===================
[20:13:53] ============================================================
[20:13:53] Testing complete. Ran 51 tests: passed: 50, skipped: 1
[20:13:53] Elapsed time: 17.231s total, 2.528s configuring, 9.381s building, 5.287s running

+ cleanup
++ stat -c %u:%g /kernel
+ chown -R 1003:1003 /kernel



^ permalink raw reply	[flat|nested] 30+ messages in thread

* ✓ Xe.CI.BAT: success for Crescent Island PMT support (rev20)
  2026-11-19 15:54 [PATCH v19 00/19] Crescent Island PMT support Michael J. Ruhl
                   ` (20 preceding siblings ...)
  2026-11-19 20:13 ` ✓ CI.KUnit: success " Patchwork
@ 2026-11-19 20:55 ` Patchwork
  21 siblings, 0 replies; 30+ messages in thread
From: Patchwork @ 2026-11-19 20:55 UTC (permalink / raw)
  To: Michael J. Ruhl; +Cc: intel-xe

[-- Attachment #1: Type: text/plain, Size: 947 bytes --]

== Series Details ==

Series: Crescent Island PMT support (rev20)
URL   : https://patchwork.freedesktop.org/series/160717/
State : success

== Summary ==

CI Bug Log - changes from xe-6189-859a3f2c44944276c49ab8d35f0ffd31b02b19c5_BAT -> xe-pw-160717v20_BAT
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  

Participating hosts (15 -> 14)
------------------------------

  Missing    (1): bat-bmg-3 


Changes
-------

  No changes found


Build changes
-------------

  * Linux: xe-6189-859a3f2c44944276c49ab8d35f0ffd31b02b19c5 -> xe-pw-160717v20

  IGT_9199: f28241ac1ad57574315e7bd31b174294cca2f29c @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
  xe-6189-859a3f2c44944276c49ab8d35f0ffd31b02b19c5: 859a3f2c44944276c49ab8d35f0ffd31b02b19c5
  xe-pw-160717v20: 160717v20

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-160717v20/index.html

[-- Attachment #2: Type: text/html, Size: 1496 bytes --]

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: [PATCH v19 14/19] drm/xe/vsec: Crescent Island PMT callbacks
  2026-11-19 15:54 ` [PATCH v19 14/19] drm/xe/vsec: Crescent Island PMT callbacks Michael J. Ruhl
@ 2026-11-19 21:05   ` Rodrigo Vivi
  2026-11-19 21:41     ` Ruhl, Michael J
  0 siblings, 1 reply; 30+ messages in thread
From: Rodrigo Vivi @ 2026-11-19 21:05 UTC (permalink / raw)
  To: Michael J. Ruhl
  Cc: platform-driver-x86, intel-xe, hansg, ilpo.jarvinen,
	matthew.brost, thomas.hellstrom, airlied, simona, david.e.box,
	anoop.c.vijay, badal.nilawar, matthew.d.roper, james.ausmus

On Thu, Nov 19, 2026 at 07:54:52AM -0800, Michael J. Ruhl wrote:
> CRI PMT support requires callbacks to access the discovery data and
> control areas. Access is a common MMIO area that requires an index to
> be set before access is allowed.
> 
> Introduce the necessary callbacks to get the discovery, status and
> control information for CRI PMT usage.
> 
> Add the glue logic to register the CRI PMT functionality.
> 
> Signed-off-by: Michael J. Ruhl <michael.j.ruhl@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_vsec.c | 178 ++++++++++++++++++++++++++++++++++-
>  1 file changed, 174 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_vsec.c b/drivers/gpu/drm/xe/xe_vsec.c
> index a814d7151eea..58eb85fb6a9f 100644
> --- a/drivers/gpu/drm/xe/xe_vsec.c
> +++ b/drivers/gpu/drm/xe/xe_vsec.c
> @@ -4,6 +4,7 @@
>  #include <linux/bits.h>
>  #include <linux/cleanup.h>
>  #include <linux/errno.h>
> +#include <linux/log2.h>
>  #include <linux/intel_vsec.h>
>  #include <linux/module.h>
>  #include <linux/mutex.h>
> @@ -344,10 +345,15 @@ int xe_pmt_telem_read(struct device *dev, u32 guid, u64 *data, loff_t user_offse
>  	}
>  
>  	scoped_guard(mutex, &xe->pmt.lock) {
> +		u32 device_id = FIELD_GET(GUID_DEVICE_ID, guid);
> +
>  		/* set SoC re-mapper index register based on GUID memory region */
>  		xe->soc_remapper.set_telem_region(xe, mem_region);
>  
>  		memcpy_fromio(data, telem_addr, count);
> +
> +		if (device_id == CRI_DEVICE_ID)
> +			xe->soc_remapper.set_telem_region(xe, CRI_IDX_TELEM_DISCOVERY);
>  	}
>  
>  	xe_pm_runtime_put(xe);
> @@ -358,20 +364,178 @@ int xe_pmt_telem_read(struct device *dev, u32 guid, u64 *data, loff_t user_offse
>  	return ret == 0 ? count : ret;
>  }
>  
> -static struct pmt_callbacks xe_pmt_cb = {
> +/**
> + * xe_pmt_discovery_read - Given a device and an index, read discovery data into a buffer
> + * @dev: valid Xe device
> + * @cap_id: PMT type
> + * @element: element to access
> + * @disc_data: buffer for discovery data
> + * @count: bytes to read

count doesn't exist below...

> + *
> + * This is a callback API.  I.e this can be accessed external to the XE driver
> + * (PMT driver scope).  Because of this, DRM hotplug needs to be verified
> + * (drm_dev_enter()).
> + *
> + * Return:
> + * * -ENODEV device is not available (hotplug)
> + * * -EINVAL for unsupported device or PMT feature
> + * * 0 on success
> + */
> +static int xe_pmt_discovery_read(struct device *dev, unsigned long cap_id, u32 element,
> +				 u32 *disc_data)
> +{
> +	struct xe_device *xe = kdev_to_xe_device(dev);
> +	void __iomem *disc_addr = xe->mmio.regs;
> +	struct intel_vsec_header *headers;
> +	int ret = 0;
> +	u32 offset;
> +	int idx;
> +
> +	if (!drm_dev_enter(&xe->drm, &idx))
> +		return -ENODEV;
> +
> +	if (xe->info.platform != XE_CRESCENTISLAND) {
> +		ret = -EINVAL;
> +		goto dev_exit;
> +	}
> +
> +	switch (cap_id) {
> +	case ilog2(VSEC_CAP_TELEMETRY):
> +		headers = &cri_telemetry;
> +		break;
> +
> +	case ilog2(VSEC_CAP_CRASHLOG):
> +		headers = &cri_crashlog;
> +		break;
> +
> +	default:
> +		ret = -EINVAL;
> +		goto dev_exit;
> +	}
> +
> +	offset = element * (headers->entry_size * sizeof(u32));
> +	disc_addr += headers->offset + offset;
> +
> +	scoped_guard(mutex, &xe->pmt.lock) {
> +		xe->soc_remapper.set_telem_region(xe, CRI_IDX_TELEM_DISCOVERY);
> +		memcpy_fromio(disc_data, disc_addr, PMT_DISC_DWORDS * sizeof(u32));
> +	}

we probably need rpm get/put here, no?!

> +
> +dev_exit:
> +	drm_dev_exit(idx);
> +
> +	return ret;
> +}
> +
> +/**
> + * xe_pmt_read_reg() - read a crashlog register
> + * @dev: the xe device that registered the callback
> + * @guid: PMT guid of the crashlog instance
> + * @reg: data read from the PMT data structure
> + * @offset: which data to read from the PMT data structure
> + *
> + * Read the requested PMT register based on the pcie device and guid.  The
> + * supported struct is the Crashlog Type1 Version2.
> + *
> + * Currently this is for CRI only.
> + *
> + * Return:
> + * * -ENODEV device is not available (hotplug)
> + * * -EINVAL invalid guid
> + * * 0       success
> + */
> +static int xe_pmt_read_reg(struct device *dev, u32 guid, u32 *reg, u32 offset)
> +{
> +	struct xe_device *xe = kdev_to_xe_device(dev);
> +	void __iomem *disc_addr = xe->mmio.regs + xe->pmt.base_offset;
> +	int ret = 0;
> +	u32 inst;
> +	int idx;
> +
> +	if (FIELD_GET(GUID_DEVICE_ID, guid) != CRI_DEVICE_ID ||
> +	    FIELD_GET(GUID_CAP_TYPE, guid) != CRASHLOG)
> +		return -EINVAL;
> +
> +	if (!drm_dev_enter(&xe->drm, &idx))
> +		return -ENODEV;
> +
> +	inst = FIELD_GET(GUID_RECORD_ID, guid) == PUNIT ?
> +		CRI_CRASHLOG_PUNIT_DISC_OFFSET : CRI_CRASHLOG_OOBMSM_DISC_OFFSET;
> +	disc_addr += inst + offset;
> +
> +	xe_pm_runtime_get(xe);
> +
> +	scoped_guard(mutex, &xe->pmt.lock) {
> +		xe->soc_remapper.set_telem_region(xe, CRI_IDX_TELEM_DISCOVERY);
> +
> +		*reg = readl(disc_addr);
> +	}
> +
> +	xe_pm_runtime_put(xe);
> +
> +	drm_dev_exit(idx);
> +
> +	return ret;
> +}
> +
> +static int xe_pmt_write_reg(struct device *dev, u32 guid, u32 reg, u32 offset)
> +{
> +	struct xe_device *xe = kdev_to_xe_device(dev);
> +	void __iomem *disc_addr = xe->mmio.regs + xe->pmt.base_offset;
> +	int ret = 0;
> +	u32 inst;
> +	int idx;
> +
> +	if (FIELD_GET(GUID_DEVICE_ID, guid) != CRI_DEVICE_ID ||
> +	    FIELD_GET(GUID_CAP_TYPE, guid) != CRASHLOG)
> +		return -EINVAL;
> +
> +	if (!drm_dev_enter(&xe->drm, &idx))
> +		return -ENODEV;
> +
> +	inst = FIELD_GET(GUID_RECORD_ID, guid) == PUNIT ?
> +		CRI_CRASHLOG_PUNIT_DISC_OFFSET : CRI_CRASHLOG_OOBMSM_DISC_OFFSET;
> +	disc_addr += inst + offset;
> +
> +	xe_pm_runtime_get(xe);
> +
> +	scoped_guard(mutex, &xe->pmt.lock) {
> +		xe->soc_remapper.set_telem_region(xe, CRI_IDX_TELEM_DISCOVERY);
> +
> +		writel(reg, disc_addr);
> +	}
> +
> +	xe_pm_runtime_put(xe);
> +
> +	drm_dev_exit(idx);
> +
> +	return ret;
> +}
> +
> +static struct pmt_callbacks xe_bmg_pmt_cb = {
>  	.read_telem = xe_pmt_telem_read,
>  };
>  
> +static struct pmt_callbacks xe_cri_pmt_cb = {
> +	.read_telem = xe_pmt_telem_read,
> +	.read_discovery = xe_pmt_discovery_read,
> +	.read_reg = xe_pmt_read_reg,
> +	.write_reg = xe_pmt_write_reg,
> +};
> +
>  static const int vsec_platforms[] = {
>  	[XE_BATTLEMAGE] = XE_VSEC_BMG,
> +	[XE_CRESCENTISLAND] = XE_VSEC_CRI,
>  };
>  
>  static enum xe_vsec get_platform_info(struct xe_device *xe)
>  {
> -	if (xe->info.platform > XE_BATTLEMAGE)
> +	if (xe->info.platform > XE_CRESCENTISLAND)
>  		return XE_VSEC_UNKNOWN;
>  
> -	if (IS_SRIOV_VF(xe) && xe->info.platform == XE_BATTLEMAGE)
> +	if (IS_SRIOV_VF(xe) &&
> +	    (xe->info.platform == XE_BATTLEMAGE ||
> +	     xe->info.platform == XE_CRESCENTISLAND))
>  		return XE_VSEC_UNKNOWN;
>  
>  	return vsec_platforms[xe->info.platform];
> @@ -399,8 +563,14 @@ void xe_vsec_init(struct xe_device *xe)
>  	switch (platform) {
>  	case XE_VSEC_BMG:
>  		xe->pmt.base_offset = BMG_TELEMETRY_OFFSET;
> -		info->priv_data = &xe_pmt_cb;
> +		info->priv_data = &xe_bmg_pmt_cb;
>  		break;
> +
> +	case XE_VSEC_CRI:
> +		xe->pmt.base_offset = CRI_PMT_OFFSET;
> +		info->priv_data = &xe_cri_pmt_cb;
> +		break;
> +
>  	default:
>  		break;
>  	}
> -- 
> 2.43.0
> 

^ permalink raw reply	[flat|nested] 30+ messages in thread

* RE: [PATCH v19 14/19] drm/xe/vsec: Crescent Island PMT callbacks
  2026-11-19 21:05   ` Rodrigo Vivi
@ 2026-11-19 21:41     ` Ruhl, Michael J
  2026-11-19 21:55       ` Vivi, Rodrigo
  0 siblings, 1 reply; 30+ messages in thread
From: Ruhl, Michael J @ 2026-11-19 21:41 UTC (permalink / raw)
  To: Vivi, Rodrigo
  Cc: platform-driver-x86@vger.kernel.org,
	intel-xe@lists.freedesktop.org, hansg@kernel.org,
	ilpo.jarvinen@linux.intel.com, Brost, Matthew,
	thomas.hellstrom@linux.intel.com, airlied@gmail.com,
	simona@ffwll.ch, david.e.box@linux.intel.com, Vijay, Anoop C,
	Nilawar, Badal, Roper, Matthew D, Ausmus, James

>-----Original Message-----
>From: Vivi, Rodrigo <rodrigo.vivi@intel.com>
>Sent: Thursday, November 19, 2026 4:05 PM
>To: Ruhl, Michael J <michael.j.ruhl@intel.com>
>Cc: platform-driver-x86@vger.kernel.org; intel-xe@lists.freedesktop.org;
>hansg@kernel.org; ilpo.jarvinen@linux.intel.com; Brost, Matthew
><matthew.brost@intel.com>; thomas.hellstrom@linux.intel.com;
>airlied@gmail.com; simona@ffwll.ch; david.e.box@linux.intel.com; Vijay,
>Anoop C <anoop.c.vijay@intel.com>; Nilawar, Badal
><badal.nilawar@intel.com>; Roper, Matthew D <matthew.d.roper@intel.com>;
>Ausmus, James <james.ausmus@intel.com>
>Subject: Re: [PATCH v19 14/19] drm/xe/vsec: Crescent Island PMT callbacks
>
>On Thu, Nov 19, 2026 at 07:54:52AM -0800, Michael J. Ruhl wrote:
>> CRI PMT support requires callbacks to access the discovery data and
>> control areas. Access is a common MMIO area that requires an index to
>> be set before access is allowed.
>>
>> Introduce the necessary callbacks to get the discovery, status and
>> control information for CRI PMT usage.
>>
>> Add the glue logic to register the CRI PMT functionality.
>>
>> Signed-off-by: Michael J. Ruhl <michael.j.ruhl@intel.com>
>> ---
>>  drivers/gpu/drm/xe/xe_vsec.c | 178
>++++++++++++++++++++++++++++++++++-
>>  1 file changed, 174 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/xe/xe_vsec.c b/drivers/gpu/drm/xe/xe_vsec.c
>> index a814d7151eea..58eb85fb6a9f 100644
>> --- a/drivers/gpu/drm/xe/xe_vsec.c
>> +++ b/drivers/gpu/drm/xe/xe_vsec.c
>> @@ -4,6 +4,7 @@
>>  #include <linux/bits.h>
>>  #include <linux/cleanup.h>
>>  #include <linux/errno.h>
>> +#include <linux/log2.h>
>>  #include <linux/intel_vsec.h>
>>  #include <linux/module.h>
>>  #include <linux/mutex.h>
>> @@ -344,10 +345,15 @@ int xe_pmt_telem_read(struct device *dev, u32
>guid, u64 *data, loff_t user_offse
>>  	}
>>
>>  	scoped_guard(mutex, &xe->pmt.lock) {
>> +		u32 device_id = FIELD_GET(GUID_DEVICE_ID, guid);
>> +
>>  		/* set SoC re-mapper index register based on GUID memory
>region */
>>  		xe->soc_remapper.set_telem_region(xe, mem_region);
>>
>>  		memcpy_fromio(data, telem_addr, count);
>> +
>> +		if (device_id == CRI_DEVICE_ID)
>> +			xe->soc_remapper.set_telem_region(xe,
>CRI_IDX_TELEM_DISCOVERY);
>>  	}
>>
>>  	xe_pm_runtime_put(xe);
>> @@ -358,20 +364,178 @@ int xe_pmt_telem_read(struct device *dev, u32
>guid, u64 *data, loff_t user_offse
>>  	return ret == 0 ? count : ret;
>>  }
>>
>> -static struct pmt_callbacks xe_pmt_cb = {
>> +/**
>> + * xe_pmt_discovery_read - Given a device and an index, read discovery data
>into a buffer
>> + * @dev: valid Xe device
>> + * @cap_id: PMT type
>> + * @element: element to access
>> + * @disc_data: buffer for discovery data
>> + * @count: bytes to read
>
>count doesn't exist below...

Yeah, already cleaned up. 😊

>> + *
>> + * This is a callback API.  I.e this can be accessed external to the XE driver
>> + * (PMT driver scope).  Because of this, DRM hotplug needs to be verified
>> + * (drm_dev_enter()).
>> + *
>> + * Return:
>> + * * -ENODEV device is not available (hotplug)
>> + * * -EINVAL for unsupported device or PMT feature
>> + * * 0 on success
>> + */
>> +static int xe_pmt_discovery_read(struct device *dev, unsigned long cap_id,
>u32 element,
>> +				 u32 *disc_data)
>> +{
>> +	struct xe_device *xe = kdev_to_xe_device(dev);
>> +	void __iomem *disc_addr = xe->mmio.regs;
>> +	struct intel_vsec_header *headers;
>> +	int ret = 0;
>> +	u32 offset;
>> +	int idx;
>> +
>> +	if (!drm_dev_enter(&xe->drm, &idx))
>> +		return -ENODEV;
>> +
>> +	if (xe->info.platform != XE_CRESCENTISLAND) {
>> +		ret = -EINVAL;
>> +		goto dev_exit;
>> +	}
>> +
>> +	switch (cap_id) {
>> +	case ilog2(VSEC_CAP_TELEMETRY):
>> +		headers = &cri_telemetry;
>> +		break;
>> +
>> +	case ilog2(VSEC_CAP_CRASHLOG):
>> +		headers = &cri_crashlog;
>> +		break;
>> +
>> +	default:
>> +		ret = -EINVAL;
>> +		goto dev_exit;
>> +	}
>> +
>> +	offset = element * (headers->entry_size * sizeof(u32));
>> +	disc_addr += headers->offset + offset;
>> +
>> +	scoped_guard(mutex, &xe->pmt.lock) {
>> +		xe->soc_remapper.set_telem_region(xe,
>CRI_IDX_TELEM_DISCOVERY);
>> +		memcpy_fromio(disc_data, disc_addr, PMT_DISC_DWORDS *
>sizeof(u32));
>> +	}
>
>we probably need rpm get/put here, no?!

In the non late-binding probe path, runtime is already in place.
For the late-binding path, the runtime_get happens when the work item is queued and released
when the registration is complete.

M

>> +
>> +dev_exit:
>> +	drm_dev_exit(idx);
>> +
>> +	return ret;
>> +}
>> +
>> +/**
>> + * xe_pmt_read_reg() - read a crashlog register
>> + * @dev: the xe device that registered the callback
>> + * @guid: PMT guid of the crashlog instance
>> + * @reg: data read from the PMT data structure
>> + * @offset: which data to read from the PMT data structure
>> + *
>> + * Read the requested PMT register based on the pcie device and guid.  The
>> + * supported struct is the Crashlog Type1 Version2.
>> + *
>> + * Currently this is for CRI only.
>> + *
>> + * Return:
>> + * * -ENODEV device is not available (hotplug)
>> + * * -EINVAL invalid guid
>> + * * 0       success
>> + */
>> +static int xe_pmt_read_reg(struct device *dev, u32 guid, u32 *reg, u32
>offset)
>> +{
>> +	struct xe_device *xe = kdev_to_xe_device(dev);
>> +	void __iomem *disc_addr = xe->mmio.regs + xe->pmt.base_offset;
>> +	int ret = 0;
>> +	u32 inst;
>> +	int idx;
>> +
>> +	if (FIELD_GET(GUID_DEVICE_ID, guid) != CRI_DEVICE_ID ||
>> +	    FIELD_GET(GUID_CAP_TYPE, guid) != CRASHLOG)
>> +		return -EINVAL;
>> +
>> +	if (!drm_dev_enter(&xe->drm, &idx))
>> +		return -ENODEV;
>> +
>> +	inst = FIELD_GET(GUID_RECORD_ID, guid) == PUNIT ?
>> +		CRI_CRASHLOG_PUNIT_DISC_OFFSET :
>CRI_CRASHLOG_OOBMSM_DISC_OFFSET;
>> +	disc_addr += inst + offset;
>> +
>> +	xe_pm_runtime_get(xe);
>> +
>> +	scoped_guard(mutex, &xe->pmt.lock) {
>> +		xe->soc_remapper.set_telem_region(xe,
>CRI_IDX_TELEM_DISCOVERY);
>> +
>> +		*reg = readl(disc_addr);
>> +	}
>> +
>> +	xe_pm_runtime_put(xe);
>> +
>> +	drm_dev_exit(idx);
>> +
>> +	return ret;
>> +}
>> +
>> +static int xe_pmt_write_reg(struct device *dev, u32 guid, u32 reg, u32
>offset)
>> +{
>> +	struct xe_device *xe = kdev_to_xe_device(dev);
>> +	void __iomem *disc_addr = xe->mmio.regs + xe->pmt.base_offset;
>> +	int ret = 0;
>> +	u32 inst;
>> +	int idx;
>> +
>> +	if (FIELD_GET(GUID_DEVICE_ID, guid) != CRI_DEVICE_ID ||
>> +	    FIELD_GET(GUID_CAP_TYPE, guid) != CRASHLOG)
>> +		return -EINVAL;
>> +
>> +	if (!drm_dev_enter(&xe->drm, &idx))
>> +		return -ENODEV;
>> +
>> +	inst = FIELD_GET(GUID_RECORD_ID, guid) == PUNIT ?
>> +		CRI_CRASHLOG_PUNIT_DISC_OFFSET :
>CRI_CRASHLOG_OOBMSM_DISC_OFFSET;
>> +	disc_addr += inst + offset;
>> +
>> +	xe_pm_runtime_get(xe);
>> +
>> +	scoped_guard(mutex, &xe->pmt.lock) {
>> +		xe->soc_remapper.set_telem_region(xe,
>CRI_IDX_TELEM_DISCOVERY);
>> +
>> +		writel(reg, disc_addr);
>> +	}
>> +
>> +	xe_pm_runtime_put(xe);
>> +
>> +	drm_dev_exit(idx);
>> +
>> +	return ret;
>> +}
>> +
>> +static struct pmt_callbacks xe_bmg_pmt_cb = {
>>  	.read_telem = xe_pmt_telem_read,
>>  };
>>
>> +static struct pmt_callbacks xe_cri_pmt_cb = {
>> +	.read_telem = xe_pmt_telem_read,
>> +	.read_discovery = xe_pmt_discovery_read,
>> +	.read_reg = xe_pmt_read_reg,
>> +	.write_reg = xe_pmt_write_reg,
>> +};
>> +
>>  static const int vsec_platforms[] = {
>>  	[XE_BATTLEMAGE] = XE_VSEC_BMG,
>> +	[XE_CRESCENTISLAND] = XE_VSEC_CRI,
>>  };
>>
>>  static enum xe_vsec get_platform_info(struct xe_device *xe)
>>  {
>> -	if (xe->info.platform > XE_BATTLEMAGE)
>> +	if (xe->info.platform > XE_CRESCENTISLAND)
>>  		return XE_VSEC_UNKNOWN;
>>
>> -	if (IS_SRIOV_VF(xe) && xe->info.platform == XE_BATTLEMAGE)
>> +	if (IS_SRIOV_VF(xe) &&
>> +	    (xe->info.platform == XE_BATTLEMAGE ||
>> +	     xe->info.platform == XE_CRESCENTISLAND))
>>  		return XE_VSEC_UNKNOWN;
>>
>>  	return vsec_platforms[xe->info.platform];
>> @@ -399,8 +563,14 @@ void xe_vsec_init(struct xe_device *xe)
>>  	switch (platform) {
>>  	case XE_VSEC_BMG:
>>  		xe->pmt.base_offset = BMG_TELEMETRY_OFFSET;
>> -		info->priv_data = &xe_pmt_cb;
>> +		info->priv_data = &xe_bmg_pmt_cb;
>>  		break;
>> +
>> +	case XE_VSEC_CRI:
>> +		xe->pmt.base_offset = CRI_PMT_OFFSET;
>> +		info->priv_data = &xe_cri_pmt_cb;
>> +		break;
>> +
>>  	default:
>>  		break;
>>  	}
>> --
>> 2.43.0
>>

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: [PATCH v19 14/19] drm/xe/vsec: Crescent Island PMT callbacks
  2026-11-19 21:41     ` Ruhl, Michael J
@ 2026-11-19 21:55       ` Vivi, Rodrigo
  2026-11-20 14:23         ` Ruhl, Michael J
  0 siblings, 1 reply; 30+ messages in thread
From: Vivi, Rodrigo @ 2026-11-19 21:55 UTC (permalink / raw)
  To: Ruhl, Michael J
  Cc: intel-xe@lists.freedesktop.org, hansg@kernel.org,
	david.e.box@linux.intel.com, simona@ffwll.ch,
	ilpo.jarvinen@linux.intel.com, Roper, Matthew D, Brost, Matthew,
	airlied@gmail.com, thomas.hellstrom@linux.intel.com,
	Vijay, Anoop C, Ausmus, James, Nilawar, Badal,
	platform-driver-x86@vger.kernel.org

On Thu, 2026-11-19 at 21:41 +0000, Ruhl, Michael J wrote:
> > -----Original Message-----
> > From: Vivi, Rodrigo <rodrigo.vivi@intel.com>
> > Sent: Thursday, November 19, 2026 4:05 PM
> > To: Ruhl, Michael J <michael.j.ruhl@intel.com>
> > Cc: platform-driver-x86@vger.kernel.org;
> > intel-xe@lists.freedesktop.org;
> > hansg@kernel.org; ilpo.jarvinen@linux.intel.com; Brost, Matthew
> > <matthew.brost@intel.com>; thomas.hellstrom@linux.intel.com;
> > airlied@gmail.com; simona@ffwll.ch; david.e.box@linux.intel.com;
> > Vijay,
> > Anoop C <anoop.c.vijay@intel.com>; Nilawar, Badal
> > <badal.nilawar@intel.com>; Roper, Matthew D
> > <matthew.d.roper@intel.com>;
> > Ausmus, James <james.ausmus@intel.com>
> > Subject: Re: [PATCH v19 14/19] drm/xe/vsec: Crescent Island PMT
> > callbacks
> > 
> > On Thu, Nov 19, 2026 at 07:54:52AM -0800, Michael J. Ruhl wrote:
> > > CRI PMT support requires callbacks to access the discovery data
> > > and
> > > control areas. Access is a common MMIO area that requires an
> > > index to
> > > be set before access is allowed.
> > > 
> > > Introduce the necessary callbacks to get the discovery, status
> > > and
> > > control information for CRI PMT usage.
> > > 
> > > Add the glue logic to register the CRI PMT functionality.
> > > 
> > > Signed-off-by: Michael J. Ruhl <michael.j.ruhl@intel.com>
> > > ---
> > >  drivers/gpu/drm/xe/xe_vsec.c | 178
> > ++++++++++++++++++++++++++++++++++-
> > >  1 file changed, 174 insertions(+), 4 deletions(-)
> > > 
> > > diff --git a/drivers/gpu/drm/xe/xe_vsec.c
> > > b/drivers/gpu/drm/xe/xe_vsec.c
> > > index a814d7151eea..58eb85fb6a9f 100644
> > > --- a/drivers/gpu/drm/xe/xe_vsec.c
> > > +++ b/drivers/gpu/drm/xe/xe_vsec.c
> > > @@ -4,6 +4,7 @@
> > >  #include <linux/bits.h>
> > >  #include <linux/cleanup.h>
> > >  #include <linux/errno.h>
> > > +#include <linux/log2.h>
> > >  #include <linux/intel_vsec.h>
> > >  #include <linux/module.h>
> > >  #include <linux/mutex.h>
> > > @@ -344,10 +345,15 @@ int xe_pmt_telem_read(struct device *dev,
> > > u32
> > guid, u64 *data, loff_t user_offse
> > >  	}
> > > 
> > >  	scoped_guard(mutex, &xe->pmt.lock) {
> > > +		u32 device_id = FIELD_GET(GUID_DEVICE_ID, guid);
> > > +
> > >  		/* set SoC re-mapper index register based on
> > > GUID memory
> > region */
> > >  		xe->soc_remapper.set_telem_region(xe,
> > > mem_region);
> > > 
> > >  		memcpy_fromio(data, telem_addr, count);
> > > +
> > > +		if (device_id == CRI_DEVICE_ID)
> > > +			xe->soc_remapper.set_telem_region(xe,
> > CRI_IDX_TELEM_DISCOVERY);
> > >  	}
> > > 
> > >  	xe_pm_runtime_put(xe);
> > > @@ -358,20 +364,178 @@ int xe_pmt_telem_read(struct device *dev,
> > > u32
> > guid, u64 *data, loff_t user_offse
> > >  	return ret == 0 ? count : ret;
> > >  }
> > > 
> > > -static struct pmt_callbacks xe_pmt_cb = {
> > > +/**
> > > + * xe_pmt_discovery_read - Given a device and an index, read
> > > discovery data
> > into a buffer
> > > + * @dev: valid Xe device
> > > + * @cap_id: PMT type
> > > + * @element: element to access
> > > + * @disc_data: buffer for discovery data
> > > + * @count: bytes to read
> > 
> > count doesn't exist below...
> 
> Yeah, already cleaned up. 😊
> 
> > > + *
> > > + * This is a callback API.  I.e this can be accessed external to
> > > the XE driver
> > > + * (PMT driver scope).  Because of this, DRM hotplug needs to be
> > > verified
> > > + * (drm_dev_enter()).
> > > + *
> > > + * Return:
> > > + * * -ENODEV device is not available (hotplug)
> > > + * * -EINVAL for unsupported device or PMT feature
> > > + * * 0 on success
> > > + */
> > > +static int xe_pmt_discovery_read(struct device *dev, unsigned
> > > long cap_id,
> > u32 element,
> > > +				 u32 *disc_data)
> > > +{
> > > +	struct xe_device *xe = kdev_to_xe_device(dev);
> > > +	void __iomem *disc_addr = xe->mmio.regs;
> > > +	struct intel_vsec_header *headers;
> > > +	int ret = 0;
> > > +	u32 offset;
> > > +	int idx;
> > > +
> > > +	if (!drm_dev_enter(&xe->drm, &idx))
> > > +		return -ENODEV;
> > > +
> > > +	if (xe->info.platform != XE_CRESCENTISLAND) {
> > > +		ret = -EINVAL;
> > > +		goto dev_exit;
> > > +	}
> > > +
> > > +	switch (cap_id) {
> > > +	case ilog2(VSEC_CAP_TELEMETRY):
> > > +		headers = &cri_telemetry;
> > > +		break;
> > > +
> > > +	case ilog2(VSEC_CAP_CRASHLOG):
> > > +		headers = &cri_crashlog;
> > > +		break;
> > > +
> > > +	default:
> > > +		ret = -EINVAL;
> > > +		goto dev_exit;
> > > +	}
> > > +
> > > +	offset = element * (headers->entry_size * sizeof(u32));
> > > +	disc_addr += headers->offset + offset;
> > > +
> > > +	scoped_guard(mutex, &xe->pmt.lock) {
> > > +		xe->soc_remapper.set_telem_region(xe,
> > CRI_IDX_TELEM_DISCOVERY);
> > > +		memcpy_fromio(disc_data, disc_addr,
> > > PMT_DISC_DWORDS *
> > sizeof(u32));
> > > +	}
> > 
> > we probably need rpm get/put here, no?!
> 
> In the non late-binding probe path, runtime is already in place.
> For the late-binding path, the runtime_get happens when the work item
> is queued and released
> when the registration is complete.

no possible corner case like late probe of intel_pmt itself?

in general we should always do rpm get/put around mmio/mem access to be
on the safe side.

> 
> M
> 
> > > +
> > > +dev_exit:
> > > +	drm_dev_exit(idx);
> > > +
> > > +	return ret;
> > > +}
> > > +
> > > +/**
> > > + * xe_pmt_read_reg() - read a crashlog register
> > > + * @dev: the xe device that registered the callback
> > > + * @guid: PMT guid of the crashlog instance
> > > + * @reg: data read from the PMT data structure
> > > + * @offset: which data to read from the PMT data structure
> > > + *
> > > + * Read the requested PMT register based on the pcie device and
> > > guid.  The
> > > + * supported struct is the Crashlog Type1 Version2.
> > > + *
> > > + * Currently this is for CRI only.
> > > + *
> > > + * Return:
> > > + * * -ENODEV device is not available (hotplug)
> > > + * * -EINVAL invalid guid
> > > + * * 0       success
> > > + */
> > > +static int xe_pmt_read_reg(struct device *dev, u32 guid, u32
> > > *reg, u32
> > offset)
> > > +{
> > > +	struct xe_device *xe = kdev_to_xe_device(dev);
> > > +	void __iomem *disc_addr = xe->mmio.regs + xe-
> > > >pmt.base_offset;
> > > +	int ret = 0;
> > > +	u32 inst;
> > > +	int idx;
> > > +
> > > +	if (FIELD_GET(GUID_DEVICE_ID, guid) != CRI_DEVICE_ID ||
> > > +	    FIELD_GET(GUID_CAP_TYPE, guid) != CRASHLOG)
> > > +		return -EINVAL;
> > > +
> > > +	if (!drm_dev_enter(&xe->drm, &idx))
> > > +		return -ENODEV;
> > > +
> > > +	inst = FIELD_GET(GUID_RECORD_ID, guid) == PUNIT ?
> > > +		CRI_CRASHLOG_PUNIT_DISC_OFFSET :
> > CRI_CRASHLOG_OOBMSM_DISC_OFFSET;
> > > +	disc_addr += inst + offset;
> > > +
> > > +	xe_pm_runtime_get(xe);
> > > +
> > > +	scoped_guard(mutex, &xe->pmt.lock) {
> > > +		xe->soc_remapper.set_telem_region(xe,
> > CRI_IDX_TELEM_DISCOVERY);
> > > +
> > > +		*reg = readl(disc_addr);
> > > +	}
> > > +
> > > +	xe_pm_runtime_put(xe);
> > > +
> > > +	drm_dev_exit(idx);
> > > +
> > > +	return ret;
> > > +}
> > > +
> > > +static int xe_pmt_write_reg(struct device *dev, u32 guid, u32
> > > reg, u32
> > offset)
> > > +{
> > > +	struct xe_device *xe = kdev_to_xe_device(dev);
> > > +	void __iomem *disc_addr = xe->mmio.regs + xe-
> > > >pmt.base_offset;
> > > +	int ret = 0;
> > > +	u32 inst;
> > > +	int idx;
> > > +
> > > +	if (FIELD_GET(GUID_DEVICE_ID, guid) != CRI_DEVICE_ID ||
> > > +	    FIELD_GET(GUID_CAP_TYPE, guid) != CRASHLOG)
> > > +		return -EINVAL;
> > > +
> > > +	if (!drm_dev_enter(&xe->drm, &idx))
> > > +		return -ENODEV;
> > > +
> > > +	inst = FIELD_GET(GUID_RECORD_ID, guid) == PUNIT ?
> > > +		CRI_CRASHLOG_PUNIT_DISC_OFFSET :
> > CRI_CRASHLOG_OOBMSM_DISC_OFFSET;
> > > +	disc_addr += inst + offset;
> > > +
> > > +	xe_pm_runtime_get(xe);
> > > +
> > > +	scoped_guard(mutex, &xe->pmt.lock) {
> > > +		xe->soc_remapper.set_telem_region(xe,
> > CRI_IDX_TELEM_DISCOVERY);
> > > +
> > > +		writel(reg, disc_addr);
> > > +	}
> > > +
> > > +	xe_pm_runtime_put(xe);
> > > +
> > > +	drm_dev_exit(idx);
> > > +
> > > +	return ret;
> > > +}
> > > +
> > > +static struct pmt_callbacks xe_bmg_pmt_cb = {
> > >  	.read_telem = xe_pmt_telem_read,
> > >  };
> > > 
> > > +static struct pmt_callbacks xe_cri_pmt_cb = {
> > > +	.read_telem = xe_pmt_telem_read,
> > > +	.read_discovery = xe_pmt_discovery_read,
> > > +	.read_reg = xe_pmt_read_reg,
> > > +	.write_reg = xe_pmt_write_reg,
> > > +};
> > > +
> > >  static const int vsec_platforms[] = {
> > >  	[XE_BATTLEMAGE] = XE_VSEC_BMG,
> > > +	[XE_CRESCENTISLAND] = XE_VSEC_CRI,
> > >  };
> > > 
> > >  static enum xe_vsec get_platform_info(struct xe_device *xe)
> > >  {
> > > -	if (xe->info.platform > XE_BATTLEMAGE)
> > > +	if (xe->info.platform > XE_CRESCENTISLAND)
> > >  		return XE_VSEC_UNKNOWN;
> > > 
> > > -	if (IS_SRIOV_VF(xe) && xe->info.platform ==
> > > XE_BATTLEMAGE)
> > > +	if (IS_SRIOV_VF(xe) &&
> > > +	    (xe->info.platform == XE_BATTLEMAGE ||
> > > +	     xe->info.platform == XE_CRESCENTISLAND))
> > >  		return XE_VSEC_UNKNOWN;
> > > 
> > >  	return vsec_platforms[xe->info.platform];
> > > @@ -399,8 +563,14 @@ void xe_vsec_init(struct xe_device *xe)
> > >  	switch (platform) {
> > >  	case XE_VSEC_BMG:
> > >  		xe->pmt.base_offset = BMG_TELEMETRY_OFFSET;
> > > -		info->priv_data = &xe_pmt_cb;
> > > +		info->priv_data = &xe_bmg_pmt_cb;
> > >  		break;
> > > +
> > > +	case XE_VSEC_CRI:
> > > +		xe->pmt.base_offset = CRI_PMT_OFFSET;
> > > +		info->priv_data = &xe_cri_pmt_cb;
> > > +		break;
> > > +
> > >  	default:
> > >  		break;
> > >  	}
> > > --
> > > 2.43.0
> > > 

^ permalink raw reply	[flat|nested] 30+ messages in thread

* RE: [PATCH v19 14/19] drm/xe/vsec: Crescent Island PMT callbacks
  2026-11-19 21:55       ` Vivi, Rodrigo
@ 2026-11-20 14:23         ` Ruhl, Michael J
  2026-11-20 15:33           ` Vivi, Rodrigo
  0 siblings, 1 reply; 30+ messages in thread
From: Ruhl, Michael J @ 2026-11-20 14:23 UTC (permalink / raw)
  To: Vivi, Rodrigo
  Cc: intel-xe@lists.freedesktop.org, hansg@kernel.org,
	david.e.box@linux.intel.com, simona@ffwll.ch,
	ilpo.jarvinen@linux.intel.com, Roper, Matthew D, Brost, Matthew,
	airlied@gmail.com, thomas.hellstrom@linux.intel.com,
	Vijay, Anoop C, Ausmus, James, Nilawar, Badal,
	platform-driver-x86@vger.kernel.org



>-----Original Message-----
>From: Vivi, Rodrigo <rodrigo.vivi@intel.com>
>Sent: Thursday, November 19, 2026 4:55 PM
>To: Ruhl, Michael J <michael.j.ruhl@intel.com>
>Cc: intel-xe@lists.freedesktop.org; hansg@kernel.org;
>david.e.box@linux.intel.com; simona@ffwll.ch; ilpo.jarvinen@linux.intel.com;
>Roper, Matthew D <matthew.d.roper@intel.com>; Brost, Matthew
><matthew.brost@intel.com>; airlied@gmail.com;
>thomas.hellstrom@linux.intel.com; Vijay, Anoop C <anoop.c.vijay@intel.com>;
>Ausmus, James <james.ausmus@intel.com>; Nilawar, Badal
><badal.nilawar@intel.com>; platform-driver-x86@vger.kernel.org
>Subject: Re: [PATCH v19 14/19] drm/xe/vsec: Crescent Island PMT callbacks
>
>On Thu, 2026-11-19 at 21:41 +0000, Ruhl, Michael J wrote:
>> > -----Original Message-----
>> > From: Vivi, Rodrigo <rodrigo.vivi@intel.com>
>> > Sent: Thursday, November 19, 2026 4:05 PM
>> > To: Ruhl, Michael J <michael.j.ruhl@intel.com>
>> > Cc: platform-driver-x86@vger.kernel.org;
>> > intel-xe@lists.freedesktop.org;
>> > hansg@kernel.org; ilpo.jarvinen@linux.intel.com; Brost, Matthew
>> > <matthew.brost@intel.com>; thomas.hellstrom@linux.intel.com;
>> > airlied@gmail.com; simona@ffwll.ch; david.e.box@linux.intel.com;
>> > Vijay,
>> > Anoop C <anoop.c.vijay@intel.com>; Nilawar, Badal
>> > <badal.nilawar@intel.com>; Roper, Matthew D
>> > <matthew.d.roper@intel.com>;
>> > Ausmus, James <james.ausmus@intel.com>
>> > Subject: Re: [PATCH v19 14/19] drm/xe/vsec: Crescent Island PMT
>> > callbacks
>> >
>> > On Thu, Nov 19, 2026 at 07:54:52AM -0800, Michael J. Ruhl wrote:
>> > > CRI PMT support requires callbacks to access the discovery data
>> > > and
>> > > control areas. Access is a common MMIO area that requires an
>> > > index to
>> > > be set before access is allowed.
>> > >
>> > > Introduce the necessary callbacks to get the discovery, status
>> > > and
>> > > control information for CRI PMT usage.
>> > >
>> > > Add the glue logic to register the CRI PMT functionality.
>> > >
>> > > Signed-off-by: Michael J. Ruhl <michael.j.ruhl@intel.com>
>> > > ---
>> > >  drivers/gpu/drm/xe/xe_vsec.c | 178
>> > ++++++++++++++++++++++++++++++++++-
>> > >  1 file changed, 174 insertions(+), 4 deletions(-)
>> > >
>> > > diff --git a/drivers/gpu/drm/xe/xe_vsec.c
>> > > b/drivers/gpu/drm/xe/xe_vsec.c
>> > > index a814d7151eea..58eb85fb6a9f 100644
>> > > --- a/drivers/gpu/drm/xe/xe_vsec.c
>> > > +++ b/drivers/gpu/drm/xe/xe_vsec.c
>> > > @@ -4,6 +4,7 @@
>> > >  #include <linux/bits.h>
>> > >  #include <linux/cleanup.h>
>> > >  #include <linux/errno.h>
>> > > +#include <linux/log2.h>
>> > >  #include <linux/intel_vsec.h>
>> > >  #include <linux/module.h>
>> > >  #include <linux/mutex.h>
>> > > @@ -344,10 +345,15 @@ int xe_pmt_telem_read(struct device *dev,
>> > > u32
>> > guid, u64 *data, loff_t user_offse
>> > >  	}
>> > >
>> > >  	scoped_guard(mutex, &xe->pmt.lock) {
>> > > +		u32 device_id = FIELD_GET(GUID_DEVICE_ID, guid);
>> > > +
>> > >  		/* set SoC re-mapper index register based on
>> > > GUID memory
>> > region */
>> > >  		xe->soc_remapper.set_telem_region(xe,
>> > > mem_region);
>> > >
>> > >  		memcpy_fromio(data, telem_addr, count);
>> > > +
>> > > +		if (device_id == CRI_DEVICE_ID)
>> > > +			xe->soc_remapper.set_telem_region(xe,
>> > CRI_IDX_TELEM_DISCOVERY);
>> > >  	}
>> > >
>> > >  	xe_pm_runtime_put(xe);
>> > > @@ -358,20 +364,178 @@ int xe_pmt_telem_read(struct device *dev,
>> > > u32
>> > guid, u64 *data, loff_t user_offse
>> > >  	return ret == 0 ? count : ret;
>> > >  }
>> > >
>> > > -static struct pmt_callbacks xe_pmt_cb = {
>> > > +/**
>> > > + * xe_pmt_discovery_read - Given a device and an index, read
>> > > discovery data
>> > into a buffer
>> > > + * @dev: valid Xe device
>> > > + * @cap_id: PMT type
>> > > + * @element: element to access
>> > > + * @disc_data: buffer for discovery data
>> > > + * @count: bytes to read
>> >
>> > count doesn't exist below...
>>
>> Yeah, already cleaned up. 😊
>>
>> > > + *
>> > > + * This is a callback API.  I.e this can be accessed external to
>> > > the XE driver
>> > > + * (PMT driver scope).  Because of this, DRM hotplug needs to be
>> > > verified
>> > > + * (drm_dev_enter()).
>> > > + *
>> > > + * Return:
>> > > + * * -ENODEV device is not available (hotplug)
>> > > + * * -EINVAL for unsupported device or PMT feature
>> > > + * * 0 on success
>> > > + */
>> > > +static int xe_pmt_discovery_read(struct device *dev, unsigned
>> > > long cap_id,
>> > u32 element,
>> > > +				 u32 *disc_data)
>> > > +{
>> > > +	struct xe_device *xe = kdev_to_xe_device(dev);
>> > > +	void __iomem *disc_addr = xe->mmio.regs;
>> > > +	struct intel_vsec_header *headers;
>> > > +	int ret = 0;
>> > > +	u32 offset;
>> > > +	int idx;
>> > > +
>> > > +	if (!drm_dev_enter(&xe->drm, &idx))
>> > > +		return -ENODEV;
>> > > +
>> > > +	if (xe->info.platform != XE_CRESCENTISLAND) {
>> > > +		ret = -EINVAL;
>> > > +		goto dev_exit;
>> > > +	}
>> > > +
>> > > +	switch (cap_id) {
>> > > +	case ilog2(VSEC_CAP_TELEMETRY):
>> > > +		headers = &cri_telemetry;
>> > > +		break;
>> > > +
>> > > +	case ilog2(VSEC_CAP_CRASHLOG):
>> > > +		headers = &cri_crashlog;
>> > > +		break;
>> > > +
>> > > +	default:
>> > > +		ret = -EINVAL;
>> > > +		goto dev_exit;
>> > > +	}
>> > > +
>> > > +	offset = element * (headers->entry_size * sizeof(u32));
>> > > +	disc_addr += headers->offset + offset;
>> > > +
>> > > +	scoped_guard(mutex, &xe->pmt.lock) {
>> > > +		xe->soc_remapper.set_telem_region(xe,
>> > CRI_IDX_TELEM_DISCOVERY);
>> > > +		memcpy_fromio(disc_data, disc_addr,
>> > > PMT_DISC_DWORDS *
>> > sizeof(u32));
>> > > +	}
>> >
>> > we probably need rpm get/put here, no?!
>>
>> In the non late-binding probe path, runtime is already in place.
>> For the late-binding path, the runtime_get happens when the work item
>> is queued and released
>> when the registration is complete.
>
>no possible corner case like late probe of intel_pmt itself?
>
>in general we should always do rpm get/put around mmio/mem access to be
>on the safe side.

This sequence has three entry points:

device probe
device probe survivability

late-binding

If the device is not on, the probe path will have other issues....

late-binding the reference has been taken.

So the assumption is that we have power... if we get to this point and don't have
power, I think that that is an error state.

How about:

check for power
exit with error if power is not on

?

m

>>
>> M
>>
>> > > +
>> > > +dev_exit:
>> > > +	drm_dev_exit(idx);
>> > > +
>> > > +	return ret;
>> > > +}
>> > > +
>> > > +/**
>> > > + * xe_pmt_read_reg() - read a crashlog register
>> > > + * @dev: the xe device that registered the callback
>> > > + * @guid: PMT guid of the crashlog instance
>> > > + * @reg: data read from the PMT data structure
>> > > + * @offset: which data to read from the PMT data structure
>> > > + *
>> > > + * Read the requested PMT register based on the pcie device and
>> > > guid.  The
>> > > + * supported struct is the Crashlog Type1 Version2.
>> > > + *
>> > > + * Currently this is for CRI only.
>> > > + *
>> > > + * Return:
>> > > + * * -ENODEV device is not available (hotplug)
>> > > + * * -EINVAL invalid guid
>> > > + * * 0       success
>> > > + */
>> > > +static int xe_pmt_read_reg(struct device *dev, u32 guid, u32
>> > > *reg, u32
>> > offset)
>> > > +{
>> > > +	struct xe_device *xe = kdev_to_xe_device(dev);
>> > > +	void __iomem *disc_addr = xe->mmio.regs + xe-
>> > > >pmt.base_offset;
>> > > +	int ret = 0;
>> > > +	u32 inst;
>> > > +	int idx;
>> > > +
>> > > +	if (FIELD_GET(GUID_DEVICE_ID, guid) != CRI_DEVICE_ID ||
>> > > +	    FIELD_GET(GUID_CAP_TYPE, guid) != CRASHLOG)
>> > > +		return -EINVAL;
>> > > +
>> > > +	if (!drm_dev_enter(&xe->drm, &idx))
>> > > +		return -ENODEV;
>> > > +
>> > > +	inst = FIELD_GET(GUID_RECORD_ID, guid) == PUNIT ?
>> > > +		CRI_CRASHLOG_PUNIT_DISC_OFFSET :
>> > CRI_CRASHLOG_OOBMSM_DISC_OFFSET;
>> > > +	disc_addr += inst + offset;
>> > > +
>> > > +	xe_pm_runtime_get(xe);
>> > > +
>> > > +	scoped_guard(mutex, &xe->pmt.lock) {
>> > > +		xe->soc_remapper.set_telem_region(xe,
>> > CRI_IDX_TELEM_DISCOVERY);
>> > > +
>> > > +		*reg = readl(disc_addr);
>> > > +	}
>> > > +
>> > > +	xe_pm_runtime_put(xe);
>> > > +
>> > > +	drm_dev_exit(idx);
>> > > +
>> > > +	return ret;
>> > > +}
>> > > +
>> > > +static int xe_pmt_write_reg(struct device *dev, u32 guid, u32
>> > > reg, u32
>> > offset)
>> > > +{
>> > > +	struct xe_device *xe = kdev_to_xe_device(dev);
>> > > +	void __iomem *disc_addr = xe->mmio.regs + xe-
>> > > >pmt.base_offset;
>> > > +	int ret = 0;
>> > > +	u32 inst;
>> > > +	int idx;
>> > > +
>> > > +	if (FIELD_GET(GUID_DEVICE_ID, guid) != CRI_DEVICE_ID ||
>> > > +	    FIELD_GET(GUID_CAP_TYPE, guid) != CRASHLOG)
>> > > +		return -EINVAL;
>> > > +
>> > > +	if (!drm_dev_enter(&xe->drm, &idx))
>> > > +		return -ENODEV;
>> > > +
>> > > +	inst = FIELD_GET(GUID_RECORD_ID, guid) == PUNIT ?
>> > > +		CRI_CRASHLOG_PUNIT_DISC_OFFSET :
>> > CRI_CRASHLOG_OOBMSM_DISC_OFFSET;
>> > > +	disc_addr += inst + offset;
>> > > +
>> > > +	xe_pm_runtime_get(xe);
>> > > +
>> > > +	scoped_guard(mutex, &xe->pmt.lock) {
>> > > +		xe->soc_remapper.set_telem_region(xe,
>> > CRI_IDX_TELEM_DISCOVERY);
>> > > +
>> > > +		writel(reg, disc_addr);
>> > > +	}
>> > > +
>> > > +	xe_pm_runtime_put(xe);
>> > > +
>> > > +	drm_dev_exit(idx);
>> > > +
>> > > +	return ret;
>> > > +}
>> > > +
>> > > +static struct pmt_callbacks xe_bmg_pmt_cb = {
>> > >  	.read_telem = xe_pmt_telem_read,
>> > >  };
>> > >
>> > > +static struct pmt_callbacks xe_cri_pmt_cb = {
>> > > +	.read_telem = xe_pmt_telem_read,
>> > > +	.read_discovery = xe_pmt_discovery_read,
>> > > +	.read_reg = xe_pmt_read_reg,
>> > > +	.write_reg = xe_pmt_write_reg,
>> > > +};
>> > > +
>> > >  static const int vsec_platforms[] = {
>> > >  	[XE_BATTLEMAGE] = XE_VSEC_BMG,
>> > > +	[XE_CRESCENTISLAND] = XE_VSEC_CRI,
>> > >  };
>> > >
>> > >  static enum xe_vsec get_platform_info(struct xe_device *xe)
>> > >  {
>> > > -	if (xe->info.platform > XE_BATTLEMAGE)
>> > > +	if (xe->info.platform > XE_CRESCENTISLAND)
>> > >  		return XE_VSEC_UNKNOWN;
>> > >
>> > > -	if (IS_SRIOV_VF(xe) && xe->info.platform ==
>> > > XE_BATTLEMAGE)
>> > > +	if (IS_SRIOV_VF(xe) &&
>> > > +	    (xe->info.platform == XE_BATTLEMAGE ||
>> > > +	     xe->info.platform == XE_CRESCENTISLAND))
>> > >  		return XE_VSEC_UNKNOWN;
>> > >
>> > >  	return vsec_platforms[xe->info.platform];
>> > > @@ -399,8 +563,14 @@ void xe_vsec_init(struct xe_device *xe)
>> > >  	switch (platform) {
>> > >  	case XE_VSEC_BMG:
>> > >  		xe->pmt.base_offset = BMG_TELEMETRY_OFFSET;
>> > > -		info->priv_data = &xe_pmt_cb;
>> > > +		info->priv_data = &xe_bmg_pmt_cb;
>> > >  		break;
>> > > +
>> > > +	case XE_VSEC_CRI:
>> > > +		xe->pmt.base_offset = CRI_PMT_OFFSET;
>> > > +		info->priv_data = &xe_cri_pmt_cb;
>> > > +		break;
>> > > +
>> > >  	default:
>> > >  		break;
>> > >  	}
>> > > --
>> > > 2.43.0
>> > >

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: [PATCH v19 14/19] drm/xe/vsec: Crescent Island PMT callbacks
  2026-11-20 14:23         ` Ruhl, Michael J
@ 2026-11-20 15:33           ` Vivi, Rodrigo
  0 siblings, 0 replies; 30+ messages in thread
From: Vivi, Rodrigo @ 2026-11-20 15:33 UTC (permalink / raw)
  To: Ruhl, Michael J
  Cc: intel-xe@lists.freedesktop.org, hansg@kernel.org,
	david.e.box@linux.intel.com, simona@ffwll.ch,
	ilpo.jarvinen@linux.intel.com, Roper, Matthew D, Brost, Matthew,
	airlied@gmail.com, thomas.hellstrom@linux.intel.com,
	Vijay, Anoop C, Ausmus, James, Nilawar, Badal,
	platform-driver-x86@vger.kernel.org

On Fri, 2026-11-20 at 14:23 +0000, Ruhl, Michael J wrote:
> 
> 
> > -----Original Message-----
> > From: Vivi, Rodrigo <rodrigo.vivi@intel.com>
> > Sent: Thursday, November 19, 2026 4:55 PM
> > To: Ruhl, Michael J <michael.j.ruhl@intel.com>
> > Cc: intel-xe@lists.freedesktop.org; hansg@kernel.org;
> > david.e.box@linux.intel.com; simona@ffwll.ch;
> > ilpo.jarvinen@linux.intel.com;
> > Roper, Matthew D <matthew.d.roper@intel.com>; Brost, Matthew
> > <matthew.brost@intel.com>; airlied@gmail.com;
> > thomas.hellstrom@linux.intel.com; Vijay, Anoop C
> > <anoop.c.vijay@intel.com>;
> > Ausmus, James <james.ausmus@intel.com>; Nilawar, Badal
> > <badal.nilawar@intel.com>; platform-driver-x86@vger.kernel.org
> > Subject: Re: [PATCH v19 14/19] drm/xe/vsec: Crescent Island PMT
> > callbacks
> > 
> > On Thu, 2026-11-19 at 21:41 +0000, Ruhl, Michael J wrote:
> > > > -----Original Message-----
> > > > From: Vivi, Rodrigo <rodrigo.vivi@intel.com>
> > > > Sent: Thursday, November 19, 2026 4:05 PM
> > > > To: Ruhl, Michael J <michael.j.ruhl@intel.com>
> > > > Cc: platform-driver-x86@vger.kernel.org;
> > > > intel-xe@lists.freedesktop.org;
> > > > hansg@kernel.org; ilpo.jarvinen@linux.intel.com; Brost, Matthew
> > > > <matthew.brost@intel.com>; thomas.hellstrom@linux.intel.com;
> > > > airlied@gmail.com; simona@ffwll.ch;
> > > > david.e.box@linux.intel.com;
> > > > Vijay,
> > > > Anoop C <anoop.c.vijay@intel.com>; Nilawar, Badal
> > > > <badal.nilawar@intel.com>; Roper, Matthew D
> > > > <matthew.d.roper@intel.com>;
> > > > Ausmus, James <james.ausmus@intel.com>
> > > > Subject: Re: [PATCH v19 14/19] drm/xe/vsec: Crescent Island PMT
> > > > callbacks
> > > > 
> > > > On Thu, Nov 19, 2026 at 07:54:52AM -0800, Michael J. Ruhl
> > > > wrote:
> > > > > CRI PMT support requires callbacks to access the discovery
> > > > > data
> > > > > and
> > > > > control areas. Access is a common MMIO area that requires an
> > > > > index to
> > > > > be set before access is allowed.
> > > > > 
> > > > > Introduce the necessary callbacks to get the discovery,
> > > > > status
> > > > > and
> > > > > control information for CRI PMT usage.
> > > > > 
> > > > > Add the glue logic to register the CRI PMT functionality.
> > > > > 
> > > > > Signed-off-by: Michael J. Ruhl <michael.j.ruhl@intel.com>
> > > > > ---
> > > > >  drivers/gpu/drm/xe/xe_vsec.c | 178
> > > > ++++++++++++++++++++++++++++++++++-
> > > > >  1 file changed, 174 insertions(+), 4 deletions(-)
> > > > > 
> > > > > diff --git a/drivers/gpu/drm/xe/xe_vsec.c
> > > > > b/drivers/gpu/drm/xe/xe_vsec.c
> > > > > index a814d7151eea..58eb85fb6a9f 100644
> > > > > --- a/drivers/gpu/drm/xe/xe_vsec.c
> > > > > +++ b/drivers/gpu/drm/xe/xe_vsec.c
> > > > > @@ -4,6 +4,7 @@
> > > > >  #include <linux/bits.h>
> > > > >  #include <linux/cleanup.h>
> > > > >  #include <linux/errno.h>
> > > > > +#include <linux/log2.h>
> > > > >  #include <linux/intel_vsec.h>
> > > > >  #include <linux/module.h>
> > > > >  #include <linux/mutex.h>
> > > > > @@ -344,10 +345,15 @@ int xe_pmt_telem_read(struct device
> > > > > *dev,
> > > > > u32
> > > > guid, u64 *data, loff_t user_offse
> > > > >  	}
> > > > > 
> > > > >  	scoped_guard(mutex, &xe->pmt.lock) {
> > > > > +		u32 device_id = FIELD_GET(GUID_DEVICE_ID,
> > > > > guid);
> > > > > +
> > > > >  		/* set SoC re-mapper index register based on
> > > > > GUID memory
> > > > region */
> > > > >  		xe->soc_remapper.set_telem_region(xe,
> > > > > mem_region);
> > > > > 
> > > > >  		memcpy_fromio(data, telem_addr, count);
> > > > > +
> > > > > +		if (device_id == CRI_DEVICE_ID)
> > > > > +			xe-
> > > > > >soc_remapper.set_telem_region(xe,
> > > > CRI_IDX_TELEM_DISCOVERY);
> > > > >  	}
> > > > > 
> > > > >  	xe_pm_runtime_put(xe);
> > > > > @@ -358,20 +364,178 @@ int xe_pmt_telem_read(struct device
> > > > > *dev,
> > > > > u32
> > > > guid, u64 *data, loff_t user_offse
> > > > >  	return ret == 0 ? count : ret;
> > > > >  }
> > > > > 
> > > > > -static struct pmt_callbacks xe_pmt_cb = {
> > > > > +/**
> > > > > + * xe_pmt_discovery_read - Given a device and an index, read
> > > > > discovery data
> > > > into a buffer
> > > > > + * @dev: valid Xe device
> > > > > + * @cap_id: PMT type
> > > > > + * @element: element to access
> > > > > + * @disc_data: buffer for discovery data
> > > > > + * @count: bytes to read
> > > > 
> > > > count doesn't exist below...
> > > 
> > > Yeah, already cleaned up. 😊
> > > 
> > > > > + *
> > > > > + * This is a callback API.  I.e this can be accessed
> > > > > external to
> > > > > the XE driver
> > > > > + * (PMT driver scope).  Because of this, DRM hotplug needs
> > > > > to be
> > > > > verified
> > > > > + * (drm_dev_enter()).
> > > > > + *
> > > > > + * Return:
> > > > > + * * -ENODEV device is not available (hotplug)
> > > > > + * * -EINVAL for unsupported device or PMT feature
> > > > > + * * 0 on success
> > > > > + */
> > > > > +static int xe_pmt_discovery_read(struct device *dev,
> > > > > unsigned
> > > > > long cap_id,
> > > > u32 element,
> > > > > +				 u32 *disc_data)
> > > > > +{
> > > > > +	struct xe_device *xe = kdev_to_xe_device(dev);
> > > > > +	void __iomem *disc_addr = xe->mmio.regs;
> > > > > +	struct intel_vsec_header *headers;
> > > > > +	int ret = 0;
> > > > > +	u32 offset;
> > > > > +	int idx;
> > > > > +
> > > > > +	if (!drm_dev_enter(&xe->drm, &idx))
> > > > > +		return -ENODEV;
> > > > > +
> > > > > +	if (xe->info.platform != XE_CRESCENTISLAND) {
> > > > > +		ret = -EINVAL;
> > > > > +		goto dev_exit;
> > > > > +	}
> > > > > +
> > > > > +	switch (cap_id) {
> > > > > +	case ilog2(VSEC_CAP_TELEMETRY):
> > > > > +		headers = &cri_telemetry;
> > > > > +		break;
> > > > > +
> > > > > +	case ilog2(VSEC_CAP_CRASHLOG):
> > > > > +		headers = &cri_crashlog;
> > > > > +		break;
> > > > > +
> > > > > +	default:
> > > > > +		ret = -EINVAL;
> > > > > +		goto dev_exit;
> > > > > +	}
> > > > > +
> > > > > +	offset = element * (headers->entry_size *
> > > > > sizeof(u32));
> > > > > +	disc_addr += headers->offset + offset;
> > > > > +
> > > > > +	scoped_guard(mutex, &xe->pmt.lock) {
> > > > > +		xe->soc_remapper.set_telem_region(xe,
> > > > CRI_IDX_TELEM_DISCOVERY);
> > > > > +		memcpy_fromio(disc_data, disc_addr,
> > > > > PMT_DISC_DWORDS *
> > > > sizeof(u32));
> > > > > +	}
> > > > 
> > > > we probably need rpm get/put here, no?!
> > > 
> > > In the non late-binding probe path, runtime is already in place.
> > > For the late-binding path, the runtime_get happens when the work
> > > item
> > > is queued and released
> > > when the registration is complete.
> > 
> > no possible corner case like late probe of intel_pmt itself?
> > 
> > in general we should always do rpm get/put around mmio/mem access
> > to be
> > on the safe side.
> 
> This sequence has three entry points:
> 
> device probe
> device probe survivability
> 
> late-binding
> 
> If the device is not on, the probe path will have other issues....
> 
> late-binding the reference has been taken.
> 
> So the assumption is that we have power... if we get to this point
> and don't have
> power, I think that that is an error state.
> 
> How about:
> 
> check for power
> exit with error if power is not on

great idea

        if (!xe_pm_runtime_get_if_active(xe))
                 return -ENODATA;

...

	xe_pm_runtime_put(xe);

> 
> ?
> 
> m
> 
> > > 
> > > M
> > > 
> > > > > +
> > > > > +dev_exit:
> > > > > +	drm_dev_exit(idx);
> > > > > +
> > > > > +	return ret;
> > > > > +}
> > > > > +
> > > > > +/**
> > > > > + * xe_pmt_read_reg() - read a crashlog register
> > > > > + * @dev: the xe device that registered the callback
> > > > > + * @guid: PMT guid of the crashlog instance
> > > > > + * @reg: data read from the PMT data structure
> > > > > + * @offset: which data to read from the PMT data structure
> > > > > + *
> > > > > + * Read the requested PMT register based on the pcie device
> > > > > and
> > > > > guid.  The
> > > > > + * supported struct is the Crashlog Type1 Version2.
> > > > > + *
> > > > > + * Currently this is for CRI only.
> > > > > + *
> > > > > + * Return:
> > > > > + * * -ENODEV device is not available (hotplug)
> > > > > + * * -EINVAL invalid guid
> > > > > + * * 0       success
> > > > > + */
> > > > > +static int xe_pmt_read_reg(struct device *dev, u32 guid, u32
> > > > > *reg, u32
> > > > offset)
> > > > > +{
> > > > > +	struct xe_device *xe = kdev_to_xe_device(dev);
> > > > > +	void __iomem *disc_addr = xe->mmio.regs + xe-
> > > > > > pmt.base_offset;
> > > > > +	int ret = 0;
> > > > > +	u32 inst;
> > > > > +	int idx;
> > > > > +
> > > > > +	if (FIELD_GET(GUID_DEVICE_ID, guid) != CRI_DEVICE_ID
> > > > > ||
> > > > > +	    FIELD_GET(GUID_CAP_TYPE, guid) != CRASHLOG)
> > > > > +		return -EINVAL;
> > > > > +
> > > > > +	if (!drm_dev_enter(&xe->drm, &idx))
> > > > > +		return -ENODEV;
> > > > > +
> > > > > +	inst = FIELD_GET(GUID_RECORD_ID, guid) == PUNIT ?
> > > > > +		CRI_CRASHLOG_PUNIT_DISC_OFFSET :
> > > > CRI_CRASHLOG_OOBMSM_DISC_OFFSET;
> > > > > +	disc_addr += inst + offset;
> > > > > +
> > > > > +	xe_pm_runtime_get(xe);
> > > > > +
> > > > > +	scoped_guard(mutex, &xe->pmt.lock) {
> > > > > +		xe->soc_remapper.set_telem_region(xe,
> > > > CRI_IDX_TELEM_DISCOVERY);
> > > > > +
> > > > > +		*reg = readl(disc_addr);
> > > > > +	}
> > > > > +
> > > > > +	xe_pm_runtime_put(xe);
> > > > > +
> > > > > +	drm_dev_exit(idx);
> > > > > +
> > > > > +	return ret;
> > > > > +}
> > > > > +
> > > > > +static int xe_pmt_write_reg(struct device *dev, u32 guid,
> > > > > u32
> > > > > reg, u32
> > > > offset)
> > > > > +{
> > > > > +	struct xe_device *xe = kdev_to_xe_device(dev);
> > > > > +	void __iomem *disc_addr = xe->mmio.regs + xe-
> > > > > > pmt.base_offset;
> > > > > +	int ret = 0;
> > > > > +	u32 inst;
> > > > > +	int idx;
> > > > > +
> > > > > +	if (FIELD_GET(GUID_DEVICE_ID, guid) != CRI_DEVICE_ID
> > > > > ||
> > > > > +	    FIELD_GET(GUID_CAP_TYPE, guid) != CRASHLOG)
> > > > > +		return -EINVAL;
> > > > > +
> > > > > +	if (!drm_dev_enter(&xe->drm, &idx))
> > > > > +		return -ENODEV;
> > > > > +
> > > > > +	inst = FIELD_GET(GUID_RECORD_ID, guid) == PUNIT ?
> > > > > +		CRI_CRASHLOG_PUNIT_DISC_OFFSET :
> > > > CRI_CRASHLOG_OOBMSM_DISC_OFFSET;
> > > > > +	disc_addr += inst + offset;
> > > > > +
> > > > > +	xe_pm_runtime_get(xe);
> > > > > +
> > > > > +	scoped_guard(mutex, &xe->pmt.lock) {
> > > > > +		xe->soc_remapper.set_telem_region(xe,
> > > > CRI_IDX_TELEM_DISCOVERY);
> > > > > +
> > > > > +		writel(reg, disc_addr);
> > > > > +	}
> > > > > +
> > > > > +	xe_pm_runtime_put(xe);
> > > > > +
> > > > > +	drm_dev_exit(idx);
> > > > > +
> > > > > +	return ret;
> > > > > +}
> > > > > +
> > > > > +static struct pmt_callbacks xe_bmg_pmt_cb = {
> > > > >  	.read_telem = xe_pmt_telem_read,
> > > > >  };
> > > > > 
> > > > > +static struct pmt_callbacks xe_cri_pmt_cb = {
> > > > > +	.read_telem = xe_pmt_telem_read,
> > > > > +	.read_discovery = xe_pmt_discovery_read,
> > > > > +	.read_reg = xe_pmt_read_reg,
> > > > > +	.write_reg = xe_pmt_write_reg,
> > > > > +};
> > > > > +
> > > > >  static const int vsec_platforms[] = {
> > > > >  	[XE_BATTLEMAGE] = XE_VSEC_BMG,
> > > > > +	[XE_CRESCENTISLAND] = XE_VSEC_CRI,
> > > > >  };
> > > > > 
> > > > >  static enum xe_vsec get_platform_info(struct xe_device *xe)
> > > > >  {
> > > > > -	if (xe->info.platform > XE_BATTLEMAGE)
> > > > > +	if (xe->info.platform > XE_CRESCENTISLAND)
> > > > >  		return XE_VSEC_UNKNOWN;
> > > > > 
> > > > > -	if (IS_SRIOV_VF(xe) && xe->info.platform ==
> > > > > XE_BATTLEMAGE)
> > > > > +	if (IS_SRIOV_VF(xe) &&
> > > > > +	    (xe->info.platform == XE_BATTLEMAGE ||
> > > > > +	     xe->info.platform == XE_CRESCENTISLAND))
> > > > >  		return XE_VSEC_UNKNOWN;
> > > > > 
> > > > >  	return vsec_platforms[xe->info.platform];
> > > > > @@ -399,8 +563,14 @@ void xe_vsec_init(struct xe_device *xe)
> > > > >  	switch (platform) {
> > > > >  	case XE_VSEC_BMG:
> > > > >  		xe->pmt.base_offset = BMG_TELEMETRY_OFFSET;
> > > > > -		info->priv_data = &xe_pmt_cb;
> > > > > +		info->priv_data = &xe_bmg_pmt_cb;
> > > > >  		break;
> > > > > +
> > > > > +	case XE_VSEC_CRI:
> > > > > +		xe->pmt.base_offset = CRI_PMT_OFFSET;
> > > > > +		info->priv_data = &xe_cri_pmt_cb;
> > > > > +		break;
> > > > > +
> > > > >  	default:
> > > > >  		break;
> > > > >  	}
> > > > > --
> > > > > 2.43.0
> > > > > 

^ permalink raw reply	[flat|nested] 30+ messages in thread

end of thread, other threads:[~2026-11-20 15:33 UTC | newest]

Thread overview: 30+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-19 15:54 [PATCH v19 00/19] Crescent Island PMT support Michael J. Ruhl
2026-11-19 15:54 ` [PATCH v19 01/19] platform/x86/intel/pmt: Introduce a callback for discovery data Michael J. Ruhl
2026-11-19 20:06   ` David E. Box
2026-11-19 15:54 ` [PATCH v19 02/19] platform/x86/intel/pmt: Use the pre-populated header info for crashlog Michael J. Ruhl
2026-11-19 20:13   ` David E. Box
2026-11-19 15:54 ` [PATCH v19 03/19] drm/xe/vsec: VSEC requires soc-remapper Michael J. Ruhl
2026-11-19 15:54 ` [PATCH v19 04/19] drm/xe/vsec: Do not register BMG PMT for VF Michael J. Ruhl
2026-11-19 15:54 ` [PATCH v19 05/19] drm/xe/vsec: Correct locking order Michael J. Ruhl
2026-11-19 15:54 ` [PATCH v19 06/19] drm/xe/vsec: Use correct pm state get Michael J. Ruhl
2026-11-19 15:54 ` [PATCH v19 07/19] drm/xe/vsec: Add DOC text for VSEC Michael J. Ruhl
2026-11-19 15:54 ` [PATCH v19 08/19] drm/xe/vsec: Support possible hotplug exit Michael J. Ruhl
2026-11-19 15:54 ` [PATCH v19 09/19] drm/xe/vsec: Refactor BattleMage PMT defines Michael J. Ruhl
2026-11-19 15:54 ` [PATCH v19 10/19] drm/xe/vsec: Update VSEC probe order Michael J. Ruhl
2026-11-19 15:54 ` [PATCH v19 11/19] drm/xe/vsec: Add base_offset to allow for more flexibilty Michael J. Ruhl
2026-11-19 15:54 ` [PATCH v19 12/19] drm/xe/vsec: Support Crescent Island PMT Michael J. Ruhl
2026-11-19 15:54 ` [PATCH v19 13/19] drm/xe/vsec: Crescent Island PMT decode Michael J. Ruhl
2026-11-19 15:54 ` [PATCH v19 14/19] drm/xe/vsec: Crescent Island PMT callbacks Michael J. Ruhl
2026-11-19 21:05   ` Rodrigo Vivi
2026-11-19 21:41     ` Ruhl, Michael J
2026-11-19 21:55       ` Vivi, Rodrigo
2026-11-20 14:23         ` Ruhl, Michael J
2026-11-20 15:33           ` Vivi, Rodrigo
2026-11-19 15:54 ` [PATCH v19 15/19] drm/xe/vsec: Support late bind fw information Michael J. Ruhl
2026-11-19 15:54 ` [PATCH v19 16/19] drm/xe/vsec: Add PMT GUID internal access Michael J. Ruhl
2026-11-19 15:54 ` [PATCH v19 17/19] drm/xe/vsec: Update PMT " Michael J. Ruhl
2026-11-19 15:54 ` [PATCH v19 18/19] drm/xe/vsec: Refactor platform check Michael J. Ruhl
2026-11-19 15:54 ` [PATCH v19 19/19] drm/xe/vsec: Support survivability mode for CRI Michael J. Ruhl
2026-11-19 20:11 ` ✗ CI.checkpatch: warning for Crescent Island PMT support (rev20) Patchwork
2026-11-19 20:13 ` ✓ CI.KUnit: success " Patchwork
2026-11-19 20:55 ` ✓ Xe.CI.BAT: " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.