From: Patrick Steinhardt <ps@pks.im>
To: Farid Zakaria <farid.m.zakaria@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Jeff King <peff@peff.net>, M Hickford <mirth.hickford@gmail.com>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Jeff Hostetler <jeffhostetler@github.com>
Subject: Re: [PATCH v2 1/3] credential-cache--daemon: do not apply core.sharedRepository
Date: Mon, 9 Nov 2026 08:55:05 +0100 [thread overview]
Message-ID: <avF8WVT1W4o27CzG@pks.im> (raw)
In-Reply-To: <20261104-fz-credential-cache-race-v2-1-ddccd0831eba@gmail.com>
On Wed, Nov 04, 2026 at 11:53:14AM -0800, Farid Zakaria wrote:
> init_socket_directory() creates the leading directories of the socket
> path with safe_create_leading_directories_const(). That function
> honors "core.sharedRepository", which is meant for files inside the
> git directory. The socket lives in the user's home directory, e.g.
> "~/.cache/git/credential", and the repository the daemon happens to be
> started from has no say over its permissions.
>
> Use safe_create_leading_directories_no_share_const() instead, which
> ignores "core.sharedRepository".
Yup, makes sense, and the patch is obviously correct.
Patrick
next prev parent reply other threads:[~2026-11-09 7:55 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-01 23:29 [PATCH 0/2] credential-cache: fix two races when daemons start at once Farid Zakaria
2026-11-01 23:29 ` [PATCH 1/2] credential-cache--daemon: allow a concurrently created socket dir Farid Zakaria
2026-11-03 8:01 ` Patrick Steinhardt
2026-11-04 18:25 ` Farid Zakaria
2026-11-04 2:58 ` Jeff King
2026-11-01 23:29 ` [PATCH 2/2] credential-cache--daemon: do not take over a running daemon's socket Farid Zakaria
2026-11-03 8:01 ` Patrick Steinhardt
2026-11-04 18:28 ` Farid Zakaria
2026-11-03 17:24 ` Junio C Hamano
2026-11-04 3:07 ` Jeff King
2026-11-04 19:53 ` [PATCH v2 0/3] credential-cache: fix two races when daemons start at once Farid Zakaria
2026-11-04 19:53 ` [PATCH v2 1/3] credential-cache--daemon: do not apply core.sharedRepository Farid Zakaria
2026-11-09 7:55 ` Patrick Steinhardt [this message]
2026-11-04 19:53 ` [PATCH v2 2/3] credential-cache--daemon: allow a concurrently created socket dir Farid Zakaria
2026-11-09 7:55 ` Patrick Steinhardt
2026-11-04 19:53 ` [PATCH v2 3/3] credential-cache--daemon: do not take over a running daemon's socket Farid Zakaria
2026-11-05 7:39 ` [PATCH v2 0/3] credential-cache: fix two races when daemons start at once Junio C Hamano
2026-11-06 18:45 ` Farid Zakaria
2026-11-08 1:56 ` Junio C Hamano
2026-11-08 4:27 ` Farid Zakaria
2026-11-09 21:24 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avF8WVT1W4o27CzG@pks.im \
--to=ps@pks.im \
--cc=Johannes.Schindelin@gmx.de \
--cc=farid.m.zakaria@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jeffhostetler@github.com \
--cc=mirth.hickford@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.