Re: [PATCH 4/4] drm/xe: Use intel_display_gse_irq_handler()

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Mon, Nov 09, 2026 at 02:22:58PM +0200, Jani Nikula wrote:
> On Mon, 09 Nov 2026, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> > On Mon, Nov 09, 2026 at 02:05:08PM +0200, Jani Nikula wrote:
> >> On Mon, 09 Nov 2026, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> >> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >> >
> >> > Replace the direct intel_opregion_asle_intr() call with the
> >> > new intel_display_gse_irq_handler() abstraction. We don't
> >> > want to leak random opregion symbols out from the display
> >> > code.
> >> 
> >> This depends on [1] which I don't think is merged yet?
> >
> > It's in drm-intel-next. Need to remember to postpone this
> > one when pushing the rest to drm-xe-next.
> 
> So it is, my bad.
> 
> I think patch 4 is independent of 1-3, and could be merged right away
> via drm-intel-next, as is usual for display patches. Right?

Hmm. I figured it would create a conflict, but looks like this
line didn't end up in the context of the other patches. So yeah,
should be fine to push this into drm-intel-next.

> 
> BR,
> Jani.
> 
> >
> >> 
> >> Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> >> 
> >> 
> >> [1] https://lore.kernel.org/r/20261105203427.8696-3-ville.syrjala@linux.intel.com
> >> 
> >> >
> >> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >> > ---
> >> >  drivers/gpu/drm/xe/display/xe_display.c | 2 +-
> >> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >> >
> >> > diff --git a/drivers/gpu/drm/xe/display/xe_display.c b/drivers/gpu/drm/xe/display/xe_display.c
> >> > index 21692408f9be..0236f69a0f88 100644
> >> > --- a/drivers/gpu/drm/xe/display/xe_display.c
> >> > +++ b/drivers/gpu/drm/xe/display/xe_display.c
> >> > @@ -220,7 +220,7 @@ void xe_display_gse_irq_handler(struct xe_device *xe, u32 gu_misc_iir)
> >> >  		return;
> >> >  
> >> >  	if (gu_misc_iir & GU_MISC_GSE)
> >> > -		intel_opregion_asle_intr(display);
> >> > +		intel_display_gse_irq_handler(display);
> >> >  }
> >> >  
> >> >  void xe_display_irq_reset(struct xe_device *xe)
> >> 
> >> -- 
> >> Jani Nikula, Intel
> 
> -- 
> Jani Nikula, Intel

-- 
Ville Syrjälä
Intel