All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Ville Syrjala" <ville.syrjala@linux.intel.com>,
	intel-xe@lists.freedesktop.org
Subject: Re: [PATCH 4/4] drm/xe: Use intel_display_gse_irq_handler()
Date: Mon, 09 Nov 2026 11:51:05 +0000	[thread overview]
Message-ID: <sashiko-outbox-204904@kernel.org> (raw)
In-Reply-To: <20261109114554.19597-5-ville.syrjala@linux.intel.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] drm/xe: call to undeclared and undefined
  intel_display_gse_irq_handler()
--

commit da9b4f3b875bfbf33a72170de1fb2c018547566b
Author: Ville Syrjälä <ville.syrjala@linux.intel.com>

drm/xe: Use intel_display_gse_irq_handler()

This commit replaces the direct call to intel_opregion_asle_intr() in
xe_display_gse_irq_handler() with intel_display_gse_irq_handler().

> diff --git a/drivers/gpu/drm/xe/display/xe_display.c b/drivers/gpu/drm/xe/display/xe_display.c
> index 21692408f9be0..0236f69a0f883 100644
> --- a/drivers/gpu/drm/xe/display/xe_display.c
> +++ b/drivers/gpu/drm/xe/display/xe_display.c
> @@ -220,7 +220,7 @@ void xe_display_gse_irq_handler(struct xe_device *xe, u32 gu_misc_iir)
>  		return;
>  
>  	if (gu_misc_iir & GU_MISC_GSE)
> -		intel_opregion_asle_intr(display);
> +		intel_display_gse_irq_handler(display);
>  }

[Severity: High]
Does this break the build when CONFIG_DRM_XE_DISPLAY is enabled?
intel_display_gse_irq_handler() is neither declared nor defined anywhere
in the tree, causing an implicit function declaration error during
compilation and an undefined symbol at link time.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261109114554.19597-1-ville.syrjala@linux.intel.com?part=4

  reply	other threads:[~2026-11-09 11:51 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-09 11:45 [PATCH 0/4] drm/xe: Clean up the GU_MISC irq handling Ville Syrjala
2026-11-09 11:45 ` [PATCH 1/4] drm/xe: s/xe_display_irq_enable()/xe_display_gse_irq_handler()/ Ville Syrjala
2026-11-09 11:59   ` Jani Nikula
2026-11-09 11:45 ` [PATCH 2/4] drm/xe: Extract xe_gu_misc_irq_{postinstall,reset}() Ville Syrjala
2026-11-09 12:00   ` Jani Nikula
2026-11-09 11:45 ` [PATCH 3/4] drm/xe: Only enable the GSE interrupt when display needs it Ville Syrjala
2026-11-09 12:03   ` Jani Nikula
2026-11-09 11:45 ` [PATCH 4/4] drm/xe: Use intel_display_gse_irq_handler() Ville Syrjala
2026-11-09 11:51   ` sashiko-bot [this message]
2026-11-09 12:28     ` Ville Syrjälä
2026-11-09 12:05   ` Jani Nikula
2026-11-09 12:15     ` Ville Syrjälä
2026-11-09 12:22       ` Jani Nikula
2026-11-09 12:34         ` Ville Syrjälä
2026-11-09 14:10 ` ✓ CI.KUnit: success for drm/xe: Clean up the GU_MISC irq handling Patchwork
2026-11-09 14:59 ` ✓ Xe.CI.BAT: " Patchwork
2026-11-09 16:28 ` ✗ Xe.CI.FULL: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-204904@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.