All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Nuno Sá" <nuno.sa@analog.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio@vger.kernel.org,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	Nicolas Ferre <nicolas.ferre@microchip.com>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Claudiu Beznea <claudiu.beznea@tuxon.dev>,
	Song Qiang <songqiang1304521@gmail.com>,
	Radu Sabau <radu.sabau@analog.com>,
	Maxwell Doose <maxwell@maxwelld.cc>,
	Tomasz Duszynski <tduszyns@gmail.com>,
	Erikas Bitovtas <xerikasxx@gmail.com>,
	Waqar Hameed <waqar.hameed@axis.com>,
	David Lechner <dlechner@baylibre.com>,
	Andy Shevchenko <andy@kernel.org>,
	linux-kernel@vger.kernel.org,
	Jonathan Cameron <jonathan.cameron@oss.qualcomm.com>
Subject: Re: [RESEND PATCH 00/14] IIO: Ensure iio_trigger_poll() is of the device owned trigger.
Date: Mon, 9 Nov 2026 16:00:21 +0000	[thread overview]
Message-ID: <avHt_kXGwyQNHQx9@nsa> (raw)
In-Reply-To: <20261109042851.1326940-1-jic23@kernel.org>

On Mon, Nov 09, 2026 at 04:28:37AM +0000, Jonathan Cameron wrote:
> From: Jonathan Cameron <jonathan.cameron@oss.qualcomm.com>
> 
> Resend due to wrong linux-iio email address. Sorry for the noise!
> 
> LLM used to help pull this fairly straight forward series together.
> 
> The primary aim here is to ensure a clean layering between the two sides
> of the trigger / pollfunc (push to buffers) divide.  The caller of
> iio_trigger_poll() and iio_trigger_poll_nested() should be using data
> relevant to the trigger, not iio_dev->trig which is the
> current_trigger for the device. Most drivers got this layering right,
> but not this set!
> 
> This is also step 1 in a plan to make iio_dev->trig opaque allowing
> more control of how it is assigned and avoiding traps around lifetimes.
> 
> Includes one precursor fix that has been broken long enough I think
> we can just merge it via the slow path along with the rest of these.
> 
> Jonathan Cameron (14):
>   iio: accel: mma8452: unregister own trigger rather than current one
>   iio: accel: mma8452: poll own trigger from interrupt handler
>   iio: adc: max1027: poll own trigger from interrupt handler
>   iio: adc: ti-ads1119: poll own trigger from interrupt handler
>   iio: adc: mxs-lradc-adc: poll own trigger from interrupt handler
>   iio: adc: at91-sama5d2: poll own trigger on data ready interrupt
>   iio: light: vl6180: poll own trigger from interrupt handler
>   iio: proximity: vl53l0x-i2c: poll own trigger from interrupt handler
>   iio: adc: ad4691: poll own trigger from interrupt handler
>   iio: chemical: scd30: poll own trigger from interrupt handler
>   iio: proximity: vl53l1x-i2c: poll own trigger from interrupt handler
>   iio: proximity: irsd200: poll own trigger from interrupt handler
>   iio: light: vcnl4000: poll own trigger from interrupt handler
>   iio: adc: at91_adc: poll the enabled trigger from interrupt handler
> 
>  drivers/iio/accel/mma8452.c         | 11 ++++++++---
>  drivers/iio/adc/ad4691.c            |  4 +++-
>  drivers/iio/adc/at91-sama5d2_adc.c  |  2 +-
>  drivers/iio/adc/at91_adc.c          |  6 ++++--
>  drivers/iio/adc/max1027.c           |  2 +-
>  drivers/iio/adc/mxs-lradc-adc.c     |  2 +-
>  drivers/iio/adc/ti-ads1119.c        |  2 +-
>  drivers/iio/chemical/scd30.h        |  2 ++
>  drivers/iio/chemical/scd30_core.c   |  4 +++-
>  drivers/iio/light/vcnl4000.c        |  4 +++-
>  drivers/iio/light/vl6180.c          |  2 +-
>  drivers/iio/proximity/irsd200.c     |  4 +++-
>  drivers/iio/proximity/vl53l0x-i2c.c |  2 +-
>  drivers/iio/proximity/vl53l1x-i2c.c |  4 +++-
>  14 files changed, 35 insertions(+), 16 deletions(-)
> 
> -- 
> 2.56.0
> 

LGTM

Reviewed-by: Nuno Sá <nuno.sa@analog.com>


      parent reply	other threads:[~2026-11-09 15:59 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-09  4:28 [RESEND PATCH 00/14] IIO: Ensure iio_trigger_poll() is of the device owned trigger Jonathan Cameron
2026-11-09  4:28 ` [RESEND PATCH 01/14] iio: accel: mma8452: unregister own trigger rather than current one Jonathan Cameron
2026-11-09  4:28 ` [RESEND PATCH 02/14] iio: accel: mma8452: poll own trigger from interrupt handler Jonathan Cameron
2026-11-09  4:28 ` [RESEND PATCH 03/14] iio: adc: max1027: " Jonathan Cameron
2026-11-09  4:28 ` [RESEND PATCH 04/14] iio: adc: ti-ads1119: " Jonathan Cameron
2026-11-09  4:28 ` [RESEND PATCH 05/14] iio: adc: mxs-lradc-adc: " Jonathan Cameron
2026-11-09  4:28 ` [RESEND PATCH 06/14] iio: adc: at91-sama5d2: poll own trigger on data ready interrupt Jonathan Cameron
2026-11-09  4:28 ` [RESEND PATCH 07/14] iio: light: vl6180: poll own trigger from interrupt handler Jonathan Cameron
2026-11-09  4:28 ` [RESEND PATCH 08/14] iio: proximity: vl53l0x-i2c: " Jonathan Cameron
2026-11-09  4:28 ` [RESEND PATCH 09/14] iio: adc: ad4691: " Jonathan Cameron
2026-11-09  4:28 ` [RESEND PATCH 10/14] iio: chemical: scd30: " Jonathan Cameron
2026-11-09  4:28 ` [RESEND PATCH 11/14] iio: proximity: vl53l1x-i2c: " Jonathan Cameron
2026-11-09  8:42   ` Joshua Crofts
2026-11-09  4:28 ` [RESEND PATCH 12/14] iio: proximity: irsd200: " Jonathan Cameron
2026-11-09  4:28 ` [RESEND PATCH 13/14] iio: light: vcnl4000: " Jonathan Cameron
2026-11-09  8:46   ` Joshua Crofts
2026-11-09  4:28 ` [RESEND PATCH 14/14] iio: adc: at91_adc: poll the enabled " Jonathan Cameron
2026-11-09  9:15 ` [RESEND PATCH 00/14] IIO: Ensure iio_trigger_poll() is of the device owned trigger Joshua Crofts
2026-11-09 16:00 ` Nuno Sá [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avHt_kXGwyQNHQx9@nsa \
    --to=nuno.sa@analog.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=andy@kernel.org \
    --cc=claudiu.beznea@tuxon.dev \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=jonathan.cameron@oss.qualcomm.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maxwell@maxwelld.cc \
    --cc=miquel.raynal@bootlin.com \
    --cc=nicolas.ferre@microchip.com \
    --cc=radu.sabau@analog.com \
    --cc=songqiang1304521@gmail.com \
    --cc=tduszyns@gmail.com \
    --cc=waqar.hameed@axis.com \
    --cc=xerikasxx@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.