Re: [PATCH] ui/dbus: validate clipboard selection in Release handler

["Daniel P. Berrangé" <berrange@redhat.com>]

On Mon, Oct 19, 2026 at 01:23:51PM +0400, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
> 
> The clipboard "Release" D-Bus method handler passes the caller provided
> selection to qemu_clipboard_peer_release() without any bounds check,
> unlike the "Grab" and "Request" handlers.
> 
> An out-of-range selection reaches qemu_clipboard_info(), which asserts
> selection < QEMU_CLIPBOARD_SELECTION__COUNT and aborts QEMU (with
> asserts compiled out, it would index the cbinfo[] array out of bounds).
> 
> Reject invalid selections with an error, following the same pattern as
> the other clipboard handlers.
> 
> Resolves: https://gitlab.com/qemu-project/qemu/-/work_items/4717
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>  ui/dbus-clipboard.c | 13 ++++++++++++-
>  1 file changed, 12 insertions(+), 1 deletion(-)

If you remove the text about "with asserts compiled out..." as Peter
suggested, then

  Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com       ~~        https://hachyderm.io/@berrange :|
|: https://libvirt.org          ~~          https://entangle-photo.org :|
|: https://pixelfed.art/berrange   ~~    https://fstop138.berrange.com :|