Re: [PATCH net-next v5 01/15] devlink, mlx5: add init/fini ops for shared devlink

[Jiri Pirko <jiri@resnulli.us>]

Tue, Nov 10, 2026 at 03:07:10PM +0100, przemyslaw.kitszel@intel.com wrote:
>Add .shd_init() and .shd_fini() ops, that will be called for the first
>devlink_shd_get() (to initialize driver's priv data) and on the last
>devlink_shd_put() (to allow for the cleanup). Both ops are optional.
>
>.shd_init() could return an error, which will stop creation of shd
>instance. The initializer also gets an additional, optional param,
>that driver could use for any needs.
>
>devlink_shd_get() now returns ERR_PTR() on failure instead of NULL, so
>the error from .shd_init() reaches the caller. Adjust mlx5, the only
>user, to that and to the new param.
>
>If any of the callbacks will need to get devlink instance, it could
>be accessed by shd_priv_to_devlink().
>
>Both callbacks are called with devl_lock held, .shd_init() before
>devlink is registered, .shd_fini() after it is unregistered.
>
>Next commit will make use of the callbacks, a later one will make use
>also of the additional param.
>
>Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
>Acked-by: Tariq Toukan <tariqt@nvidia.com>
>Signed-off-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>

Reviewed-by: Jiri Pirko <jiri@nvidia.com>