Re: [PATCH net-next v5 14/15] devlink: add devlink_alloc_drv()

[Jiri Pirko <jiri@resnulli.us>]

Tue, Nov 10, 2026 at 03:07:23PM +0100, przemyslaw.kitszel@intel.com wrote:
>devlink_alloc() records the driver bound to @dev at the time of the
>call as the owner of the new instance. That fits the common case of
>a driver creating an instance for the device it is bound to, but not
>a PF driver that creates instances for its VFs, as the VF device could
>be:
> * not bound to any driver yet (VF driver not loaded, or
>   sriov_drivers_autoprobe disabled), what triggers the WARN_ON() in
>   __devlink_alloc();
> * bound to another driver (VF driver, or vfio-pci), which could be
>   unloaded while the instance is still registered, leaving the stored
>   driver pointer dangling (it is used to report the driver name in
>   devlink dev info).
>
>Add devlink_alloc_drv(), a variant of devlink_alloc() that takes the
>owning driver explicitly, as devlink_shd_get() already does.
>
>The first user is ice, in the next patch, which creates a devlink
>instance for each of its VFs.
>
>Such an instance reports the owning driver in devlink dev info, not the
>one bound to the device in sysfs. Document that in devlink-info.rst.
>
>Signed-off-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>

Reviewed-by: Jiri Pirko <jiri@nvidia.com>