[PATCH] media: firewire: Drop <linux/mod_devicetable.h> from firedtv.h

[PATCH] media: firewire: Drop <linux/mod_devicetable.h> from firedtv.h

[Uwe Kleine-König (The Capable Hub)]

This header has 6 consumers:

	x$ git grep firedtv.h
	drivers/media/firewire/firedtv-avc.c:#include "firedtv.h"
	drivers/media/firewire/firedtv-ci.c:#include "firedtv.h"
	drivers/media/firewire/firedtv-dvb.c:#include "firedtv.h"
	drivers/media/firewire/firedtv-fe.c:#include "firedtv.h"
	drivers/media/firewire/firedtv-fw.c:#include "firedtv.h"
	drivers/media/firewire/firedtv-rc.c:#include "firedtv.h"

In these 6 files and the header itself only a single device_id struct is
used:

	$ git grep -oE "\<(acpi_device_id|amba_id|ap_device_id|apr_device_id|auxiliary_device_id|bcma_device_id|ccw_device_id|cdx_device_id|coreboot_device_id|css_device_id|dfl_device_id|dmi_(device|system)_id|eisa_device_id|fsl_mc_device_id|hda_device_id|hid_device_id|hv_vmbus_device_id|i2c_device_id|i3c_device_id|ieee1394_device_id|input_device_id|ipack_device_id|isapnp_device_id|ishtp_device_id|mcb_device_id|mdio_device_id|mei_cl_device_id|mhi_device_id|mips_cdmm_device_id|of_device_id|parisc_device_id|pci_device_id|pci_epf_device_id|pcmcia_device_id|platform_device_id|pnp_(card_)?device_id|rio_device_id|rpmsg_device_id|sdio_device_id|sdw_device_id|serio_device_id|slim_device_id|spi_device_id|spmi_device_id|ssam_device_id|ssb_device_id|tb_service_id|tee_client_device_id|typec_device_id|ulpi_device_id|usb_device_id|vchiq_device_id|vio_device_id|virtio_device_id|wmi_device_id|x86_(cpu|device)_id|zorro_device_id|cpu_feature)\>" drivers/media/firewire/firedtv.h drivers/media/firewire/firedtv-{avc,ci,dvb,fe,fw,rc}.c | sort -u
	drivers/media/firewire/firedtv-fw.c:ieee1394_device_id

struct ieee1394_device_id is provided by <linux/firewire.h> which is
included by firedtv-fw.c.

So <linux/mod_devicetable.h> can be dropped from firedtv.h.

Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
---
Hello,

this is part of the quest to get rid of <linux/mod_devicetable.h> which
introduces a big bunch of useless dependencies.

Best regards
Uwe

 drivers/media/firewire/firedtv.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/media/firewire/firedtv.h b/drivers/media/firewire/firedtv.h
index 190bb1a57079..428f9403fd2a 100644
--- a/drivers/media/firewire/firedtv.h
+++ b/drivers/media/firewire/firedtv.h
@@ -13,7 +13,6 @@
 #include <linux/dvb/dmx.h>
 #include <linux/dvb/frontend.h>
 #include <linux/list.h>
-#include <linux/mod_devicetable.h>
 #include <linux/mutex.h>
 #include <linux/spinlock_types.h>
 #include <linux/types.h>

base-commit: aaa2f954c21b205a0bcd0961e5b2be4e82e58455
-- 
2.56.0.rc1

Re: media: firewire: Drop <linux/mod_devicetable.h> from firedtv.h

[Uwe Kleine-König (The Capable Hub)]

[-- Attachment #1: Type: text/plain, Size: 2151 bytes --]

Hello,

On Thu, Nov 12, 2026 at 03:29:44AM -0800, Patchwork Integration wrote:
> Dear Uwe Kleine-König (The Capable Hub):
> 
> Thanks for your patches! Unfortunately the Media CI robot detected some
> issues:
> 
> # Test media-patchstyle:test-valid-ancestor
> ERROR: This code is not based on any of the branches: next fixes
>        from https://gitlab.freedesktop.org/linux-media/media-committers.git.
>        The output of media-ci will not be reliable, and the code will not
>        land upstream as-is. Please rebase your code.

Well the base I chose is next-20261111, but drivers/media/firewire
didn't see any changes in there since v7.2-rc2, and also

	https://gitlab.freedesktop.org/linux-media/media-committers.git next

doesn't have any changes to that directory, so it should apply there
just fine.

> # Test checkpatch:./0001-media-firewire-Drop-linux-mod_devicetable.h-from-fir.patch checkpatch
> WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
> #24: 
> $ git grep -oE "\<(acpi_device_id|amba_id|ap_device_id|apr_device_id|auxiliary_device_id|bcma_device_id|ccw_device_id|cdx_device_id|coreboot_device_id|css_device_id|dfl_device_id|dmi_(device|system)_id|eisa_device_id|fsl_mc_device_id|hda_device_id|hid_device_id|hv_vmbus_device_id|i2c_device_id|i3c_device_id|ieee1394_device_id|input_device_id|ipack_device_id|isapnp_device_id|ishtp_device_id|mcb_device_id|mdio_device_id|mei_cl_device_id|mhi_device_id|mips_cdmm_device_id|of_device_id|parisc_device_id|pci_device_id|pci_epf_device_id|pcmcia_device_id|platform_device_id|pnp_(card_)?device_id|rio_device_id|rpmsg_device_id|sdio_device_id|sdw_device_id|serio_device_id|slim_device_id|spi_device_id|spmi_device_id|ssam_device_id|ssb_device_id|tb_service_id|tee_client_device_id|typec_device_id|ulpi_device_id|usb_device_id|vchiq_device_id|vio_device_id|virtio_device_id|wmi_device_id|x86_(cpu|device)_id|zorro_device_id|cpu_feature)\>" drivers/media/firewire/firedtv.h drivers/media/firewire/firedtv-{avc,ci,dvb,fe,fw,rc}.c | sort -u

I'd expect that there is an exception for commands like that?

Best regards
Uwe

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH] media: firewire: Drop <linux/mod_devicetable.h> from firedtv.h

[Uwe Kleine-König (The Capable Hub)]

[-- Attachment #1: Type: text/plain, Size: 334 bytes --]

On Thu, Nov 12, 2026 at 11:18:15AM +0100, Uwe Kleine-König (The Capable Hub) wrote:
> This header has 6 consumers:
> 
> 	x$ git grep firedtv.h

There --^ is a stray x. Iff you like the patch as is otherwise feel free
to drop this when applying. Otherwise I will fix it in the next revision
of this patch.

Best regards
Uwe

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]