Re: [PATCH nf-next v10 0/6] ipset: replace internal hash table with rhashtable

[Florian Westphal <fw@strlen.de>]

Jozsef Kadlecsik <kadlec@netfilter.org> wrote:
> In my opinion the patches should be applied to nf-next: the new method 
> passes all the tests, no functionality lost and it evicts all the issues 
> in the old code. There's no point for further tuning.
> 
> I'm absolutely grateful for your hard work, Florian!

Thanks Jozsef!

I pushed a few of the test updates to ipset.git, but not this
3-part-series:

https://patchwork.ozlabs.org/project/netfilter-devel/patch/20261111101603.22698-1-fw@strlen.de/

First one passes on either rhashtable branch or main, but I'm not sure
it should :-)

Resp. I'm not sure what the contract/expected behavior of net,iface set
type is when the address matches the net/mask entry, but the interface
doesn't.  I followed existing behaviour, so that test would enshrine
that: it stops matching more candidates.

I'd prefer if you could double-check that the semantics that the test
is checking are sensible/correct.

2 and 3 fail on main, in both cases I think these are bugs in
the existing implementation.

Thanks Jozsef for your help!