Re: [PATCH nf-next v10 0/6] ipset: replace internal hash table with rhashtable

[Florian Westphal <fw@strlen.de>]

Jozsef Kadlecsik <kadlec@netfilter.org> wrote:
> > I pushed a few of the test updates to ipset.git, but not this 
> > 3-part-series:
> > 
> > https://patchwork.ozlabs.org/project/netfilter-devel/patch/20261111101603.22698-1-fw@strlen.de/
> > 
> > First one passes on either rhashtable branch or main, but I'm not sure
> > it should :-)
> > 
> > Resp. I'm not sure what the contract/expected behavior of net,iface set 
> > type is when the address matches the net/mask entry, but the interface 
> > doesn't.  I followed existing behaviour, so that test would enshrine 
> > that: it stops matching more candidates.
> 
> Hm, it shouldn't. The expected behaviour is as follows: if the net/mask 
> entry matches but the interface not, then the code should continue trying 
> to find matching entries but just with the same mask value and not with 
> other ones. That way the same net/mask entry behind multiple interfaces is 
> supported and matched.

In that case a v11 might be needed; the conversion follows the observed
behavior.

> I'll have a look at it.

Thanks Jozsef!