From: Patrick Steinhardt <ps@pks.im>
To: Junio C Hamano <gitster@pobox.com>
Cc: Yusuke Hayashi via B4 Relay
<devnull+yusuke8h.gmail.com@kernel.org>,
git@vger.kernel.org, Karthik Nayak <karthik.188@gmail.com>,
Yusuke Hayashi <yusuke8h@gmail.com>
Subject: Re: [PATCH] refs: drop unused `peel_iterated_oid()` declaration
Date: Fri, 13 Nov 2026 08:04:26 +0100 [thread overview]
Message-ID: <ava2ejke3jl7Bv5S@pks.im> (raw)
In-Reply-To: <xmqqv761j3df.fsf@gitster.g>
On Thu, Nov 12, 2026 at 10:45:00AM -0800, Junio C Hamano wrote:
> Yusuke Hayashi via B4 Relay <devnull+yusuke8h.gmail.com@kernel.org>
> writes:
>
> > From: Yusuke Hayashi <yusuke8h@gmail.com>
> >
> > Commit 5a5c7359f7 (refs: drop `current_ref_iter` hack, 2025-10-23)
> > removed `peel_iterated_oid()` from "refs.c" after converting all of its
> > callers to `reference_get_peeled_oid()`, leaving behind the declaration
> > in "refs.h".
> >
> > Remove the unused declaration and its comment.
> >
> > Signed-off-by: Yusuke Hayashi <yusuke8h@gmail.com>
> > ---
> > refs.h | 13 -------------
> > 1 file changed, 13 deletions(-)
>
> obviously correct ;-) Thanks, will queue.
Indeed, thanks for cleaning up after me!
Patrick
prev parent reply other threads:[~2026-11-13 7:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-12 5:57 [PATCH] refs: drop unused `peel_iterated_oid()` declaration Yusuke Hayashi via B4 Relay
2026-11-12 5:57 ` Yusuke Hayashi
2026-11-12 18:45 ` Junio C Hamano
2026-11-13 7:04 ` Patrick Steinhardt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ava2ejke3jl7Bv5S@pks.im \
--to=ps@pks.im \
--cc=devnull+yusuke8h.gmail.com@kernel.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=karthik.188@gmail.com \
--cc=yusuke8h@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.