From: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
To: Feng-Yi Hsueh <fyhsueh4linux@gmail.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
devicetree@vger.kernel.org, Jacky Huang <ychuang3@nuvoton.com>,
Shan-Chun Hung <schung@nuvoton.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/2] Input: keyboard: Add Nuvoton MA35D1 keypad driver
Date: Fri, 13 Nov 2026 07:28:55 +0100 [thread overview]
Message-ID: <avatz4Q8JbrAJNn_@monoceros> (raw)
In-Reply-To: <20261110111419.89535-3-fyhsueh4linux@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 331 bytes --]
On Tue, Nov 10, 2026 at 07:14:19PM +0800, Feng-Yi Hsueh wrote:
> +#include <linux/mod_devicetable.h>
> [...]
> +#include <linux/platform_device.h>
Please don't include <linux/mod_devicetable.h> as it introduces a bunch
of unneeded build dependencies. <linux/platform_device.h> is sufficient
to get of_device_id.
Best regards
Uwe
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2026-11-13 6:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-10 11:14 [PATCH v1 0/2] Input: Add Nuvoton MA35D1 keypad support Feng-Yi Hsueh
2026-11-10 11:14 ` [PATCH v1 1/2] dt-bindings: input: Add Nuvoton MA35D1 keypad controller Feng-Yi Hsueh
2026-11-10 11:25 ` sashiko-bot
2026-11-10 18:36 ` Conor Dooley
2026-11-10 11:14 ` [PATCH v1 2/2] Input: keyboard: Add Nuvoton MA35D1 keypad driver Feng-Yi Hsueh
2026-11-10 11:24 ` sashiko-bot
2026-11-13 6:28 ` Uwe Kleine-König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avatz4Q8JbrAJNn_@monoceros \
--to=u.kleine-koenig@baylibre.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=fyhsueh4linux@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=schung@nuvoton.com \
--cc=ychuang3@nuvoton.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.