From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Yonggang Luo <luoyonggang@gmail.com>
Cc: qemu-devel@nongnu.org,
Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>,
Matthew Rosato <mjrosato@linux.ibm.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
Eric Farman <farman@linux.ibm.com>,
Cornelia Huck <cohuck@redhat.com>,
Philippe Mathieu-Daude <philmd@mailo.com>,
David Hildenbrand <david@kernel.org>, Fam Zheng <fam@euphon.net>,
qemu-s390x@nongnu.org
Subject: Re: [PATCH v2 4/4] hw/microblaze: defer PetaLogix endianness default until init
Date: Fri, 13 Nov 2026 10:29:35 +0000 [thread overview]
Message-ID: <avbmj_yz4JI5f6lW@redhat.com> (raw)
In-Reply-To: <20261105194958.1117-5-luoyonggang@gmail.com>
On Fri, Nov 06, 2026 at 03:49:57AM +0800, Yonggang Luo wrote:
> The PetaLogix machine read its endianness default from
> target_big_endian() in class_init. In a multi-target binary the target
> is not selected yet at class_init, so the default cannot be computed
> there. Set the property default to "unspecified" instead, and resolve
> it to big or little in petalogix_s3adsp1800_init(), where the target is
> known.
>
> Until the machine is initialized, endianness reads back as
> "unspecified" rather than big or little.
>
> Reviewed-by: Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>
> Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
> ---
> hw/microblaze/petalogix_s3adsp1800_mmu.c | 11 ++++++++---
> 1 file changed, 8 insertions(+), 3 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com ~~ https://hachyderm.io/@berrange :|
|: https://libvirt.org ~~ https://entangle-photo.org :|
|: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|
prev parent reply other threads:[~2026-11-13 10:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-05 19:49 [PATCH v2 0/4] hw/(pci/scsi/virtio-mem): Avoid call to target_info() in class_init Yonggang Luo
2026-11-05 19:49 ` [PATCH v2 1/4] hw/pci: Avoid guard loadparm with target_s390x() for s390x " Yonggang Luo
2026-11-05 19:49 ` [PATCH v2 2/4] hw/scsi: " Yonggang Luo
2026-11-05 19:49 ` [PATCH v2 3/4] hw/virtio/virtio-mem: Avoid call to target_info() " Yonggang Luo
2026-11-05 19:49 ` [PATCH v2 4/4] hw/microblaze: defer PetaLogix endianness default until init Yonggang Luo
2026-11-13 10:29 ` Daniel P. Berrangé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avbmj_yz4JI5f6lW@redhat.com \
--to=berrange@redhat.com \
--cc=cohuck@redhat.com \
--cc=david@kernel.org \
--cc=edgar.iglesias@gmail.com \
--cc=fam@euphon.net \
--cc=farman@linux.ibm.com \
--cc=luoyonggang@gmail.com \
--cc=mjrosato@linux.ibm.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@mailo.com \
--cc=pierrick.bouvier@oss.qualcomm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.