[PATCH] xfs/654: don't complain if the healthmon xfs_io already exited

[PATCH] xfs/654: don't complain if the healthmon xfs_io already exited

[Avinesh Kumar]

From: Avinesh Kumar <avinesh.kumar@suse.com>

After the unmount, the test resumes the stopped xfs_io healthmon
process, which reads the "filesystem unmounted" event, sees EOF, and
exits on its own.  The test then sends it a SIGTERM anyway in case it
did not exit.  If xfs_io has already exited and been reaped by the
shell, kill prints "kill: (PID) - No such process" to stderr, which
doesn't match the golden output:

    +/opt/xfstests/tests/xfs/654: line 50: kill: (170710) - No such process
     mount refcount is in range
     mount + healthmon refcount is in range

Redirect kill's output to $seqres.full, as _kill_xfs_healer does.

Fixes: 79f6b1c3 ("xfs: test health monitoring code")
Signed-off-by: Avinesh Kumar <avinesh.kumar@suse.com>
---
 tests/xfs/654 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/xfs/654 b/tests/xfs/654
index 012f31a8..e8d815ae 100755
--- a/tests/xfs/654
+++ b/tests/xfs/654
@@ -47,7 +47,7 @@ mon_nomount_refcount="$(_module_refcount xfs)"
 # Capture mod refcount after continuing healthmon (which should exit due to the
 # unmount) and killing it.
 kill -CONT $healer_pid
-kill $healer_pid
+kill $healer_pid &>> $seqres.full
 wait
 unset healer_pid
 nomon_nomount_refcount="$(_module_refcount xfs)"
-- 
2.56.0

Re: [PATCH] xfs/654: don't complain if the healthmon xfs_io already exited

[Christoph Hellwig]

Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>

Re: [PATCH] xfs/654: don't complain if the healthmon xfs_io already exited

[Zorro Lang]

On Wed, Nov 11, 2026 at 04:20:19PM +0100, Avinesh Kumar wrote:
> From: Avinesh Kumar <avinesh.kumar@suse.com>
> 
> After the unmount, the test resumes the stopped xfs_io healthmon
> process, which reads the "filesystem unmounted" event, sees EOF, and
> exits on its own.  The test then sends it a SIGTERM anyway in case it
> did not exit.  If xfs_io has already exited and been reaped by the
> shell, kill prints "kill: (PID) - No such process" to stderr, which
> doesn't match the golden output:
> 
>     +/opt/xfstests/tests/xfs/654: line 50: kill: (170710) - No such process
>      mount refcount is in range
>      mount + healthmon refcount is in range
> 
> Redirect kill's output to $seqres.full, as _kill_xfs_healer does.
> 
> Fixes: 79f6b1c3 ("xfs: test health monitoring code")
> Signed-off-by: Avinesh Kumar <avinesh.kumar@suse.com>
> ---

Reviewed-by: Zorro Lang <zlang@kernel.org>

>  tests/xfs/654 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/xfs/654 b/tests/xfs/654
> index 012f31a8..e8d815ae 100755
> --- a/tests/xfs/654
> +++ b/tests/xfs/654
> @@ -47,7 +47,7 @@ mon_nomount_refcount="$(_module_refcount xfs)"
>  # Capture mod refcount after continuing healthmon (which should exit due to the
>  # unmount) and killing it.
>  kill -CONT $healer_pid
> -kill $healer_pid
> +kill $healer_pid &>> $seqres.full
>  wait
>  unset healer_pid
>  nomon_nomount_refcount="$(_module_refcount xfs)"
> -- 
> 2.56.0
> 
>