Re: [PATCH v6 10/19] platform/x86: hp-bioscfg: Rename local variable

[Alejandro Colomar <alx@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1282 bytes --]

Hi Joe,

> Date: 2026-11-14 08:04:56-0800
> From: Joe Perches <joe@perches.com>
>
> On Sat, 2026-11-14 at 16:23 +0100, Alejandro Colomar wrote:
> > strprefix shadows a function of the same name.  Let's rename it.
> []
> > diff --git a/drivers/platform/x86/hp/hp-bioscfg/spmobj-attributes.c b/drivers/platform/x86/hp/hp-bioscfg/spmobj-attributes.c
> []
> > @@ -87,13 +87,13 @@ int hp_populate_security_buffer(u16 *authbuf, const char *authentication)
> >  		 */
> >  
> >  		/* append UTF_PREFIX to part and then convert it to unicode */
> > -		strprefix = kasprintf(GFP_KERNEL, "%s%s", UTF_PREFIX,
> > +		prefix = kasprintf(GFP_KERNEL, "%s%s", UTF_PREFIX,
> >  				      authentication);
> > -		if (!strprefix)
> > +		if (!prefix)
> >  			return -ENOMEM;
> >  
> > -		auth = hp_ascii_to_utf16_unicode(auth, strprefix);
> > -		kfree(strprefix);
> > +		auth = hp_ascii_to_utf16_unicode(auth, prefix);
> 
> unassociated defect but the auth buffer isn't apparently sized
> so some write beyond buffer seems possible.

Thanks!

I don't fully understand that utf code, so I'll leave this to anyone
else who knows about it.  But I'm interested in it, so if anyone writes
a patch, please CC me.


Cheers,
Alex

-- 
<https://www.alejandro-colomar.es>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]