All of lore.kernel.org
 help / color / mirror / Atom feed
From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Lee Jones <lee@kernel.org>
Cc: vkoul@kernel.org, yung-chuan.liao@linux.intel.com,
	pierre-louis.bossart@linux.dev, linux-sound@vger.kernel.org,
	mfd@lists.linux.dev, linux-kernel@vger.kernel.org,
	patches@opensource.cirrus.com
Subject: Re: [PATCH v2 RESEND 2/2] mfd: cs42l43: Move to core detach helper
Date: Mon, 16 Nov 2026 10:07:27 +0000	[thread overview]
Message-ID: <avrV3wz5jISM9Fne@opensource.cirrus.com> (raw)
In-Reply-To: <179370028929.793788.4070701675472724398@kernel.org>

On Fri, Nov 13, 2026 at 07:30:29PM +0000, Lee Jones wrote:
> On Mon, 02 Nov 2026, Charles Keepax wrote:
> 
> > Now the core has a helper to signal a device will detach from
> > the SoundWire bus, there is no need for the cs42l43 driver code
> > to separately track that. Switch to using the new core helper.
> >
> > Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>
> > Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
> > ---
> > -	reinit_completion(&cs42l43->device_detach);
> > +	sdw_slave_signal_unattach(cs42l43->sdw);
> 
> Isn't 'cs42l43->sdw' NULL when the device is connected via I2C?

Yup but still safe.

+static inline void sdw_slave_signal_unattach(struct sdw_slave
*slave)
+{
+       if (!slave)
+               return;

> Also, doesn't the comment in cs42l43_soft_reset() still claim that this
> function waits for the device to detach from the bus?

Yeah that is a fair point I will update the comment and do a
spin.

Thanks,
Charles

  reply	other threads:[~2026-11-16 10:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-02 16:41 [PATCH v2 RESEND 0/2] Add SoundWire detach helper Charles Keepax
2026-11-02 16:41 ` [PATCH v2 RESEND 1/2] soundwire: Add a helper function to indicate a device will detach Charles Keepax
2026-11-02 16:41 ` [PATCH v2 RESEND 2/2] mfd: cs42l43: Move to core detach helper Charles Keepax
2026-11-13 19:30   ` Lee Jones
2026-11-16 10:07     ` Charles Keepax [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-09-24 12:05 [PATCH v2 RESEND 0/2] Add SoundWire " Charles Keepax
2026-09-24 12:05 ` [PATCH v2 RESEND 2/2] mfd: cs42l43: Move to core " Charles Keepax
2026-10-14 15:18   ` Lee Jones
2026-10-14 15:34     ` Charles Keepax

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avrV3wz5jISM9Fne@opensource.cirrus.com \
    --to=ckeepax@opensource.cirrus.com \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=mfd@lists.linux.dev \
    --cc=patches@opensource.cirrus.com \
    --cc=pierre-louis.bossart@linux.dev \
    --cc=vkoul@kernel.org \
    --cc=yung-chuan.liao@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.