All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Roger Pau Monné" <roger@xenproject.org>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Teddy Astie <teddy.astie@vates.tech>
Subject: Re: [PATCH 2/4] x86/IRQ: use less heavy locking in free_domain_pirqs()
Date: Tue, 17 Nov 2026 12:35:28 +0100	[thread overview]
Message-ID: <avw8AA3K2k3PKqQv@Mac.lan> (raw)
In-Reply-To: <97f680e6-0d3c-4077-977d-bd6ba7e64f66@suse.com>

On Tue, Nov 17, 2026 at 11:38:29AM +0100, Jan Beulich wrote:
> On 17.11.2026 11:31, Roger Pau Monné wrote:
> > On Thu, Oct 29, 2026 at 03:24:13PM +0100, Jan Beulich wrote:
> >> Holding the domain's PCI lock (alongside its event lock) is sufficient
> >> around unmap_domain_pirq().
> >>
> >> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> > 
> > Acked-by: Roger Pau Monné <roger@xenproject.org>
> 
> Thanks, but: Considering your reply to patch 1, did you forget to make this
> conditional upon the same prereq change that you outline there?

Strictly speaking this function is only called from
arch_domain_destroy(), which is done after PCI devices are deassigned
and MSIs are torn down.  In this context unmap_domain_pirq() is only
caled against GSIs.  But yes, for correctness (and to avoid confusion)
I should have tied it to the same request as patch 1.

Thanks, Roger.


  reply	other threads:[~2026-11-17 11:35 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-29 14:22 [PATCH 0/4] x86: yet more PCI locking adjustments Jan Beulich
2026-10-29 14:23 ` [PATCH 1/4] x86/physdev: use less heavy locking in physdev_unmap_pirq() Jan Beulich
2026-11-17 10:29   ` Roger Pau Monné
2026-10-29 14:24 ` [PATCH 2/4] x86/IRQ: use less heavy locking in free_domain_pirqs() Jan Beulich
2026-11-17 10:31   ` Roger Pau Monné
2026-11-17 10:38     ` Jan Beulich
2026-11-17 11:35       ` Roger Pau Monné [this message]
2026-10-29 14:24 ` [PATCH 3/4] x86/MSI: drop redundant checking Jan Beulich
2026-11-17 10:34   ` Roger Pau Monné
2026-10-29 14:25 ` [PATCH 4/4] x86: tighten PCI-related locking assertions Jan Beulich
2026-11-17 10:41   ` Roger Pau Monné
2026-11-17 11:11     ` Jan Beulich
2026-11-17 11:27       ` Roger Pau Monné

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avw8AA3K2k3PKqQv@Mac.lan \
    --to=roger@xenproject.org \
    --cc=andrew.cooper3@citrix.com \
    --cc=jbeulich@suse.com \
    --cc=teddy.astie@vates.tech \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.