From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, marcandre.lureau@redhat.com
Subject: Re: [PATCH] tests/qmp-cmd-test: Simplify @qapi-type test
Date: Tue, 17 Nov 2026 15:56:43 +0000 [thread overview]
Message-ID: <avx5O0dsL5yGxUpE@redhat.com> (raw)
In-Reply-To: <20261117103629.2612744-1-armbru@redhat.com>
On Tue, Nov 17, 2026 at 11:36:29AM +0100, Markus Armbruster wrote:
> test_qapi_type() checks that if @qapi-type is present, it resolves in
> output of query-qmp-schema. Absent @qapi-type is reported with
> g_test_message except for child and link properties.
>
> The exception became useless when we implemented @qapi-type for child
> and link properties. Drop it.
>
> Fixes: 6955264d5821 ("qom: Convert child and link properties to QAPI-aware registration")
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> tests/qtest/qmp-cmd-test.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com ~~ https://hachyderm.io/@berrange :|
|: https://libvirt.org ~~ https://entangle-photo.org :|
|: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|
prev parent reply other threads:[~2026-11-17 15:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 10:36 [PATCH] tests/qmp-cmd-test: Simplify @qapi-type test Markus Armbruster
2026-11-17 15:56 ` Daniel P. Berrangé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avx5O0dsL5yGxUpE@redhat.com \
--to=berrange@redhat.com \
--cc=armbru@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.