* [PATCH] tests/qmp-cmd-test: Simplify @qapi-type test
@ 2026-11-17 10:36 Markus Armbruster
2026-11-17 15:56 ` Daniel P. Berrangé
0 siblings, 1 reply; 2+ messages in thread
From: Markus Armbruster @ 2026-11-17 10:36 UTC (permalink / raw)
To: qemu-devel; +Cc: marcandre.lureau
test_qapi_type() checks that if @qapi-type is present, it resolves in
output of query-qmp-schema. Absent @qapi-type is reported with
g_test_message except for child and link properties.
The exception became useless when we implemented @qapi-type for child
and link properties. Drop it.
Fixes: 6955264d5821 ("qom: Convert child and link properties to QAPI-aware registration")
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
tests/qtest/qmp-cmd-test.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/tests/qtest/qmp-cmd-test.c b/tests/qtest/qmp-cmd-test.c
index acb7b0dd6a9..5138582bb3f 100644
--- a/tests/qtest/qmp-cmd-test.c
+++ b/tests/qtest/qmp-cmd-test.c
@@ -384,8 +384,7 @@ static void test_qapi_type(void)
if (qapi_type) {
g_assert_nonnull(qmp_schema_lookup(&schema, qapi_type));
- } else if (!g_str_has_prefix(ty, "child<") &&
- !g_str_has_prefix(ty, "link<")) {
+ } else {
g_test_message("%s.%s %s has no associated qapi-type",
name, propname, ty);
}
--
2.55.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] tests/qmp-cmd-test: Simplify @qapi-type test
2026-11-17 10:36 [PATCH] tests/qmp-cmd-test: Simplify @qapi-type test Markus Armbruster
@ 2026-11-17 15:56 ` Daniel P. Berrangé
0 siblings, 0 replies; 2+ messages in thread
From: Daniel P. Berrangé @ 2026-11-17 15:56 UTC (permalink / raw)
To: Markus Armbruster; +Cc: qemu-devel, marcandre.lureau
On Tue, Nov 17, 2026 at 11:36:29AM +0100, Markus Armbruster wrote:
> test_qapi_type() checks that if @qapi-type is present, it resolves in
> output of query-qmp-schema. Absent @qapi-type is reported with
> g_test_message except for child and link properties.
>
> The exception became useless when we implemented @qapi-type for child
> and link properties. Drop it.
>
> Fixes: 6955264d5821 ("qom: Convert child and link properties to QAPI-aware registration")
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> tests/qtest/qmp-cmd-test.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com ~~ https://hachyderm.io/@berrange :|
|: https://libvirt.org ~~ https://entangle-photo.org :|
|: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-11-17 15:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-17 10:36 [PATCH] tests/qmp-cmd-test: Simplify @qapi-type test Markus Armbruster
2026-11-17 15:56 ` Daniel P. Berrangé
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.