All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>
Cc: qemu-devel@nongnu.org, "Fabiano Rosas" <farosas@suse.de>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Peter Xu" <peterx@redhat.com>
Subject: Re: [PATCH] tests/docker/dockerfiles/release: use full registry name for image
Date: Tue, 17 Nov 2026 17:03:15 +0000	[thread overview]
Message-ID: <avyI084uxF7pMh0-@redhat.com> (raw)
In-Reply-To: <00c0e48d-4186-44de-a078-a69586201211@oss.qualcomm.com>

On Tue, Nov 17, 2026 at 09:01:26AM -0800, Pierrick Bouvier wrote:
> On 11/17/2026 12:17 AM, Daniel P. Berrangé wrote:
> > On Mon, Nov 16, 2026 at 04:23:11PM -0700, Pierrick Bouvier wrote:
> >> By default, podman does not have docker.io preconfigured as default
> >> registry, so building fails.
> >>
> >> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>
> >> ---
> >>  tests/docker/dockerfiles/release.docker | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/tests/docker/dockerfiles/release.docker b/tests/docker/dockerfiles/release.docker
> >> index ca6babde01e..a606eb5ee79 100644
> >> --- a/tests/docker/dockerfiles/release.docker
> >> +++ b/tests/docker/dockerfiles/release.docker
> >> @@ -1,6 +1,6 @@
> >>  ARG UBUNTU_VERSION="UBUNTU_VERSION_build_arg_must_be_set"
> >>  
> >> -FROM ubuntu:$UBUNTU_VERSION AS build
> >> +FROM docker.io/ubuntu:$UBUNTU_VERSION AS build
> > 
> > How about docker.io/library/ubuntu  to match our ubuntu2404.docker ?
> >
> 
> Sounds good to me, it's the same image behind the hoods and it's more
> consistent.

With that changed, consider it to have

  Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com       ~~        https://hachyderm.io/@berrange :|
|: https://libvirt.org          ~~          https://entangle-photo.org :|
|: https://pixelfed.art/berrange   ~~    https://fstop138.berrange.com :|



      reply	other threads:[~2026-11-17 17:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 23:23 [PATCH] tests/docker/dockerfiles/release: use full registry name for image Pierrick Bouvier
2026-11-17  8:17 ` Daniel P. Berrangé
2026-11-17 17:01   ` Pierrick Bouvier
2026-11-17 17:03     ` Daniel P. Berrangé [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avyI084uxF7pMh0-@redhat.com \
    --to=berrange@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=farosas@suse.de \
    --cc=peterx@redhat.com \
    --cc=pierrick.bouvier@oss.qualcomm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.