All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] tests/docker/dockerfiles/release: use full registry name for image
@ 2026-11-16 23:23 Pierrick Bouvier
  2026-11-17  8:17 ` Daniel P. Berrangé
  0 siblings, 1 reply; 4+ messages in thread
From: Pierrick Bouvier @ 2026-11-16 23:23 UTC (permalink / raw)
  To: qemu-devel; +Cc: Fabiano Rosas, Alex Bennée, Pierrick Bouvier, Peter Xu

By default, podman does not have docker.io preconfigured as default
registry, so building fails.

Signed-off-by: Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>
---
 tests/docker/dockerfiles/release.docker | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/docker/dockerfiles/release.docker b/tests/docker/dockerfiles/release.docker
index ca6babde01e..a606eb5ee79 100644
--- a/tests/docker/dockerfiles/release.docker
+++ b/tests/docker/dockerfiles/release.docker
@@ -1,6 +1,6 @@
 ARG UBUNTU_VERSION="UBUNTU_VERSION_build_arg_must_be_set"
 
-FROM ubuntu:$UBUNTU_VERSION AS build
+FROM docker.io/ubuntu:$UBUNTU_VERSION AS build
 
 # add deb-src for apt build-dep
 RUN sed -e 's/Types: deb/Types: deb deb-src/' -i /etc/apt/sources.list.d/* || true
-- 
2.47.3



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] tests/docker/dockerfiles/release: use full registry name for image
  2026-11-16 23:23 [PATCH] tests/docker/dockerfiles/release: use full registry name for image Pierrick Bouvier
@ 2026-11-17  8:17 ` Daniel P. Berrangé
  2026-11-17 17:01   ` Pierrick Bouvier
  0 siblings, 1 reply; 4+ messages in thread
From: Daniel P. Berrangé @ 2026-11-17  8:17 UTC (permalink / raw)
  To: Pierrick Bouvier; +Cc: qemu-devel, Fabiano Rosas, Alex Bennée, Peter Xu

On Mon, Nov 16, 2026 at 04:23:11PM -0700, Pierrick Bouvier wrote:
> By default, podman does not have docker.io preconfigured as default
> registry, so building fails.
> 
> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>
> ---
>  tests/docker/dockerfiles/release.docker | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/docker/dockerfiles/release.docker b/tests/docker/dockerfiles/release.docker
> index ca6babde01e..a606eb5ee79 100644
> --- a/tests/docker/dockerfiles/release.docker
> +++ b/tests/docker/dockerfiles/release.docker
> @@ -1,6 +1,6 @@
>  ARG UBUNTU_VERSION="UBUNTU_VERSION_build_arg_must_be_set"
>  
> -FROM ubuntu:$UBUNTU_VERSION AS build
> +FROM docker.io/ubuntu:$UBUNTU_VERSION AS build

How about docker.io/library/ubuntu  to match our ubuntu2404.docker ?

>  
>  # add deb-src for apt build-dep
>  RUN sed -e 's/Types: deb/Types: deb deb-src/' -i /etc/apt/sources.list.d/* || true
> -- 
> 2.47.3
> 
> 

With regards,
Daniel
-- 
|: https://berrange.com       ~~        https://hachyderm.io/@berrange :|
|: https://libvirt.org          ~~          https://entangle-photo.org :|
|: https://pixelfed.art/berrange   ~~    https://fstop138.berrange.com :|



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] tests/docker/dockerfiles/release: use full registry name for image
  2026-11-17  8:17 ` Daniel P. Berrangé
@ 2026-11-17 17:01   ` Pierrick Bouvier
  2026-11-17 17:03     ` Daniel P. Berrangé
  0 siblings, 1 reply; 4+ messages in thread
From: Pierrick Bouvier @ 2026-11-17 17:01 UTC (permalink / raw)
  To: Daniel P. Berrangé
  Cc: qemu-devel, Fabiano Rosas, Alex Bennée, Peter Xu

On 11/17/2026 12:17 AM, Daniel P. Berrangé wrote:
> On Mon, Nov 16, 2026 at 04:23:11PM -0700, Pierrick Bouvier wrote:
>> By default, podman does not have docker.io preconfigured as default
>> registry, so building fails.
>>
>> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>
>> ---
>>  tests/docker/dockerfiles/release.docker | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tests/docker/dockerfiles/release.docker b/tests/docker/dockerfiles/release.docker
>> index ca6babde01e..a606eb5ee79 100644
>> --- a/tests/docker/dockerfiles/release.docker
>> +++ b/tests/docker/dockerfiles/release.docker
>> @@ -1,6 +1,6 @@
>>  ARG UBUNTU_VERSION="UBUNTU_VERSION_build_arg_must_be_set"
>>  
>> -FROM ubuntu:$UBUNTU_VERSION AS build
>> +FROM docker.io/ubuntu:$UBUNTU_VERSION AS build
> 
> How about docker.io/library/ubuntu  to match our ubuntu2404.docker ?
>

Sounds good to me, it's the same image behind the hoods and it's more
consistent.

>>  
>>  # add deb-src for apt build-dep
>>  RUN sed -e 's/Types: deb/Types: deb deb-src/' -i /etc/apt/sources.list.d/* || true
>> -- 
>> 2.47.3
>>
>>
> 
> With regards,
> Daniel



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] tests/docker/dockerfiles/release: use full registry name for image
  2026-11-17 17:01   ` Pierrick Bouvier
@ 2026-11-17 17:03     ` Daniel P. Berrangé
  0 siblings, 0 replies; 4+ messages in thread
From: Daniel P. Berrangé @ 2026-11-17 17:03 UTC (permalink / raw)
  To: Pierrick Bouvier; +Cc: qemu-devel, Fabiano Rosas, Alex Bennée, Peter Xu

On Tue, Nov 17, 2026 at 09:01:26AM -0800, Pierrick Bouvier wrote:
> On 11/17/2026 12:17 AM, Daniel P. Berrangé wrote:
> > On Mon, Nov 16, 2026 at 04:23:11PM -0700, Pierrick Bouvier wrote:
> >> By default, podman does not have docker.io preconfigured as default
> >> registry, so building fails.
> >>
> >> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>
> >> ---
> >>  tests/docker/dockerfiles/release.docker | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/tests/docker/dockerfiles/release.docker b/tests/docker/dockerfiles/release.docker
> >> index ca6babde01e..a606eb5ee79 100644
> >> --- a/tests/docker/dockerfiles/release.docker
> >> +++ b/tests/docker/dockerfiles/release.docker
> >> @@ -1,6 +1,6 @@
> >>  ARG UBUNTU_VERSION="UBUNTU_VERSION_build_arg_must_be_set"
> >>  
> >> -FROM ubuntu:$UBUNTU_VERSION AS build
> >> +FROM docker.io/ubuntu:$UBUNTU_VERSION AS build
> > 
> > How about docker.io/library/ubuntu  to match our ubuntu2404.docker ?
> >
> 
> Sounds good to me, it's the same image behind the hoods and it's more
> consistent.

With that changed, consider it to have

  Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com       ~~        https://hachyderm.io/@berrange :|
|: https://libvirt.org          ~~          https://entangle-photo.org :|
|: https://pixelfed.art/berrange   ~~    https://fstop138.berrange.com :|



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-11-17 17:03 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-16 23:23 [PATCH] tests/docker/dockerfiles/release: use full registry name for image Pierrick Bouvier
2026-11-17  8:17 ` Daniel P. Berrangé
2026-11-17 17:01   ` Pierrick Bouvier
2026-11-17 17:03     ` Daniel P. Berrangé

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.