From: Brian Norris <briannorris@chromium.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Subject: Re: [PATCH] tracing: 'select' GENERIC_TRACER, not 'depends'
Date: Tue, 17 Nov 2026 09:45:13 -0800 [thread overview]
Message-ID: <avySqRwpInSfLIgK@google.com> (raw)
In-Reply-To: <20261117085317.4ae87046@gandalf.local.home>
On Tue, Nov 17, 2026 at 08:53:17AM -0500, Steven Rostedt wrote:
> On Mon, 16 Nov 2026 14:46:53 -0800
> Brian Norris <briannorris@chromium.org> wrote:
>
> > GENERIC_TRACER is not a user-selectable symbol, so it's impossible to
> > enable FTRACE_STARTUP_TEST unless one also enables some other symbol
> > that 'selects' GENERIC_TRACER for us.
>
> I believe that was the way it was intended. The selftests are to test the
> things that select GENERIC_TRACER. Why would we enable tests for something
> that isn't enabled?
You may have discovered in your other reply, but these tests are
applicable to code used by EVENT_TRACING, which can be enabled without
GENERIC_TRACER.
But I do see how this still might not be exactly the right choice,
especially given some of sashiko's comments.
Brian
prev parent reply other threads:[~2026-11-17 17:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 22:46 [PATCH] tracing: 'select' GENERIC_TRACER, not 'depends' Brian Norris
2026-11-16 22:58 ` sashiko-bot
2026-11-17 13:55 ` Steven Rostedt
2026-11-17 18:23 ` Brian Norris
2026-11-17 18:36 ` sashiko-bot
2026-11-17 18:42 ` Brian Norris
2026-11-17 19:22 ` Steven Rostedt
2026-11-17 19:23 ` Steven Rostedt
2026-11-17 20:35 ` Brian Norris
2026-11-17 21:10 ` Steven Rostedt
2026-11-17 21:41 ` Brian Norris
2026-11-18 0:58 ` Masami Hiramatsu (Google)
2026-11-17 13:53 ` Steven Rostedt
2026-11-17 17:45 ` Brian Norris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avySqRwpInSfLIgK@google.com \
--to=briannorris@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.