All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brian Norris <briannorris@chromium.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: sashiko-bot@kernel.org, sashiko-reviews@lists.linux.dev,
	linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH] tracing: 'select' GENERIC_TRACER, not 'depends'
Date: Tue, 17 Nov 2026 13:41:18 -0800	[thread overview]
Message-ID: <avzJ_uvfpL2nPij7@google.com> (raw)
In-Reply-To: <20261117161011.59101930@gandalf.local.home>

On Tue, Nov 17, 2026 at 04:10:11PM -0500, Steven Rostedt wrote:
> On Tue, 17 Nov 2026 12:35:41 -0800
> Brian Norris <briannorris@chromium.org> wrote:
> 
> > On Tue, Nov 17, 2026 at 02:23:10PM -0500, Steven Rostedt wrote:
> > > On Tue, 17 Nov 2026 14:22:03 -0500
> > > Steven Rostedt <rostedt@goodmis.org> wrote:
> > > 
> > > As it doesn't need to be visible let's still have:  
> > 
> > What's wrong with visible? Hiding it is part of the confusion, because
> > it disappears when you select something else, even though it's still
> > effectively enabled.
> 
> Well, one thing, it's precedence.

Do you mean: because that's how you've done it previously? Or
precedence, as in "other tracers take precedence over a visible
EVENT_TRACING"?

> But another is that you can only deselect
> it if everything else is not selected.

Right, but that's pretty typical of interdependent features, I think.
And it's explicitly represented in the menu:

 - the non-deselectable item loses its box, to represent that it's no
   longer a checkbox that can be unchecked

 - if one wants to drill into "why can't I uncheck?", the Help option
   gives a good breakdown, with something like:

     Selected by [y]:
       - GENERIC_TRACER [=y]

   That gives you a burn-down of what other things must be disabled if
   you want to disable it.

Brian

  reply	other threads:[~2026-11-17 21:41 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 22:46 [PATCH] tracing: 'select' GENERIC_TRACER, not 'depends' Brian Norris
2026-11-16 22:58 ` sashiko-bot
2026-11-17 13:55   ` Steven Rostedt
2026-11-17 18:23     ` Brian Norris
2026-11-17 18:36       ` sashiko-bot
2026-11-17 18:42         ` Brian Norris
2026-11-17 19:22       ` Steven Rostedt
2026-11-17 19:23         ` Steven Rostedt
2026-11-17 20:35           ` Brian Norris
2026-11-17 21:10             ` Steven Rostedt
2026-11-17 21:41               ` Brian Norris [this message]
2026-11-18  0:58           ` Masami Hiramatsu (Google)
2026-11-17 13:53 ` Steven Rostedt
2026-11-17 17:45   ` Brian Norris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avzJ_uvfpL2nPij7@google.com \
    --to=briannorris@chromium.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=sashiko-bot@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.