All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Arnav Kapoor <kapoorarnav43@gmail.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Gwendal Grignou" <gwendal@chromium.org>,
	"Stephen Boyd" <swboyd@chromium.org>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/6] iio: proximity: sx9324: fix proximity threshold writes
Date: Tue, 17 Nov 2026 20:59:06 +0200	[thread overview]
Message-ID: <avyj-lOGvj04A_Ak@ashevche-desk.local> (raw)
In-Reply-To: <20261116205320.26070-3-kapoorarnav43@gmail.com>

On Tue, Nov 17, 2026 at 02:23:10AM +0530, Arnav Kapoor wrote:
> sx9324_read_thresh() reports a PROX_THRESH code r as r for r <= 1 and as
> r * r / 2 otherwise, but sx9324_write_thresh() converts back with
> int_sqrt(2 * val).

> For odd r the read value is (r * r - 1) / 2,

No, it's r²/2 but in integer arithmetics. That's why for odd number squares
it gives 1/2 that becomes 0.

> so writing back the value that was just read programs r - 1: setting the
> threshold to the value it already has lowers it, for 127 of the 256
> codes (3, 5, 7, ...).
> 
> The int to unsigned int conversion also lets some negative values
> through: 2 * val wraps, so e.g. INT_MIN is written as 0 and values just
> above INT_MIN as small thresholds instead of being rejected.
> 
> Reject negative values and use int_sqrt(2 * val + 1), which picks the
> largest code whose reported threshold does not exceed the requested
> value and makes read_thresh() and write_thresh() inverses of each
> other for all 256 codes.

So, for the read part

	reg		value
	0		0
	1		1
	2		2
	3		4
	4		8
	5		12
	6		18
	7		24
	....

For the write part (the negative is problematic only on 32-bit case IIUC)

	value		reg
	-INT_MIN	0
	-INT_MIN + 1	1
	-INT_MIN + 2	2
	-INT_MIN + 3	2
	...
	0		0
	1		1
	2		2
	3		2
	4		2	// has to be 3
	5		3
	6		3
	7		3
	8		4
	9		4
	...
	12		4	// has to be 5
	13		5
	...
	18		6
	...
	24		6	// has to be 7
	...

Yep, what we see is off-by-one for full squares. This is because division
by 2 in integer arithmetics makes it floor number. So, what you want
to have is a correction for all odd numbers.

...

> static int sx9324_write_thresh(struct sx_common_data *data,

>  	reg = SX9324_REG_PROX_CTRL6 + chan->channel / 2;

This one is not used in the conditionals, so the new check may well be done
before it.

> +	if (_val < 0)

Checking _val after assigning val to it is confusing.

> +		return -EINVAL;
> +
> +	/* Inverse of read_thresh(), so that writing back a read value is a no-op */
>  	if (val >= 1)

First of all, I would drop the '=' here.

> -		val = int_sqrt(2 * val);
> +		val = int_sqrt(2 * val + 1);

And here I would rather use (val % 2) instead of 1. See above why.

>  	if (val > 0xff)
>  		return -EINVAL;

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2026-11-17 18:59 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 20:53 [PATCH 0/6] iio: proximity: sx93xx: fix raw reads, thresholds, hysteresis and gain Arnav Kapoor
2026-11-16 20:53 ` [PATCH 1/6] iio: proximity: sx_common: fix raw reads while the trigger is in use Arnav Kapoor
2026-11-16 20:53 ` [PATCH 2/6] iio: proximity: sx9324: fix proximity threshold writes Arnav Kapoor
2026-11-17 18:59   ` Andy Shevchenko [this message]
2026-11-17 19:10     ` Arnav Kapoor
2026-11-18  7:01       ` Andy Shevchenko
2026-11-18 10:06         ` Arnav Kapoor
2026-11-16 20:53 ` [PATCH 3/6] iio: proximity: sx9324: reject negative hysteresis values Arnav Kapoor
2026-11-17 19:09   ` Andy Shevchenko
2026-11-17 19:15     ` Arnav Kapoor
2026-11-16 20:53 ` [PATCH 4/6] iio: proximity: sx9360: fix hardware gain encoding Arnav Kapoor
2026-11-16 20:53 ` [PATCH 5/6] iio: proximity: sx9360: fix proximity threshold writes Arnav Kapoor
2026-11-17 19:11   ` Andy Shevchenko
2026-11-16 20:53 ` [PATCH 6/6] iio: proximity: sx9360: reject negative hysteresis values Arnav Kapoor
2026-11-17 19:12   ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avyj-lOGvj04A_Ak@ashevche-desk.local \
    --to=andriy.shevchenko@intel.com \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=gwendal@chromium.org \
    --cc=jic23@kernel.org \
    --cc=kapoorarnav43@gmail.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=swboyd@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.