From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Arnav Kapoor <kapoorarnav43@gmail.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Gwendal Grignou" <gwendal@chromium.org>,
"Stephen Boyd" <swboyd@chromium.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/6] iio: proximity: sx9324: reject negative hysteresis values
Date: Tue, 17 Nov 2026 21:09:42 +0200 [thread overview]
Message-ID: <avymdpJluGiOnZEC@ashevche-desk.local> (raw)
In-Reply-To: <20261116205320.26070-4-kapoorarnav43@gmail.com>
On Tue, Nov 17, 2026 at 02:23:11AM +0530, Arnav Kapoor wrote:
> sx9324_write_hysteresis() copies the value into an unsigned int before
> comparing it with the threshold, so a negative value becomes a large
> one, passes the "val >= pthresh >> 2" check and sets the largest
> hysteresis instead of being rejected. Return -EINVAL for negative
> values.
As noticed earlier not all cases might have this issue, please elaborate if
this is for 32- and 64-bit cases or only for the former.
...
> unsigned int hyst, val = _val;
> int ret, pthresh;
>
> + if (_val < 0)
> + return -EINVAL;
Same (semantic) issue, you are checking variable after its use.
...
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-11-17 19:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 20:53 [PATCH 0/6] iio: proximity: sx93xx: fix raw reads, thresholds, hysteresis and gain Arnav Kapoor
2026-11-16 20:53 ` [PATCH 1/6] iio: proximity: sx_common: fix raw reads while the trigger is in use Arnav Kapoor
2026-11-16 20:53 ` [PATCH 2/6] iio: proximity: sx9324: fix proximity threshold writes Arnav Kapoor
2026-11-17 18:59 ` Andy Shevchenko
2026-11-17 19:10 ` Arnav Kapoor
2026-11-18 7:01 ` Andy Shevchenko
2026-11-18 10:06 ` Arnav Kapoor
2026-11-16 20:53 ` [PATCH 3/6] iio: proximity: sx9324: reject negative hysteresis values Arnav Kapoor
2026-11-17 19:09 ` Andy Shevchenko [this message]
2026-11-17 19:15 ` Arnav Kapoor
2026-11-16 20:53 ` [PATCH 4/6] iio: proximity: sx9360: fix hardware gain encoding Arnav Kapoor
2026-11-16 20:53 ` [PATCH 5/6] iio: proximity: sx9360: fix proximity threshold writes Arnav Kapoor
2026-11-17 19:11 ` Andy Shevchenko
2026-11-16 20:53 ` [PATCH 6/6] iio: proximity: sx9360: reject negative hysteresis values Arnav Kapoor
2026-11-17 19:12 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avymdpJluGiOnZEC@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=gwendal@chromium.org \
--cc=jic23@kernel.org \
--cc=kapoorarnav43@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.