All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Mladek <pmladek@suse.com>
To: Zack Rusin <zack.rusin@broadcom.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Baoquan He <baoquan.he@linux.dev>,
	Mike Rapoport <rppt@kernel.org>,
	Pasha Tatashin <pasha.tatashin@soleen.com>,
	Pratyush Yadav <pratyush@kernel.org>,
	Dave Young <ruirui.yang@linux.dev>,
	Borislav Petkov <bp@alien8.de>,
	Ajay Kaher <ajay.kaher@broadcom.com>,
	Alexey Makhalov <alexey.makhalov@broadcom.com>,
	x86@kernel.org, Joel Granados <joel.granados@kernel.org>,
	Thomas Gleixner <tglx@kernel.org>, Ingo Molnar <mingo@redhat.com>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	virtualization@lists.linux.dev,
	bcm-kernel-feedback-list@broadcom.com,
	linux-kernel@vger.kernel.org,
	John Ogness <john.ogness@linutronix.de>,
	Steven Rostedt <rostedt@goodmis.org>,
	Sergey Senozhatsky <senozhatsky@chromium.org>,
	Kees Cook <kees@kernel.org>, Jonathan Corbet <corbet@lwn.net>,
	Bo Gan <bo.gan@broadcom.com>,
	Brennan Lamoreaux <brennan.lamoreaux@broadcom.com>,
	kexec@lists.infradead.org, linux-doc@vger.kernel.org,
	"Guilherme G. Piccoli" <gpiccoli@igalia.com>,
	Maaz Mombasawala <maaz.mombasawala@broadcom.com>,
	Shuah Khan <skhan@linuxfoundation.org>,
	Randy Dunlap <rdunlap@infradead.org>,
	Stephen Brennan <stephen.s.brennan@oracle.com>,
	Michael Kelley <mhklinux@outlook.com>,
	Ian Forbes <ian.forbes@broadcom.com>,
	Bradley Morgan <brads@mainlining.org>
Subject: Re: [PATCH v4 1/4] panic: Add a platform panic notifier list
Date: Fri, 20 Nov 2026 09:36:37 +0100	[thread overview]
Message-ID: <awAGlQhpaLtrHCAR@pathway> (raw)
In-Reply-To: <3d156f7b5ec4f3d6f91e288a38f87d2368f1365f.1794980455.git.zack.rusin@broadcom.com>

On Wed 2026-11-18 01:01:48, Zack Rusin wrote:
> Some platforms set crash_kexec_post_notifiers so their crash handlers
> run before kdump. That also runs every other panic notifier and kmsg
> dumper before the crash kernel.
> 
> Add panic_notifiers_platform_list for platform callbacks that need to
> run early and are safe while other CPUs are still running. Call it
> from vpanic() before kdump and before stopping the other CPUs,
> independently of crash_kexec_post_notifiers.
> 
> Also call it from __crash_kexec() if a crash kernel is loaded, since a
> fatal oops can enter kdump without panic(). Call it before taking the
> kexec lock, so a callback that panics can still enter kdump. Run the
> list at most once, including when a callback panics.
> 
> Add disable_panic_notifiers_platform_list to skip these callbacks
> when debugging panic or kdump failures.
> 
> Suggested-by: Petr Mladek <pmladek@suse.com>
> Link: https://lore.kernel.org/r/ateYxCu63pRY9EGq@pathway.suse.cz
> Signed-off-by: Zack Rusin <zack.rusin@broadcom.com>

JFYI, it looks reasonable from my POV:

Reviewed-by: Petr Mladek <pmladek@suse.com>

Best Regards,
Petr

WARNING: multiple messages have this Message-ID (diff)
From: Petr Mladek <pmladek@suse.com>
To: Zack Rusin <zack.rusin@broadcom.com>
Cc: linux-doc@vger.kernel.org, Kees Cook <kees@kernel.org>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	Dave Young <ruirui.yang@linux.dev>,
	Stephen Brennan <stephen.s.brennan@oracle.com>,
	Bo Gan <bo.gan@broadcom.com>, "H. Peter Anvin" <hpa@zytor.com>,
	Pasha Tatashin <pasha.tatashin@soleen.com>,
	Jonathan Corbet <corbet@lwn.net>,
	Brennan Lamoreaux <brennan.lamoreaux@broadcom.com>,
	x86@kernel.org, Joel Granados <joel.granados@kernel.org>,
	Alexey Makhalov <alexey.makhalov@broadcom.com>,
	Ingo Molnar <mingo@redhat.com>,
	bcm-kernel-feedback-list@broadcom.com,
	Ajay Kaher <ajay.kaher@broadcom.com>,
	Bradley Morgan <brads@mainlining.org>,
	Baoquan He <baoquan.he@linux.dev>,
	John Ogness <john.ogness@linutronix.de>,
	virtualization@lists.linux.dev,
	Steven Rostedt <rostedt@goodmis.org>,
	Maaz Mombasawala <maaz.mombasawala@broadcom.com>,
	Borislav Petkov <bp@alien8.de>,
	Shuah Khan <skhan@linuxfoundation.org>,
	Michael Kelley <mhklinux@outlook.com>,
	Pratyush Yadav <pratyush@kernel.org>,
	Randy Dunlap <rdunlap@infradead.org>,
	kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
	Ian Forbes <ian.forbes@broadcom.com>,
	Sergey Senozhatsky <senozhatsky@chromium.org>,
	Thomas Gleixner <tglx@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Mike Rapoport <rppt@kernel.org>
Subject: Re: [PATCH v4 1/4] panic: Add a platform panic notifier list
Date: Fri, 20 Nov 2026 09:36:37 +0100	[thread overview]
Message-ID: <awAGlQhpaLtrHCAR@pathway> (raw)
In-Reply-To: <3d156f7b5ec4f3d6f91e288a38f87d2368f1365f.1794980455.git.zack.rusin@broadcom.com>

On Wed 2026-11-18 01:01:48, Zack Rusin wrote:
> Some platforms set crash_kexec_post_notifiers so their crash handlers
> run before kdump. That also runs every other panic notifier and kmsg
> dumper before the crash kernel.
> 
> Add panic_notifiers_platform_list for platform callbacks that need to
> run early and are safe while other CPUs are still running. Call it
> from vpanic() before kdump and before stopping the other CPUs,
> independently of crash_kexec_post_notifiers.
> 
> Also call it from __crash_kexec() if a crash kernel is loaded, since a
> fatal oops can enter kdump without panic(). Call it before taking the
> kexec lock, so a callback that panics can still enter kdump. Run the
> list at most once, including when a callback panics.
> 
> Add disable_panic_notifiers_platform_list to skip these callbacks
> when debugging panic or kdump failures.
> 
> Suggested-by: Petr Mladek <pmladek@suse.com>
> Link: https://lore.kernel.org/r/ateYxCu63pRY9EGq@pathway.suse.cz
> Signed-off-by: Zack Rusin <zack.rusin@broadcom.com>

JFYI, it looks reasonable from my POV:

Reviewed-by: Petr Mladek <pmladek@suse.com>

Best Regards,
Petr


  parent reply	other threads:[~2026-11-20  8:36 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18  6:01 [PATCH v4 0/4] panic, x86/vmware: Preserve crash logs before kdump Zack Rusin
2026-11-18  6:01 ` Zack Rusin
2026-11-18  6:01 ` [PATCH v4 1/4] panic: Add a platform panic notifier list Zack Rusin
2026-11-18  6:01   ` Zack Rusin
2026-11-18  6:16   ` sashiko-bot
2026-11-20  8:36   ` Petr Mladek [this message]
2026-11-20  8:36     ` Petr Mladek
2026-11-18  6:01 ` [PATCH v4 2/4] x86/vmware: Add a bounded panic log sender Zack Rusin
2026-11-18  6:01   ` Zack Rusin
2026-11-18  6:18   ` sashiko-bot
2026-11-18  6:18     ` sashiko-bot
2026-11-20  9:10   ` Petr Mladek
2026-11-20  9:10     ` Petr Mladek
2026-11-18  6:01 ` [PATCH v4 3/4] x86/vmware: Add the vmware_record_panic_msg sysctl Zack Rusin
2026-11-18  6:01   ` Zack Rusin
2026-11-18  6:14   ` sashiko-bot
2026-11-18  6:14     ` sashiko-bot
2026-11-18  6:42     ` Baoquan He
2026-11-18  6:42       ` Baoquan He
2026-11-18  7:02       ` Andrew Morton
2026-11-18  7:02         ` Andrew Morton
2026-11-18  7:51         ` Baoquan He
2026-11-18  7:51           ` Baoquan He
2026-11-18  7:53           ` Bradley Morgan
2026-11-18  7:53             ` Bradley Morgan
2026-11-18  8:09             ` Baoquan He
2026-11-18  8:09               ` Baoquan He
2026-11-19 11:07           ` Pratyush Yadav
2026-11-19 11:07             ` Pratyush Yadav
2026-11-19 15:35         ` Roman Gushchin
2026-11-19 15:35           ` Roman Gushchin
2026-11-18 14:36       ` Steven Rostedt
2026-11-18 14:36         ` Steven Rostedt
2026-11-20  9:19   ` Petr Mladek
2026-11-20  9:19     ` Petr Mladek
2026-11-18  6:01 ` [PATCH v4 4/4] x86/vmware: Report guest crashes after kmsg dumpers Zack Rusin
2026-11-18  6:01   ` Zack Rusin
2026-11-18  6:12   ` sashiko-bot
2026-11-18  6:12     ` sashiko-bot
2026-11-20 10:27   ` Petr Mladek
2026-11-20 10:27     ` Petr Mladek
2026-11-20 16:50     ` Zack Rusin
2026-11-20 16:50       ` Zack Rusin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=awAGlQhpaLtrHCAR@pathway \
    --to=pmladek@suse.com \
    --cc=ajay.kaher@broadcom.com \
    --cc=akpm@linux-foundation.org \
    --cc=alexey.makhalov@broadcom.com \
    --cc=baoquan.he@linux.dev \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=bo.gan@broadcom.com \
    --cc=bp@alien8.de \
    --cc=brads@mainlining.org \
    --cc=brennan.lamoreaux@broadcom.com \
    --cc=corbet@lwn.net \
    --cc=dave.hansen@linux.intel.com \
    --cc=gpiccoli@igalia.com \
    --cc=hpa@zytor.com \
    --cc=ian.forbes@broadcom.com \
    --cc=joel.granados@kernel.org \
    --cc=john.ogness@linutronix.de \
    --cc=kees@kernel.org \
    --cc=kexec@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maaz.mombasawala@broadcom.com \
    --cc=mhklinux@outlook.com \
    --cc=mingo@redhat.com \
    --cc=pasha.tatashin@soleen.com \
    --cc=pratyush@kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=rppt@kernel.org \
    --cc=ruirui.yang@linux.dev \
    --cc=senozhatsky@chromium.org \
    --cc=skhan@linuxfoundation.org \
    --cc=stephen.s.brennan@oracle.com \
    --cc=tglx@kernel.org \
    --cc=virtualization@lists.linux.dev \
    --cc=x86@kernel.org \
    --cc=zack.rusin@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.