All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Yitian Shao <fighters390@qq.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	jani.nikula@intel.com, sebastian.wick@redhat.com,
	uma.shankar@intel.com, suraj.kandpal@intel.com
Subject: Re: [PATCH v3 0/4] drm/i915/dp: Attach HDR_OUTPUT_METADATA on eDP
Date: Sat, 21 Nov 2026 03:43:40 +0200	[thread overview]
Message-ID: <awD3TIOlLBMHZvu6@intel.com> (raw)
In-Reply-To: <tencent_D31B4BA3A4E1F42313C008AFE786BB6D6F07@qq.com>

On Sat, Nov 21, 2026 at 08:54:05AM +0800, Yitian Shao wrote:
> This series makes HDR work on pre-ICL eDP panels that decode the metadata
> through the Intel AUX HDR interface instead of a gamut metadata DIP.
> 
> Patch 1 removes the LSPCON check from intel_dp_has_gamut_metadata_dip(),
> which made the helper answer the wrong question.
> 
> Patch 2 attaches HDR_OUTPUT_METADATA on eDP when the panel's TCON advertises
> PQ decoding, and skips the infoframe when no DIP is available.
> 
> Patch 3 is the pre-existing LSPCON issue pointed out during review: refuse
> HDR support when the port cannot transmit the gamut metadata DIP.
> 
> Patch 4 writes the content luminance over DPCD only when the SDP path is not
> in use, since the SDP takes precedence.

We still haven't solved the fastset issue, but I think we can mostly
sidestep it for now by always forcing a full modeset when the HDR
metadata changes.

Probably the most straightforward way to do that is by changing
intel_digital_connector_atomic_check() to flag connectors_changed=true
instead of mode_changed=true if the metadata changes on a connector
that uses the AUX HDR interface. A commit with connectors_change==true
will always result in a full modeset.

And I'm thinking that we do want that check to be just the
"are we using the HDR AUX interface" and nothing more. We should
not consider the SDP override stuff at all. That's because the HDR
AUX interface also sets up other stuff such as the 2084 decode and
segmented backlight. I believe this is in fact a pre-existing bug 
in the code; If the metadata changes between PQ and SDR but otherwise
remains in place we are currently failing to update the TCON.

Eventually we'll probably want a proper fastset support for this
stuff, but no need to rush it now IMO.

> 
> v3:
>  - Drop the LSPCON check from intel_dp_has_gamut_metadata_dip() and move it
>    to intel_dp_add_properties(), per Ville.
>  - Fold the checks into intel_dp_hdr_metadata_supported() instead of an
>    ever growing if-statement.
>  - Add the LSPCON DIP check as a separate patch, per Ville.
>  - Invert the content luminance condition: use DPCD when there is no SDP.
>  - Dropped the fastset concern from v2. The analysis was confirmed correct,
>    but HDR metadata fastset support is already broken and needs a separate
>    fix (possibly crtc_state->backlight_changed), so it does not belong here.
> 
> v2:
>  - Do not skip the infoframe on LSPCON (superseded by patch 1 and 2).
>  - Only attach the property when the Intel AUX HDR backlight interface is in
>    use, to avoid reading the untagged union.
> 
> Testing: CometLake-U (Gen9.5) laptop with a 3840x2160 10bpc eDP panel that
> advertises BT2020 + ST2084. With the equivalent change applied the connector
> exposes HDR_OUTPUT_METADATA, GNOME 50 offers the HDR switch, and the panel
> enters PQ/BT2020 mode. The TCON HDR backlight interface was already in use.
> v3 was compile-tested only; I have not re-run the runtime test.
> 
> Yitian Shao (4):
>   drm/i915/dp: Drop LSPCON check from intel_dp_has_gamut_metadata_dip()
>   drm/i915/dp: Attach HDR_OUTPUT_METADATA on eDP with TCON HDR support
>   drm/i915/display: Check gamut metadata DIP support in LSPCON HDR
>     detection
>   drm/i915/dp: Prefer SDP over DPCD for HDR content luminance
> 
>  drivers/gpu/drm/i915/display/intel_dp.c       | 32 ++++++++++++++++---
>  .../drm/i915/display/intel_dp_aux_backlight.c | 11 ++++++-
>  .../drm/i915/display/intel_dp_aux_backlight.h |  3 ++
>  drivers/gpu/drm/i915/display/intel_lspcon.c   |  5 +++
>  4 files changed, 46 insertions(+), 5 deletions(-)
> 
> -- 
> 2.53.0

-- 
Ville Syrjälä
Intel

  reply	other threads:[~2026-11-21  1:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-21  0:54 [PATCH v3 0/4] drm/i915/dp: Attach HDR_OUTPUT_METADATA on eDP Yitian Shao
2026-11-21  1:43 ` Ville Syrjälä [this message]
     [not found] <20261121005409.17626-1-fighters390@qq.com>
2026-11-21  1:17 ` Yitian Shao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=awD3TIOlLBMHZvu6@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=fighters390@qq.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=sebastian.wick@redhat.com \
    --cc=suraj.kandpal@intel.com \
    --cc=uma.shankar@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.