All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v3 0/4] drm/i915/dp: Attach HDR_OUTPUT_METADATA on eDP
@ 2026-11-21  0:54 Yitian Shao
  2026-11-21  1:43 ` Ville Syrjälä
  0 siblings, 1 reply; 3+ messages in thread
From: Yitian Shao @ 2026-11-21  0:54 UTC (permalink / raw)
  To: intel-gfx
  Cc: dri-devel, ville.syrjala, jani.nikula, sebastian.wick,
	uma.shankar, suraj.kandpal

This series makes HDR work on pre-ICL eDP panels that decode the metadata
through the Intel AUX HDR interface instead of a gamut metadata DIP.

Patch 1 removes the LSPCON check from intel_dp_has_gamut_metadata_dip(),
which made the helper answer the wrong question.

Patch 2 attaches HDR_OUTPUT_METADATA on eDP when the panel's TCON advertises
PQ decoding, and skips the infoframe when no DIP is available.

Patch 3 is the pre-existing LSPCON issue pointed out during review: refuse
HDR support when the port cannot transmit the gamut metadata DIP.

Patch 4 writes the content luminance over DPCD only when the SDP path is not
in use, since the SDP takes precedence.

v3:
 - Drop the LSPCON check from intel_dp_has_gamut_metadata_dip() and move it
   to intel_dp_add_properties(), per Ville.
 - Fold the checks into intel_dp_hdr_metadata_supported() instead of an
   ever growing if-statement.
 - Add the LSPCON DIP check as a separate patch, per Ville.
 - Invert the content luminance condition: use DPCD when there is no SDP.
 - Dropped the fastset concern from v2. The analysis was confirmed correct,
   but HDR metadata fastset support is already broken and needs a separate
   fix (possibly crtc_state->backlight_changed), so it does not belong here.

v2:
 - Do not skip the infoframe on LSPCON (superseded by patch 1 and 2).
 - Only attach the property when the Intel AUX HDR backlight interface is in
   use, to avoid reading the untagged union.

Testing: CometLake-U (Gen9.5) laptop with a 3840x2160 10bpc eDP panel that
advertises BT2020 + ST2084. With the equivalent change applied the connector
exposes HDR_OUTPUT_METADATA, GNOME 50 offers the HDR switch, and the panel
enters PQ/BT2020 mode. The TCON HDR backlight interface was already in use.
v3 was compile-tested only; I have not re-run the runtime test.

Yitian Shao (4):
  drm/i915/dp: Drop LSPCON check from intel_dp_has_gamut_metadata_dip()
  drm/i915/dp: Attach HDR_OUTPUT_METADATA on eDP with TCON HDR support
  drm/i915/display: Check gamut metadata DIP support in LSPCON HDR
    detection
  drm/i915/dp: Prefer SDP over DPCD for HDR content luminance

 drivers/gpu/drm/i915/display/intel_dp.c       | 32 ++++++++++++++++---
 .../drm/i915/display/intel_dp_aux_backlight.c | 11 ++++++-
 .../drm/i915/display/intel_dp_aux_backlight.h |  3 ++
 drivers/gpu/drm/i915/display/intel_lspcon.c   |  5 +++
 4 files changed, 46 insertions(+), 5 deletions(-)

-- 
2.53.0


^ permalink raw reply	[flat|nested] 3+ messages in thread
[parent not found: <20261121005409.17626-1-fighters390@qq.com>]

end of thread, other threads:[~2026-11-21  1:43 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-21  0:54 [PATCH v3 0/4] drm/i915/dp: Attach HDR_OUTPUT_METADATA on eDP Yitian Shao
2026-11-21  1:43 ` Ville Syrjälä
     [not found] <20261121005409.17626-1-fighters390@qq.com>
2026-11-21  1:17 ` Yitian Shao

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.