From: Daniel Golle <daniel@makrotopia.org>
To: Nicolas Dufresne <nicolas.dufresne@collabora.com>
Cc: Detlev Casanova <detlev.casanova@collabora.com>,
Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Heiko Stuebner <heiko@sntech.de>, Alex Bee <knaerzche@gmail.com>,
Hans Verkuil <hverkuil+cisco@kernel.org>,
Jonas Karlman <jonas@kwiboo.se>,
Sebastian Fricke <sebastian.fricke@collabora.com>,
linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/7] media: rkvdec: hevc: bound the RPS reads by the control size
Date: Fri, 20 Nov 2026 23:17:42 +0000 [thread overview]
Message-ID: <awDU_2e2yIVP5VMx@makrotopia.org> (raw)
In-Reply-To: <6ae6d1101d3f7095d11462579a5a3313153533e6.camel@collabora.com>
Hi Nicolas,
thanks for the review and sorry about the messy text.
On Mon, Nov 16, 2026 at 08:49:44AM -0500, Nicolas Dufresne wrote:
> Le samedi 14 novembre 2026 à 10:22 +0000, Daniel Golle a écrit :
> > The RPS helpers read num_short_term_ref_pic_sets elements of the
> > EXT_SPS_ST_RPS control and num_long_term_ref_pics_sps elements of the
> > EXT_SPS_LT_RPS control, however many elements userspace passed.
> >
>
> What did you want to say?
The number of RPS entries comes from the SPS control, the entries
themselves from the EXT_SPS_ST_RPS/LT_RPS array controls. The driver
never checks that the arrays are as long as the SPS says, so it reads
past the end of what userspace passed. I will reword the message
along these lines in v2.
>
> > Beyond
> > the passed elements they read stale entries of the control's array,
> > and past its allocation once the SPS counts more sets than the control
>
> More broken text, can you work a bit on your messages, be concise, precise,
> don't get into details but into the understanding of what you are achieving. The
> code is precise enough.
Got it. Reading it again now I understand your point, I may have been a
bit too excited about my findings on a Saturday morning...
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Golle <daniel@makrotopia.org>
To: Nicolas Dufresne <nicolas.dufresne@collabora.com>
Cc: Detlev Casanova <detlev.casanova@collabora.com>,
Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Heiko Stuebner <heiko@sntech.de>, Alex Bee <knaerzche@gmail.com>,
Hans Verkuil <hverkuil+cisco@kernel.org>,
Jonas Karlman <jonas@kwiboo.se>,
Sebastian Fricke <sebastian.fricke@collabora.com>,
linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/7] media: rkvdec: hevc: bound the RPS reads by the control size
Date: Fri, 20 Nov 2026 23:17:42 +0000 [thread overview]
Message-ID: <awDU_2e2yIVP5VMx@makrotopia.org> (raw)
In-Reply-To: <6ae6d1101d3f7095d11462579a5a3313153533e6.camel@collabora.com>
Hi Nicolas,
thanks for the review and sorry about the messy text.
On Mon, Nov 16, 2026 at 08:49:44AM -0500, Nicolas Dufresne wrote:
> Le samedi 14 novembre 2026 à 10:22 +0000, Daniel Golle a écrit :
> > The RPS helpers read num_short_term_ref_pic_sets elements of the
> > EXT_SPS_ST_RPS control and num_long_term_ref_pics_sps elements of the
> > EXT_SPS_LT_RPS control, however many elements userspace passed.
> >
>
> What did you want to say?
The number of RPS entries comes from the SPS control, the entries
themselves from the EXT_SPS_ST_RPS/LT_RPS array controls. The driver
never checks that the arrays are as long as the SPS says, so it reads
past the end of what userspace passed. I will reword the message
along these lines in v2.
>
> > Beyond
> > the passed elements they read stale entries of the control's array,
> > and past its allocation once the SPS counts more sets than the control
>
> More broken text, can you work a bit on your messages, be concise, precise,
> don't get into details but into the understanding of what you are achieving. The
> code is precise enough.
Got it. Reading it again now I understand your point, I may have been a
bit too excited about my findings on a Saturday morning...
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2026-11-20 23:18 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-14 10:22 [PATCH 0/7] media: rkvdec: Fix the HEVC reference picture set handling Daniel Golle
2026-11-14 10:22 ` Daniel Golle
2026-11-14 10:22 ` [PATCH 1/7] media: rkvdec: hevc: apply request controls first Daniel Golle
2026-11-14 10:22 ` Daniel Golle
2026-11-14 10:22 ` [PATCH 2/7] media: rkvdec: vdpu383: complete refused HEVC requests Daniel Golle
2026-11-14 10:22 ` Daniel Golle
2026-11-14 10:22 ` [PATCH 3/7] media: rkvdec: hevc: bound the RPS reads by the control size Daniel Golle
2026-11-14 10:22 ` Daniel Golle
2026-11-16 13:49 ` Nicolas Dufresne
2026-11-16 13:49 ` Nicolas Dufresne
2026-11-20 23:17 ` Daniel Golle [this message]
2026-11-20 23:17 ` Daniel Golle
2026-11-20 23:23 ` Daniel Golle
2026-11-20 23:23 ` Daniel Golle
2026-11-14 10:23 ` [PATCH 5/7] media: rkvdec: vdpu381: refuse HEVC jobs without RPS sets Daniel Golle
2026-11-14 10:23 ` Daniel Golle
2026-11-14 10:23 ` [PATCH 6/7] media: rkvdec: hevc: cache every short-term RPS set Daniel Golle
2026-11-14 10:23 ` Daniel Golle
2026-11-14 10:23 ` [PATCH 7/7] media: rkvdec: hevc: check the RPS scratch allocation Daniel Golle
2026-11-14 10:23 ` Daniel Golle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=awDU_2e2yIVP5VMx@makrotopia.org \
--to=daniel@makrotopia.org \
--cc=detlev.casanova@collabora.com \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=heiko@sntech.de \
--cc=hverkuil+cisco@kernel.org \
--cc=jonas@kwiboo.se \
--cc=knaerzche@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=nicolas.dufresne@collabora.com \
--cc=sebastian.fricke@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.