From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Yitian Shao <fighters390@qq.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
jani.nikula@intel.com, sebastian.wick@redhat.com,
uma.shankar@intel.com, suraj.kandpal@intel.com
Subject: Re: [PATCH v3 3/4] drm/i915/display: Check gamut metadata DIP support in LSPCON HDR detection
Date: Sat, 21 Nov 2026 03:21:54 +0200 [thread overview]
Message-ID: <awDyMsr6IOZoZHG_@intel.com> (raw)
In-Reply-To: <tencent_D44B8524BAF46993C808B9E7EEBB0AEF4C07@qq.com>
On Sat, Nov 21, 2026 at 08:54:08AM +0800, Yitian Shao wrote:
> intel_lspcon_detect_hdr_capability() asks the LSPCON whether it can do HDR,
> but not whether the port can actually transmit the gamut metadata DIP. If
> an LSPCON is hooked up to a port without that capability we would advertise
> HDR support that cannot be delivered.
>
> Refuse to claim HDR support in that case.
>
> Signed-off-by: Yitian Shao <fighters390@qq.com>
> ---
> drivers/gpu/drm/i915/display/intel_lspcon.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_lspcon.c b/drivers/gpu/drm/i915/display/intel_lspcon.c
> index 9ceabbc..797137d 100644
> --- a/drivers/gpu/drm/i915/display/intel_lspcon.c
> +++ b/drivers/gpu/drm/i915/display/intel_lspcon.c
> @@ -137,6 +137,11 @@ bool intel_lspcon_detect_hdr_capability(struct intel_digital_port *dig_port)
> u8 hdr_caps;
> int ret;
>
> + if (!intel_dp_has_gamut_metadata_dip(&dig_port->base)) {
> + lspcon->hdr_supported = false;
Maybe a bit redundant, but the other code paths also do this so
I think we do want the redundancy in the name of consistency.
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> + return false;
> + }
> +
> ret = drm_dp_dpcd_read(&intel_dp->aux, get_hdr_status_reg(lspcon),
> &hdr_caps, 1);
>
> --
> 2.53.0
--
Ville Syrjälä
Intel
next prev parent reply other threads:[~2026-11-21 1:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20261121005409.17626-1-fighters390@qq.com>
2026-11-21 0:54 ` [PATCH v3 1/4] drm/i915/dp: Drop LSPCON check from intel_dp_has_gamut_metadata_dip() Yitian Shao
2026-11-21 1:13 ` Ville Syrjälä
2026-11-21 0:54 ` [PATCH v3 2/4] drm/i915/dp: Attach HDR_OUTPUT_METADATA on eDP with TCON HDR support Yitian Shao
2026-11-21 1:20 ` Ville Syrjälä
2026-11-21 0:54 ` [PATCH v3 3/4] drm/i915/display: Check gamut metadata DIP support in LSPCON HDR detection Yitian Shao
2026-11-21 1:21 ` Ville Syrjälä [this message]
2026-11-21 0:54 ` [PATCH v3 4/4] drm/i915/dp: Prefer SDP over DPCD for HDR content luminance Yitian Shao
2026-11-21 1:28 ` Ville Syrjälä
2026-11-21 1:06 ` ✗ LGCI.VerificationFailed: failure for series starting with [v3,1/4] drm/i915/dp: Drop LSPCON check from intel_dp_has_gamut_metadata_dip() Patchwork
2026-11-21 1:17 ` [PATCH v3 0/4] drm/i915/dp: Attach HDR_OUTPUT_METADATA on eDP Yitian Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=awDyMsr6IOZoZHG_@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=fighters390@qq.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=sebastian.wick@redhat.com \
--cc=suraj.kandpal@intel.com \
--cc=uma.shankar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.