All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Yitian Shao <fighters390@qq.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	jani.nikula@intel.com, sebastian.wick@redhat.com,
	uma.shankar@intel.com, suraj.kandpal@intel.com
Subject: Re: [PATCH v3 4/4] drm/i915/dp: Prefer SDP over DPCD for HDR content luminance
Date: Sat, 21 Nov 2026 03:28:57 +0200	[thread overview]
Message-ID: <awDz2WfzlvnUSd9q@intel.com> (raw)
In-Reply-To: <tencent_10977788255152703A88096844DFF3EF9D06@qq.com>

On Sat, Nov 21, 2026 at 08:54:09AM +0800, Yitian Shao wrote:
> intel_dp_aux_write_content_luminance() skips the DPCD write when the
> encoder cannot send a gamut metadata SDP. That is backwards: the DPCD
> register is exactly what the AUX HDR interface uses on those platforms,
> while the SDP takes precedence where it is available.
> 
> Invert the check.
> 
> Signed-off-by: Yitian Shao <fighters390@qq.com>
> ---
>  drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
> index 8c7fd99..92516f3 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
> @@ -250,7 +250,11 @@ intel_dp_aux_write_content_luminance(struct intel_connector *connector,
>  	int ret;
>  	u8 buf[4];
>  
> -	if (!intel_dp_has_gamut_metadata_dip(connector->encoder))
> +	/*
> +	 * When the metadata is sent as a gamut metadata SDP it takes
> +	 * precedence over the DPCD based content luminance.
> +	 */
> +	if (intel_dp_has_gamut_metadata_dip(connector->encoder))

If we want to check something here then I think it would have to be the
same 'supports_sdp_colorimetry && intel_dp_has_gamut_metadata_dip()'
check we do when setting the INTEL_EDP_HDR_TCON_SDP_OVERRIDE_AUX bit.
That is the bit that tells the tcon which source of information
to use.

The other option is to check nothing and always write the value.
INTEL_EDP_HDR_TCON_SDP_OVERRIDE_AUX will then make the tcon ignore
the written value if it supports the SDP override.

>  		return;
>  
>  	buf[0] = hdr_metadata->hdmi_metadata_type1.max_cll & 0xFF;
> -- 
> 2.53.0

-- 
Ville Syrjälä
Intel

  reply	other threads:[~2026-11-21  1:29 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20261121005409.17626-1-fighters390@qq.com>
2026-11-21  0:54 ` [PATCH v3 1/4] drm/i915/dp: Drop LSPCON check from intel_dp_has_gamut_metadata_dip() Yitian Shao
2026-11-21  1:13   ` Ville Syrjälä
2026-11-21  0:54 ` [PATCH v3 2/4] drm/i915/dp: Attach HDR_OUTPUT_METADATA on eDP with TCON HDR support Yitian Shao
2026-11-21  1:20   ` Ville Syrjälä
2026-11-21  0:54 ` [PATCH v3 3/4] drm/i915/display: Check gamut metadata DIP support in LSPCON HDR detection Yitian Shao
2026-11-21  1:21   ` Ville Syrjälä
2026-11-21  0:54 ` [PATCH v3 4/4] drm/i915/dp: Prefer SDP over DPCD for HDR content luminance Yitian Shao
2026-11-21  1:28   ` Ville Syrjälä [this message]
2026-11-21  1:06 ` ✗ LGCI.VerificationFailed: failure for series starting with [v3,1/4] drm/i915/dp: Drop LSPCON check from intel_dp_has_gamut_metadata_dip() Patchwork
2026-11-21  1:17 ` [PATCH v3 0/4] drm/i915/dp: Attach HDR_OUTPUT_METADATA on eDP Yitian Shao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=awDz2WfzlvnUSd9q@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=fighters390@qq.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=sebastian.wick@redhat.com \
    --cc=suraj.kandpal@intel.com \
    --cc=uma.shankar@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.