From: Kaartic Sivaraam <kaartic.sivaraam@gmail.com>
To: Patrick Steinhardt <ps@pks.im>, git@vger.kernel.org
Cc: Karthik Nayak <karthik.188@gmail.com>
Subject: Re: [PATCH v2 0/7] setup: enforce repo passed to `create_repository()` has no state
Date: Mon, 28 Sep 2026 17:45:00 +0530 [thread overview]
Message-ID: <b0ec2ef9-7aef-4f7d-b31b-7141b39c2d24@gmail.com> (raw)
In-Reply-To: <20260928-pks-create-repository-stateless-v2-0-a03612f703fa@pks.im>
On 9/28/26 15:21, Patrick Steinhardt wrote:
>
> [... snip ...]
>
> 3: 3a7c197f1b = 3: 8dd89f144a builtin/init: refactor messy creation of leading directories
> 4: c3ced666bd = 4: f37db1b17d builtin/init: move handling of "core.sharedRepository" into "setup.c"
> 5: 25918a4ff6 = 5: db76d32f2c builtin/clone: don't apply "core.sharedRepository" to leading dirs
> 6: a742852675 ! 6: 19388a188c repository: adapt `repo_clear()` to fully reset the repository
> @@ Commit message
> some state because we don't make sure to clear the whole structure.
>
> Refactor the function to set the whole repository to all-zeroes to avoid
> - any kind of leaking state. While at it, make it a bit more robust when
> - called on an already-blank repository.
> + any kind of leaking state. Replace calls of `FREE_AND_NULL()` to instead
> + use free(3p) to avoid zeroing out the data twice.
>
s/free(3p)/free/
Rest of the inter-diff looks neat.
--
Sivaraam
next prev parent reply other threads:[~2026-09-28 12:15 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-24 9:19 [PATCH 0/7] setup: enforce repo passed to `create_repository()` has no state Patrick Steinhardt
2026-09-24 9:19 ` [PATCH 1/7] path: drop useless `safe_create_leading_directories_1()` Patrick Steinhardt
2026-09-28 9:01 ` Karthik Nayak
2026-09-24 9:19 ` [PATCH 2/7] path: introduce `safe_create_leading_directories_no_share_const()` Patrick Steinhardt
2026-09-25 19:49 ` Kaartic Sivaraam
2026-09-28 7:15 ` Patrick Steinhardt
2026-09-28 9:21 ` Kaartic Sivaraam
2026-09-24 9:19 ` [PATCH 3/7] builtin/init: refactor messy creation of leading directories Patrick Steinhardt
2026-09-25 20:21 ` Kaartic Sivaraam
2026-09-24 9:19 ` [PATCH 4/7] builtin/init: move handling of "core.sharedRepository" into "setup.c" Patrick Steinhardt
2026-09-25 20:54 ` Kaartic Sivaraam
2026-09-28 9:13 ` Karthik Nayak
2026-09-24 9:19 ` [PATCH 5/7] builtin/clone: don't apply "core.sharedRepository" to leading dirs Patrick Steinhardt
2026-09-24 9:19 ` [PATCH 6/7] repository: adapt `repo_clear()` to fully reset the repository Patrick Steinhardt
2026-09-28 9:18 ` Karthik Nayak
2026-09-28 9:52 ` Patrick Steinhardt
2026-09-24 9:19 ` [PATCH 7/7] setup: enforce that passed-in repo does not carry relevant state Patrick Steinhardt
2026-09-25 21:08 ` [PATCH 0/7] setup: enforce repo passed to `create_repository()` has no state Kaartic Sivaraam
2026-09-28 9:20 ` Karthik Nayak
2026-09-28 9:51 ` [PATCH v2 " Patrick Steinhardt
2026-09-28 9:51 ` [PATCH v2 1/7] path: drop useless `safe_create_leading_directories_1()` Patrick Steinhardt
2026-09-28 9:51 ` [PATCH v2 2/7] path: introduce `safe_create_leading_directories_no_share_const()` Patrick Steinhardt
2026-09-28 9:51 ` [PATCH v2 3/7] builtin/init: refactor messy creation of leading directories Patrick Steinhardt
2026-09-28 9:51 ` [PATCH v2 4/7] builtin/init: move handling of "core.sharedRepository" into "setup.c" Patrick Steinhardt
2026-09-28 9:51 ` [PATCH v2 5/7] builtin/clone: don't apply "core.sharedRepository" to leading dirs Patrick Steinhardt
2026-09-28 9:51 ` [PATCH v2 6/7] repository: adapt `repo_clear()` to fully reset the repository Patrick Steinhardt
2026-09-28 9:51 ` [PATCH v2 7/7] setup: enforce that passed-in repo does not carry relevant state Patrick Steinhardt
2026-09-28 12:15 ` Kaartic Sivaraam [this message]
2026-09-28 12:19 ` [PATCH v2 0/7] setup: enforce repo passed to `create_repository()` has no state Kaartic Sivaraam
2026-09-28 12:48 ` Patrick Steinhardt
2026-09-28 15:59 ` Junio C Hamano
2026-09-28 12:48 ` Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0ec2ef9-7aef-4f7d-b31b-7141b39c2d24@gmail.com \
--to=kaartic.sivaraam@gmail.com \
--cc=git@vger.kernel.org \
--cc=karthik.188@gmail.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.