From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: Kaartic Sivaraam <kaartic.sivaraam@gmail.com>,
Karthik Nayak <karthik.188@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH v2 0/7] setup: enforce repo passed to `create_repository()` has no state
Date: Mon, 28 Sep 2026 08:59:11 -0700 [thread overview]
Message-ID: <xmqqtsn9mkog.fsf@gitster.g> (raw)
In-Reply-To: <arpiK4chGRDnHXrW@pks.im> (Patrick Steinhardt's message of "Mon, 28 Sep 2026 14:48:43 +0200")
Patrick Steinhardt <ps@pks.im> writes:
>> Oops. I meant s/free(3p)/free(3)/
>
> Ah. 3p is correct though and refers to the POSIX man pages.
If used in a context where you really care about posix specified
behaviour and are interferred by differences among generic C
library's free() implementations, free(3p) may be the right way to
spell it out concisely.
Everywhere else, like in this patch where you do not care about the
distinction, the extra 'p' is merely a noise, I would have to say.
If you are writing a wrapper that _depends_ on your platform free()
being strictly posix compliant, then you might write something like
#ifdef WE_HAVE_POSIX_FREE
#define safe_free(x) free(x)
#else
static void safe_free(void *x)
{
...
}
#endif
and your commit log message may say "We use free(3p) where
available, but otherwise emulate it via platform free() with some
safety knob".
next prev parent reply other threads:[~2026-09-28 15:59 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-24 9:19 [PATCH 0/7] setup: enforce repo passed to `create_repository()` has no state Patrick Steinhardt
2026-09-24 9:19 ` [PATCH 1/7] path: drop useless `safe_create_leading_directories_1()` Patrick Steinhardt
2026-09-28 9:01 ` Karthik Nayak
2026-09-24 9:19 ` [PATCH 2/7] path: introduce `safe_create_leading_directories_no_share_const()` Patrick Steinhardt
2026-09-25 19:49 ` Kaartic Sivaraam
2026-09-28 7:15 ` Patrick Steinhardt
2026-09-28 9:21 ` Kaartic Sivaraam
2026-09-24 9:19 ` [PATCH 3/7] builtin/init: refactor messy creation of leading directories Patrick Steinhardt
2026-09-25 20:21 ` Kaartic Sivaraam
2026-09-24 9:19 ` [PATCH 4/7] builtin/init: move handling of "core.sharedRepository" into "setup.c" Patrick Steinhardt
2026-09-25 20:54 ` Kaartic Sivaraam
2026-09-28 9:13 ` Karthik Nayak
2026-09-24 9:19 ` [PATCH 5/7] builtin/clone: don't apply "core.sharedRepository" to leading dirs Patrick Steinhardt
2026-09-24 9:19 ` [PATCH 6/7] repository: adapt `repo_clear()` to fully reset the repository Patrick Steinhardt
2026-09-28 9:18 ` Karthik Nayak
2026-09-28 9:52 ` Patrick Steinhardt
2026-09-24 9:19 ` [PATCH 7/7] setup: enforce that passed-in repo does not carry relevant state Patrick Steinhardt
2026-09-25 21:08 ` [PATCH 0/7] setup: enforce repo passed to `create_repository()` has no state Kaartic Sivaraam
2026-09-28 9:20 ` Karthik Nayak
2026-09-28 9:51 ` [PATCH v2 " Patrick Steinhardt
2026-09-28 9:51 ` [PATCH v2 1/7] path: drop useless `safe_create_leading_directories_1()` Patrick Steinhardt
2026-09-28 9:51 ` [PATCH v2 2/7] path: introduce `safe_create_leading_directories_no_share_const()` Patrick Steinhardt
2026-09-28 9:51 ` [PATCH v2 3/7] builtin/init: refactor messy creation of leading directories Patrick Steinhardt
2026-09-28 9:51 ` [PATCH v2 4/7] builtin/init: move handling of "core.sharedRepository" into "setup.c" Patrick Steinhardt
2026-09-28 9:51 ` [PATCH v2 5/7] builtin/clone: don't apply "core.sharedRepository" to leading dirs Patrick Steinhardt
2026-09-28 9:51 ` [PATCH v2 6/7] repository: adapt `repo_clear()` to fully reset the repository Patrick Steinhardt
2026-09-28 9:51 ` [PATCH v2 7/7] setup: enforce that passed-in repo does not carry relevant state Patrick Steinhardt
2026-09-28 12:15 ` [PATCH v2 0/7] setup: enforce repo passed to `create_repository()` has no state Kaartic Sivaraam
2026-09-28 12:19 ` Kaartic Sivaraam
2026-09-28 12:48 ` Patrick Steinhardt
2026-09-28 15:59 ` Junio C Hamano [this message]
2026-09-28 12:48 ` Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtsn9mkog.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=kaartic.sivaraam@gmail.com \
--cc=karthik.188@gmail.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.