From: Dan Carpenter <dan.carpenter@linaro.org>
To: Su Hui <suhui@nfschina.com>
Cc: joel@jms.id.au, andrew@codeconstruct.com.au, robh@kernel.org,
arnd@arndb.de, gregkh@linuxfoundation.org, roblip@gmail.com,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] soc: aspeed: lpc: Fix impossible judgment condition
Date: Fri, 27 Oct 2023 07:38:19 +0300 [thread overview]
Message-ID: <b0fb2821-42e2-40e1-88f4-0a697cdb2a97@kadam.mountain> (raw)
In-Reply-To: <20231027020703.1231875-1-suhui@nfschina.com>
On Fri, Oct 27, 2023 at 10:07:04AM +0800, Su Hui wrote:
> smatch error：
> drivers/soc/aspeed/aspeed-lpc-snoop.c:169
> aspeed_lpc_snoop_config_irq() warn: platform_get_irq() does not return zero
>
> platform_get_irq() return non-zero IRQ number or negative error code,
> change '!lpc_snoop->irq' to 'lpc_snoop->irq < 0' to fix this.
>
> Fixes: 9f4f9ae81d0a ("drivers/misc: add Aspeed LPC snoop driver")
> Signed-off-by: Su Hui <suhui@nfschina.com>
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@linaro.org>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH] soc: aspeed: lpc: Fix impossible judgment condition
Date: Fri, 27 Oct 2023 07:38:19 +0300 [thread overview]
Message-ID: <b0fb2821-42e2-40e1-88f4-0a697cdb2a97@kadam.mountain> (raw)
In-Reply-To: <20231027020703.1231875-1-suhui@nfschina.com>
On Fri, Oct 27, 2023 at 10:07:04AM +0800, Su Hui wrote:
> smatch error?
> drivers/soc/aspeed/aspeed-lpc-snoop.c:169
> aspeed_lpc_snoop_config_irq() warn: platform_get_irq() does not return zero
>
> platform_get_irq() return non-zero IRQ number or negative error code,
> change '!lpc_snoop->irq' to 'lpc_snoop->irq < 0' to fix this.
>
> Fixes: 9f4f9ae81d0a ("drivers/misc: add Aspeed LPC snoop driver")
> Signed-off-by: Su Hui <suhui@nfschina.com>
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@linaro.org>
To: Su Hui <suhui@nfschina.com>
Cc: joel@jms.id.au, andrew@codeconstruct.com.au, robh@kernel.org,
arnd@arndb.de, gregkh@linuxfoundation.org, roblip@gmail.com,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] soc: aspeed: lpc: Fix impossible judgment condition
Date: Fri, 27 Oct 2023 07:38:19 +0300 [thread overview]
Message-ID: <b0fb2821-42e2-40e1-88f4-0a697cdb2a97@kadam.mountain> (raw)
In-Reply-To: <20231027020703.1231875-1-suhui@nfschina.com>
On Fri, Oct 27, 2023 at 10:07:04AM +0800, Su Hui wrote:
> smatch error：
> drivers/soc/aspeed/aspeed-lpc-snoop.c:169
> aspeed_lpc_snoop_config_irq() warn: platform_get_irq() does not return zero
>
> platform_get_irq() return non-zero IRQ number or negative error code,
> change '!lpc_snoop->irq' to 'lpc_snoop->irq < 0' to fix this.
>
> Fixes: 9f4f9ae81d0a ("drivers/misc: add Aspeed LPC snoop driver")
> Signed-off-by: Su Hui <suhui@nfschina.com>
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
regards,
dan carpenter
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-10-27 4:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-27 2:07 [PATCH] soc: aspeed: lpc: Fix impossible judgment condition Su Hui
2023-10-27 2:07 ` Su Hui
2023-10-27 2:07 ` Su Hui
2023-10-27 4:38 ` Dan Carpenter [this message]
2023-10-27 4:38 ` Dan Carpenter
2023-10-27 4:38 ` Dan Carpenter
2023-10-27 7:16 ` Greg KH
2023-10-27 7:16 ` Greg KH
2023-10-27 7:16 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0fb2821-42e2-40e1-88f4-0a697cdb2a97@kadam.mountain \
--to=dan.carpenter@linaro.org \
--cc=andrew@codeconstruct.com.au \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=joel@jms.id.au \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=roblip@gmail.com \
--cc=suhui@nfschina.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.