Re: Can't burn DVD under 2.5.59 with ide-cd

["Henning P. Schmiedehausen" <hps@intermeta.de>]

Jens Axboe <axboe@suse.de> writes:

>In drivers/ide/ide-cd.c:cdrom_end_request(), try to insert something
>ala:

>	if ((rq->flags & REQ_SENSE) && uptodate) {
>                struct request *failed = (struct request *) rq->buffer;
>                struct cdrom_info *info = drive->driver_data;
>                void *sense = &info->sense_data;

>+		if (failed && block_pc_request(failed))
>+			printk("%s: failed %p\n", __FUNCTION__, failed->sense);

>                if (failed && failed->sense)
>                        sense = failed->sense;

Shouldn't this be below the 2nd if() and then just test "sense" ?

Like 

>                if (failed && failed->sense)
>                        sense = failed->sense;

>+		if (failed && block_pc_request(failed))
>+			printk("%s: failed %p\n", __FUNCTION__, sense);

That makes sure, that you report what is analyzed later here:

>                cdrom_analyze_sense_data(drive, failed, sense);


	Regards
		Henning


-- 
Dipl.-Inf. (Univ.) Henning P. Schmiedehausen       -- Geschaeftsfuehrer
INTERMETA - Gesellschaft fuer Mehrwertdienste mbH     hps@intermeta.de

Am Schwabachgrund 22  Fon.: 09131 / 50654-0   info@intermeta.de
D-91054 Buckenhof     Fax.: 09131 / 50654-20