Re: [PATCH v2 4/6] selftests/mm: fix vm_util.c build failures: add snapshot of fs.h

[David Hildenbrand <david@redhat.com>]

On 14.06.24 04:30, John Hubbard wrote:
> On Ubuntu 23.04, on a clean git tree, the selftests/mm build fails due
> 10 or 20 missing items, all of which are found in fs.h, which is created
> via "make headers". However, as per [1], the idea is to stop requiring
> "make headers", and instead, take a snapshot of the files and check them
> in.
> 
> Here are a few of the build errors:
> 
> vm_util.c:34:21: error: variable has incomplete type 'struct pm_scan_arg'
>          struct pm_scan_arg arg;
> ...
> vm_util.c:45:28: error: use of undeclared identifier 'PAGE_IS_WPALLOWED'
> ...
> vm_util.c:55:21: error: variable has incomplete type 'struct page_region'
> ...
> vm_util.c:105:20: error: use of undeclared identifier 'PAGE_IS_SOFT_DIRTY'
> 
> To fix this, add fs.h, taken from a snapshot of ./usr/include/linux/fs.h
> after running "make headers".
> 
> [1] commit e076eaca5906 ("selftests: break the dependency upon local
> header files")
> 
> Cc: David Hildenbrand <david@redhat.com>
> Signed-off-by: John Hubbard <jhubbard@nvidia.com>
> ---

Acked-by: David Hildenbrand <david@redhat.com>

-- 
Cheers,

David / dhildenb