From: Dave Hansen <dave.hansen@intel.com>
To: John Hubbard <jhubbard@nvidia.com>,
Andrew Morton <akpm@linux-foundation.org>,
Jeff Xu <jeffxu@chromium.org>, Shuah Khan <shuah@kernel.org>
Cc: Andrei Vagin <avagin@google.com>,
Axel Rasmussen <axelrasmussen@google.com>,
Christian Brauner <brauner@kernel.org>,
David Hildenbrand <david@redhat.com>, Kees Cook <kees@kernel.org>,
Kent Overstreet <kent.overstreet@linux.dev>,
"Liam R . Howlett" <Liam.Howlett@oracle.com>,
Muhammad Usama Anjum <usama.anjum@collabora.com>,
Peter Xu <peterx@redhat.com>, Rich Felker <dalias@libc.org>,
linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 6/6] selftests/mm: remove local __NR_* definitions
Date: Wed, 12 Feb 2025 12:34:36 -0800 [thread overview]
Message-ID: <dc585017-6740-4cab-a536-b12b37a7582d@intel.com> (raw)
In-Reply-To: <20240614023009.221547-7-jhubbard@nvidia.com>
Hi John,
On 6/13/24 19:30, John Hubbard wrote:
> --- a/tools/testing/selftests/mm/protection_keys.c
> +++ b/tools/testing/selftests/mm/protection_keys.c
> @@ -42,7 +42,7 @@
> #include <sys/wait.h>
> #include <sys/stat.h>
> #include <fcntl.h>
> -#include <unistd.h>
> +#include <linux/unistd.h>
> #include <sys/ptrace.h>
> #include <setjmp.h>
I'm not quite sure how but this broke the protection_keys.c selftest for
me. Before this commit (a5c6bc590094a1a73cf6fa3f505e1945d2bf2461) things
are fine. But after, I get:
running PKEY tests for unsupported CPU/OS
The "unsupported" test just makes a pkey_alloc() syscall. It's probably
calling the wrong syscall number or something.
I think it's still broken in mainline. What's the right fix?
next prev parent reply other threads:[~2025-02-12 20:34 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-14 2:30 [PATCH v2 0/6] cleanups, fixes, and progress towards avoiding "make headers" John Hubbard
2024-06-14 2:30 ` [PATCH v2 1/6] selftests/mm: mseal, self_elf: fix missing __NR_mseal John Hubbard
2024-06-14 12:28 ` David Hildenbrand
2024-06-14 12:41 ` David Hildenbrand
2024-06-14 18:02 ` John Hubbard
2024-06-17 18:11 ` David Hildenbrand
2024-06-18 1:52 ` John Hubbard
2024-06-14 2:30 ` [PATCH v2 2/6] selftests/mm: mseal, self_elf: factor out test macros and other duplicated items John Hubbard
2024-06-14 12:28 ` David Hildenbrand
2024-06-14 14:56 ` Jeff Xu
2024-06-14 2:30 ` [PATCH v2 3/6] selftests/mm: mseal, self_elf: rename TEST_END_CHECK to REPORT_TEST_PASS John Hubbard
2024-06-14 12:29 ` David Hildenbrand
2024-06-14 2:30 ` [PATCH v2 4/6] selftests/mm: fix vm_util.c build failures: add snapshot of fs.h John Hubbard
2024-06-14 12:29 ` David Hildenbrand
2024-06-14 2:30 ` [PATCH v2 5/6] selftests/mm: kvm, mdwe fixes to avoid requiring "make headers" John Hubbard
2024-06-14 12:31 ` David Hildenbrand
2024-06-15 0:09 ` John Hubbard
2024-06-14 2:30 ` [PATCH v2 6/6] selftests/mm: remove local __NR_* definitions John Hubbard
2024-06-14 12:32 ` David Hildenbrand
2025-02-12 20:34 ` Dave Hansen [this message]
2025-02-12 22:31 ` John Hubbard
2025-02-13 11:32 ` Li Wang
2025-02-13 20:47 ` John Hubbard
2025-02-13 8:04 ` John Hubbard
2025-02-13 15:00 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc585017-6740-4cab-a536-b12b37a7582d@intel.com \
--to=dave.hansen@intel.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=avagin@google.com \
--cc=axelrasmussen@google.com \
--cc=brauner@kernel.org \
--cc=dalias@libc.org \
--cc=david@redhat.com \
--cc=jeffxu@chromium.org \
--cc=jhubbard@nvidia.com \
--cc=kees@kernel.org \
--cc=kent.overstreet@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=peterx@redhat.com \
--cc=shuah@kernel.org \
--cc=usama.anjum@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.