All of lore.kernel.org
 help / color / mirror / Atom feed
From: <Tudor.Ambarus@microchip.com>
To: <alexander.sverdlin@nokia.com>, <linux-mtd@lists.infradead.org>,
	<mika.westerberg@linux.intel.com>
Cc: computersforpeace@gmail.com, bbrezillon@kernel.org,
	richard@nod.at, romain.porte@nokia.com, stable@vger.kernel.org,
	marek.vasut@gmail.com, pascal.fabreges@nokia.com,
	bmeng.cn@gmail.com, dwmw2@infradead.org
Subject: Re: [PATCH v4] mtd: spi-nor: intel-spi: Avoid crossing 4K address boundary on read/write
Date: Thu, 21 Mar 2019 16:48:11 +0000	[thread overview]
Message-ID: <b2cb3593-12bd-3e45-ebc3-e6633add93ae@microchip.com> (raw)
In-Reply-To: <20190319171749.19052-1-alexander.sverdlin@nokia.com>



On 03/19/2019 07:18 PM, Sverdlin, Alexander (Nokia - DE/Ulm) wrote:
> From: Alexander Sverdlin <alexander.sverdlin@nokia.com>
> 
> It was observed that reads crossing 4K address boundary are failing.
> 
> This limitation is mentioned in Intel documents:
> 
> Intel(R) 9 Series Chipset Family Platform Controller Hub (PCH) Datasheet:
> 
> "5.26.3 Flash Access
> Program Register Access:
> * Program Register Accesses are not allowed to cross a 4 KB boundary..."
> 
> Enhanced Serial Peripheral Interface (eSPI)
> Interface Base Specification (for Client and Server Platforms):
> 
> "5.1.4 Address
> For other memory transactions, the address may start or end at any byte
> boundary. However, the address and payload length combination must not
> cross the naturally aligned address boundary of the corresponding Maximum
> Payload Size. It must not cross a 4 KB address boundary."
> 
> Avoid this by splitting an operation crossing the boundary into two
> operations.
> 
> Cc: stable@vger.kernel.org
> Reported-by: Romain Porte <romain.porte@nokia.com>
> Tested-by: Pascal Fabreges <pascal.fabreges@nokia.com>
> Signed-off-by: Alexander Sverdlin <alexander.sverdlin@nokia.com>
> ---
> Changelog:
> v2: More macros! As suggested by Mika.
> v3: Actually compiled. Sorry Mika, the lines are really long now.
> v4: Add "mtd:" to the subject
> 
>  drivers/mtd/spi-nor/intel-spi.c | 8 ++++++++
>  1 file changed, 8 insertions(+)

Applied to http://git.infradead.org/linux-mtd.git, spi-nor/next. Thanks.
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: <Tudor.Ambarus@microchip.com>
To: <alexander.sverdlin@nokia.com>, <linux-mtd@lists.infradead.org>,
	<mika.westerberg@linux.intel.com>
Cc: <marek.vasut@gmail.com>, <dwmw2@infradead.org>,
	<computersforpeace@gmail.com>, <bbrezillon@kernel.org>,
	<richard@nod.at>, <bmeng.cn@gmail.com>, <romain.porte@nokia.com>,
	<pascal.fabreges@nokia.com>, <stable@vger.kernel.org>
Subject: Re: [PATCH v4] mtd: spi-nor: intel-spi: Avoid crossing 4K address boundary on read/write
Date: Thu, 21 Mar 2019 16:48:11 +0000	[thread overview]
Message-ID: <b2cb3593-12bd-3e45-ebc3-e6633add93ae@microchip.com> (raw)
In-Reply-To: <20190319171749.19052-1-alexander.sverdlin@nokia.com>



On 03/19/2019 07:18 PM, Sverdlin, Alexander (Nokia - DE/Ulm) wrote:
> From: Alexander Sverdlin <alexander.sverdlin@nokia.com>
> 
> It was observed that reads crossing 4K address boundary are failing.
> 
> This limitation is mentioned in Intel documents:
> 
> Intel(R) 9 Series Chipset Family Platform Controller Hub (PCH) Datasheet:
> 
> "5.26.3 Flash Access
> Program Register Access:
> * Program Register Accesses are not allowed to cross a 4 KB boundary..."
> 
> Enhanced Serial Peripheral Interface (eSPI)
> Interface Base Specification (for Client and Server Platforms):
> 
> "5.1.4 Address
> For other memory transactions, the address may start or end at any byte
> boundary. However, the address and payload length combination must not
> cross the naturally aligned address boundary of the corresponding Maximum
> Payload Size. It must not cross a 4 KB address boundary."
> 
> Avoid this by splitting an operation crossing the boundary into two
> operations.
> 
> Cc: stable@vger.kernel.org
> Reported-by: Romain Porte <romain.porte@nokia.com>
> Tested-by: Pascal Fabreges <pascal.fabreges@nokia.com>
> Signed-off-by: Alexander Sverdlin <alexander.sverdlin@nokia.com>
> ---
> Changelog:
> v2: More macros! As suggested by Mika.
> v3: Actually compiled. Sorry Mika, the lines are really long now.
> v4: Add "mtd:" to the subject
> 
>  drivers/mtd/spi-nor/intel-spi.c | 8 ++++++++
>  1 file changed, 8 insertions(+)

Applied to http://git.infradead.org/linux-mtd.git, spi-nor/next. Thanks.

  parent reply	other threads:[~2019-03-21 16:50 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-13  8:21 [PATCH v3] spi-nor: intel-spi: Avoid crossing 4K address boundary on read/write Sverdlin, Alexander (Nokia - DE/Ulm)
2019-03-13  8:21 ` Sverdlin, Alexander (Nokia - DE/Ulm)
2019-03-13 10:56 ` Mika Westerberg
2019-03-13 10:56   ` Mika Westerberg
2019-03-19 16:29 ` Tudor.Ambarus
2019-03-19 16:29   ` Tudor.Ambarus
2019-03-19 16:50   ` Sverdlin, Alexander (Nokia - DE/Ulm)
2019-03-19 16:50     ` Sverdlin, Alexander (Nokia - DE/Ulm)
2019-03-25  0:38     ` Sasha Levin
2019-03-19 16:52   ` Sverdlin, Alexander (Nokia - DE/Ulm)
2019-03-19 16:52     ` Sverdlin, Alexander (Nokia - DE/Ulm)
2019-03-19 17:18   ` [PATCH v4] mtd: " Sverdlin, Alexander (Nokia - DE/Ulm)
2019-03-19 17:18     ` Sverdlin, Alexander (Nokia - DE/Ulm)
2019-03-20  6:49     ` Tudor.Ambarus
2019-03-20  6:49       ` Tudor.Ambarus
2019-03-20  7:39       ` Mika Westerberg
2019-03-20  7:39         ` Mika Westerberg
2019-03-21 16:48     ` Tudor.Ambarus [this message]
2019-03-21 16:48       ` Tudor.Ambarus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b2cb3593-12bd-3e45-ebc3-e6633add93ae@microchip.com \
    --to=tudor.ambarus@microchip.com \
    --cc=alexander.sverdlin@nokia.com \
    --cc=bbrezillon@kernel.org \
    --cc=bmeng.cn@gmail.com \
    --cc=computersforpeace@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=marek.vasut@gmail.com \
    --cc=mika.westerberg@linux.intel.com \
    --cc=pascal.fabreges@nokia.com \
    --cc=richard@nod.at \
    --cc=romain.porte@nokia.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.