From: Paolo Bonzini <pbonzini@redhat.com>
To: Sean Christopherson <seanjc@google.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH v2 5/5] KVM: x86: allow defining return-0 static calls
Date: Tue, 15 Feb 2022 19:07:23 +0100 [thread overview]
Message-ID: <b34d235f-e22a-71dc-0c20-7be46d2182ff@redhat.com> (raw)
In-Reply-To: <Ygvi5jr4V8S/bKSe@google.com>
On 2/15/22 18:29, Sean Christopherson wrote:
> s/KVM_X86_OP_RET0/KVM_X86_OP_OPTIONAL_RET0
>
> And maybe "NULL func" instead of "NULL value", since some members of kvm_x86_ops
> hold a value, not a func.
>
>> struct kvm_x86_ops will be changed to __static_call_return0.
> This implies kvm_x86_ops itself is changed, which is incorrect. "will be patched
> to __static_call_return0() when updating static calls" or so.
>
Very good point, thanks.
Paolo
prev parent reply other threads:[~2022-02-15 18:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-14 13:16 [PATCH v2 0/5] kvm: x86: better handling of optional kvm_x86_ops Paolo Bonzini
2022-02-14 13:16 ` [PATCH v2 1/5] KVM: x86: use static_call_cond for optional callbacks Paolo Bonzini
2022-02-15 16:55 ` Sean Christopherson
2022-02-14 13:16 ` [PATCH v2 2/5] KVM: x86: remove KVM_X86_OP_NULL and mark optional kvm_x86_ops Paolo Bonzini
2022-02-15 17:08 ` Sean Christopherson
2022-02-15 17:09 ` Paolo Bonzini
2022-02-14 13:16 ` [PATCH v2 3/5] KVM: x86: warn on incorrectly NULL static calls Paolo Bonzini
2022-02-15 17:10 ` Sean Christopherson
2022-02-14 13:16 ` [PATCH v2 4/5] KVM: x86: make several APIC virtualization callbacks optional Paolo Bonzini
2022-02-15 17:12 ` Sean Christopherson
2022-02-14 13:16 ` [PATCH v2 5/5] KVM: x86: allow defining return-0 static calls Paolo Bonzini
2022-02-15 17:29 ` Sean Christopherson
2022-02-15 18:07 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b34d235f-e22a-71dc-0c20-7be46d2182ff@redhat.com \
--to=pbonzini@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=seanjc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.