Re: [Intel-wired-lan] [PATCH iwl-next v1 1/1] igc: add support for ethtool.set_phys_id

[Jacob Keller <jacob.e.keller@intel.com>]

On 5/23/2024 1:44 AM, Przemek Kitszel wrote:
> On 5/22/24 11:19, Vitaly Lifshits wrote:
>> Add support for ethtool.set_phys_id callback to initiate LED blinking
>> and stopping them by the ethtool interface.
>> This is done by storing the initial LEDCTL register value and restoring
>> it when LED blinking is terminated.
>>
>> In addition, moved IGC_LEDCTL related defines from igc_leds.c to
>> igc_defines.h where they can be included by all of the igc module
>> files.
>>
>> Signed-off-by: Vitaly Lifshits <vitaly.lifshits@intel.com>
>> Signed-off-by: Menachem Fogel <menachem.fogel@intel.com>
> 
> sender's SoB should be last.
> Should, by any chance, Menachem be marked as an author of this change?
> 
> side note: we should CC netdev and obey netdev rules, like not sending
> -next content during window being closed for new submissions
> https://patchwork.hopto.org/net-next.html
> 
> 

My understanding is that Intel Wired LAN is a little more relaxed with
accepting iwl-next queued submissions even when net-next is closed. They
of course won't get sent until the merge window opens, but we can queue
and validate them internally during this time. I guess since we started
Cc'ing both intel-wired-lan and netdev, that might not be the case
anymore? Certainly in cases like this (where netdev isn't even on the cc
at all) it does not matter.