From: "naamax.meir" <naamax.meir@linux.intel.com>
To: Vitaly Lifshits <vitaly.lifshits@intel.com>, intel-wired-lan@osuosl.org
Cc: kurt@linutronix.de, Menachem Fogel <menachem.fogel@intel.com>,
lukas@wunner.de
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v1 1/1] igc: add support for ethtool.set_phys_id
Date: Sun, 2 Jun 2024 13:17:40 +0300 [thread overview]
Message-ID: <bd7cd5ac-3f7d-4710-8248-14a33943d3b2@linux.intel.com> (raw)
In-Reply-To: <20240522091911.2862403-1-vitaly.lifshits@intel.com>
On 5/22/2024 12:19, Vitaly Lifshits wrote:
> Add support for ethtool.set_phys_id callback to initiate LED blinking
> and stopping them by the ethtool interface.
> This is done by storing the initial LEDCTL register value and restoring
> it when LED blinking is terminated.
>
> In addition, moved IGC_LEDCTL related defines from igc_leds.c to
> igc_defines.h where they can be included by all of the igc module
> files.
>
> Signed-off-by: Vitaly Lifshits <vitaly.lifshits@intel.com>
> Signed-off-by: Menachem Fogel <menachem.fogel@intel.com>
> ---
> drivers/net/ethernet/intel/igc/igc_defines.h | 22 ++++++++++++++
> drivers/net/ethernet/intel/igc/igc_ethtool.c | 32 ++++++++++++++++++++
> drivers/net/ethernet/intel/igc/igc_hw.h | 2 ++
> drivers/net/ethernet/intel/igc/igc_leds.c | 21 +------------
> drivers/net/ethernet/intel/igc/igc_main.c | 2 ++
> 5 files changed, 59 insertions(+), 20 deletions(-)
Tested-by: Naama Meir <naamax.meir@linux.intel.com>
prev parent reply other threads:[~2024-06-02 10:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-22 9:19 [Intel-wired-lan] [PATCH iwl-next v1 1/1] igc: add support for ethtool.set_phys_id Vitaly Lifshits
2024-05-23 8:44 ` Przemek Kitszel
2024-05-23 18:27 ` Jacob Keller
2024-06-02 10:17 ` naamax.meir [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd7cd5ac-3f7d-4710-8248-14a33943d3b2@linux.intel.com \
--to=naamax.meir@linux.intel.com \
--cc=intel-wired-lan@osuosl.org \
--cc=kurt@linutronix.de \
--cc=lukas@wunner.de \
--cc=menachem.fogel@intel.com \
--cc=vitaly.lifshits@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.