From: Petr Cvek <petr.cvek@tul.cz>
To: Robert Jarzmik <robert.jarzmik@free.fr>
Cc: ulf.hansson@linaro.org, linux-mmc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/4] mmc: pxamci: Disable DATA_TRAN_DONE interrupt sooner
Date: Fri, 21 Apr 2017 01:37:04 +0200 [thread overview]
Message-ID: <b3b51174-970f-fed1-060f-21ea8b6ee4dc@tul.cz> (raw)
In-Reply-To: <87k26g6whu.fsf@belgarion.home>
Dne 19.4.2017 v 21:14 Robert Jarzmik napsal(a):
> Petr Cvek <petr.cvek@tul.cz> writes:
>
>> Disable the DATA_TRAN_DONE interrupt as soon as possible in the handler.
> Yeah, but why, please explain.
> If that's only to "reduce" the race occurrence, then I'd rather have this patch
> dropped. Otherwise if there is a compelling reason let's see ...
>
I created it during researching where put the IRQ enable in the callback and then I left it that way the data done interrupt will be disabled if there was an error at the beginning of the pxamci_data_done().
I dropped the patch and re-tested and it works (in the case the tests at the start of the pxamci_data_done() fail there will be probably some irq hell though :-D).
> Cheers.
>
WARNING: multiple messages have this Message-ID (diff)
From: petr.cvek@tul.cz (Petr Cvek)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/4] mmc: pxamci: Disable DATA_TRAN_DONE interrupt sooner
Date: Fri, 21 Apr 2017 01:37:04 +0200 [thread overview]
Message-ID: <b3b51174-970f-fed1-060f-21ea8b6ee4dc@tul.cz> (raw)
In-Reply-To: <87k26g6whu.fsf@belgarion.home>
Dne 19.4.2017 v 21:14 Robert Jarzmik napsal(a):
> Petr Cvek <petr.cvek@tul.cz> writes:
>
>> Disable the DATA_TRAN_DONE interrupt as soon as possible in the handler.
> Yeah, but why, please explain.
> If that's only to "reduce" the race occurrence, then I'd rather have this patch
> dropped. Otherwise if there is a compelling reason let's see ...
>
I created it during researching where put the IRQ enable in the callback and then I left it that way the data done interrupt will be disabled if there was an error at the beginning of the pxamci_data_done().
I dropped the patch and re-tested and it works (in the case the tests at the start of the pxamci_data_done() fail there will be probably some irq hell though :-D).
> Cheers.
>
next prev parent reply other threads:[~2017-04-20 23:36 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1492492523.git.petr.cvek@tul.cz>
2017-04-18 23:16 ` [PATCH 1/4] mmc: pxamci: Use the right flags for DMA callback init Petr Cvek
2017-04-18 23:16 ` Petr Cvek
2017-04-21 0:31 ` Petr Cvek
2017-04-21 0:31 ` Petr Cvek
2017-04-18 23:17 ` [PATCH 2/4] mmc: pxamci: Enhance error checking Petr Cvek
2017-04-18 23:17 ` Petr Cvek
2017-04-19 19:12 ` Robert Jarzmik
2017-04-19 19:12 ` Robert Jarzmik
2017-04-18 23:17 ` [PATCH 3/4] mmc: pxamci: Disable DATA_TRAN_DONE interrupt sooner Petr Cvek
2017-04-18 23:17 ` Petr Cvek
2017-04-19 19:14 ` Robert Jarzmik
2017-04-19 19:14 ` Robert Jarzmik
2017-04-20 23:37 ` Petr Cvek [this message]
2017-04-20 23:37 ` Petr Cvek
2017-04-18 23:18 ` [PATCH 4/4] mmc: pxamci: Fix race condition between pxamci_dma_irq() and pxamci_irq() Petr Cvek
2017-04-18 23:18 ` Petr Cvek
2017-04-19 19:22 ` Robert Jarzmik
2017-04-19 19:22 ` Robert Jarzmik
2017-04-21 1:30 ` Petr Cvek
2017-04-21 1:30 ` Petr Cvek
2017-04-27 13:14 ` Robert Jarzmik
2017-04-27 13:14 ` Robert Jarzmik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3b51174-970f-fed1-060f-21ea8b6ee4dc@tul.cz \
--to=petr.cvek@tul.cz \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=robert.jarzmik@free.fr \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.