From: Helge Deller <deller@gmx.de>
To: Yang Yingliang <yangyingliang@huawei.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-fbdev@vger.kernel.org
Cc: mpe@ellerman.id.au, christophe.leroy@csgroup.eu,
benh@kernel.crashing.org
Subject: Re: [PATCH -next] video: fbdev: chipsfb: add missing pci_disable_device() in chipsfb_pci_init()
Date: Mon, 22 Aug 2022 22:11:58 +0200 [thread overview]
Message-ID: <b3c19a63-d9f8-028b-e59a-e428be1ed8be@gmx.de> (raw)
In-Reply-To: <20220819085752.1909541-1-yangyingliang@huawei.com>
On 8/19/22 10:57, Yang Yingliang wrote:
> Add missing pci_disable_device() in error path in chipsfb_pci_init().
>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
applied.
Thanks!
Helge
> ---
> drivers/video/fbdev/chipsfb.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/video/fbdev/chipsfb.c b/drivers/video/fbdev/chipsfb.c
> index 393894af26f8..2b00a9d554fc 100644
> --- a/drivers/video/fbdev/chipsfb.c
> +++ b/drivers/video/fbdev/chipsfb.c
> @@ -430,6 +430,7 @@ static int chipsfb_pci_init(struct pci_dev *dp, const struct pci_device_id *ent)
> err_release_fb:
> framebuffer_release(p);
> err_disable:
> + pci_disable_device(dp);
> err_out:
> return rc;
> }
WARNING: multiple messages have this Message-ID (diff)
From: Helge Deller <deller@gmx.de>
To: Yang Yingliang <yangyingliang@huawei.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-fbdev@vger.kernel.org
Cc: mpe@ellerman.id.au, christophe.leroy@csgroup.eu
Subject: Re: [PATCH -next] video: fbdev: chipsfb: add missing pci_disable_device() in chipsfb_pci_init()
Date: Mon, 22 Aug 2022 22:11:58 +0200 [thread overview]
Message-ID: <b3c19a63-d9f8-028b-e59a-e428be1ed8be@gmx.de> (raw)
In-Reply-To: <20220819085752.1909541-1-yangyingliang@huawei.com>
On 8/19/22 10:57, Yang Yingliang wrote:
> Add missing pci_disable_device() in error path in chipsfb_pci_init().
>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
applied.
Thanks!
Helge
> ---
> drivers/video/fbdev/chipsfb.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/video/fbdev/chipsfb.c b/drivers/video/fbdev/chipsfb.c
> index 393894af26f8..2b00a9d554fc 100644
> --- a/drivers/video/fbdev/chipsfb.c
> +++ b/drivers/video/fbdev/chipsfb.c
> @@ -430,6 +430,7 @@ static int chipsfb_pci_init(struct pci_dev *dp, const struct pci_device_id *ent)
> err_release_fb:
> framebuffer_release(p);
> err_disable:
> + pci_disable_device(dp);
> err_out:
> return rc;
> }
next prev parent reply other threads:[~2022-08-22 20:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-19 8:57 [PATCH -next] video: fbdev: chipsfb: add missing pci_disable_device() in chipsfb_pci_init() Yang Yingliang
2022-08-19 8:57 ` Yang Yingliang
2022-08-22 20:11 ` Helge Deller [this message]
2022-08-22 20:11 ` Helge Deller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3c19a63-d9f8-028b-e59a-e428be1ed8be@gmx.de \
--to=deller@gmx.de \
--cc=benh@kernel.crashing.org \
--cc=christophe.leroy@csgroup.eu \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpe@ellerman.id.au \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.