* [PATCH] ioemu : sdl without OpenGl fix
@ 2008-07-10 13:11 sygus
0 siblings, 0 replies; 3+ messages in thread
From: sygus @ 2008-07-10 13:11 UTC (permalink / raw)
To: xen-devel
Hi,
Here is a little patch for a bug introduced recently in the SDL ioemu
rendering, in case we disable OpenGl. Without this patch, the SDL window
just stoppped when there were a call to ds->dpy_setdata, because the
pointer was not set.
Kind regards,
Frédéric Guihéry
Signed-off-by: Frédéric Guihéry <fred@cat-lan.com>
diff -r 2d100fe81044 tools/ioemu/sdl.c
--- a/tools/ioemu/sdl.c Wed Jul 09 16:00:05 2008 +0100
+++ b/tools/ioemu/sdl.c Thu Jul 10 14:58:05 2008 +0200
@@ -777,6 +777,8 @@ void sdl_display_init(DisplayState *ds,
ds->dpy_setdata = opengl_setdata;
else
ds->dpy_setdata = sdl_setdata;
+#else
+ ds->dpy_setdata = sdl_setdata;
#endif
sdl_resize(ds, 640, 400);
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH] ioemu: sdl without OpenGl fix
@ 2008-07-11 23:20 Frédéric Guihéry
2008-07-12 14:53 ` Stefano Stabellini
0 siblings, 1 reply; 3+ messages in thread
From: Frédéric Guihéry @ 2008-07-11 23:20 UTC (permalink / raw)
To: xen-devel
Hi,
Here is a little patch for a bug introduced recently in the SDL ioemu
rendering, in case we disable OpenGl. Without this patch, the SDL window
just stoppped when there were a call to ds->dpy_setdata, because the
pointer was not set.
Kind regards,
Frédéric Guihéry
Signed-off-by: Frédéric Guihéry <sygus@cat-lan.com>
diff -r 2d100fe81044 tools/ioemu/sdl.c
--- a/tools/ioemu/sdl.c Wed Jul 09 16:00:05 2008 +0100
+++ b/tools/ioemu/sdl.c Thu Jul 10 14:58:05 2008 +0200
@@ -777,6 +777,8 @@ void sdl_display_init(DisplayState *ds,
ds->dpy_setdata = opengl_setdata;
else
ds->dpy_setdata = sdl_setdata;
+#else
+ ds->dpy_setdata = sdl_setdata;
#endif
sdl_resize(ds, 640, 400);
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ioemu: sdl without OpenGl fix
2008-07-11 23:20 [PATCH] ioemu: " Frédéric Guihéry
@ 2008-07-12 14:53 ` Stefano Stabellini
0 siblings, 0 replies; 3+ messages in thread
From: Stefano Stabellini @ 2008-07-12 14:53 UTC (permalink / raw)
To: Frédéric Guihéry; +Cc: xen-devel
Frédéric Guihéry wrote:
> Hi,
>
> Here is a little patch for a bug introduced recently in the SDL ioemu
> rendering, in case we disable OpenGl. Without this patch, the SDL window
> just stoppped when there were a call to ds->dpy_setdata, because the
> pointer was not set.
>
> Kind regards,
> Frédéric Guihéry
>
> Signed-off-by: Frédéric Guihéry <sygus@cat-lan.com>
>
Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
>
> diff -r 2d100fe81044 tools/ioemu/sdl.c
> --- a/tools/ioemu/sdl.c Wed Jul 09 16:00:05 2008 +0100
> +++ b/tools/ioemu/sdl.c Thu Jul 10 14:58:05 2008 +0200
> @@ -777,6 +777,8 @@ void sdl_display_init(DisplayState *ds,
> ds->dpy_setdata = opengl_setdata;
> else
> ds->dpy_setdata = sdl_setdata;
> +#else
> + ds->dpy_setdata = sdl_setdata;
> #endif
>
> sdl_resize(ds, 640, 400);
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-07-12 14:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-10 13:11 [PATCH] ioemu : sdl without OpenGl fix sygus
-- strict thread matches above, loose matches on Subject: below --
2008-07-11 23:20 [PATCH] ioemu: " Frédéric Guihéry
2008-07-12 14:53 ` Stefano Stabellini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.